Question

How to Tune Slow SQL Strings?

Asked by: debbielampon

Hello,

I'm trying to improve performance of our asp application which runs strings such as the following in SQL Server -

select distinct tbluser.username, tbluser.userid, tbluser.firstname, tbluser.surname, tbluser.email, max(entrytime) as Entrytime    from tbluser JOIN tblvisit ON tblUser.UserID=tblvisit.UserID JOIN tblOrganisation on companyid = tblorganisation.id where tbluser.companyid =  8 AND tbluser.active = 1 AND tbluser.userid NOT IN (select userid from tblvisit where tblvisit.entrytime between '8/Feb/2005' and '15/Feb/2005')  and tbluser.active = 1 and tblorganisation.active = 1  group by orgname, username, tbluser.userid, firstname, surname, tbluser.email order by  username

which is hideously slow as the tables have a lot of data - any tips for tidying it up and improving performance please? This one above took 1:41 mins to run in SQL Query Analyser, and just times out when passed from the asp page to the server.

Many thanks
DebbieL

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2005-02-15 at 08:10:00ID21315418
Tags

query

,

select

,

slow

,

sql

Topic

Databases Miscellaneous

Participating Experts
6
Points
500
Comments
14

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. sql tuning
    how can i get the best performance from this query. select distinct i.county_id, i.folio_num, i.tenure_id, i.view_indicator from itr_owners o , itr_folios i , itr_ownerships ow ...
  2. tuning
    any way of tuning this query , its very slow. SELECT CMC_CLCL_CLAIM.CLCL_ID, CMC_SBSB_SUBSC.SBSB_ID, CMC_CLCL_CLAIM.CLCL_TOT_CHG, CMC_CLCL_CLAIM.CLCL_TOT_PAYABLE, CMC_CLCL_CLAIM.CLCL_CUR_STS, CMC_CLCL_CLAIM.CLCL_LOW_SVC_DT, CMC_CLCL_CLAIM.CLCL_HIGH_SVC_DT, CMC...
  3. AutoNumber & Surname
    Hi I want my CustomerNumber to be auto incremented. But i also want the first 3 letters of the surname to be displayed infront of the auto number. For example SMI0001. Im not sure how to do this.
  4. NOT DISTINCT
    Is there such a thing as SELECT NOT DISTINCT?
  5. SQL Tune!!
    Guys. Couple of days back I had posted this and got it as a solution. But this peace of code takes hell lot of time and they predict that this would require 21 days to complete the full updation of 10 Million records which is very bad. How can I tune this peace? DECLARE @l_...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: ptjcbPosted on 2005-02-15 at 08:14:11ID: 13315150

You could look at the execution plan in Query Analyzer to see where the script is slow. You could also check to be sure that you have indexes in the right columns (for example, companyid, active, userID). You could also set up a trace in Profiler and check for slow-running queries and then use the Index Tuning Wizard on that trace to see if you need other indexes.

 

by: debbielamponPosted on 2005-02-15 at 08:33:38ID: 13315387

Thank you,

I'm wondering how I can check whether these columns have indexes?

 

by: infexPosted on 2005-02-15 at 08:34:32ID: 13315398

You should check the indexes.

On fields where there are a lot of different values and which are needed to search for should be indexed.

Fields on which you do not search or which have only very few different values should not be indexed.

In some cases a compound index may be necessary, check in such case also the order of the fields in the index.

Hopes this helps

 

by: infexPosted on 2005-02-15 at 08:37:10ID: 13315436

Addendum

Do not use the function "between" but use > and < instead. Using between prevents some automatic optimalisations.

Hope this helps

 

by: VMontalvaoPosted on 2005-02-15 at 08:45:44ID: 13315540

1) Tables should have primary key (clustered better)
2) See the relantionships between tables. Foreign keys should be created.
3) Only use distinct keyword if you really need it.
4) Prefix all the columns with correct table name (orgname, username, firstname, surname don't have prefix)
5) If still slow, then create indexes to improve your query execution time (at least the tblvisit.entrytime looks like will need one. tbluser.username too)

I could see that you repeated one filter: (tbluser.active = 1)
It isn't necessary to write it twice! :)

 

by: debbielamponPosted on 2005-02-15 at 08:49:13ID: 13315626

Many thanks will take a look at these suggestions!

 

by: HilairePosted on 2005-02-15 at 08:55:05ID: 13315699

Please try

select username, userid, firstname, surname, email,
(select top 1 entrytime from tblVisit where UserID = U.UserID) as Entrytime    
from tbluser U
where companyid =  8 AND active = 1
AND NOT EXISTS (
      select 1 from tblvisit
      where UserID = U.UserID
      and tblvisit.entrytime between '8/Feb/2005' and '15/Feb/2005')
order by 1

 

by: debbielamponPosted on 2005-02-15 at 09:44:22ID: 13316211

At first glance and running this looks great! Will look further into it and get back. Many thanks.
Debbie Lampon

 

by: LowfatspreadPosted on 2005-02-15 at 11:15:54ID: 13317044

1. You don't need the distinct
2. Avoid Not IN / IN Lists  and Use NOT EXISTS / EXISTS instead
3. look at the query plans generated
4. use profiler/ index analyser to tune problem queries.  

select U.username, U.userid, U.firstname, U.surname, U.email
, max(entrytime) as Entrytime    
from tbluser as U
Inner Join JOIN tblvisit as V
 ON U.UserID=V.UserID
Inner Join tblOrganisation as O
 on companyid = O.id
where U.companyid =  8 AND U.active = 1
AND Not Exists  
(select userid from tblvisit as V1
      where V1.entrytime between '8/Feb/2005' and '15/Feb/2005'
          and V1.UserName=U.userid)
  and U.active = 1 and O.active = 1
 group by orgname, username, U.userid, firstname, surname, U.email
order by  username



I don't believe there is a problem with using Between since SQL can easily convert that into a range select....
you should avoid joining tables via functions where possibvle...

hth

 

by: BayDiningPosted on 2005-02-16 at 11:52:41ID: 13327934

A quick suggestion to try... and the syntax is not tested.  I believe the NOT IN (SELECT ... ) is executed every time for each row in the top query.  Use a table variable.  Also, try to not to us IN use EXISTS and NOT EXISTS.  I have more but I'm not sure what docs came from other pay sites.



declare @tableVar table (tUserid      [int])
Insert Into @tablevar
(select userid from tblvisit where tblvisit.entrytime between '8/Feb/2005' and '15/Feb/2005')



select distinct tbluser.username, tbluser.userid, tbluser.firstname, tbluser.surname, tbluser.email, max(entrytime) as Entrytime    from tbluser JOIN tblvisit ON tblUser.UserID=tblvisit.UserID JOIN tblOrganisation on companyid = tblorganisation.id where tbluser.companyid =  8 AND tbluser.active = 1 AND tbluser.userid NOT EXISTS

(SELECT tUserid FROM @tableVar)

  and tbluser.active = 1 and tblorganisation.active = 1  group by orgname, username, tbluser.userid, firstname, surname, tbluser.email order by  username

 

by: debbielamponPosted on 2005-02-18 at 02:58:35ID: 13344245

So far Hilaire's code works fastest, but has a couple of problems:

1) selecting the "top 1 entrytime from tblVisit" is not equivalent to the max entrytime, and it is the most recent visit I need. No worries, changed that code.

2) it is missing the tblorganisation information which selects only data where an organisation is active, be very grateful if this could be added to the solution?

Best wishes
Debbie

 

by: infexPosted on 2005-03-09 at 08:12:13ID: 13497316

Try :

select username, userid, firstname, surname, email,
(select max (entrytime) from tblVisit where UserID = U.UserID) as Entrytime    
from tblOrganisation, tbluser U
where companyid =  8 AND active = 1
AND companyid = tblorganisation.id
AND NOT EXISTS (
     select * from tblvisit
     where UserID = U.UserID
     and tblvisit.entrytime >= '8/Feb/2005' and tblvisit.entrytime <= '15/Feb/2005')

Make sure following fields are indexed : companyid, tblorganisation.id, entrytime, userid


20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...