Question

Noobie SQL INNER JOIN question

Asked by: JenniQ

OK, so I have a table that looks like this:


FriendId (int) | UserId (int)

This basically provides a way to track the relationship between a user and their friends... like myspace or friendster.

Now each time I add a friend i only add one entry. Say the user id = 9 and friend id = 7, so it would look like this:

FriendID   UserId
   7              9

So now i want to display the users friends. their friends can be either added by the friend or the user, there my query needed to look like this:


Here is a simplified version:

SELECT * from Friend A
left JOIN user B ON B.UserId = A.FriendId
LEFT JOIN Image C on B.MainImgId = C.ImageId
WHERE A.UserId = @userid OR A.FriendID = @UserID

This is problimatic, as I'm sure you can see. The problem is that

1) it pulls duplicate records
2) it shows the user as a friend because that satifies it conditions.

Can you offer a better way to write this simple query??

Thanks!!

-- jenni


This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2006-06-01 at 09:54:11ID21871356
Tags

inner

,

join

,

sql

Topic

Databases Miscellaneous

Participating Experts
5
Points
150
Comments
16

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Left and inner Joins
    I currently have this query DECLARE @ElaborationType INT SELECT @ElaborationType= PropertyID from QMSProperties WHERE ShortName='property:Elaboration Type' CREATE TABLE #ExpTitles(tid varchar(200),ttitle varchar(200),tpv varchar(200)) INSERT #ExpTitles (tid,ttitle,tpv)...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Arthur_WoodPosted on 2006-06-01 at 10:04:19ID: 16809109

what fields are you trying to pull, since Select * will select every field from Every Table.

And how do you see this as pulling 'duplicate records'?

AW

 

by: Arthur_WoodPosted on 2006-06-01 at 10:05:05ID: 16809114

what are the table structures of your tables: Users and Friends ?

AW

 

by: Arthur_WoodPosted on 2006-06-01 at 10:10:39ID: 16809163

do you in fact havce two tables (User and Friend)?

AW

 

by: JokulPosted on 2006-06-01 at 10:58:23ID: 16809605

From the looks of it you have a main user table (User) which containts User info + a pointer to their Image in the Image table.

Now if you want to just display the user's friends only then
SELECT * from Friend A
      left JOIN user B ON A.FriendId = B.UserId
      LEFT JOIN Image C on B.MainImgId = C.ImageId
  WHERE A.UserId = @userid;

You don't need to friend in the where clause and I would swap round the left join on user for completeness.

Now if you wanted to display the friends list of the user's friends you would have to traverse the table like a bill of materials.


 

by: RickBeebePosted on 2006-06-01 at 11:44:09ID: 16810015

First, user and image are reserved words in SQL Server - so I added brackets [ ] around the table names as shown below
Next, I moved the [User] table to the top of the join list as the base table (assuming they should always exist in the [User] table)
Then, I modifed the where clause to join to B.UserId ([User] table)  (assuming the UserId was not in the Friend table - FriendId = UserId)
Also, removed FriendId from the WHERE clause.

This seems to work:

DECLARE @USERID INT
SET @USERID = 6

SELECT *
FROM [User] B
LEFT OUTER JOIN [Friend] A ON B.UserId = A.FriendId
LEFT OUTER JOIN [Image] C ON B.MainImgId = C.ImageId
WHERE B.UserId = @userid

 

by: JenniQPosted on 2006-06-01 at 12:04:45ID: 16810222

I'm not sure if I explained my problem correctly.

So lets say
UserID 7  = Jenni
UserId 9  = Samantha
UserId 14 = Ryan

I run this query to determine who is friend's with Jenni. If Jenni added Samantha and then Ryan adds Jenni the results look like this:

UserID   FriendID
  7             9
  14           7

So, when I show this persons friends I am pulling the "FriendId". the method I am currently using will show Jenni's friends as Samantha and Jenni.

Thats not right. Jenni's friends are Samantha and Ryan. Now, I could create two records for each friend relationship. But that seems redundant. I am using this with ASP.NET so maybe there is a way to filter a dataset or something but I'd prefer to do it in the query.

IF you wanna see what the friend system looks like here is somethign like it:

http://myspace.com/jenniquick

Ok, so maybe this isin't a 'noob' question. I'm increasing the points :)

-- Jenni

 

by: rherguthPosted on 2006-06-01 at 12:25:29ID: 16810436

-- The unstated requirement is that a user's friend is not only his/her stated
-- friends, but also anyone who claims the user as a friend.
-- You may need to stop using the * and specify columns, since the UNION
-- requires the same number and type of columns in the results set.
-- Also note that UNION removes dupes by default, which is what you want
SELECT * from Friend A
      left JOIN user B ON A.FriendId = B.UserId
      LEFT JOIN Image C on B.MainImgId = C.ImageId
  WHERE A.UserId = @userid;
UNION  
SELECT * from user B
      left JOIN Friend A ON A.FriendId = B.UserId
      LEFT JOIN Image C on B.MainImgId = C.ImageId
  WHERE b.UserId = @userid;

 

by: JenniQPosted on 2006-06-01 at 14:06:16ID: 16811409

Ah sooooo cool! I haven't used the union clause before. Thats rad, it works perfect! Thanks so much.

 

by: JenniQPosted on 2006-06-01 at 14:24:36ID: 16811522

OK, I'm getting some different results now that I plugged it into my stored procedure. I am still getting an unexpected result set. Here is the query after I altered it from your original:

SELECT B.userid,B.username,B.mainImgId,B.Quote,
      A.userId,A.FriendId,A.sortOrder,A.status,A.dateAdded,A.friendType,
      C.imageSrc,C.ImageText
      FROM wisetopic_Friend A
      left JOIN wisetopic_user B ON A.FriendId = B.UserId
      LEFT JOIN wisetopic_Image C on B.MainImgId = C.ImageId
   WHERE A.UserId = @userid
UNION  
SELECT B.userid,B.username,B.mainImgId,B.Quote,
      A.userId,A.FriendId,A.sortOrder,A.status,A.dateAdded,A.friendType,
      C.imageSrc,C.ImageText
      FROM wisetopic_User B
      left JOIN wisetopic_Friend A ON A.FriendId = B.UserId
      LEFT JOIN wisetopic_Image C on B.MainImgId = C.ImageId
  WHERE b.UserId = @userid

When I execute the QUERY with the ID of 7 it returns only rows with '7'. I think i have something backwards?? :S


here is the whole friend table results:

userId      friendId    
----------- -----------
9           7          
8           7          

(2 row(s) affected)

And the result of the stored proc i changed from your suggestions:

userid      username          
----------- ---------------
7           ~ Jenni ~    
7           ~ Jenni ~    

(2 row(s) affected)


Thank you!!!

 

by: rherguthPosted on 2006-06-01 at 21:20:23ID: 16813505

Don't worry JenniQ.  I'll help you through it until it works.

  -- Bob

 

by: rherguthPosted on 2006-06-01 at 22:18:59ID: 16813692

It looks like you have a data model like this:

wisetopic_User
--------------------
userId
username
...

wisetopic_Friend
--------------------
userId
FriendId
...

It looks like (userID + FriendId) is the unique key for wisetopic_Friend and it looks like userId is the unique key for wisetopic_User.  Presumably, both userId and FriendId are foreign keys related to userId in wisetopic_User.

-- So, if you want to pull all of the friends for a specific user, it looks like this:
SELECT
      Users.userId [UserID]
      , Users.username [User Name]
      , Friends.FriendId [FriendID]
      , Friend.username [Friend Name]
      , FriendPic.imageSrc [Friend SRC]
      , FriendPic.ImageText [Friend AltText]
      , Friends.sortOrder
      , Friends.status
      , Friends.dateAdded
      , Friends.friendType
FROM
      -- Start with all users
      wisetopic_User [Users]
      -- Join only the desired user to all his/her friends
      INNER JOIN wisetopic_Friend [Friends] ON Friends.userId = Users.userId
            -- This could be tacked on in the WHERE clause, but narrows the rows faster here
            -- It would be *required* to be in the WHERE if we used a LEFT JOIN
            And Users.userId = @userid      
            -- Now get the details (username) for each friend
            INNER JOIN wisetopic_User [Friend] ON Friend.userId = Friends.FriendId
                  -- Get the image of the friends (left join because they may not have a pic ???
                  LEFT OUTER JOIN wisetopic_Image [FriendPic] ON FriendPic.ImageId = Friend.MainImgId
UNION
--Now, lets get all of the Friends that have selected our @userId as a friend:
SELECT
      -- These are switched around from the first example because FriendId is now = @userID
      Friends.FriendId [UserID]
      , [User].username [User Name]
      , Friend.userId [FriendID]
      , Friend.username [Friend Name]
      , FriendPic.imageSrc [Friend SRC]
      , FriendPic.ImageText [Friend AltText]
      -- The columns below are of debatable value since they represent the attributes other users stored for our @userID when making him/her a friend
      -- You may choose to make these NULL, which is perfectly valid for a UNION
      , Friends.sortOrder
      , Friends.status
      , Friends.dateAdded
      , Friends.friendType
FROM
      -- Start with all of the Friends
      wisetopic_Friend [Friends]
            -- Now get the details (username) for our @userID...
            INNER JOIN wisetopic_User [User] ON [User].FriendId = Friends.userId
                  -- that specified our @userId as a friend
                  And FriendId = @userid
            -- Now get the details for the Friends
            INNER JOIN wisetopic_User [Friend] ON [Friend].userId = Friends.userId
                  -- Get the image of the friends (left join because they may not have a pic ???
                  LEFT OUTER JOIN wisetopic_Image [FriendPic] ON FriendPic.ImageId = Friend.MainImgId

-- *Note, this will not return any rows at all if the @userId has no friends and is not listed by anyone else as a friend
-- *Note, the UNION looks at all of the columns to determine what constitutes a duplicate row
--      The debatable columns above could very well bodge up UNION's ability to get rid of the dupes
--      Another way to go about it would be to collect the last four columns after the UNION has run
--      Let me know if you need an example of doing that with a single statement

 

by: rherguthPosted on 2006-06-01 at 22:21:55ID: 16813702

I didn't test it, so let me know if it causes any trouble.

 

by: imsrepairPosted on 2006-06-02 at 08:45:17ID: 16817708

Try this:

You may have to list the exact field in the select list.  
The distinct will remove duplicates and the b.user_id <> @userid will remove the user


SELECT distinct * from Friend A
left JOIN user B ON B.UserId = A.FriendId
LEFT JOIN Image C on B.MainImgId = C.ImageId
WHERE (A.UserId = @userid OR A.FriendID = @UserID)
AND b.user_id <> @userid

 

by: JenniQPosted on 2006-06-02 at 13:56:52ID: 16820247

Bob,

Thank you very much for taking the time to help answer my question. With a little elbow grease this query did work perfectly! You really went above and beyond to answer my question, I wish there was a rating above Excellent!!!

Just Wonderign.... Is using brackets the same as saying AS?

-- Jenni

 

by: rherguthPosted on 2006-06-02 at 16:15:04ID: 16821048

Yes, the AS part is optional, but so are the brackets unless the alias text is a reserved word or has a space or some other character that has a meaning to SQL.  It's a style thing.  I find that if I format the SQL the same way, I can quickly see what it does.  The brackets set off what the aliases are when I quickly scan the code.  That's also why I indent the joins if the lower join is related to the join above it.  Some of my SQL SELECTs have many joins and it makes them much easier to understand.  It also helps to do as you did and only use LEFT JOINs (or only RIGHT JOINS), rather than mixing LEFT and RIGHT joins together in the same statement.

Putting the @userId in the JOIN and not in the WHERE is a debateable improvement.  It seems to improve performance, but sacrafices some readability.  When dealing with long tables, SQL's optimizer doesn't appear to help out by forcing conditions up higher in the join chain (that logically could be).  Ideally, I always want to narrow down the rows as quickly as possible to improve statement performance.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...