Question

A better way to check for duplicate before INSERT?

Asked by: TunaMaxx

Hello,

  I have a script that I use to parse flat log files and INSERT the info into a mySQL table. There are frequently very similar log entries, but for the most part, each is unique. Obviously I want to log the similar entries but skip anything that may have already been INSERTED. (For reasons beyond my control, random duplicate entries show up in subsequent log files about 5% of the time.)

  What I have been doing is a "SELECT * WHERE..."  on a few key columns (all of which are indexed - that sped things up A LOT!) to look for a match. If it finds one, obviously it skips the INSERT statement. However, when no match is found, the new information is added.

  Here (buried in some PHP seudo-code) is pretty much what I have been using to now:

/* start pseudo-code ****************************************************/
// $dupe will look at the DB and see if there is already an entry that matches what we are about INSERT
  $dupe = "SELECT * FROM x WHERE this = '$that' AND this_too = '$that_too' AND this_one = '$that_one'";

  $result = mysql_query( $dupe ) or die ( 'Unable to check for duplicates.' );
  $num = mysql_numrows( $result );

if ( $num != 0 ) {
    // A matching log entry was found - do not insert a duplicate value.
    echo "Duplicate.<br>\n";

} else {

    // Insert new info
    $sql = "INSERT INTO x_print (
                id,
                this,
                this_too,
                this_one,
                blah_1,
                blah_2
                blah_3,
                etc
          ) VALUES (
                '',
                '$that',
                '$that_too',
                '$that_one',
                '$blah_1',
                '$blah_2',
                '$blah_3',
                '$etc'
                )";

     if (!mysql_query ($sql)) {
       echo mysql_error($Link);
       die('The query could not be executed!');
     }
     echo "Inserted!<br>\n";
 }
/* end seudo-code ****************************************************/

  This method is AT LEAST 10x slower than the INSERT statements alone. Some of these log files have 100,000+ lines, and will generate 5,000 to 10,000 rows. Therefore, that's 5,000 to 10,000 SELECT statements too.

   Is there something fundementaly wrong with how I am going about this?

  Is there a better way?

Thanks,

Tony

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2004-12-08 at 18:34:25ID21235814
Tags

duplicate

,

insert

,

before

,

check

Topic

MySQL Server

Participating Experts
2
Points
250
Comments
10

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. mysql insert creates duplicates
    This is the script I'm using to insert a record into the table. The script db.php is simply the connection to the database. if I post to this script it operates correctly. But if I call this script by navigating to the url and passing the variables in the url it creates tw...
  2. PHP/MySQL duplicate records
    I've just created a login script using PHP/MySQL. The good news is I have the php page connecting to the database - adding a new user. The database is quite simple consisting of three fields: ID, username, password. Here's the problem. I tested and entered identical user nam...
  3. mysql duplicate primary key when insert
    wid is primary key How can we make user known 'Your Id is duplicate" incase we can not insert because of duplicate key
  4. MySQL Duplicate Insert Issue
    I'm tracking a bug in mysql that results in duplicate insert queries. The php script executing the mysql queries runs fine on my dev server (XP IIS5 PHP 4.3.10) with no duplicate inserts. When the script is run on the test server (Win 2K3 IIS6 PHP 4.3.10) the dupe insert bug...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: arantiusPosted on 2004-12-08 at 18:35:51ID: 12779746

Set up appropriate keys and use: http://dev.mysql.com/doc/mysql/en/REPLACE.html
"REPLACE works exactly like INSERT, except that if an old record in the table has the same value as a new record for a PRIMARY KEY or a UNIQUE index, the old record is deleted before the new record is inserted."

 

by: arantiusPosted on 2004-12-08 at 18:36:55ID: 12779753

Also, indexing any column you join on or where on is a massive speed increase.

 

by: TunaMaxxPosted on 2004-12-08 at 18:45:55ID: 12779800

How the heck did you do that? It would have taken me longer to type your response than had elapsed since I posted the Q!

I'm not 100% sure REPLACE will work for me. I don't know the primary key ('id') before the INSERT, and none of the columns need to (or can be) UNIQUE.

I may have 10 attempts at (different times / or dates) to complete 'this' and I want to log them all, not just the completed one.

Thanks,

Tony

 

by: arantiusPosted on 2004-12-08 at 19:24:55ID: 12779939

TunaMaxx,
>  duplicate entries show up in subsequent log files
what makes it duplicate?  define an index around that

 

by: arantiusPosted on 2004-12-08 at 19:29:13ID: 12779953

Something like:

ALTER TABLE test ADD UNIQUE (
    this ,
    that ,
    theother
)

 

by: TunaMaxxPosted on 2004-12-08 at 20:46:04ID: 12780205

arantius:

Does that mean that the combination of values stored in 'this, that, theother' is what is unique, or would that make each of those columns unique individually?

The log files I am parsing are from digital printers and the postcript RIP's that prep the art for printing. Seemingly, there shouldn't be too many duplicate entries, but in reality there are.

Filename:
Although every file that gets RIP'd *should* have a unique name, many times the same file will sent through again at a later date with slight modifications. Not everyone that (re)sends the files will alter the name. *I* know that everyone should be using unique names. I have set the RIP's to ensure that every OUTPUT name is unique (firstfile.000001.rtl, firstfile.000002.rtl, nextfile.000003.rtl, etc)) However, getting people to 'go out of their way' and add a unique identifier to the INPUT filename is a much larger challenge. It would be MUCH less headache to throw bigger hardware at the mySQL server to more quickly burn through the current SELECT / INSERT routine! ;)  

Time / Date:
This might be a candidate for a UNIQUE column. The problem is one set of logs has two sources, and the other set has three. Chances may be slim, but theoretically two operations could take place at the same time, and then I'd only have one of them logged. (None of the logs record micro-seconds, and I can't do anything about that) I have three years and millions of lines of logs to look through for duplicate timestamps. I wonder if or how many I'll find?

In reality, my question just might be one of research than anything else. After I have finished with converting the three years worth of logs, the daily maintenance will only be a few thousand lines. The code excecution time will sub-second versus *sub* sub-second!

Thanks,

Tony

 

by: TunaMaxxPosted on 2004-12-08 at 21:04:53ID: 12780258

Hmmm...

I wonder if this is what I am after?

http://dev.mysql.com/doc/mysql/en/INSERT_SELECT.html
"INSERT INTO tbl_temp2 (fld_id)
    SELECT tbl_temp1.fld_order_id
    FROM tbl_temp1 WHERE tbl_temp1.fld_order_id > 100;"

I'm not at work to even begin to test it, but maybe I would use something like:

INSERT INTO x (this, that, theother) VALUES ('$this', '$that', '$theother') SELECT * FROM x WHERE this <> '$this' AND that <> '$that' AND theother <> '$theother'

Something about that just doesn't look right... :)

 

by: TunaMaxxPosted on 2004-12-08 at 21:06:10ID: 12780261

Oops!

From the mysql.com link above:

"Currently, you cannot insert into a table and select from the same table in a subquery."

 

by: lokusPosted on 2004-12-09 at 01:09:29ID: 12781075

You should find a unique key or primary key first if it is possible, you mentioned filename and date/time. These 2 fields may not be unique, but would the combined of (filename and date/time) be unique? If it is still not unique, then add more fields until you can form a unique group of fields.

You did a SELECT to compare the value to insert with the current data in the table, I guess the combined of all these will form a unique key. But, if the number of fields is big, then it is no longer feasible, MySQL allows only about max 1024 bytes in a key.

With a UNIQUE KEY or PRIMAY KEY, you can then use INSERT IGNORE or REPLACE to insert the new rows.

Alternative method:
Since the duplicates forms about 5% of the rows, maybe you can just leave them. When you do your select add the DISTINCT keyword to remove the duplicates.
SELECT DISTINCT * FROM tablename.

If you want you can also do some housekeeping once in a while:
CREATE TABLE temp ( ... );
INSERT INTO temp SELECT DISTINCT * FROM yourtable;
TRUNCATE yourtable;
INSERT INTO yourtable SELECT * FROM temp;
DROP TABLE temp;
Can you get teh idea?

This shoule be more efficient than your SELECT before INSERT, I guess you have no INDEX on the table at all, so the SELECT will take quite some time.

An even better method if you are using MyISAM tables.
Create 2 tables exactly the same structure, then make a MERGE table consisting of these 2 tables.
Always insert into 1 of the MyISAM table, let say table1
Everyday, do this once, preferabley after midnight.
INSERT INTO table2 SELECT DISTINCT * FROM table1 WHERE datefield < current_date();
DELETE table2 WHERE datefield < current_date();

The idea is to move all the rows from previuos day from table1 to table2, and delete them from table1.
You will still need to use DISTICT in all your SELECT though, and you can SELECT from the combined MERGE table.


 

by: arantiusPosted on 2004-12-09 at 06:13:06ID: 12783291

>Does that mean that the combination of values stored in 'this, that, theother' is what is
>unique, or would that make each of those columns unique individually?

That's exactly it.  A UNIQUE key on 3 columns means the combination of those three columns must be unique.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...