Question

Simple form returning complex MySQL errors

Asked by: KevPerkins

Hi Guys

This is an urgent one. I have a form at the following address

http://www.colourome.com/contactfeedback.php

this form submitsm the contents of the form to a database by calling the following script:

http://www.colourome.com/enqgeneralsubmit.php

The script worked at first but then I think I made a change or did something to screw it up - can't for the life of me see what the problem is but I keep getting a MySQL syntax error -doesn't seem to make any sense because the line it refers to has remained unchanged.

Please could someone help. This one is urgent.

Thanks

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2005-02-20 at 23:20:06ID21322366
Topic: MySQL Server
Participating Experts: 3
Points: 500
Comments: 5

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: JesterTooPosted on 2005-02-21 at 00:24:26ID: 13360878

Tried to look at your script but all I get is the error message. Try posting the actual script in a comment.

by: KevPerkinsPosted on 2005-02-21 at 05:12:42ID: 13362363

OK, here it is...

<?php
//declare the connection variables
$user="20725015_mgr";
$password="col123";
$database="colourome";

// open the connection
$conn = mysql_connect ("morpheus.tiscali.co.za", $user,$password)or die("DB Connection Error:".mysql_error());

//pick the database
mysql_select_db($database, $conn)or die("DB selection Error:".mysql_error());

//create the sql statement
$sql = "INSERT INTO generalENQ(enqID, fName, sName, company, email, telOffice, telMobile, telFax, country, province, genENQ)
VALUES ('', '$_POST[fName]', '$_POST[sName]', '$_POST[company]', '$_POST[email]',
'$_POST[telOffice]', '$_POST[telMobile]', '$_POST[telFax]',
'$_POST[country]', '$_POST[province]', '$_POST[genENQ]', '$_POST[subscribe])";

//execute the sql statement
if (mysql_query($sql, $conn))
 {
 echo "Thank you, your information
 has been submitted. 
 Click <a href='index.php'>here</a> to return to the Colourome website.";
 }
 else
 {
 echo "something went wrong".mysql_error();
}

//start building the mail string
$msg = "<html>
 <body>
 <table width='500' border='1' cellspacing='0' cellpadding='5'>
<tr>
<td bgcolor='#EAEAEA'>Name and Surname: </td>
<td bgcolor='#0000FF'>$_POST[fName] $_POST[sName] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Company name: </td>
<td bgcolor='#0000FF'>$_POST[company] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Office phone number: </td>
<td bgcolor='#0000FF'>$_POST[telOffice] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Cell phone number: </td>
<td bgcolor='#0000FF'>$_POST[telMobile] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Email Address: </td>
<td bgcolor='#0000FF'>$_POST[email] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Office fax number: </td>
<td bgcolor='#0000FF'>$_POST[telFax] </td>
</tr>
<tr>
<td bgcolor='#EAEAEA'>Province and Country </td>
<td bgcolor='#0000FF'>$_POST[province], $_POST[country] </td>
</tr>
<tr bgcolor='#EAEAEA'>
<td colspan='2'>Nature of enquiry from the colourome.com website</td> </td>
</tr>
<tr bgcolor='#0000FF'>
 <td colspan='2'>$_POST[genENQ] </td>
</tr>
</table>
</body>
</html>";

//set up the email
$recipient="kevin@solidweb.co.za";
$subject="Enquiry from Colourome Website";
$mailheaders="MIME-Version: 1.0 \r\n";
$mailheaders.="Content-type: text/html; charset=iso-8859-1\r\n";
$mailheaders.= "From: $_POST[email]\n";
$mailheaders .="Reply to : $_POST[email]";

//send the email
mail($recipient, $subject, $msg, $mailheaders);

//close the connection
mysql_close();
?>

by: virmaiorPosted on 2005-02-21 at 06:24:33ID: 13362854

in the future, don't post the password and actual address of your mysql server...
you may want to ask a moderator to edit that post

the problem is in this line:

$sql = "INSERT INTO generalENQ(enqID, fName, sName, company, email, telOffice, telMobile, telFax, country, province, genENQ)
VALUES ('', '$_POST[fName]', '$_POST[sName]', '$_POST[company]', '$_POST[email]',
'$_POST[telOffice]', '$_POST[telMobile]', '$_POST[telFax]',
'$_POST[country]', '$_POST[province]', '$_POST[genENQ]', '$_POST[subscribe])";

you're doing one thing that shouldn't be done

$_POST[telOffice] should be $_POST["telOffice"]
having an unquoted name doesn't necessarily translate to its equivalent string (though it usually turns out to do so).

change it to be like this:

$sql = "INSERT INTO generalENQ(enqID, fName, sName, company, email, telOffice, telMobile, telFax, country, province, genENQ)
VALUES ('', '". $_POST['fName'] ."', '" . $_POST['sName'] . "', '" . $_POST['company'] . "' ...

by: ldbkuttyPosted on 2005-02-21 at 07:16:53ID: 13363366

Although missing a ' at the end of your query was the problem, you should take care of Sql injection. I'd do it in this way:

$sql = "INSERT INTO generalENQ(enqID, fName, sName, company, email, telOffice, telMobile, telFax, country, province, genENQ)
VALUES ('', '" . mysql_real_escape_string($_POST["fName"]) . "', '" . mysql_real_escape_string($_POST["sName"]) . "', '" . mysql_real_escape_string($_POST["company"]) . "', '" . mysql_real_escape_string($_POST["email"]) . "',
'" . mysql_real_escape_string($_POST["telOffice"]) . "', '" . mysql_real_escape_string($_POST["telMobile"]) . "', '" . mysql_real_escape_string($_POST["telFax"]) . "', '" . mysql_real_escape_string($_POST["country"]) . "', '" . mysql_real_escape_string($_POST["province"]) . "', '" . mysql_real_escape_string($_POST["genENQ"]) . "', '" . mysql_real_escape_string($_POST["subscribe"]) . "')";

// Or still look good way is to assign the escaped string in varibles and assign them in the query and within the html email.

// use stripslashes() in your email message.

by: KevPerkinsPosted on 2005-02-21 at 11:33:35ID: 13365718

OK. I'll give that a try and get back to you.

Thanks

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

Simple form returning complex MySQL errors

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

MySQL Server

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press