Question

Help regarding bulk processing.

Asked by: gram77

I have the following procedure that inserts a parameter p_paramA of type sys_refcursor into a table.

The procedure is as under and works fine:
********************************************************************
PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
                     p_paramB       OUT               NUMBER
)
IS
TYPE my_typ IS RECORD
(
      id      mytab.col1%TYPE,
      id_typ       mytab.col2%TYPE
);
      v_paramA      my_typ;
      v_err_cd       NUMBER;
BEGIN
      LOOP
            BEGIN
                  FETCH p_paramA INTO v_paramA;

                  EXIT WHEN p_paramA%NOTFOUND;

                  INSERT INTO my_tabB
                  VALUES ( v_paramA.col1,
                                    v_paramA.col2,
                                    TRUNC (SYSDATE) );
            END;
      END LOOP;

      COMMIT;
EXCEPTION
      WHEN OTHERS
      THEN
            NULL;
END my_proc;

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-04 at 09:47:51ID24783736
Topics

PL / SQL

,

Oracle Database

,

Oracle 10.x

Participating Experts
2
Points
500
Comments
10

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. error - fetch out of sequence
    Hi all, I have the following code to populate a table in database db1, reading data from 3 tables on another database db2. I have 3 nested cursors for the 3 selects. I get the following errors when executing my code: ORA-01002: fetch out of sequence ORA-06511: PL/SQL: curs...
  2. Bulk collect and update
    I have this procedure which takes a while to update 3 million rows. I have seen document for bulk collect and update but i don't know how can i impliment this in this existing procedure. If anyone can explain bulk collect and update using following procedure will be appriicat...
  3. For a purging process, I'm trying to create a procedure t…
    For a purging process, I'm trying to create a procedure that deletes and commits in a loop. There are over 7 million rows in the table. I've used some helpful tips in Experts Exchange but I'm getting the ORA-1001 invalid cursor. I'm running oracle 9.2.0.5. I want to dele...
  4. Problem with ELSE SQL%NOTFOUND THEN !!!
    Hello i have strang problem with ELSIF SQL%NOTFOUND THEN OR using ELSE SQL%NOTFOUND THEN. I have function, please see the code: See CODE 1 When i run script : SELECT update_tables.fn_InsertNewFeatureIntoTrOffer(502334,100,'WE',1,sysdate,sysdate) return_val FROM dual; (5023...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: gram77Posted on 2009-10-04 at 09:49:37ID: 25489720

I want to change the above loop into FORALL..LOOP structure and add bulk insert feature:
Please help?
PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
               p_paramB       OUT               NUMBER
)
IS
--The following statement gives a PLS-00497 error.
FETCH p_paramA BULK COLLECT INTO v_paramA;
EXIT WHEN p_paramA%NOTFOUND;
     
FORALL  i IN v_paramA LOOP
      INSERT INTO inst_activity
      VALUES ( v_paramA(i).col1,
                       v_paramA(i).col2,
                       TRUNC (SYSDATE));
END LOOP;
END my_proc;

 

by: flow01Posted on 2009-10-04 at 13:45:53ID: 25490861

You will have to fetch into an array  instead of an record.

add to declaration
type t_paramA_type IS table of my_typ INDEX BY BINARY_INTEGER;
t_paramA   t_paramA_type;

change fetch
FETCH p_paramA BULK COLLECT INTO t_paramA;

FORALL  i IN t_paramA LOOP

 

by: gram77Posted on 2009-10-05 at 02:19:07ID: 25493537

flow01:
I have made modification in the code and now I am recieving the p_paramA into an associative array called v_paramA

Now i am getting an error ORA-228096: not an object or REF.

It seems that oracle does not consider v_paramA as an object at all.

Though i have declared v_paramA as an associative array!..

************************************
PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
               p_paramB       OUT               NUMBER
)
IS
TYPE my_rec_typ IS RECORD
(col1      my_tab.col1%TYPE,
col2       my_tab.col2%TYPE);


type t_paramA_type IS table of my_rec_typ
INDEX BY BINARY_INTEGER;

v_paramA   t_paramA_type;

BEGIN

FETCH p_paramA BULK COLLECT INTO v_paramA;

     
FORALL  idx IN v_paramA LOOP
      INSERT INTO inst_activity
      VALUES ( v_paramA(idx).col1, <-- Getting error here! ORA-228096: not an object or REF.
               v_paramA(idx).col2, <-- Getting error here! ORA-228096: not an object or REF.
               TRUNC (SYSDATE));
END LOOP;
END my_proc;

 

by: gram77Posted on 2009-10-05 at 02:28:11ID: 25493575

flow01:
In the privious post, there is a syntax typo.

FORALL does not come with a loop.

Next, Surprisingly, the follwoing works fine..

but, i want this to work with FORALL not with FOR LOOP as given below:

************************************
PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
               p_paramB       OUT               NUMBER
)
IS
TYPE my_rec_typ IS RECORD
(col1      my_tab.col1%TYPE,
col2       my_tab.col2%TYPE);


type t_paramA_type IS table of my_rec_typ
INDEX BY BINARY_INTEGER;

v_paramA   t_paramA_type;

BEGIN

FETCH p_paramA BULK COLLECT INTO v_paramA;

     
FOR  idx IN v_paramA LOOP
      INSERT INTO inst_activity
      VALUES ( v_paramA(idx).col1,
               v_paramA(idx).col2,
               TRUNC (SYSDATE));
END LOOP;

END my_proc;

 

by: gram77Posted on 2009-10-05 at 02:36:35ID: 25493602

flow01:
In a nutshell, I want to know why is it that the object v_paramA is treated as an object in a FOR loop and not as an object in the FORALL stmt.


How can i overcome it?


The following stmt works fine:
FOR  idx IN v_paramA LOOP
      INSERT INTO inst_activity
      VALUES ( v_paramA(idx).col1,
               v_paramA(idx).col2,
               TRUNC (SYSDATE));
END LOOP;

But the following stmt gives an error:

FORALL  idx IN v_paramA
      INSERT INTO inst_activity
      VALUES ( v_paramA(idx).col1, <-- Getting error here! ORA-228096: not an object or REF
               v_paramA(idx).col2, <-- Getting error here! ORA-228096: not an object or REF
               TRUNC (SYSDATE));

 

by: HenkaPosted on 2009-10-05 at 05:18:43ID: 25494461

PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
               p_paramB       OUT               NUMBER
)
IS

 TYPE col1 IS TABLE OF my_tab.col1%TYPE INDEX BY PLS_INTEGER;
 TYPE col2 IS TABLE OF my_tab.col2%TYPE INDEX BY PLS_INTEGER;

pcol1  col1;
pcol2  col2;

BEGIN

FETCH p_paramA BULK COLLECT INTO pcol1,pcol2;
     
FORALL  idx IN 1 .. pcol1.count LOOP
      INSERT INTO inst_activity
      VALUES ( col1(idx),
               col2(idx),
               TRUNC (SYSDATE));
END LOOP;
END my_proc;

 

by: HenkaPosted on 2009-10-05 at 05:20:23ID: 25494468

Oh, there is typo there, yhis is all right:
PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
               p_paramB       OUT               NUMBER
)
IS

 TYPE col1 IS TABLE OF my_tab.col1%TYPE INDEX BY PLS_INTEGER;
 TYPE col2 IS TABLE OF my_tab.col2%TYPE INDEX BY PLS_INTEGER;

pcol1  col1;
pcol2  col2;

BEGIN

FETCH p_paramA BULK COLLECT INTO pcol1,pcol2;
     
FORALL  idx IN 1 .. pcol1.count LOOP
      INSERT INTO inst_activity
      VALUES ( pcol1(idx),
               pcol2(idx),
               SYSDATE);
END LOOP;
END my_proc;

 

by: flow01Posted on 2009-10-05 at 10:03:40ID: 25497102

I forgot :
There is an the stated implementation restriction that prevents us from referencing individual attributes of associative arrays / collections of records within a FORALL statement."

a. Henka's solution removes the record collections and uses collections of individual attributes.
b. You could use the record array solutions in 2 manners:
     b1. Modify the cursor to return a record of my_tab%rowtype. (adding TRUNC (SYSDATE)  to the select.
     b2. User an intermediate array
           type t_paramB_type IS table of my_rec%ROWTYPE
                INDEX BY BINARY_INTEGER;
           v_paramB   t_paramB_type;

           for i1 in 1 .. v_paramA.count loop
                v_paramB(i1).col1 := v_paramA(i1).col1;
                v_paramB(i1).col2 := v_paramA(i1).col2;
                v_paramB(i1).dat1 := TRUNC (SYSDATE);
           end loop;

           FORALL  idx IN 1 .. v_paramB.count
              INSERT INTO inst_activity
                VALUES v_paramB(idx); -- here there reference is to a record
                                                             -- instead of invididual items of a record
           END LOOP;
 

Henka's method is the most clean, but if you get more columns the b1-method delivers a more compact source.        


 

by: gram77Posted on 2009-10-06 at 01:30:45ID: 25502821

Henka:Thanks for your help. I have incorporated your solution.

I want to update my_tab with timestamp and status='N' (record not inserted) for records that could not be inserted.

I have added this in the exception section to the forall block.

Now the problem is that the exception section does not seem to recognize the idx variable
of the idx forall stmt.




PROCEDURE my_proc (p_paramA      IN        sys_refcursor,
                     p_paramB       OUT               NUMBER
)
IS
TYPE my_typ IS RECORD
(
      col1       mytab.col1%TYPE,
      col2       mytab.col2%TYPE
);
 my_rec my_typ;

 TYPE col1_table_type IS TABLE OF my_rec.col1%TYPE
 INDEX BY PLS_INTEGER;
 v_col1 col1_table_type;

 TYPE col2_table_type IS TABLE OF my_rec.col2%TYPE
 INDEX BY PLS_INTEGER;
 v_col2 col2_table_type;
BEGIN
        BEGIN
            FETCH p_paramA BULK COLLECT INTO v_col1 , v_col2;


           FORALL  idx IN 1 .. v_col1.count
               INSERT INTO my_tab
               VALUES ( v_col1(idx),
                        v_col2(idx),
                        TRUNC (SYSDATE) );
       EXCEPTION
            WHEN DUP_VAL_ON_INDEX
            THEN
            UPDATE my_tab
            SET update_ts = SYSTIMESTAMP,
                status_cd = 'N'
            WHERE  col1 = v_col1(idx) <--Error: PLS-00201, IDX must be declared.
            AND col2 = v_col2(idx);
      
            END;

      COMMIT;
EXCEPTION
      WHEN OTHERS
      THEN
            NULL;
END my_proc;

 

by: flow01Posted on 2009-10-06 at 14:05:17ID: 25509943

Search your manuals or the internet for
Handling FORALL Exceptions with the %BULK_EXCEPTIONS Attribute

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...