	[x] Posted via EE Mobile
	Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

5.8

Stored Procedure - Is this right?

Asked by jay-are in MS SQL Server

I use this stored proc with an asp datagrid and something is fishy. Let me post it first:
CREATE procedure usp_SumByControlNo1130
As
BEGIN

INSERT INTO Comments1130 (ControlNo, SumAmt)
SELECT Control#, Sum(Amount)
FROM ODSC_Schedule4 Left Join Comments1130 on ODSC_Schedule4.Control# = Comments1130.ControlNo Where odsc_schedule4.Acct# = '1130' AND Comments1130.ControlNo Is Null
GROUP BY Control#
HAVING Sum(Amount) <> 0

IF @@ERROR <> 0
BEGIN
RAISERROR('Insert into Comments1130 failed', 16, 1)
RETURN -1
END

DELETE FROM Comments1130
WHERE 0 = (
SELECT SUM(Sched4.Amount)
FROM ODSC_Schedule4 Sched4
WHERE Sched4.Control# = Comments1130.ControlNo
AND Sched4.Acct# = '1130'
)

RETURN 0

END
GO

This reads the 'amount' column in schedule4 table and sum's up each amount per control number. Then it should write that sum'd amount to my Comments1130 table. It's doing it right for about 95% of them. I found 3 though that were wrong. They were showing old sum'd amounts. Almost like its not actually updating those 3 records.

Example:
A query ran on Schedule 4 from the analyzer in sql shows this:
Control # Amount
454593 2000
45459393 -600

The same query run on Comments1130 shows this:
ControlNo SumAmt
454593 2000

The 2000 amount was the original entry. Then the -600 was posted about 10 days ago. For some reason it never changed in the Comments1130 file. I use this same stored proc on another BIG datagrid that is used a lot and I haven't had any accuracy complaints. So am I just overlooking something simple? Why isn't it working properly?

Help!

View the Solution FREE for 30 Days

20091021-EE-VQP-81 - Hierarchy

Hall of Fame

1. angelIII1,338,458
2. aneeshatti...1,130,145
3. rrjegan171,067,677
4. chapmandew766,967
5. RiteshShah729,435
6. BrandonG...626,234
7. acperkins602,988
8. reb73522,425
9. ralmada480,654
10. mark_wills446,542
11. mwvisa1405,663
12. matthews...380,570
13. Sharath_...287,698
14. EugeneZ249,260
15. ScottPletc...222,540
16. CGLuttrell218,953
17. momi_sa...206,089
18. pivar192,087
19. cs97jjm3180,186
20. pcelba174,068
21. pssandhu161,259
22. DanielWilson154,733
23. tigin44153,914
24. rob_farley143,153
25. JestersGrind139,263

1. angelIII12,723,120
2. aneeshatti...5,815,343
3. acperkins4,990,376
4. ScottPletc...4,590,513
5. chapmandew3,340,073
6. arbert2,245,195
7. Lowfatsp...2,174,384
8. EugeneZ1,922,043
9. imran_fast1,485,025
10. rafrancisco1,460,132
11. BrandonG...1,339,712
12. nmcdermaid1,263,861
13. mark_wills1,236,802
14. Hilaire1,221,775
15. matthews...1,181,041
16. Nightman1,158,168
17. bhess11,103,687
18. Mr_Peer...1,087,815
19. ptjcb1,074,620
20. rrjegan171,067,677
21. dtodd1,025,298
22. appari900,309
23. adathelad836,908
24. Sirees776,352
25. RiteshShah729,435

Stored Procedure - Is this right?

Asked by jay-are in MS SQL Server

About this solution