Question

using a conditional sproc vs. separate sprocs for returning freetext web search results

Asked by: billbiv

I am currently running a stored procedure that is set up to return results using one of fourvarying queries depending on what variables are sent in with the call to the procedure.  For the most part, the sproc executes reasonably fast (under 2 seconds via query analyzer).  There are four joins in each query and the where clause in each is testing against three different freetext searches (ie searching for the submitted text within three different indexed columns in separate tables).

What I'm wondering is whether it would be more efficient (faster) to split the sproc into 4 versions that I call specifially from the application depending on the final query required.

Page returns from the searches being executed sometimes exceed 6 seconds (about 6 times in an hour) and sometimes extend as long as 20 seconds + (unacceptable).  These delays may be due to other issues/conflicts; I just want to be sure my sql is as efficient as it can be while I also look into other areas of slowdown.

The application is a coldfusion (cfmx7) web app running on a W2000 server with IIS5.0. I pass four variables to the sproc in each call. The state of the variables sent determines which query is run withing the sproc.

Any help, suggestions appreciated.

billbiv

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2006-02-24 at 17:47:07ID21751101
Tags

sql

,

conditional

,

join

,

server

,

sproc

Topic

MS SQL Server

Participating Experts
2
Points
250
Comments
4

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Sproc Not Working
    Hi Experts, My sproc works if I enter "car" but not "car, train" as the value for @Word. How do I fix it? Thanks.

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: acperkinsPosted on 2006-02-24 at 18:01:11ID: 16043970

Perhaps it would help if you posted your stored procedure as it stands now.

 

by: aneeshattingalPosted on 2006-02-24 at 19:08:10ID: 16044098

>What I'm wondering is whether it would be more efficient (faster) to split the sproc into 4 versions that I call specifially >from the application depending on the final query required.
if you can hanle this at the front end(depending on the variale, call appropriate sp), then this will e better

Now four joins won't always reduse the performance...
 Post the SPfor more help

 

by: billbivPosted on 2006-02-25 at 09:56:07ID: 16046037

create proc sp_select_products_like_search_phrase @searchItem varchar(200), @mfgID char(2),  @catID int

-- searchItem may be single word or phrase.
-- searchItem is the text entered
-- mfg code of '00' means none entered
-- catID of 0 means none entered



as



----------------------------------
if @mfgID = '00'
----------------------------------      
      if @catID > 0 --- execute phrase, cat
            begin
      
                  SELECT       TOP 100
                        web_product_number,
                        mfgid_code,
                        db_product_title,
                        mfgsubgroup_name,
                        web_product_title,
                        webtext_product_description,
                        mfgid_name

                        
                        from dbo.category_relations_t
                        JOIN dbo.cssi_category_t ON dbo.cssi_category_t.cscat_recid = dbo.category_relations_t.catRel_cscat_recid                        join dbo.web_data_t on dbo.category_relations_t.catRel_web_product_number = dbo.web_data_t.web_product_number
                        JOIN dbo.db_t ON dbo.web_data_t.web_product_number = dbo.db_t.db_product_number
                        LEFT JOIN dbo.web_text_t ON dbo.web_text_t.webtext_web_product_number = dbo.web_data_t.web_product_number
                        JOIN dbo.mfg_id_t ON dbo.web_data_t.web_mfgid_code = dbo.mfg_id_t.mfgid_code
                        LEFT JOIN dbo.mfg_subgroup_t ON dbo.web_data_t.web_mfgsubgroup_recid = dbo.mfg_subgroup_t.mfgsubgroup_recid
                        
                        LEFT JOIN
                           FREETEXTTABLE(db_t,db_product_title, @searchItem) AS KEY_TBL_1
                                 ON db_t.db_product_number = KEY_TBL_1.[KEY]                        LEFT JOIN
                           FREETEXTTABLE(mfg_subgroup_t,mfgsubgroup_name, @searchItem) AS KEY_TBL_2
                                 ON mfg_subgroup_t.mfgsubgroup_recid = KEY_TBL_2.[KEY]
                        LEFT JOIN
                           FREETEXTTABLE(web_text_t,webtext_product_description, @searchItem) AS KEY_TBL_3
                                 ON web_text_t.webtext_web_product_number = KEY_TBL_3.[KEY]
            
            
                        WHERE      dbo.category_relations_t.catRel_cscat_recid = @catID and web_display_flag = 1
                              and (
                              (FREETEXT (db_product_title, @searchItem) OR
                              FREETEXT (mfgsubgroup_name, @searchItem) OR
                              FREETEXT (webtext_product_description, @searchItem))
                              )                                          
                        ORDER BY KEY_TBL_1.RANK DESC, KEY_TBL_2.RANK DESC, KEY_TBL_3.RANK DESC
      
            end
      else -- execute 1, phrase only
            begin
                  SELECT       TOP 100
                        web_product_number,
                        mfgid_code,
                        db_product_title,
                        mfgsubgroup_name,
                        web_product_title,
                        webtext_product_description,
                        mfgid_name
                        
                        FROM (dbo.web_data_t JOIN dbo.db_t ON (dbo.web_data_t.web_product_number = dbo.db_t.db_product_number))
                        LEFT JOIN dbo.web_text_t ON dbo.web_text_t.webtext_web_product_number = dbo.web_data_t.web_product_number
                        JOIN dbo.mfg_id_t ON dbo.web_data_t.web_mfgid_code = dbo.mfg_id_t.mfgid_code
                        LEFT JOIN dbo.mfg_subgroup_t ON dbo.web_data_t.web_mfgsubgroup_recid = dbo.mfg_subgroup_t.mfgsubgroup_recid
                        
                        LEFT JOIN
                           FREETEXTTABLE(db_t,db_product_title, @searchItem) AS KEY_TBL_1
                                 ON db_t.db_product_number = KEY_TBL_1.[KEY]
                  
                        LEFT JOIN
                           FREETEXTTABLE(mfg_subgroup_t,mfgsubgroup_name, @searchItem) AS KEY_TBL_2
                                 ON mfg_subgroup_t.mfgsubgroup_recid = KEY_TBL_2.[KEY]
                        LEFT JOIN
                           FREETEXTTABLE(web_text_t,webtext_product_description, @searchItem) AS KEY_TBL_3
                                 ON web_text_t.webtext_web_product_number = KEY_TBL_3.[KEY]
            
            
                        WHERE      (FREETEXT (db_product_title, @searchItem) OR
                              FREETEXT (mfgsubgroup_name, @searchItem) OR
                              FREETEXT (webtext_product_description, @searchItem))
                              AND      web_display_flag = 1                  
                                    
                        ORDER BY KEY_TBL_1.RANK DESC, KEY_TBL_2.RANK DESC, KEY_TBL_3.RANK DESC
            end
            
      
else --mfg is defined
      
      if @catID > 0 -- execute 3: phrase, mfg, cat
            begin

            SELECT           TOP 100
                        web_product_number,
                        mfgid_code,
                        db_product_title,
                        mfgsubgroup_name,
                        web_product_title,
                        webtext_product_description,
                        mfgid_name
                        
                        --from category_relations_t first
                        FROM dbo.category_relations_t
                        JOIN dbo.cssi_category_t ON dbo.cssi_category_t.cscat_recid = dbo.category_relations_t.catRel_cscat_recid
                        join dbo.web_data_t on dbo.category_relations_t.catRel_web_product_number = dbo.web_data_t.web_product_number
                        JOIN dbo.db_t ON dbo.web_data_t.web_product_number = dbo.db_t.db_product_number
                        LEFT JOIN dbo.web_text_t ON dbo.web_text_t.webtext_web_product_number = dbo.web_data_t.web_product_number
                        JOIN dbo.mfg_id_t ON dbo.web_data_t.web_mfgid_code = dbo.mfg_id_t.mfgid_code
                        LEFT JOIN dbo.mfg_subgroup_t ON dbo.web_data_t.web_mfgsubgroup_recid = dbo.mfg_subgroup_t.mfgsubgroup_recid
                        
                        LEFT JOIN
                           FREETEXTTABLE(db_t,db_product_title, @searchItem) AS KEY_TBL_1
                                 ON db_t.db_product_number = KEY_TBL_1.[KEY]      
                        LEFT JOIN
                           FREETEXTTABLE(mfg_subgroup_t,mfgsubgroup_name, @searchItem) AS KEY_TBL_2
                                 ON mfg_subgroup_t.mfgsubgroup_recid = KEY_TBL_2.[KEY]
                        LEFT JOIN
                           FREETEXTTABLE(web_text_t,webtext_product_description, @searchItem) AS KEY_TBL_3
                                 ON web_text_t.webtext_web_product_number = KEY_TBL_3.[KEY]

                        WHERE      dbo.category_relations_t.catRel_cscat_recid = @catID       

                        
                              AND mfgid_code = @mfgID
                              AND web_display_flag = 1 AND
                              (FREETEXT (db_product_title, @searchItem) OR
                              FREETEXT (mfgsubgroup_name, @searchItem) OR
                              FREETEXT (webtext_product_description, @searchItem))
                                                      
                        ORDER BY KEY_TBL_1.RANK DESC, KEY_TBL_2.RANK DESC, KEY_TBL_3.RANK DESC
            end

      else -- cat not defined, exectute 2: phrase, mfg
            begin
      
            SELECT           TOP 100
                        web_product_number,
                        mfgid_code,
                        db_product_title,
                        mfgsubgroup_name,
                        web_product_title,
                        webtext_product_description,
                        mfgid_name
                        
                        --from mfg_id_t
                        FROM dbo.mfg_id_t
                        JOIN dbo.web_data_t ON dbo.web_data_t.web_mfgid_code = dbo.mfg_id_t.mfgid_code
                        LEFT JOIN dbo.mfg_subgroup_t ON dbo.web_data_t.web_mfgsubgroup_recid = dbo.mfg_subgroup_t.mfgsubgroup_recid                        JOIN dbo.db_t ON dbo.web_data_t.web_product_number = dbo.db_t.db_product_number
                        LEFT JOIN dbo.web_text_t ON dbo.web_text_t.webtext_web_product_number = dbo.web_data_t.web_product_number
                        LEFT JOIN
                           FREETEXTTABLE(db_t,db_product_title, @searchItem) AS KEY_TBL_1
                                 ON db_t.db_product_number = KEY_TBL_1.[KEY]                        LEFT JOIN
                           FREETEXTTABLE(mfg_subgroup_t,mfgsubgroup_name, @searchItem) AS KEY_TBL_2
                                 ON mfg_subgroup_t.mfgsubgroup_recid = KEY_TBL_2.[KEY]
                        LEFT JOIN
                           FREETEXTTABLE(web_text_t,webtext_product_description, @searchItem) AS KEY_TBL_3
                                 ON web_text_t.webtext_web_product_number = KEY_TBL_3.[KEY]
            
            
                        WHERE      mfgid_code = @mfgID AND web_display_flag = 1      
                              AND
                              (FREETEXT (db_product_title, @searchItem) OR
                              FREETEXT (mfgsubgroup_name, @searchItem) OR
                              FREETEXT (webtext_product_description, @searchItem))
                                                                        

            
                        ORDER BY KEY_TBL_1.RANK DESC, KEY_TBL_2.RANK DESC, KEY_TBL_3.RANK DESC
      
            end


 

by: acperkinsPosted on 2006-02-25 at 10:06:12ID: 16046071

I had thought there might have been a way to combine the queries, I see now that is not fesible.  

Unless you were planning to execute the queries separately, I would leave them exactly as it is.  In other words, it the four stored procedures were only going to be called by this stored procedure, than I see no advantage, whatsoever.

Unrelated, but I would lose the "TOP 100"

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...