Question

Store Procedure Conversion failed when converting datetime from character string

Asked by: datavation

Dear Experts,

I'm trying to create a stored procedure to update a datetime field from 2 input parameters. (The reason it's like this is that I want to enter the start date/time simular to setting an Outlook reminder, where you have a Calendar Selector for the date and a Combo for the Time)

Below is the syntax:

ALTER PROCEDURE dbo.dsp_update_works
(
@work_id                              int,
@work_start_date      varchar,
@work_start_time      varchar
)
AS

UPDATE    dtb140_works
SET              work_start = CONVERT(nvarchar(50), @work_start_date, 106) + ' ' + CONVERT(nvarchar(50), @work_start_time, 108)
WHERE     (work_id = @work_id)

IF @@ERROR <> 0
BEGIN
RAISERROR ('Update Works failed.',18,1)
RETURN
END

When I run the sql it works ok. However, when I run it as a Store Procedure it errors with the following error:

Running [dbo].[dsp_update_works] ( @work_id = 2956, @work_start_date = 17/8/06, @work_start_time = 14:00:00 ).

Conversion failed when converting datetime from character string.
No rows affected.
(0 row(s) returned)
@RETURN_VALUE =
Finished running [dbo].[dsp_update_works].

I've tried various alternatives in variables, but with no success, can someone please tell me what I'm doing wrong?

Many Thanks.


This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2006-04-06 at 10:05:28ID21804377
Tags

failed

,

datetime

,

converting

,

when

,

from

Topic

MS SQL Server

Participating Experts
2
Points
500
Comments
11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. nvarchar, ntext to varchar, text?
    Howdy Experts! Hey I need help with a script? application? dts package? that will go through all the tables in my database and change any nvarchar or ntext fields to varchar and text. Caveat is that I can't lose the data that is in those fields... Any way to do it, other t...
  2. Convert Function and nvarchar
    I am trying to compare a column that is a nvarchar (24) and the data looks like : 7/21/2005 7:41:00 AM I am working with a stored procedure that has several parameters on 'where' clauses. I want to add 2 where clauses to compare >= & <= respectively to 'from' and '...
  3. Error converting nvarchar to datetime
    Hello, In my SP I dont have any column with type nvarchar even then I am getting this error when executed from ASPX page. Here is my stored procedure set ANSI_NULLS ON set QUOTED_IDENTIFIER ON go ALTER PROCEDURE [dbo].[db_Insert_Location] @address_1 varchar(50)...
  4. Error converting data type nvarchar to datetime
    I am getting this error and I can't seem to figure out how to correct it. This is urgent !! I have a table called AN_HEADER The Date fields have all been created as Datetime Data types. I have a stored procedure which is the following; CREATE PROCEDURE [dbo].[Create_Heade...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: aneeshattingalPosted on 2006-04-06 at 10:07:28ID: 16393747

U dont need the conversion, because already these are varchar
@work_start_date     varchar,
@work_start_time     varchar

 

by: aneeshattingalPosted on 2006-04-06 at 10:08:46ID: 16393761

UPDATE    dtb140_works
SET              work_start =  @work_start_date + '  ' + @work_start_time
WHERE     (work_id = @work_id)

 

by: aneeshattingalPosted on 2006-04-06 at 10:11:18ID: 16393785

declare @work_start_date     varchar(30),
@work_start_time     varchar (30)
declare @work_start datetime

select @work_start_date = '04-04-2006',@work_start_time ='11:30 pm'
SET @work_start =  @work_start_date + '  ' + @work_start_time
select @work_start

 

by: datavationPosted on 2006-04-06 at 10:13:16ID: 16393807

I've tried that and it still doesn't work.


Amending the SP to the below:

ALTER PROCEDURE dbo.dsp_update_works
(
@work_id                              int,
@work_start_time      varchar,
@work_start_date      varchar
)
AS

UPDATE    dtb140_works
SET              work_start =@work_start_date + ' ' + @work_start_time
WHERE     (work_id = @work_id)

IF @@ERROR <> 0
BEGIN
RAISERROR ('Update Works failed.',18,1)
RETURN
END

Gives the following Error:

Running [dbo].[dsp_update_works] ( @work_id = 2956, @work_start_time = 14:00, @work_start_date = 17/08/06 ).

Conversion failed when converting datetime from character string.
No rows affected.
(0 row(s) returned)
@RETURN_VALUE =
Finished running [dbo].[dsp_update_works].

 

by: acperkinsPosted on 2006-04-06 at 10:21:22ID: 16393872

>>I've tried that and it still doesn't work.<<
Than you are not paying attention, as aneeshattingal has stated (no points for me please) you need to dimension the varchars, as in:

@work_start_time     varchar(30),
@work_start_date     varchar(30)

 

by: datavationPosted on 2006-04-06 at 10:22:53ID: 16393888

Sorry, I replied before getting your following 2 comments.

Further to your addtional comments, below is my amended SP. But it's still erroring?

ALTER PROCEDURE dbo.dsp_update_works
(
@work_id                  int,
@work_start_date    varchar(30),
@work_start_time    varchar (30)
)
AS

UPDATE    dtb140_works
SET              work_start =@work_start_date + ' ' + @work_start_time
WHERE     (work_id = @work_id)

IF @@ERROR <> 0
BEGIN
RAISERROR ('Update Works failed.',18,1)
RETURN
END

 

by: datavationPosted on 2006-04-06 at 10:27:35ID: 16393917

Thanks acperkins, but I was paying attention, I just hadn't recieved the additional comment, but as I say, it's still not working. (Correct, no points awarded ;-))

 

by: aneeshattingalPosted on 2006-04-06 at 10:34:08ID: 16393983

need to use a SETDATEFORMAT DMY in ur sp

 

by: aneeshattingalPosted on 2006-04-06 at 10:34:18ID: 16393984

SET DATEFORMAT DMY
SELECT @work_start_date = '17/08/06', @work_start_time = '14:00:00'

SET @work_start =  @work_start_date + ' ' + @work_start_time
select @work_start

 

by: aneeshattingalPosted on 2006-04-06 at 10:35:01ID: 16393990

ALTER PROCEDURE dbo.dsp_update_works
(
@work_id                         int,
@work_start_time     varchar(15),
@work_start_date     varchar(15)
)
AS
SET DATEFORMAT DMY
UPDATE    dtb140_works
SET              work_start =@work_start_date + ' ' + @work_start_time
WHERE     (work_id = @work_id)

IF @@ERROR <> 0
BEGIN
RAISERROR ('Update Works failed.',18,1)
RETURN
END

 

by: datavationPosted on 2006-04-06 at 10:47:24ID: 16394127

Many Thanks aneeshattingal, that's excellent.


20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...