Question

Optimization needed on string parsing

Asked by: bhess1

Below is a fraction of a stored procedure I am writing to parse out some non-normalized data into a more normal form.  

What we have are data records containing two specific fields:  MMYString (varchar 255) and MMYLongString (text).  These hold strings containing the make, model, and year of vehicles that the product can be used with.  The MMY strings look like this:

HONDA;CRF250R;2006|HONDA;CRF250R;2005|HONDA;CRF250R;2004

The information will be in MMYString unless the data length is more than 255 characters.  Then the data will be in MMYLongString, and no information will be in MMYString.  Note that we have data strings well over 30kb long for some cases.

I have created a routine that will strip the information out of a text field, and incorporated that into my code, a piece of which is below.  I am looking for any assistance in optimizing this routine, since I would like to run it nightly, and the process takes over an hour at this time.

------------------------------------------------
DECLARE @text table(txt text)


SET @separator = '|'

DECLARE c_Parse CURSOR FOR
      SELECT p.ProductID, lastModificationDate
      FROM SearchJoin sj
      INNER JOIN product P
            ON sj.productid = P.productId
      WHERE MMYExists = 'Y'
            AND lastmodificationdate >= @Cutoff
      ORDER BY p.ProductID

OPEN c_Parse
FETCH NEXT FROM c_Parse INTO @PID, @LMD

WHILE @@FETCH_STATUS = 0
BEGIN
      SELECT @WorkStr = ISNULL(MMYString, '') FROM searchJoin WHERE productid = @Pid
      IF @WorkStr = '' -- Data in mmylongstring
      BEGIN
            INSERT INTO @text
            SELECT MMYLongString AS Txt
            FROM SearchJoin sj
            WHERE sj.ProductID = @PID

            SELECT @i = 1,
                  @len = datalength(txt),
                  @curpos = 1
            FROM @text

            WHILE @curpos <= @len  -- Parse out a text field of arbitrary length in the
            BEGIN
                  select @lastpos=@curpos
                        ,@patindex=patindex('%'+@separator+'%',substring(txt,@lastpos+1,101))
                        ,@patindex=case @patindex when 0 then @len-@lastpos+1 else @patindex END
                        ,@val=substring(txt,@lastpos,@patindex)
                        ,@curpos=@lastpos+@patindex+1
                  FROM @text
            
                  If @Val LIKE '_%;_%;[1-2][0-9][0-9][0-9]' AND @val not like '%;%;%;%'
                  BEGIN
                        Set @Ptr = charindex(';',@val)
                        Set @Make = Left(@Val, @Ptr - 1)
                        SET @Ptr2 = CHARINDEX(';', @val, @ptr + 1)
                        Set @Model = Substring(@Val, @Ptr+1, @Ptr2 - (@ptr + 1))
                        Set @Year = SUBSTRING(@val, @Ptr2 + 1, LEN(@Val))
                  
                        SET @NewID = 0

                        SELECT @NewID = MMYID
                        FROM MMY
                        WHERE Make = @Make
                              AND Model = @Model
                              AND mmy.Year = @Year

                        IF IsNull(@NewID, 0) = 0
                        BEGIN
                        
                              INSERT INTO MMY (Make, Model, Year)
                              VALUES (@Make, @Model, @Year)
                  
                        END
                        IF NOT EXISTS (SELECT * FROM #Product_MMY WHERE ProductID = @PID AND MMYID = @NewID)
                              INSERT INTO #Product_mmy (ProductID, MMYID, LastModificationdate)
                              VALUES (@PID, @NewID, @LMD)
                  
                  END
            END

            DELETE
            FROM @Text
      END
      ELSE
      BEGIN
            WHILE LEN(@WorkStr)>0
            BEGIN
                  Set @Ptr = CHARINDEX(@Separator, @WorkStr, @Ptr2)
                  IF @Ptr = 0
                  BEGIN
                        SET @Val = @WorkStr
                        SET @WorkStr = ''
                  END
                  ELSE
                  BEGIN
                        SET @Val = LEFT(@WorkStr, @ptr-1)
                        SET @WorkStr = SUBSTRING(@WorkStr, @Ptr+1, LEN(@WorkStr))
                  END
                  Set @Make = Left(@Val, @Ptr - 1)
                  SET @Ptr2 = CHARINDEX(';', @val, @ptr + 1)
                  Set @Model = Substring(@Val, @Ptr+1, @Ptr2 - (@ptr + 1))
                  Set @Year = SUBSTRING(@val, @Ptr2 + 1, LEN(@Val))
                  
                  SET @NewID = 0

                  SELECT @NewID = MMYID
                  FROM MMY
                  WHERE Make = @Make
                        AND Model = @Model
                        AND mmy.Year = @Year

                  IF IsNull(@NewID, 0) = 0
                  BEGIN
                        
                        INSERT INTO MMY (Make, Model, Year)
                        VALUES (@Make, @Model, @Year)
                  
                  END
                  IF NOT EXISTS (SELECT * FROM #Product_MMY WHERE ProductID = @PID AND MMYID = @NewID)
                        INSERT INTO #Product_mmy (ProductID, MMYID, LastModificationdate)
                        VALUES (@PID, @NewID, @LMD)
            END
      END
      
      FETCH NEXT FROM c_Parse INTO @PID, @LMD
END

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-02-15 at 15:26:46ID22392945
Tags

1

,

charindex

,

cursor

,

optimizing

,

parse

Topic

MS SQL Server

Participating Experts
1
Points
500
Comments
4

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. par file
    Waht is a file with .par used for and what does this extension mean? Can I list the parameters for import in a .par file and use this file in imp, like imp file=filename.par Please suggest.
  2. PAR Protocol
    How has the PAR Protocol been extended for use in the Internet?
  3. Converting from PERL to Executable using PAR
    I have a PERL script that begins with the following: use Win32::OLE qw(in with); use Win32::OLE::Const 'Microsoft Excel'; When I convert my PERL script to an executable using pp -o file.exe file.pl, there is no problem. But, when I run file.exe I receive the following pop-...
  4. What does the /par in a .bat file mean?
    I am learning to do batch files, and came across this /par in my .bat file. I dont know really how it got there, as I was just manually creating the batch. I did just install easy batch creator, but I didnt use that prog. Anyway here is the code that I have in my batch, but ...
  5. Unable to implement the Perl Packager utility (pp) which c…
    Installed ActivePerl 5.8.8.817 on Windows 2000 Server with the following modules: Parse::Binary 0.10 Win32::Exe 0.09 Module::ScanDeps 0.62 PAR::Dist 0.16 Getopt::ArgvFile 1.07 Executed the perl Makefile.pl command for PAR 0.951 and the following is returned: C:\Perl\mod\PAR...
  6. Importing Error --Using Par file.
    Hi experts. we are using Oracle 10g database. using DATA PUMP i exported data. I have exported dump file & target data base in place. I just need to import only data to target data base, tables which I am importing have constraints defined.( I don't want to disable the...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: nmcdermaidPosted on 2007-02-15 at 22:37:25ID: 18546551

This is the only time that I suggest that this is better done outside the database, say in a VBScript or a VB.Net console application.

Generally string parsing is a bit quicker in an external dedicated app as opposed to a database. The general idea is that you run your app to convert your free text source file into a CSV containing MMY. which you then import into a staging and perform any matching/mapping operations in the database.

You may be able to avoid using a cursor that way which would also improve performance.

An hour isn't too bad for a batch process anyway, if its the only one.

 

by: bhess1Posted on 2007-02-16 at 10:31:28ID: 18550683

The only problem with your suggestion is that the source is, unfortunately, the database (don't ask - it's a 3rd party app custom modified for us by requests from people without a clue... ARRGGGHHH!)

So, I would have to extract the information from the DB, send it to an external app, parse it, then add it to the new table structure.  Ugly, but possible... I'll look into it.

Other than this possible solution, I take it you have no better solution than the one above.  (I may need to move the code elements for parsing the text fields around to some SQL snippet sites, since I could find no code that would successfully parse text more than 8k long).

 

by: nmcdermaidPosted on 2007-02-16 at 21:42:32ID: 18554067

It looks like you know more than me about processing text fields but here is what I see, feel free to shoot me down in flames, because then I will know a little more about processing text data types.

1. Is there any reason that you can't select MMYString in the original cursor, i.e. remove this:

SELECT @WorkStr = ISNULL(MMYString, '') FROM searchJoin WHERE productid = @Pid


and add it to the original cursor:

SELECT p.ProductID, lastModificationDate, sj.MMYString
FROM SearchJoin sj
INNER JOIN product P
ON sj.productid = P.productId
WHERE MMYExists = 'Y'
AND lastmodificationdate >= @Cutoff
ORDER BY p.ProductID

That will save one trip back to the table within cursor. There are a few other places this happens but there might be a good reason for that.


Another suggestion is to have one SP that normalised the text field into a table, for example, parse into a table that contains ProductID, Make, Model, Year.

Then add a bunch of indexes to that table, and then do a bulk operation which joins that to other tables to populate MMY and #Product_mmy in one big bulk operation.


I'm guessing the bulk of the time is in parsing the text field. There's not much you can do about that except do it externally. It may not be as bad as you think, especially if it saves you 40 minutes. If you can at least parse into multiple varchar columns that'll help.

Regarding the external method, I take it this is SQL 2000? It wouldn't be that hard to write a DTS that bulk exports, parses (with a VBScript) then bulk imports.

I have written a few VBS parsing scripts and got some good results.


So in summary my general suggestions are:

1. Try to get the text parsing part out of the way and do the rest using joins rather than cursors
2. Perhaps investigate the bulk export/parse/import option. Even if you just chop the 30k text field into 8 varchar fields internally, at least then you can dispense with annoying text field functions.


Because I haven't seen the whole SP this may be impractical, but maybe I have given you something to think about.

 

by: bhess1Posted on 2007-02-20 at 09:09:23ID: 18572056

A good overview of the possibilities, and you have definitely given me some tools to consider.  I attempted the original select on the hope that a table variable with one row of one text field would keep that in memory, allowing for faster parsing of the text.  And I believe that has proved to be true for TSQL parsing.

Thanks

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...