[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.
Question
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
9.6

Audit trigger not logging deletions

Asked by fuerteventura in MS SQL Server

Tags: SQL Server, 200/2005

I Have created a trigger to log all activity on a table. It is logging all details perfectly for updates and additions, however it is not writing a row when you merely delete a row. My code is below - can anyone spot where I'm goiing wrong?




1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:

ALTER  trigger *Tr_myTableName *on dbo.myTableName for insert, update,
delete as
 
      declare @bit int ,     
      @field int ,     
      @maxfield int ,     
      @char int ,     
      @fieldname varchar(*700*) ,     
      @TableName varchar(*700*) ,     
      @PKCols varchar(*700*) ,     
      @sql varchar(*8000*),     
      @UpdateDate varchar(*100*) ,     
      @UserName varchar(*800*) ,     
      @Type char(*9*) ,     
      @PKSelect varchar(*6500*),     
           
 
      select @TableName = 'myTableName'     
      select       @UserName = system_user ,           
 
 
      if exists (select * from inserted)           
            if exists (select * from deleted)                 
                  select @Type = '*UDT' *          
            else                 
                  select @Type = 'INS'     
      else           
            select @Type = 'DEL'               
 
      select *  into #del from deleted 
      select *  into #ins from inserted           
          
      select      @PKCols = coalesce(@PKCols + ' and', ' on') + ' i.' +
c.COLUMN_NAME + ' = d.' + c.COLUMN_NAME     
            from      INFORMATION_SCHEMA.TABLE_CONSTRAINTS pk ,        
   INFORMATION_SCHEMA.KEY_COLUMN_USAGE c     
            where       pk.TABLE_NAME = @TableName      and    
 CONSTRAINT_TYPE = 'PRIMARY KEY'      and      c.TABLE_NAME =
pk.TABLE_NAME     
            and      c.CONSTRAINT_NAME = pk.CONSTRAINT_NAME           
     
      select @PKSelect = coalesce(@PKSelect+'+','') + '''<' +
COLUMN_NAME + '=''+convert(varchar(100),coalesce(i.' + COLUMN_NAME
+',d.' + COLUMN_NAME + '))+''>'''     
            from      INFORMATION_SCHEMA.TABLE_CONSTRAINTS pk ,        
   INFORMATION_SCHEMA.KEY_COLUMN_USAGE c     
            where       pk.TABLE_NAME = @TableName      and    
 CONSTRAINT_TYPE = 'PRIMARY KEY'      and      c.TABLE_NAME =
pk.TABLE_NAME      and      c.CONSTRAINT_NAME = pk.CONSTRAINT_NAME      
    
     
         
 
      select @field = 0, @maxfield = max(ORDINAL_POSITION) from
INFORMATION_SCHEMA.COLUMNS where TABLE_NAME = @TableName     
     
      while @field < @maxfield     
            begin           
                  select @field = min(ORDINAL_POSITION)
                  from INFORMATION_SCHEMA.COLUMNS
                  where TABLE_NAME = @TableName and ORDINAL_POSITION >
@field           
 
                  select @bit = (@field - 1 )% 8 + 1           
                  select @bit = power(2,@bit - 1)           
                  select @char = ((@field - 1) / 8) + 1           
                 
                  if substring(COLUMNS_UPDATED(),@char, 1) & @bit > 0 or
@Type in ('INS','DEL')           
                        begin                 
                              select @fieldname = COLUMN_NAME
                              from INFORMATION_SCHEMA.COLUMNS
                              where TABLE_NAME = @TableName and
ORDINAL_POSITION = @field                 
                              select @sql =             'insert
*tblAudit (audType, TblNam, primaryKey, FldName,
                                                  Old, New, audDat,
User*)'                 
                              *select @sql = @sql +       ' 
			      select @sql = @sql +       ',''' +
@Type + '''' *                
                              select @sql = @sql +       ',''' +
@TableName + ''''                 
                              select @sql = @sql +       ',' + @PKSelect
                
                              select @sql = @sql +       ',''' +
@fieldname + ''''                 
                              select @sql = @sql +      
',convert(varchar(1000),d.' + @fieldname + ')'                 
                              select @sql = @sql +      
',convert(varchar(1000),i.' + @fieldname + ')'                 
                              select @sql = @sql +       ',''' +
@UpdateDate + ''''                 
                              select @sql = @sql +       ',''' +
@UserName + ''''                 
                              select @sql = @sql +       ' from #ins i
full outer join #del d'                 
                              select @sql = @sql +       @PKCols        
        
                              select @sql = @sql +       ' where i.' +
@fieldname + ' <> d.' + @fieldname                 
                              select @sql = @sql +       ' or (i.' +
@fieldname + ' is null and  d.' + @fieldname + ' is not null)'          
      
                              select @sql = @sql +       ' or (i.' +
@fieldname + ' is not null and  d.' + @fieldname + ' is null)'          
      
                              exec (@sql)           
                        end     
            end
 
     GO
SET QUOTED_IDENTIFIER OFF
GO
SET ANSI_NULLS ON
GO
[+][-]02/07/08 02:10 PM, ID: 20845857Accepted Solution

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

About this solution

Zone: MS SQL Server
Tags: SQL Server, 200/2005
Sign Up Now!
Solution Provided By: ScottPletcher
Participating Experts: 1
Solution Grade: A
 
[+][-]02/08/08 01:12 AM, ID: 20848774Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
 
Loading Advertisement...
20091021-EE-VQP-81 / EE_QW_2_20070628