Advertisement

10.13.2008 at 09:58AM PDT, ID: 23810090
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
6.8

How to improve this stored procedure?

Asked by sassy168 in MS SQL Server

Tags: , ,

I have this stored procedure. How can i improve it ? seems like i am repeating my code. Also, i would like to insert records for the entire month instead of inserting daily. ThanksStart Free Trial 
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:

set ANSI_NULLS OFF
set QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[Insert_Data] AS
 
SET NOCOUNT ON
 
 
 
DECLARE @start_date int
DECLARE @end_date int
SET @start_date = 24
SET @end_date = 43
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (convert(varchar(8),getdate(),112),1, @start_date,0,0,0,(getdate()))
 SET @start_date = @start_date + 1
 
END
 
SET @start_date =44
SET @end_date = 47
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (dateadd(dd, 1, convert(varchar(8),getdate(),112)), 1, @start_date, 0,0,0, getdate())
 
 
 SET @start_date = @start_date + 1
 
END
 
 
SET @start_date = 24
SET @end_date = 43
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (convert(varchar(8),getdate(),112),2, @start_date,0,0,0,(getdate()))
 SET @start_date = @start_date + 1
 
END
 
SET @start_date =44
SET @end_date = 47
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (dateadd(dd, 1, convert(varchar(8),getdate(),112)), 2, @start_date, 0,0,0, getdate())
 
 
 SET @start_date = @start_date + 1
 
END
 
 
 
SET @start_date = 24
SET @end_date = 43
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (convert(varchar(8),getdate(),112),3, @start_date,0,0,0,(getdate()))
 SET @start_date = @start_date + 1
 
END
 
SET @start_date =44
SET @end_date = 47
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (dateadd(dd, 1, convert(varchar(8),getdate(),112)), 3, @start_date, 0,0,0, getdate())
 
 
 SET @start_date = @start_date + 1
 
END
 
 
 
 
 
SET @start_date = 24
SET @end_date = 43
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (convert(varchar(8),getdate(),112),4, @start_date,0,0,0,(getdate()))
 SET @start_date = @start_date + 1
 
END
 
SET @start_date =44
SET @end_date = 47
 
 
 
WHILE @start_date <= @end_date
BEGIN
 -- do your insert...
 
insert into Actual_Data values (dateadd(dd, 1, convert(varchar(8),getdate(),112)), 4, @start_date, 0,0,0, getdate())
 
 
 SET @start_date = @start_date + 1
 
END
 
 
 --Insert compounding records
 
SET @start_date =16
SET @end_date = 24
 
WHILE @start_date <= @end_date
BEGIN
 
INSERT INTO Actual_Data 
( 
	datestamp, 
	Board_ID, 
	Time_ID, 
	Actual_Qty, 
	Target_Qty, 
	Comment_ID, 
    Run_Date
)
SELECT 
	dateadd(dd, 7, getdate()), 
    @start_date,
	( SELECT Time_ID FROM TB_Time WHERE ltrim(rtrim(Time_Desc))= ( SELECT datename(dw,getdate()) )),
	0,
	0,
	15,
	convert(varchar(8),getdate(),112)
 
 SET @start_date = @start_date + 1
 
UPDATE Actual_Data	
SET Target_Qty = ( SELECT Target_Qty FROM TB_Target WHERE TB_Target.Board_ID = Actual_Data.Board_ID and TB_Target.Time_ID =Actual_Data.Time_ID)
 
 
END
[+][-]10.13.2008 at 10:12AM PDT, ID: 22704135

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 10:49AM PDT, ID: 22704501

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 10:50AM PDT, ID: 22704510

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 11:26AM PDT, ID: 22704870

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 11:51AM PDT, ID: 22705100

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 11:32PM PDT, ID: 22709004

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]10.13.2008 at 11:33PM PDT, ID: 22709010

View this solution now by starting your 7-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zone: MS SQL Server
Tags: microsoft, sql server, 2000
Sign Up Now!
Solution Provided By: momi_sabag
Participating Experts: 2
Solution Grade: A
 
 
[+][-]10.14.2008 at 01:35PM PDT, ID: 22715721

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]10.14.2008 at 01:51PM PDT, ID: 22715872

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]10.14.2008 at 04:39PM PDT, ID: 22716993

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]10.15.2008 at 10:48PM PDT, ID: 22728329

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
 
Loading Advertisement...
20081112-EE-VQP-42 - Hierarchy / EE_QW_2_20070628