Question

SQL Insert multiple rows on duplicate key update incorrect syntax

Asked by: marklye

Hi there

Hopefully an easy on for you SQL gurus out there.  I want an SQL statement that will insert if a unique key does not exist, and update the record if it does for multiple records.   I have attached my SQL.   On the final line Ive just set enq_stats=3 while testing, but in the final version, I want to UPDATE with the results from the select query.

Just running the insert without the ON DUPLICATE KEY part works perfectly in an empty table, and inserts 10 or so records from the result of the select statement.  As I have set consult_id to be a unique key, this obviously needs the ON DUPLICATE KEY part to then update.  But thats where Im stuck

Hope this makes sense, thanks very much
Mark

insert into leader_stats (consult_id,enq_stats)
select consultants.id,
count(enquiries.id) as enq
from consultants
left join enquiries on consultants.id=consult_id
where enquiries.date_sent between DATEADD(day, -100, CURRENT_TIMESTAMP) and 
DATEADD(day, -1, CURRENT_TIMESTAMP)
group by consultants.id
ON DUPLICATE KEY UPDATE enq_stats=3

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-11-17 at 22:02:09ID23913320
Tags

SQL

Topics

MS SQL Server

,

SQL Server 2005

,

SQLBase

Participating Experts
1
Points
0
Comments
7

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Accurate Stats with MySQL
    I have made a Redirect script that use MySQL to store the site's info (such as the URL, number of hits sent) the way it works is that I set a maximum number of hits to be send every day.. and each time I redirect a user to that site, it increment the number of hit sent today...
  2. How do I Count Unique Values in a Column in Excel  when F…
    I have a spread sheet which monitors works on several sites. Issues are normally passed to me for each site once. They are split into Issue types eg, building, Misc, A/C etc. Each Issue can be completed independent of the other issues for a particular site. Columns of concer...
  3. Select Unique Incorrect Syntax....
    Hello Experts, trainee SQL Developer here, having a little difficulty with a Select Unique statement... What I'm trying to achieve is a list of unique JBAPEmail (Email Addresses) where the JBAPEmail is not listed on JBACandidate.JBAUsername (registered email addresses)... ...
  4. Select Unique Incorrect Syntax....
    Hello Experts, trainee SQL Developer here, having a little difficulty with a Select Unique statement... What I'm trying to achieve is a list of unique JBAPEmail (Email Addresses) where the JBAPEmail is not listed on JBACandidate.JBAUsername (registered email addresses)... ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Sharath_123Posted on 2008-11-18 at 00:03:28ID: 22982705

replace your statement with MERGE statement.

MERGE Leader_Stats AS T
      USING (SELECT consultants.id AS Consultants_ID,
                    COUNT(enquiries.id) AS Enq
               FROM consultants
               LEFT JOIN enquiries ON consultants.id=consult_id
              WHERE enquiries.date_sent BETWEEN DATEADD(DAY, -100, CURRENT_TIMESTAMP) 
                AND DATEADD(DAY, -1, CURRENT_TIMESTAMP)
              GROUP BY consultants.id) AS S(Consultants_ID,Enq)
         ON (T.Consult_ID = S.Consult_ID)
       WHEN MATCHED THEN UPDATE SET Enq_Status = S.Enq
       WHEN NOT MATCHED THEN INSERT(consult_id,enq_stats) VALUES (S.Consultant_ID,S.Enq)

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:

Select allOpen in new window

 

by: marklyePosted on 2008-11-18 at 14:49:00ID: 22989773

Hi there

Thanks for ther reply, although it errors with:

Msg 156, Level 15, State 1, Line 2
Incorrect syntax near the keyword 'AS'.
Msg 156, Level 15, State 1, Line 9
Incorrect syntax near the keyword 'AS'.


Im probably doing something stupid!  Im using SQL Express 2005 if that helps...

Cheers
Mark

 

by: Sharath_123Posted on 2008-11-18 at 15:19:45ID: 22990038

MERGE statement is new in SQL Server 2008. So you can use the UPDATE and INSERT statement.

------ To update the exisiting records
UPDATE T2
   SET consult_id = T1.consult_id, enq_stats = T1.enq
  FROM (SELECT consultants.id, COUNT(enquiries.id) AS enq
          FROM consultants
          LEFT JOIN enquiries 
            ON consultants.id=consult_id
         WHERE enquiries.date_sent BETWEEN DATEADD(day, -100, CURRENT_TIMESTAMP) and 
               DATEADD(day, -1, CURRENT_TIMESTAMP)
         GROUP BY consultants.id) T1
  JOIN leader_stats T2 ON T1.consult_id = T2.consult_id
 
------ To insert as a new record if not exisit
INSERT INTO leader_stats(consult_id,enq_stats)
       (SELECT consultants.id, COUNT(enquiries.id) AS enq
          FROM consultants
          LEFT JOIN enquiries 
            ON consultants.id=consult_id
         WHERE enquiries.date_sent BETWEEN DATEADD(day, -100, CURRENT_TIMESTAMP) and 
               DATEADD(day, -1, CURRENT_TIMESTAMP)
         GROUP BY consultants.id) T1
  LEFT OUTER JOIN leader_stats T2 ON T1.consult_id = T2.consult_id
 WHERE T2.consult_id IS NULL

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:

Select allOpen in new window

 

by: marklyePosted on 2008-11-18 at 15:50:35ID: 22990287

thanks again for this.  The update works like a dream, but the insert errors with:

Incorrect syntax near 'T1'.

Furthermore, is there a way to work both statements in to the one statement, maybe using ON DUPLICATE KEY UPDATE ?   Although this may not be compatible for SQL express 2005?

Thanks a million...getting there

Mark

 

by: Sharath_123Posted on 2008-11-18 at 15:59:23ID: 22990362

check the queries

-- Check this one
 INSERT INTO leader_stats(consult_id,enq_stats)
       SELECT consultants.id, COUNT(enquiries.id) AS enq
          FROM consultants
          LEFT JOIN enquiries 
            ON consultants.id=consult_id
         WHERE enquiries.date_sent BETWEEN DATEADD(day, -100, CURRENT_TIMESTAMP) and 
               DATEADD(day, -1, CURRENT_TIMESTAMP)
         GROUP BY consultants.id 
  LEFT OUTER JOIN leader_stats T2 ON consultants.consult_id = T2.consult_id
 WHERE T2.consult_id IS NULL
 
-- If the above query doesn't work, then create a temp table 
SELECT consultants.id AS consult_id , COUNT(enquiries.id) AS enq
  INTO #TempTable
  FROM consultants
  LEFT JOIN enquiries 
    ON consultants.id=consult_id
 WHERE enquiries.date_sent BETWEEN DATEADD(day, -100, CURRENT_TIMESTAMP) and 
       DATEADD(day, -1, CURRENT_TIMESTAMP)
 GROUP BY consultants.id
         
-- use the temp table in your INSERT and UPDATE statements
INSERT INTO leader_stats(consult_id,enq_stats)
SELECT consult_id,enq
 FROM #TempTable T1
 LEFT JOIN leader_stats T2 ON T1.consult_id = T2.consult_id
WHERE T2.consult_id IS NULL
 
UPDATE T2
   SET consult_id = T1.consult_id, enq_stats = T1.enq
  FROM #TempTable T1
  JOIN leader_stats T2 ON T1.consult_id = T2.consult_id

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:

Select allOpen in new window

 

by: marklyePosted on 2008-11-19 at 21:01:02ID: 23001289

Hi there

The top query didnt work either.  Thanks though.  For info, Ive found a better way to do it I think by using NOT EXISTS, then running the UPDATE

Thanks for the UPDATE command in the first place though

Cheers
Mark

INSERT INTO leader_stats
(consult_id)
SELECT consultants.id
FROM consultants
WHERE 
not exists (select consult_id from leader_stats
where leader_stats.consult_id = consultants.id)

                                              
1:
2:
3:
4:
5:
6:
7:

Select allOpen in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...