Question

SQL Server Trigger for UPDATE

Asked by: gplana

Dear expert:

I have a table that has a lot of fields, say fields A, B, C, .... I want to add a trigger that, if there is an update which is updating field B, it put also the new value on field A but only if field A is actually NULL.

I tried to make this with an AFTER UPDATE trigger, putting an UPDATE sentence inside, but it seems there is a transaction conflict (maybe because my update blocks the UPDATE that fires the trigger.

I know how to solve this on Oracle (just modifying the :new.A value on an AFTER INSERT trigger), but on SQL-Server 2000 I don't know how to solve it. Any help, please ?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-09-20 at 03:06:47ID24746473
Tags

SQL Server

,

T-SQL

Topic

MS SQL Server

Participating Experts
3
Points
500
Comments
23

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Trigger and Transaction
    I have created a trigger on a table that will fire off after an insertion on that table. This insertion action is part of a transaction. Does the trigger fires off only when the transaction is committed or it will just fire regardless of whether the transaction is rolled back...
  2. triggers
    hi every1.. i m making a project in oracle.. the project is for a company which sells and buys products so there is a stock table a purchase table and a sales table.. what i want 2 do is that when some1 inserts data in the sales table and requried stock is not available then...
  3. Trigger based on transaction
    If I run the following in Oracle delete * from tableA where id in (1,2). I want to run a trigger which audits these deletes, but I want it to audit them as part of the same transaction, so the audit table would have transaction idDeleted ----------- -- . ...
  4. Trigger
    hello experts, i want to create trigger in which case it should create a table at sunday 12.00 noon and drop the table on the next day 1.00 noon automatically ?? i mean is it really possible if so can u just show me with an example?? Thanxs Shyam.

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: greenhacksPosted on 2009-09-20 at 03:31:00ID: 25376572

I would strongly recommend to avoid using of triggers.
Adds more load on the server.

Try to handle this via code would be a better way.

Will see if i can test some trigger code when i get chance, or you can wait for anyother Expert to answer it.

 

by: QlemoPosted on 2009-09-20 at 03:31:41ID: 25376574

There should be no transaction conflict, the trigger is part of the same transaction.

Could you show us please the trigger code you use?

 

by: greenhacksPosted on 2009-09-20 at 03:32:48ID: 25376575

Disadvantages (Problems) of Triggers
http://blog.sqlauthority.com/2007/05/24/sql-server-disadvantages-problems-of-triggers/

Also most of the hosting company disable it.

 

by: gplanaPosted on 2009-09-20 at 04:26:02ID: 25376771

Thank you for your answer.

I have no access to source code, so I need to implement this with a trigger on the database.

I haven't my code in front of me now, but I write something like this:

CREATE TRIGGER trig_dates ON myTable
AFTER UPDATE
IF UPDATED(B)
DECLARE
    CURSOR cInserted IS SELECT id, B FROM INSERTED WHERE A IS NULL;
BEGIN
   DECLARE @b datetime;
   DECLARE @id int;
 
   OPEN cInserted
   FETCH NEXT FROM cInserted INTO @id, @b;
 
   WHILE @@fetch_status = 0 BEGIN
      UPDATE myTable SET B=@b WHERE id=@id;
 
      FETCH NEXT FROM cInserted INTO @id, @a;
   END; 
   CLOSE cInserted;
END;

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:

Select allOpen in new window

 

by: QlemoPosted on 2009-09-20 at 04:38:02ID: 25376812

No need for a cursor.

CREATE TRIGGER trig_dates ON myTable
AFTER UPDATE
IF UPDATED(B)
BEGIN
   update tbl
      set A=new.B
     from inserted new join myTable tbl on new.id = tbl.id
    where new.A is null
END;

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:

Select allOpen in new window

 

by: gplanaPosted on 2009-09-20 at 06:31:42ID: 25377166

I didn't know you can do a join inside an UPDATE.

I will try tomorrow and let you know. Regards.

 

by: QlemoPosted on 2009-09-20 at 07:52:13ID: 25377418

You cannot. If you are using Oracle :-) This is "special syntax" of MSSQL.

There is a pretty good article for the join options you have with different databases at http:/articles/Database/Miscellaneous/UPDATES-with-JOIN-for-everybody.html (http:A_1517.html). I'm certain it contains some Oracle surprise for you, too. If you find it interesting, don't forget to vote Yes for the "Was this article helpful?".

 

by: gplanaPosted on 2009-09-20 at 08:08:36ID: 25377502

Actually I'm using SQL-Server.

I mention Oracle because I have a lot of experience on Oracle, but The solution I were looking for was for SQL-Server, which I think you have provided it before.

I'll try tomorrow and let you know.

Regards.

 

by: QlemoPosted on 2009-09-20 at 08:36:12ID: 25377597

... and there the Article author went in  ^^^ ...

I know that we are talking about MSSQL. I just wanted to point out the difference between both, and that Oracle allows for a similar syntax (but not the same).
Happy trying ...

 

by: acperkinsPosted on 2009-09-20 at 10:21:03ID: 25377959

Just a very minor change (no points please), just to allow for the time when B does not change:

CREATE TRIGGER trig_dates ON myTable

AFTER UPDATE

AS

IF UPDATED(B)
    BEGIN
        UPDATE  tbl
        SET     A = new.B
        FROM    INSERTED new
                JOIN myTable tbl ON new.id = tbl.id
                JOIN DELETED old ON new.id = old.id
        WHERE   new.A IS NULL
                        AND new.B <> Old.B
    END


If there is any chance that the new or old B could be Null then change:
AND new.B <> Old.B

To:
(AND new.B <> Old.B
Or (new.B IS NULL And old.B IS NOT NULL)
Or (new.B IS NOT NULL And old.B IS NULL))

 

by: gplanaPosted on 2009-09-20 at 10:36:33ID: 25378019

Thank you.

 

by: QlemoPosted on 2009-09-20 at 10:48:13ID: 25378119

That's true, acp. Totally overseen ... Under rare conditions, this might be an issue.

Why we need that? IF UPDATED(B) is triggered if the column is set in an UPDATE, even if it is unchanged or empty.  As long as it remains empty (NULL), no harm would be done; but if B is filled already without triggering the code (how ever this should happen), at first update of the table with B in SET the value would be copied into A. Whether that is a bug or a feature is left to the question author.

 

by: gplanaPosted on 2009-09-20 at 11:09:26ID: 25378261

Sorry, I think now I don't fully understand. Which bug ? Does this bug invalidates the second code or the first one ?

 

by: acperkinsPosted on 2009-09-20 at 11:13:43ID: 25378281

>>Why we need that? IF UPDATED(B) is triggered if the column is set in an UPDATE, even if it is unchanged or empty.<<
That was to account for the time when B is updated, but not changed.  But you are right that is for the author to decide if it is relevant or not.

 

by: gplanaPosted on 2009-09-20 at 11:23:41ID: 25378330

Yes, it could be rellevant, as maybe the program is updating the field even when there is no change (maybe is updating all fields for any change).

What I don't understand is the comment abut the bug.

 

by: QlemoPosted on 2009-09-20 at 11:33:38ID: 25378379

As long as B is NULL, that value will be updated for A each time you update your table. I.e. the trigger is writing NULL into A each time.

Is there any situation were B could be filled, but with the trigger disabled temporarily, e.g. bulk inserts/copys or the like? Or records inserted with a already filled-out B?

 

by: gplanaPosted on 2009-09-20 at 11:44:17ID: 25378423

no, there aren't bulk inserts or something like that. So once the trigger is created, it won't be dsabled.

 

by: acperkinsPosted on 2009-09-20 at 13:09:11ID: 25378752

Just forget about the specific case of NULL for now.  If you only want to update A when B's value actually changes then you have to compare the before and after values as I posted.  All IF UPDATED(B) tells you is that B participated in an UPDATE statement and not that its value changed.

I trust that is clear.

 

by: gplanaPosted on 2009-09-20 at 13:15:28ID: 25378769

Excellent. Now I understand. Thank you very much.

So I wil add the conditions on the WHERE.

 

by: gplanaPosted on 2009-09-21 at 05:55:43ID: 31631108

Excellent. It worked properly now.

Can you explain why my own solution failed ? Is it not possible to query the UPDATED trigger using a cursor inside the trigger?

 

by: QlemoPosted on 2009-09-21 at 06:17:20ID: 25382498

>> "Can you explain why my own solution failed"
No, I cannot. Even if using a Cursor, it should have worked.

 

by: gplanaPosted on 2009-09-21 at 06:30:59ID: 25382607

It didn't work with a cursor, but this solution is better. So thank you a lot.

Maybe there was another error and now it's fixed because I rewrited the trigger.

You helped me a lot, Qlemo. Thank you so much.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...