Question

When dateadd function makes it to next day, my logic fails.

Asked by: Mehram

SQL Server 2005

If a person has come (timein varchar(8) ) 180 minutes late then his office time (otimein)
he should be treated as 1 day absent.
If he is 77 minutes late, he should be treated as 1/2 absent.
If he is 17 minutes late, he should be treated as 1/4 absent.

My code, (see code snippet) works as long as the otimein is less than 21:00:00,
otherwise it fails because then the dateadd functions makes it to next day.

What is the correct way?

update a
set  remarks	=   case when a.flag not in ('R','G') then
        case when a.timein > convert(varchar,dateadd(s,180*60,convert(datetime,a.otimein)),108) then '1 Absent' 
   else case when a.timein > convert(varchar,dateadd(s,77*60,convert(datetime,a.otimein)),108) then '1/2 Absent' 
   else case when a.timein > convert(varchar,dateadd(s,17*60,convert(datetime,a.otimein)),108) then '1/4 Absent' 
   else a.remarks
   end end end end 
from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2009-11-06 at 20:26:44ID24879953
Tags: Mateen
Topic: MS SQL Server
Participating Experts: 3
Points: 500
Comments: 14

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: MuhammadKashifPosted on 2009-11-06 at 22:28:37ID: 25765198

For this your Times (timein, otimein) should contain date part too. like '2009/11/07 09:00'

bit change in your query because no need to use convert.

try following

Regards,
Kashif

declare @otimein datetime,
	@timein datetime
set @otimein = '2009/11/07 22:00'
set @timein = '2009/11/08 00:00' 
select	 case when datediff(minute, dateadd(minute, 180, @otimein), @timein) > 0 then '1 Absent'
	else case when datediff(minute, dateadd(minute, 77, @otimein), @timein) > 0 then '1/2 Absent' 
	else case when datediff(minute, dateadd(minute, 17, @otimein), @timein) > 0 then '1/4 Absent' 
	else 'No Absent'
	end end end

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:

Select all Open in new window

by: dqmqPosted on 2009-11-06 at 22:49:10ID: 25765228

Better to compare datetimes than to compare strings.

case when convert(datetime,a.timein,108) > dateadd(s,180*60,convert(datetime,a.otimein,108) then '1 Absent'

Having said that, you have a different problem if the office time is before midnight and the time in is after midnight.

by: MehramPosted on 2009-11-06 at 23:29:39ID: 25765311

Hi Muhammad Kamran

For this your Times (timein, otimein) should contain date part too. like '2009/11/07 09:00' >>

Our timein, otimein does not contain date part.

By taking an imaginary date I have reached so far which seems to be working.

But this code looks ugly and long.

update a
     set  remarks	=   case when a.flag not in ('R','G') then
                case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,14400,convert(datetime,'1969/01/01 ' + otimein)))  between - 86399 and -14400 then '1 Absent'
           else case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,10800,convert(datetime,'1969/01/01 ' + otimein)))  between - 14399 and -1020 then '1/2 Absent'
           else case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,1020,convert(datetime,'1969/01/01 ' + otimein)))  between - 1019 and -1 then '1/4 Absent'
           else a.remarks
           end end end end 
	from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: MehramPosted on 2009-11-06 at 23:30:45ID: 25765318

Hi dqmg,

Could you recode my this try in more efficient way.

update a
set remarks = case when a.flag not in ('R','G') then
case when datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,14400,convert(datetime,'1969/01/01 ' + otimein))) between - 86399 and -14400 then '1 Absent'
else case when datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,10800,convert(datetime,'1969/01/01 ' + otimein))) between - 14399 and -1020 then '1/2 Absent'
else case when datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,1020,convert(datetime,'1969/01/01 ' + otimein))) between - 1019 and -1 then '1/4 Absent'
else a.remarks
end end end end
from @t a

by: MehramPosted on 2009-11-06 at 23:31:43ID: 25765323

Hi dqmg,

Could you recode my this try in more efficient way.

update a
     set  remarks       =   case when a.flag not in ('R','G') then
                case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,14400,convert(datetime,'1969/01/01 ' + otimein)))  between - 86399 and -14400 then '1 Absent'
           else case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,10800,convert(datetime,'1969/01/01 ' + otimein)))  between - 14399 and -1020 then '1/2 Absent'
           else case when  datediff(s,convert(datetime,'1969/01/01 ' + a.timein) , dateadd(s,1020,convert(datetime,'1969/01/01 ' + otimein)))  between - 1019 and -1 then '1/4 Absent'
           else a.remarks
           end end end end
        from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: MehramPosted on 2009-11-06 at 23:45:00ID: 25765362

Hi expert,

My second try is also not working correctly.

by: MehramPosted on 2009-11-07 at 00:12:12ID: 25765414

Hi dqmg

<<YOu have a different problem if the office time is before midnight and the time in is after midnight.
We dont have this issue right now.

<<Better to compare datetimes than to compare strings.
Agreed.

If times fall within the same day. Then this code is working.

Thanks for your guidance.

	update a
     set  remarks	=   case when a.flag not in ('R','G') then
                case when  datediff(s,a.timein ,otimein) * -1 > 14400 then '1 Absent'
           else case when  datediff(s,a.timein ,otimein) * -1 > 10800 then '1/2 Absent'
           else case when  datediff(s,a.timein ,otimein) * -1 > 1020  then '1/4 Absent'
           else a.remarks
           end end end end 
	from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: MuhammadKashifPosted on 2009-11-07 at 00:25:55ID: 25765435

>>My second try is also not working correctly.
ofcourse it will not give your desired result. the only thing can solve your problem is that there should be date part in the fields not as you are concatenating.

>>Could you recode my this try in more efficient way.
no need to concate date with time convert(datetime,'1969/01/01 ' + a.timein)
just use convert(datetime, a.timein) it will automatically add default date with your time like
like if i use
select convert(datetime,'9:10') It will be '1900-01-01 09:10:00.000'

have following query but again i say that it will not solve your problem.

One thing that you can do... set some time period say('00:00' and '3:00') ... if timein is between that period than consider is as the previous day's timein. I can explain this if you require this way

Regards,
Kashif

update a
set  remarks       =   case when a.flag not in ('R','G') then
        case when  datediff(s,convert(datetime, a.timein) , dateadd(s,14400,convert(datetime, otimein)))  between - 86399 and -14400 then '1 Absent'
   else case when  datediff(s,convert(datetime, a.timein) , dateadd(s,10800,convert(datetime, otimein)))  between - 14399 and -1020 then '1/2 Absent'
   else case when  datediff(s,convert(datetime, a.timein) , dateadd(s,1020,convert(datetime, otimein)))  between - 1019 and -1 then '1/4 Absent'
   else a.remarks
   end end end end
from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: Sharath_123Posted on 2009-11-07 at 00:50:46ID: 25765488

try this

        update a
     set  remarks       =   case when a.flag not in ('R','G') then
                case when  datediff(minute,a.otimein ,timein) > 180 then '1 Absent'
                     when  datediff(minute,a.otimein ,timein) > 77 then '1/2 Absent'
                     when  datediff(minute,a.otimein ,timein) > 17  then '1/4 Absent'
                     else a.remarks
           end end
        from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: MuhammadKashifPosted on 2009-11-07 at 01:36:23ID: 25765596

I applied the above mentioned logic in the following query

I have changed @timein to the following to implement the logic.
case when @timein between '00:00' and '03:00' then dateadd(day, 1, @timein) else @timein end

Regards,
Kashif

declare @otimein varchar(5),
	@timein varchar(5)
set @otimein = '22:00'
set @timein = '01:01' 
select	 case when datediff(minute, dateadd(minute, 180, @otimein), 
			case when @timein between '00:00' and '03:00' then dateadd(day, 1, @timein) else @timein end
			) > 0 then '1 Absent'
	else case when datediff(minute, dateadd(minute, 77, @otimein), 
			case when @timein between '00:00' and '03:00' then dateadd(day, 1, @timein) else @timein end
	) > 0 then '1/2 Absent' 
	else case when datediff(minute, dateadd(minute, 17, @otimein), 
			case when @timein between '00:00' and '03:00' then dateadd(day, 1, @timein) else @timein end
	) > 0 then '1/4 Absent' 
	else 'No Absent'
	end end end

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:

Select all Open in new window

by: Sharath_123Posted on 2009-11-07 at 01:43:44ID: 25765610

How exactly you are storing the dates in your "timein" and "otimein" columns? If that in date + time ( time in 24 hors format) then you can just try my query.

by: MehramPosted on 2009-11-07 at 02:59:39ID: 25765783

Hi Sharath_123

Your code is working like magic.
Thanks.

BTw, One of my friend gave me this which is nearly same as yours.

	update a
     set  remarks	=   case when a.flag not in ('R','G') then
                case when  datediff(s,a.timein ,otimein) * -1 > 14400 then '1 Absent'
           else case when  datediff(s,a.timein ,otimein) * -1 > 10800 then '1/2 Absent'
           else case when  datediff(s,a.timein ,otimein) * -1 > 1020  then '1/4 Absent'
           else a.remarks
           end end end end 
	from @t a

1:
2:
3:
4:
5:
6:
7:
8:

Select all Open in new window

by: MehramPosted on 2009-11-07 at 03:01:09ID: 31651314

Thanks and regards.

by: Sharath_123Posted on 2009-11-07 at 03:35:51ID: 25765885

Mehram - You are welcome. Your query is also good but no need to have the extra "else case". Instead of multiplying with -1 you can swap the columns in the datediff function.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

When dateadd function makes it to next day, my logic fails.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Mateen

MS SQL Server

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press