Passing in SQL Server Parameter in Where IN clause : sql, parameter, clause, server

May 17, 2008 12:52pm pdt

1. chapmandew 1,139,490
2. angelIII 656,012
3. aneeshat... 347,059
4. ee_rlee 305,823
5. dtodd 190,705
6. brejk 170,605
7. ptjcb 151,519
8. mark_wills 146,165
9. PFrog 98,658
10. acperkins 86,575
11. dqmq 75,630
12. dportas 74,146
13. momi_sabag 71,940
14. maradam 71,186
15. Thomasian 70,100

1. angelIII 1,936,203
2. chapmandew 1,139,490
3. aneeshat... 912,164
4. ptjcb 515,911
5. Yveau 505,473
6. dtodd 401,710
7. PFrog 368,686
8. dqmq 346,978
9. imitchie 324,100
10. ee_rlee 305,823
11. appari 277,897
12. Lowfatsp... 220,339
13. rboyd56 192,515
14. SQL_SERV... 183,215
15. acperkins 181,914

02.09.2007 at 02:03PM PST, ID: 22157124

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

8.4

Passing in SQL Server Parameter in Where IN clause

Zones: SQL Server 2005, MS SQL Server

Tags: sql, parameter, clause, server

I have the following stored procedure:
---
create procedure uspGetRefills
@p varchar(255)
as
select * from uvwRefill
where Cast(MSRecID as varchar(255)) in (@p)
---
I want to pass in a list of parameters 'comma' delimited into the where clause. Currently, I've tried the following:

----
uspGetRefills '1,2'
---

But it does't work. However, if I do the following:
---
select * from uvwRefill
where Cast(MSRecID as varchar(255)) in ('1','2')
---
It returns what I need. Now do I pass a parameter into SQL Server to get this to work? Or will I need to build the SQL Statement Dynamically?

Start your free trial to view this solution

Question Stats

Zone: Microsoft

Question Asked By: bugsnbre2

Solution Provided By: Sirees

Participating Experts: 4

Solution Grade: A

Translate:

Loading Advertisement...

Microsoft

Internet Protocols
Applications

Development
OS

Hardware
Windows Security

Apple

Operating Systems
Hardware

Programming
Networking

Software

Internet

Search Engines
File Sharing
WebTrends / Stats
Spy / Ad Blockers

Web Browsers
New Net Users
Web Development
Chat / IM

Anti Spam
Web Servers
Anti-Virus
Email Clients

Gamers

Tips
Online / MMORPG
Puzzle
Emulators

Action / Adventure
Role Playing
Consoles
Game Programming

Strategy
Sports
Misc
Computer Games

Digital Living

Hardware
New Net Users
New Users

Software
Digital Music
Gaming World

Home Security
Apple
Networking Hardware

Virus & Spyware

Vulnerabilities
IDS
Encryption
Anti-Virus

Operating Systems Security
Software Firewalls
WebApplications
Cell Phones

Operating Systems
Internet
Hardware Firewalls

Hardware

Handhelds / PDAs
Displays / Monitors
Components
Networking Hardware

Peripherals
Laptops/Notebooks
Storage
Servers

Desktops
New Users
Misc
Apple

Software

System Utilities
Industry Specific
Network Management
Photos / Graphics
Page Layout
VMWare
Misc
Web Development

OS
CYGWIN
Voice Recognition
Message Queue
Quality Assurance
Security
Firewalls
MultiMedia Applications

Development
Database
Office / Productivity
Business Management
OS/2 Apps
Server Software
Internet / Email

ITPro

OS
Storage
Encryption
Operating Systems Security
Apple Hardware
Laptops & Notebooks
Servers
Networking Hardware
Peripherals

Devices
Displays / Monitors
WebTrends / Stats
Search Engines
Firewalls
WebApplications
IDS
Vulnerabilities
Email Clients

File Sharing
Spy / Ad Blockers
Web Browsers
Web Servers
Networking
Anti-Virus
Chat / IM
Anti Spam

Developer

Web Servers
Web Browsers
Game Programming
Dev Tools
Industry Specific
Office / Productivity

Database
CYGWIN
Web Development
Search Engines
File Sharing
WebTrends / Stats

Programming
Content Management
Application Servers
Protocols

Storage

Removable Backup Media
Storage Technology
Servers

Grid
Remote Access
Backup / Restore

Misc
Hard Drives

Miscellaneous
Security
Development
Linux
VMWare

MainFrame OS
Unix
Apple
OS / 2
AS / 400

BeOS
Microsoft
VMS / OpenVMS

Database

Oracle
Miscellaneous
MySQL
Software
Sybase
Contact Management
PostgreSQL
Data Manipulation
Clarion
InterSystems Cache

Siebel
MUMPS
OLAP
SQLBase
SAS
GIS & GPS
4GL
Berkeley DB
DB2
Informix

Interbase / Firebird
FoxPro
Reporting
LDAP
Filemaker Pro
MS SQL Server
dBase
MS Access

Security

Misc
Web Browsers
Software Firewalls
Operating Systems Security
File Sharing

Spy / Ad Blockers
Vulnerabilities
WebApplications
IDS
Anti-Virus

Encryption
Anti Spam
Email Clients
VPN
Chat / IM

Programming

Editors IDEs
Installation
Handhelds / PDAs
Multimedia Programming
System / Kernel

Algorithms
Game
Signal Processing
Project Management
Open Source

Database
Misc
Languages
Processor Platforms
Theory

Web Development

Scripting
Blogs
Web Servers
Software
Search Engines
Web Graphics
Images

Internet Marketing
Images and Photos
Components
Document Imaging
Web Languages/Standards
Illustration
WebApplications

Fonts
WebTrends / Stats
Authoring
Digital Camera Software
Miscellaneous

Networking

Protocols
Apple Networking
Network Management
Message Queue
Application Servers
Content Management
File Servers
Email Servers
Misc
Java Editors & IDEs

Wireless
Networking Hardware
Backup / Restore
System Utilities
ISPs & Hosting
Web Servers
Storage Technology
Removable Backup Media
Servers
Broadband

Grid
OS / 2
Novell Netware
Unix Networking
Windows Networking
Security
Telecommunications
Operating Systems
Linux Networking

Other

Community Advisor
Lounge
Community Support
New Net Users

Philosophy / Religion
Math / Science
Miscellaneous
URLs

Expert Lounge
Politics
Puzzles / Riddles

Community Support

Suggestions
New to EE
New Topics
Community Advisor

CleanUp
Announcements
General

Feedback
Input
EE Bugs

02.09.2007 at 02:08PM PST, ID: 18504926

Rank: Sage

Sirees:

Try modifying the procedure as

create procedure uspGetRefills
@p varchar(500)
as
begin
declare @SQL varchar(600)
set @SQL = 'select * from uvwRefill where Cast(MSRecID as varchar(255)) in ('+ @p+')'
EXEC(@SQL)
end

Accepted Solution

02.09.2007 at 02:08PM PST, ID: 18504930

Rank: Sage

BriCrowe:

you can't use a parameter this way without using dynamic sql with has its own drawbacks

DECLARE @sql varchar(1000)
SET @sql = 'SELECT * FROM uvwRefill WHERE MSRecID IN (' + @p + ')'
EXEC (@sql)

You don't need to cast it in this case.

Assisted Solution

02.09.2007 at 02:26PM PST, ID: 18505030

Rank: Genius

ScottPletcher:

By far the best solution is to parse @p into a table variable / temp table and then join on that. This will produce a far better execution plan [SQL is optimized for doing joins] and the overheading of splitting a char string is relatively low.

DECLARE @recIds TABLE (
recId INT,
PRIMARY KEY (recId) --will help performance!
)

-- add code here to parse @p into the entries in the table below:
-- there are several examples on EE and on the web in general;
-- if you would like code added to do the split, just let me know.

-- ...code to parse / split goes here
-- ...

select *
from uvwRefill
inner join @recIds recIds ON recIds.recId = uvwRefill.MSRecID

02.09.2007 at 02:27PM PST, ID: 18505039

Rank: Genius

angelIII:

you should avoid the dynamic sql olutions suggested above...

please create the following function:

CREATE FUNCTION dbo.ParmsToList (@Parameters varchar(500))
returns @result TABLE (Value varchar(30))
AS
begin
DECLARE @TempList table
(
Value varchar(30)
)

DECLARE @Value varchar(30), @Pos int

SET @Parameters = LTRIM(RTRIM(@Parameters))+ ','
SET @Pos = CHARINDEX(',', @Parameters, 1)

IF REPLACE(@Parameters, ',', '') <> ''
BEGIN
WHILE @Pos > 0
BEGIN
SET @Value = LTRIM(RTRIM(LEFT(@Parameters, @Pos - 1)))
IF @Value <> ''
BEGIN
INSERT INTO @TempList (Value) VALUES (@Value) --Use Appropriate conversion
END
SET @Parameters = RIGHT(@Parameters, LEN(@Parameters) - @Pos)
SET @Pos = CHARINDEX(',', @Parameters, 1)

END
END
INSERT @result
SELECT value
FROM @TempList
RETURN
END

and you will make your procedure like this:

create procedure uspGetRefills
@p varchar(255)
as
select * from uvwRefill
where MSRecID in (select cast(value as int) from dbo.ParmsToList(@p) )

02.09.2007 at 02:30PM PST, ID: 18505053

Rank: Genius

ScottPletcher:

How many rows are in uvwRefill? If/as it becomes progressively bigger, your performance will get progressively worse.

02.09.2007 at 02:40PM PST, ID: 18505106

bugsnbre2:

There are 8200 rows in the view, but I will only be returning 5 or 6 at the most.

02.09.2007 at 02:55PM PST, ID: 18505200

Rank: Genius

ScottPletcher:

See you in a few months, when it grows and you post another q to figure out how to speed it up :-) (and we wonder why software development is moving offshore).

02.09.2007 at 03:14PM PST, ID: 18505273

bugsnbre2:

Not if I use your solution!!

20080206-EE-VQP-25