Question

Manual Auto-Increment

Asked by: batchakamal

I have the following INSERT trigger in a table to add the maximum number based on Center and Year for the inserted record. This table is going to hold around 2 million records. Is this a best way to do Auto-Increment.
OR
Create a Table as a ControlTable with InWardNumber as a column to hold the last number. During Insert I can get that number and add one to this IncomingItems.InWardNumber and also update the controlTable for the next Number.

Also, very importantly, how about if many users try to insert on this table? How this trigger will behave?

ALTER TRIGGER [InsertWithInWardNumber] ON [dbo].[IncomingItems]
For Insert
AS
declare @CustomNo nvarchar(Max)
SET @CustomNo = (SELECT InWardNumber FROM INSERTED)
IF (@CustomNo IS NULL OR ltrim(rtrim(@CustomNo)) = '')
BEGIN
	select @CustomNo = ISNULL(max(InWardNumber),0) + 1 from IncomingItems
		where IncomingItems.CenterId = (SELECT CenterId FROM INSERTED)
		and   IncomingItems.ItemYear = (SELECT ItemYear FROM INSERTED)
 
	Update dbo.IncomingItems set InWardNumber = @CustomNo
	Where InWardId = (SELECT InWardId FROM INSERTED) 
END

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-06 at 23:54:12ID24880108
Topic

SQL Server 2005

Participating Experts
3
Points
500
Comments
7

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Auto Increment
    I need to create a table with an auto-increment column. e.g. myTable.idCol Is this an option and if not, what code do I need in what trigger
  2. Auto increment?
    Does Oracle have an Auto Increment data type? I have 8i and need to create an auto increment. Thanks

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: angelIIIPosted on 2009-11-06 at 23:55:38ID: 25765381

why not use the IDENTITY ?
that does all the work for you, and much better...

 

by: batchakamalPosted on 2009-11-06 at 23:57:27ID: 25765387

No, this increment is based on CenterId and ItemYear for InWardNumber (This is a logical number).
Already I have an identity column as a Primary Key which is InWardId.

 

by: BitsqueezerPosted on 2009-11-07 at 01:09:38ID: 25765526

Hi,

I would say you will get in troubles with this kind of increment.

Let's say the year is 2009 and the CenterID is 1. Your resulting number would be 20091. Then, a few records later, the CenterID is 10, resulting number would be 200910. In 2010 and CenterID 1 you number would be 20101.
The table would look like this:

20091
20092
20093
20094
20095
20096
20097
20098
20099
20101
200910

Your trigger asks for a record of this table where the CenterID and year is equal to the one which was inserted. First question is: Where does the CenterID in the inserted record come from? Normally you would expect that this is a new number because it is an INSERT command. If it is a new number, the result of the SELECT would be an empty record, so ISNULL...+1 would be 1, in every case of a new CenterID. If CenterID is not a new number, the result would be the next number after CenterID and because the SELECT only returns one number the MAX does always return this one number. Even if the WHERE would be changed, you would see that there is a problem between 20099, 20101 and 200910 as the last one is the maximum one.
Next is that you test if the CustomerNo is empty in an inserted record - normally I would expect that this is the case in every new record as you want to generate a new number. So the result would be the trigger is never executed.
Next is the many users. "Max" is always a problem in a multi-user environment as you never know if the record is the max record in the next microsecond. Between two commands there can be a difference in an environment with heavy load.

So, you said you already have an ID on this table which cannot be used for auto-increment the custom number. As this is the case I would do it in this way:

1. You already have two fields for CenterID and year which are the base of the new number - let it in this way and don't add an extra field to calculate an assembled number and store it in the database. For the example above your table could look like this:

InwardID    Year     CenterID
34567         2009      8
34568         2009      9
34569         2009      10
...
34970         2010      1
34971         2010      2

2. now let the client do the work: If you open a record of this table, display the fields Year and CenterID as one number like "2009-8" or whatever you like. This is no problem in any client. For the user there is no difference of displaying a precalculated field or displaying an assembled field. And in SQL you have a lot more possibilities to select the right records as you can select records of a year and sort the records with the CenterID and so on.

3. now the INSERT: Again let the client do the work. In the moment of the insert you can test the table with MAX(CenterID) if there is already a CenterID "2" in year 2010 - which is the case here in the example, another user was faster. If this is the case, loop until MAX(CenterID) doesn't return a result. Then try to use the new ID for the INSERT command and catch the error if there is one. If there is one it means again another user was faster, so loop again. You will need a VERY high load to let the user wait longer than one or two seconds to save the new record.

Another possibility is to insert a new record when the user begins to write one and display the new CustomerNo in the client application. The number is reserved on this way and to get the number you can use the same loop as described above. This would only move the time to wait for a new number to the beginning instead of the time when the user is saving the record. The disadvantage of this method is, if the user decides to close the record without saving the number was blocked for other users which got a higher number in the meantime. So you must delete the unused one when closing the form and maybe get the not used number for the next user - this is difficult and not so easy as the first method.

Cheers,

Christian

 

by: batchakamalPosted on 2009-11-08 at 02:48:06ID: 25770086

Hi Bitsqueezer,

Thanks for your longer response. But I think you did not understand what I meant above or I did not write as you can understand well. Sorry for that.

Actually I did not mention anything about Combining those column value into one as you mentioned 20091, 20092 etc. In my case, my InwardNumber is going to be unique for each Center and Year, as I clearly mentioned in the trigger query.

My question was, what is the best alternative for the above method? How it will affect the performance?

I hope I clarified you.

 

by: samijsrPosted on 2009-11-08 at 04:20:08ID: 25770255

trigger is not advisable unless, it is very important as it make database performance slow. as of your case where the data is 2 miliom, It's not at all advaisable to have such trigger.

Other Alternative could be : use identity columne  

Or use the manula Increment through your front-end client side program instead on database.

3rd Option I will suggest if both above is not suite for your program then use a stored procedure for insert statement, and make manual increment within stored procedure instead of trigger.

 

by: batchakamalPosted on 2009-11-08 at 04:30:26ID: 25770269

1. I cannot use Identity Column because I want to increment this column for Each Center for Each Year.
2. If I make this code in front end application, then how about if more than one user press Save for this page? Only one user will get the new number.
3. If I make this code as a SP, again same as point 2, if n number of user call this sproc at the same time.

So, which other alternative is the best?

 

by: samijsrPosted on 2009-11-08 at 04:54:21ID: 25770320

In case 2 there is a chances of delay response from Server and same time other user also save at same time, but it cane be handled by checking if the number already exsit, in save statement.

case 3: through SP this problem will have very less chance as SQL database lock system, what ever insert statement execute, it will be in Que, and u can roll back insert statement, if incremental  value  already exist exist.

Option 4: As I said that use of trigger, for such statement is only advisable when there is no other better option, so as of your requirement may be trigger is best suited.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...