Question

Stored Procedure Help - creating with Parameters to pull into Excel

Asked by: JeffSturgeon2002

I need help with my SP below. My goal is to create a SP that has two parameters @StartDate and @EndDate that will require a end user to populate values into two distinct cells in Excel.

I tried to run my SP in SQL as such to test it and did not get what I hoped:

EXEC dbo.cusExcelMTD
      @StartDate = '2009-09-01 21:36:1.625', --  datetime
      @EndDate = '2009-09-31 21:36:1.625' --  datetime

and I got this back:

Msg 8114, Level 16, State 5, Procedure cusExcelMTD, Line 0
Error converting data type varchar to datetime.

I think I need to set up my parameters better, but not 100%. Can someone spot check my coding below and make recommendations? Any help is appreciated!

SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
 
CREATE PROCEDURE [dbo].[cusExcelMTD]
        @StartDate DATETIME = NULL,
        @EndDate DATETIME = NULL
AS 
        BEGIN
                SET NOCOUNT ON ;
 
                CREATE TABLE #TEMP
                        (
                          Type VARCHAR(25) NULL,
                          Month INT NULL,
                          Year INT NULL,
                          CompanyId INT NULL,
                          Date DATETIME NULL,
                          FacilityId INT NULL,
                          DoctorId INT NULL,
                          Specifier INT NULL,
                          Collectable VARCHAR(20) NULL,
                          Total MONEY NULL,
                          DOType VARCHAR(20) NULL,
                          FacilityFlag VARCHAR(2) NULL,
                          DoctorFlag VARCHAR(2) NULL,
                          GroupFlag VARCHAR(20) NULL
                        )
 
                INSERT
                        #TEMP
                        SELECT
                                Type = 'charges',
                                Month = DATEPART(month , ara.day),
                                Year = DATEPART(year , ara.day),
                                CompanyId = ara.CompanyId,
                                Date = CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                ara.FacilityId,
                                ara.DoctorId,
                                Specifier = NULL,
                                Collectable = CONVERT(VARCHAR(20) , NULL),
                                Total = SUM(ara.InsAmount + ara.PatAmount),
                                DOType = CASE WHEN 2 = 1 THEN 'service'
                                              ELSE 'entry'
                                         END,
                                FacilityFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                    ELSE 'Y'
                                               END,
                                DoctorFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                  ELSE 'Y'
                                             END,
                                GroupFlag = '(none)'
                        FROM
                                ARAggregates ara
                        WHERE
                                ara.Type = 'C' AND
                                ara.Day >= ISNULL(@StartDate , '1/1/1900') AND
                                ara.Day < DATEADD(month , 1 , ISNULL(@EndDate , '1/1/3000')) 
                                
                        GROUP BY
                                CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                DATEPART(month , ara.day),
                                DATEPART(year , ara.day),
                                ara.FacilityId,
                                ara.DoctorId,
                                ara.CompanyId
 
                INSERT
                        #TEMP
                        SELECT
                                Type = 'payments',
                                Month = DATEPART(month , ara.day),
                                Year = DATEPART(year , ara.day),
                                ara.CompanyId,
                                Date = CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                ara.FacilityId,
                                ara.DoctorId,
                                Specifier = 1,
                                Collectable = CONVERT(VARCHAR(20) , NULL),
                                Total = SUM(InsAmount + PatAmount) * -1,
                                DOType = CASE WHEN 2 = 1 THEN 'service'
                                              ELSE 'entry'
                                         END,
                                FacilityFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                    ELSE 'Y'
                                               END,
                                DoctorFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                  ELSE 'Y'
                                             END,
                                GroupFlag = '(none)'
                        FROM
                                ARAggregates ara
                        WHERE
                                ara.Type = 'P' AND
                                ara.DateType = 'entry' AND
                                ara.Day >= ISNULL(@StartDate , '1/1/1900') AND
                                ara.Day < DATEADD(month , 1 , ISNULL(@EndDate , '1/1/3000'))
                        GROUP BY
                                CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                DATEPART(month , ara.day),
                                DATEPART(year , ara.day),
                                ara.FacilityId,
                                ara.DoctorId,
                                ara.CompanyId
 
                INSERT
                        #TEMP
                        SELECT
                                Type = 'adjustments',
                                Month = DATEPART(month , ara.day),
                                Year = DATEPART(year , ara.day),
                                ara.CompanyId,
                                Date = CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                ara.FacilityId,
                                ara.DoctorId,
                                Specifier = 2,
                                Collectable = ISNULL(ml.FunctionName , 'Y'),
                                Total = SUM(InsAmount + PatAmount) * -1,
                                DOType = CASE WHEN 2 = 1 THEN 'service'
                                              ELSE 'entry'
                                         END,
                                FacilityFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                    ELSE 'Y'
                                               END,
                                DoctorFlag = CASE WHEN NULL IS NULL THEN 'N'
                                                  ELSE 'Y'
                                             END,
                                GroupFlag = '(none)'
                        FROM
                                ARAggregates ara 
								LEFT OUTER JOIN MedLists ml ON ml.TableName = 'AdjustmentTypes' AND ara.ActionTypeMId = ml.MedListsID
                        WHERE
                                ara.Type = 'A' AND
                                ara.DateType = 'entry' AND
                                ara.Day >= ISNULL(@StartDate , '1/1/1900') AND
                                ara.Day < DATEADD(month , 1 , ISNULL(@EndDate , '1/1/3000'))
                        GROUP BY
                                CONVERT(DATETIME , CONVERT(CHAR(12) , ara.day)),
                                ISNULL(ml.FunctionName , 'Y'),
                                DATEPART(month , ara.day),
                                DATEPART(year , ara.day),
                                ara.FacilityId,
                                ara.DoctorId,
                                ara.CompanyId
 
                SELECT
                        t.CompanyId,
                        t.Type,
                        t.Month,
                        t.Year,
                        CASE WHEN t.Date IS NULL THEN CAST('1799-01-01' AS DATETIME)
                             ELSE t.Date
                        END Date,
                        t.Total
                FROM
                        #TEMP t 
						LEFT OUTER JOIN DoctorFacility d ON t.DoctorId = d.DoctorFacilityId 
						LEFT OUTER JOIN DoctorFacility f ON t.FacilityId = f.DoctorFacilityId 
						LEFT OUTER JOIN DoctorFacility fg ON t.CompanyId = fg.DoctorFacilityId
                ORDER BY
                        Year,
                        Month,
                        Date
 
                DROP TABLE #TEMP
 
END

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-07 at 19:47:42ID24881185
Topics

SQL Server 2005

,

MS SQL Server

,

MS SQL Reporting

Participating Experts
1
Points
500
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. T-SQL:  Use datetime parameters to build 'WHERE some…
    Hello SQL Experts In T-SQL I'm trying to take two passed datetime parameters, test to make sure they are not null, and then build a WHERE clase like what I have air-coded below, but my T-SQL skills are not quite there. If anyone can help with this code block, I'd appreciate...
  2. Distinct combined with asterisk?
    Hi, I want to pull a distinct parameter, and also use an asterisk. Is that possible? In other words, SELECT distinct name, * FROM table So get a distinct name, but it also pulls everything else?

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: aneeshattingalPosted on 2009-11-07 at 19:54:57ID: 25769348

enddate is invalid, it should be       @EndDate datetime = '2009-09-30 21:36:1.625' --  datetime   30 is the last day

 

by: JeffSturgeon2002Posted on 2009-11-07 at 19:58:46ID: 25769350

geez ....

I changed to 30 and I get October records I dont want. Wondering how that happened.

 

by: aneeshattingalPosted on 2009-11-07 at 20:04:36ID: 25769354

so what's it supposed to return ?  according  your where condition

                                ara.Day >= ISNULL(@StartDate , '1/1/1900') AND
                                ara.Day < DATEADD(month , 1 , ISNULL(@EndDate , '1/1/3000'))

it must return all the records >= = '2009-09-01 21:36:1.625'  and endDate <   '2009-10-30 21:36:1.625'   ... not sure what you are looking for

 

by: JeffSturgeon2002Posted on 2009-11-07 at 20:12:19ID: 25769366

my end date is 09/30 not 10/30, so I don't know why it pulled the October records

 

by: aneeshattingalPosted on 2009-11-07 at 20:15:17ID: 25769371

you are adding 1 month to the enddate in "DATEADD(month , 1 , ISNULL(@EndDate , '1/1/3000')) "

you need to change all the occurrences of the above to
    ISNULL(@EndDate , '2048-01-01')

 

by: JeffSturgeon2002Posted on 2009-11-07 at 20:22:44ID: 31651490

THANKS

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...