Question

If Exists Update Else Insert Stored Procedure MS SQL 2008

Asked by: garethtnash

Hello All,

I'm trying to build an update or insert SP, but seem to be getting a little lost with this, I think the SP I'm trying to build below is fairly self explanotory, but let me know if you need more detail.
grateful if you can highlight what I have done wrong, or highlight a better way of doing this.

Many thanks

G

USE [RecrutaDeveloper]
GO
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
-- =============================================
-- Author:        GTN
-- Create date: 02/09/2009
-- Description:   StoredProcedure for adding a job advert
-- =============================================
CREATE PROCEDURE [dbo].[usp_tokendeduction] 
@AdvertID smallint,
@SiteID smallint
 AS
 IF EXISTS
    (
        SELECT SUM([Views] +1) AS @views
            FROM JobBoards.View
            WHERE AdvertID = @AdvertID
    )
    Begin 
    UPDATE JobBoards.View
    SET [Views] = '@views'
    Where AdvertID = @AdvertID
 Else
 INSERT INTO JobBoards.View(AdvertID, SiteID, [Views])
     VALUES('@AdvertID', '@SiteID', '1')
 
GO

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-09-07 at 12:02:10ID24713213
Topic

SQL Server 2008

Participating Experts
3
Points
500
Comments
13

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. sp_displayroles stored procedure
    I'm writing a program that needs to achive data on the Sybase roles by using the DB_Library interface. I wanted to use the sp_displayroles stored procedure, but althought I managed to operate the sp, i fail to retrieve the results (the DBROW returns NO_MORE_ROWS) FAIL
  2. Highlight text
    Hi I'm using asp.net c# and was wondering if anyone knows how to highlight text that matches the words in a queryphase. i.e A search for hotels london with gym would return: Keywords: hotels. This luxury 170-bedroo...London Heathrow Airport:|18 mi......gymnasium, whirlpool ...
  3. SELF parameter
    Hi all, I have a simple question. I have to form A and B. Form B inherits from Form A In FORM A- procedure CallP (formName :TForm); virtual; abstract; procedure example; . . procedure TFormA.example (tobject example); begin FormB.CallP(SELF); end; -------------------...
  4. Understanding SQL SP's
    I have a create table procedure that runs three SP's to populate it- and I am having trouble getting them to work- I added four more columns to the table and the first SP errors out Msg 213, Level 16, State 1, Line 1 Insert Error: Column name or number of supplied values ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: pivarPosted on 2009-09-07 at 12:15:23ID: 25276813

Hi,

Is this what you want?

/peter

CREATE PROCEDURE [dbo].[usp_tokendeduction]
@AdvertID smallint,
@SiteID smallint
 AS
DECLARE @views int
 SELECT @views=SUM([Views]) +1
            FROM JobBoards.View
            WHERE AdvertID = @AdvertID
 IF (@views IS NOT NULL)
    Begin
    UPDATE JobBoards.View
    SET [Views] = @views
    Where AdvertID = @AdvertID
 Else
 INSERT INTO JobBoards.View(AdvertID, SiteID, [Views])
     VALUES(@AdvertID, @SiteID, 1)
 
GO

 

by: brejkPosted on 2009-09-07 at 12:16:29ID: 25276820

See the snippet below. Personally I'd prefer to create two procedures - one for update and one for insert and then call them in IF ELSE conditions into the third stored procedure (keep your T-SQL code modular).

CREATE PROCEDURE [dbo].[usp_tokendeduction] 
  @AdvertID smallint,
  @SiteID smallint
AS
IF EXISTS (
  SELECT *
  FROM JobBoards
  WHERE AdvertID = @AdvertID
) BEGIN
  UPDATE JobBoards
  SET [Views] = [Views] + 1
  WHERE AdvertID = @AdvertID;
END;
ELSE BEGIN
  INSERT INTO JobBoards (AdvertID, SiteID, [Views])
  SELECT @AdvertID, @SiteID, 1;
END;
GO
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:

Select allOpen in new window

 

by: pivarPosted on 2009-09-07 at 12:16:51ID: 25276823

Sorry, better like this

CREATE PROCEDURE [dbo].[usp_tokendeduction]
@AdvertID smallint,
@SiteID smallint
 AS
DECLARE @views int
 SELECT @views=SUM([Views]) +1
            FROM JobBoards.View
            WHERE AdvertID = @AdvertID
 IF (@views IS NOT NULL) BEGIN
    UPDATE JobBoards.View
    SET [Views] = @views
    Where AdvertID = @AdvertID
 END ELSE BEGIN
   INSERT INTO JobBoards.View(AdvertID, SiteID, [Views])
       VALUES(@AdvertID, @SiteID, 1)
 END
 
GO

 

by: pivarPosted on 2009-09-07 at 12:22:09ID: 25276852

I think brejk understood the question a little bit better. I would recommend that solution.

 

by: pcelbaPosted on 2009-09-07 at 12:28:59ID: 25276880

Let suppose AdvertID, SiteID, [Views] are numeric:

USE [RecrutaDeveloper]
GO
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
-- =============================================
-- Author:        GTN
-- Create date: 02/09/2009
-- Description:   StoredProcedure for adding a job advert
-- =============================================
CREATE PROCEDURE [dbo].[usp_tokendeduction] 
@AdvertID smallint,
@SiteID smallint
 AS
 
 BEGIN TRANSACTION
 IF EXISTS
    (
    SELECT [Views]
      FROM JobBoards.View
     WHERE AdvertID = @AdvertID
    )
     Begin 
      UPDATE JobBoards.View
         SET [Views] = [Views] + 1
       Where AdvertID = @AdvertID
    End
 Else
   INSERT INTO JobBoards.View (AdvertID, SiteID, [Views])
        VALUES (@AdvertID, @SiteID, 1)
 
 COMMIT
 
GO
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:

Select allOpen in new window

 

by: pcelbaPosted on 2009-09-07 at 12:32:48ID: 25276899

Hmm, I am the slowest one...  :-(

 

by: garethtnashPosted on 2009-09-07 at 12:36:05ID: 31625786

Fantastic thanks all

 

by: brejkPosted on 2009-09-07 at 12:36:35ID: 25276916

@pcelba: Why would you put a single DML into an explicit transaction? It is a transaction already.
Also, when playing with explcit transactions wouldn't it be better to provide some error handling?

However, you may be right about the table name. I called it JobBoards, cause I can't figure out how one could name a table XXX.View ("view" is a T-SQL keyword and it is reaaaally bad practice to use keywords in object identifiers).

 

by: pcelbaPosted on 2009-09-07 at 13:06:01ID: 25277022

It is not single DML. The SP is testing the row existence first and then decides about UPDATE/INSERT. The transaction should avoid duplicate row inserting in a case when no PK is defined on JobBoards.View yet.

I agree with you about the table naming (but it could be a view) and error handling. Some nondefault transaction isolation level should be defined also.

The PK definition would probably be easier than transaction but again it needs error handling (I know, the possibility of error is very low).

And sorry for jumping in so late - I have been playing with some locking and it caused the delay.

 

by: garethtnashPosted on 2009-09-07 at 13:08:05ID: 25277028

Table name changed - thanks

 

by: brejkPosted on 2009-09-07 at 13:13:14ID: 25277051

@pcelba: I can't imagine any crazy DBA/dev that won't put a PK on AdvertID and SiteID... Thus I find the transaction unnecessary here.

PS. Now I realize my code is probably also bad! :-) I missed SiteID in SARG of my SELECT statement.

 

by: brejkPosted on 2009-09-07 at 13:20:51ID: 25277078

So finally, the query can look like this:

CREATE PROCEDURE [dbo].[usp_tokendeduction] 
  @AdvertID smallint,
  @SiteID smallint
AS
IF EXISTS (
  SELECT *
  FROM JobBoards.ViewStats
  WHERE AdvertID = @AdvertID AND SiteID = @SiteID
) BEGIN
  UPDATE JobBoards.ViewStats
  SET [Views] = [Views] + 1
  WHERE AdvertID = @AdvertID AND SiteID = @SiteID;
END;
ELSE BEGIN
  INSERT INTO JobBoards.ViewStats (AdvertID, SiteID, [Views])
  SELECT @AdvertID, @SiteID, 1;
END;
GO

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:

Select allOpen in new window

 

by: pcelbaPosted on 2009-09-07 at 16:22:15ID: 25277812

I even know such DBA...

So if proper PK exists then transaction is a nonsense and the code could look like this one:

CREATE PROCEDURE [dbo].[usp_tokendeduction] 
  @AdvertID smallint,
  @SiteID smallint
AS
BEGIN TRY
  INSERT INTO JobBoards.ViewStats (AdvertID, SiteID, [Views])
   VALUES (@AdvertID, @SiteID, 1);
END TRY
BEGIN CATCH
  -- Some check for error_number() = 2627 could be here
  UPDATE JobBoards.ViewStats
     SET [Views] = [Views] + 1
   WHERE AdvertID = @AdvertID AND SiteID = @SiteID;
END CATCH
GO
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:

Select allOpen in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...