Access ADO - best way to add records

May 17, 2008 06:29am pdt

1. LSMConsu... 18,043
2. boag2000 8,850
3. peter57r 7,800
4. vadimrapp1 7,625
5. chapmandew 7,500
6. TextReport 7,400
7. LPurvis 5,564
8. angelIII 5,325
9. kelvinsp... 5,000
10. adraughn 4,750
11. DatabaseMX 4,600
12. ee_rlee 4,500
13. ScottPle... 4,080
14. dqmq 4,000
15. jlaborde 3,500

1. LPurvis 89,536
2. peter57r 76,636
3. LSMConsu... 68,800
4. rockiroads 44,447
5. SidFishes 33,544
6. capricorn1 32,918
7. stevbe 31,815
8. jimhorn 28,429
9. nico5038 26,250
10. thenelson 24,639
11. JDettman 20,668
12. jefftwilley 19,800
13. harfang 17,972
14. Arthur_Wood 16,774
15. TextReport 15,950

05.06.2008 at 04:51AM PDT, ID: 23379095

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

7.2

Access ADO - best way to add records

Zones: Microsoft ADP, Microsoft Access Database, Access Forms

Below I'm adding records to a table called Audit_Changes for a particular Client. Its in an Access ADP.
I need all the fields, so SELECT * would make sense.
However, I don't need all the records - in fact I don't need any, as I'm only adding a record.
How could I improve this?

stSQL = "SELECT * FROM Audit_Changes"
Set cnnADO = CurrentProject.Connection
Set rsNewData = New ADODB.Recordset
rsNewData.Open stSQL, cnnADO, adOpenDynamic, adLockOptimistic
With rsNewData
.AddNew
!ClientID = stCllientID
etc.

Start your free trial to view this solution

Question Stats

Zone: Microsoft

Question Asked By: jdhackett

Solution Provided By: Arthur_Wood

Participating Experts: 3

Solution Grade: A

Translate:

Loading Advertisement...

Microsoft

Internet Protocols
Applications

Development
OS

Hardware
Windows Security

Apple

Operating Systems
Hardware

Programming
Networking

Software

Internet

Search Engines
File Sharing
WebTrends / Stats
Spy / Ad Blockers

Web Browsers
New Net Users
Web Development
Chat / IM

Anti Spam
Web Servers
Anti-Virus
Email Clients

Gamers

Tips
Online / MMORPG
Puzzle
Emulators

Action / Adventure
Role Playing
Consoles
Game Programming

Strategy
Sports
Misc
Computer Games

Digital Living

Hardware
New Net Users
New Users

Software
Digital Music
Gaming World

Home Security
Apple
Networking Hardware

Virus & Spyware

Vulnerabilities
IDS
Encryption
Anti-Virus

Operating Systems Security
Software Firewalls
WebApplications
Cell Phones

Operating Systems
Internet
Hardware Firewalls

Hardware

Handhelds / PDAs
Displays / Monitors
Components
Networking Hardware

Peripherals
Laptops/Notebooks
Storage
Servers

Desktops
New Users
Misc
Apple

Software

System Utilities
Industry Specific
Network Management
Photos / Graphics
Page Layout
VMWare
Misc
Web Development

OS
CYGWIN
Voice Recognition
Message Queue
Quality Assurance
Security
Firewalls
MultiMedia Applications

Development
Database
Office / Productivity
Business Management
OS/2 Apps
Server Software
Internet / Email

ITPro

OS
Storage
Encryption
Operating Systems Security
Apple Hardware
Laptops & Notebooks
Servers
Networking Hardware
Peripherals

Devices
Displays / Monitors
WebTrends / Stats
Search Engines
Firewalls
WebApplications
IDS
Vulnerabilities
Email Clients

File Sharing
Spy / Ad Blockers
Web Browsers
Web Servers
Networking
Anti-Virus
Chat / IM
Anti Spam

Developer

Web Servers
Web Browsers
Game Programming
Dev Tools
Industry Specific
Office / Productivity

Database
CYGWIN
Web Development
Search Engines
File Sharing
WebTrends / Stats

Programming
Content Management
Application Servers
Protocols

Storage

Removable Backup Media
Storage Technology
Servers

Grid
Remote Access
Backup / Restore

Misc
Hard Drives

Miscellaneous
Security
Development
Linux
VMWare

MainFrame OS
Unix
Apple
OS / 2
AS / 400

BeOS
Microsoft
VMS / OpenVMS

Database

Oracle
Miscellaneous
MySQL
Software
Sybase
Contact Management
PostgreSQL
Data Manipulation
Clarion
InterSystems Cache

Siebel
MUMPS
OLAP
SQLBase
SAS
GIS & GPS
4GL
Berkeley DB
DB2
Informix

Interbase / Firebird
FoxPro
Reporting
LDAP
Filemaker Pro
MS SQL Server
dBase
MS Access

Security

Misc
Web Browsers
Software Firewalls
Operating Systems Security
File Sharing

Spy / Ad Blockers
Vulnerabilities
WebApplications
IDS
Anti-Virus

Encryption
Anti Spam
Email Clients
VPN
Chat / IM

Programming

Editors IDEs
Installation
Handhelds / PDAs
Multimedia Programming
System / Kernel

Algorithms
Game
Signal Processing
Project Management
Open Source

Database
Misc
Languages
Processor Platforms
Theory

Web Development

Scripting
Blogs
Web Servers
Software
Search Engines
Web Graphics
Images

Internet Marketing
Images and Photos
Components
Document Imaging
Web Languages/Standards
Illustration
WebApplications

Fonts
WebTrends / Stats
Authoring
Digital Camera Software
Miscellaneous

Networking

Protocols
Apple Networking
Network Management
Message Queue
Application Servers
Content Management
File Servers
Email Servers
Misc
Java Editors & IDEs

Wireless
Networking Hardware
Backup / Restore
System Utilities
ISPs & Hosting
Web Servers
Storage Technology
Removable Backup Media
Servers
Broadband

Grid
OS / 2
Novell Netware
Unix Networking
Windows Networking
Security
Telecommunications
Operating Systems
Linux Networking

Other

Community Advisor
Lounge
Community Support
New Net Users

Philosophy / Religion
Math / Science
Miscellaneous
URLs

Expert Lounge
Politics
Puzzles / Riddles

Community Support

Suggestions
New to EE
New Topics
Community Advisor

CleanUp
Announcements
General

Feedback
Input
EE Bugs

05.06.2008 at 05:08AM PDT, ID: 21506513

Rank: Genius

Arthur_Wood:

stSQL = "SELECT * FROM Audit_Changes where 1 = 0"

the Wher clause, which clearly is False, will keep Access from returning ANY records.

AW

Accepted Solution

05.06.2008 at 06:14AM PDT, ID: 21506965

jdhackett:

Thanks. You know, I'm programming Access for years, and I don't think I've ever seen that method in any books. But it makes sense!

05.06.2008 at 07:01AM PDT, ID: 21507327

Badotz:

Create an insert query "ins_Audit_Changes":

INSERT INTO Audit_Changes (Field1, Field2, ..., FieldN)
Select ([@F1] AS Field1, [@F2] AS Field2, ..., [@FN] AS FieldN);

and pass the values as parameters:

stSQL = "ins_Audit_Changes " + "'" + STRING_FIELD + "'," + NUMERIC_FIELD + "'," + STRING_FIELD + "'" etc.
CurrentProject.Connection.Execute stSQL

This method does away with all of the ADO vars, too.

05.06.2008 at 06:08PM PDT, ID: 21512409

vadimrapp1:

You don't need to run any statement to add records. People very often program in Access like in VB, doing all the work themselves, and thus throwing away 80% of the benefits. Access works best if you allow it to do the job itself - bind the form to recordsource, bind control to controlsource, and Access will do the rest.

If the form is supposed to add new records, all you need to do is specify form's property Data Entry=Yes.

05.06.2008 at 06:27PM PDT, ID: 21512484

Badotz:

You say "bind your data", I say "free yourself" - different schools of thought.

There is no "right way" to solve this problem, so it depends on the asker.

05.06.2008 at 07:11PM PDT, ID: 21512693

vadimrapp1:

I say "have Access do the job", you say "do it yourself". I specify one property and have Access do the rest; you code everything yourself. Yes, sure, everybody can make their own choice to code one line or 100. Equally, you can choose to buy a car and then walk.

05.06.2008 at 11:09PM PDT, ID: 21513495

Badotz:

Huh? I suggested two lines of code an a query definition. Where are the 100 lines?

05.07.2008 at 04:58AM PDT, ID: 21515356

vadimrapp1:

In professional code, other 98 evaluate the input before the operation, and handle possible errors after it.

05.07.2008 at 07:25AM PDT, ID: 21516712

Badotz:

>>In professional code, other 98 evaluate the input before the operation, and handle possible errors after it.

Surely you jest?

It is difficult for me to imagine any errors happening *before* I run the query, and while there may be a *single* error thrown upon running the query - which can be handled - it is hardly likely to require 98 lines.

05.07.2008 at 09:19AM PDT, ID: 21517948

vadimrapp1:

Before - not errors, but validation of the input. For instance, you will probably want to ensure that NUMERIC FIELD is not NULL, which would return error (yes, I do understand that that can be put in the same sql as well, but there's no real difference between having X extra lines of code and having one sql statement spanning X lines - in fact, the former is more readable).

Besides, of course when I said about 100 lines I did not mean one statement. If you "free yourself" and work with unbound form, then, I assume, INSERT is no exception, and you code _every_ database operation - navigation, undo, update, delete, search... do you not? even if you are able to make it relatively compact, still, where's the benefit of this if the other way is not doing it at all?

That said, may I suggest that if we want to discuss this further, maybe we shouldn't piggyback asker's question. What I posted initially was alternative way for him to resolve his problem (with the ultimate choice being his, of course). Feel free to click my name and send email, or we can move to microsoft.public.access.adp.sqlserver newsgroup.

20080236-EE-VQP-29 / EE_QW_2_20070628