Question

Filter Form records shown using varCriteria

Asked by: Ludique

I have an unbound form with 9 fields - 1 xext, 1xYes/No, 7xCombo boxes.  After extensive trawling though EE I decided to use the solution explained in http://www.experts-exchange.com/Microsoft/Development/MS_Access/Q_21582815.html by Harfang which I have amended (as far as I'm able) with my own specifics.  

When the user has entered/selected data (or not) and clicks the OK button I would like it to open the form frmPolicy which is based on the query forFrmPolicy.

The button to Clear the form before entering data works fine.  
However, on clicking OK I just get a message like:   ContactID=7 AND ProviderID=30 AND PolicyPrint=-1
Presumably indicating that it's got the selected data form the form but not doing anything with it.  Right?  

The solution feels so close I can almost smell it!  So what have I missed?
Here's my version of the code:

Option Compare Database

Option Explicit

Private Sub cmdClear_Click()
   ContactID = Null
   ProviderID = Null
   ProductID = Null
   PolicyStatusID = Null
   Kfdreference = Null
   PolicyFundFormatID = Null
   AdviserID = Null
   ParaplannerID = Null
   PolicyPrint = Yes
   ContactID.SetFocus
End Sub

Private Sub cmdQuery_Click()

    Dim varCriteria As Variant

    varCriteria = Null
        If Not IsNull(ContactID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("ContactID", dbLong, ContactID)
    If Not IsNull(ProviderID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("ProviderID", dbLong, ProviderID)
    If Not IsNull(ProductID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("ProductID", dbLong, ProductID)
    If Not IsNull(PolicyStatusID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("PolicyStatusID", dbLong, PolicyStatusID)
    If Not IsNull(Kfdreference) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("Kfdreference", dbText, Kfdreference)
    If Not IsNull(PolicyFundFormatID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("PolicyFundFormatID", dbLong, PolicyFundFormatID)
    If Not IsNull(AdviserID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("AdviserID", dbLong, AdviserID)
    If Not IsNull(ParaplannerID) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("ParaplannerID", dbLong, ParaplannerID)
    If Not IsNull(PolicyPrint) Then _
        varCriteria = varCriteria + " AND " & BuildCriteria("PolicyPrint", dbBoolean, PolicyPrint)


    MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

    'Exit Sub
   
    ' store into a query definition for later use:
    CurrentDb.QueryDefs("qselTemp").SQL = "SELECT * FROM forFrmPolicy" & " WHERE " + varCriteria & ";"
   
    ' open a report:
    ' DoCmd.OpenReport "rptPolicies", acViewPreview, WhereCondition:=Nz(varCriteria)

    ' filter an open form:
    Forms!frmPolicy.Filter = Nz(varCriteria)
    Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)

End Sub



This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-08-17 at 11:26:00ID22770456
Tags

access

,

filter

,

buildcriteria

Topics

Microsoft Access Database

,

Visual Basic Programming

Participating Experts
1
Points
500
Comments
16

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

    Free Tech Articles

    1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
      It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
    2. SCCM OSD Basic troubleshooting
      SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
    3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
      This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
    4. Create a Win7 Gadget
      This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
    5. Outlook continually prompting for username and password
      There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
    6. Backup Exchange 2010 Information Store using Windows Backup
      There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

    Cloud Class Webinars

    1. Avoiding Bugs in Microsoft Access
      Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
    2. Top 10 Best New Features in Visio 2010
      Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
    3. IT Consultant Business Secrets Revealed
      Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
    4. Disaster Recovery and Business Continuity
      Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
    5. Organize Your Visio Diagrams with Containers and Lists
      Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
    6. How to Us Objects, Properties, Events and Methods in Microsoft Access
      Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

    Join the Community

    Give a Little. Get a Lot.

    Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

    Join the Community

    Answers

     

    by: 1WilliamPosted on 2007-08-17 at 11:44:19ID: 19719306

    You need to remove the first AND thusly:
    varCriteria = Mid(varCriteria , 6)


    Private Sub cmdQuery_Click()

        Dim varCriteria As Variant

        varCriteria = Null
            If Not IsNull(ContactID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("ContactID", dbLong, ContactID)
        If Not IsNull(ProviderID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("ProviderID", dbLong, ProviderID)
        If Not IsNull(ProductID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("ProductID", dbLong, ProductID)
        If Not IsNull(PolicyStatusID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("PolicyStatusID", dbLong, PolicyStatusID)
        If Not IsNull(Kfdreference) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("Kfdreference", dbText, Kfdreference)
        If Not IsNull(PolicyFundFormatID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("PolicyFundFormatID", dbLong, PolicyFundFormatID)
        If Not IsNull(AdviserID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("AdviserID", dbLong, AdviserID)
        If Not IsNull(ParaplannerID) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("ParaplannerID", dbLong, ParaplannerID)
        If Not IsNull(PolicyPrint) Then _
            varCriteria = varCriteria + " AND " & BuildCriteria("PolicyPrint", dbBoolean, PolicyPrint)


        MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

        'Exit Sub
       
        ' store into a query definition for later use:

          varCriteria = Mid(varCriteria , 6)   ' NEW^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

        CurrentDb.QueryDefs("qselTemp").SQL = "SELECT * FROM forFrmPolicy" & " WHERE " + varCriteria & ";"
       
        ' open a report:
        ' DoCmd.OpenReport "rptPolicies", acViewPreview, WhereCondition:=Nz(varCriteria)

        ' filter an open form:
        Forms!frmPolicy.Filter = Nz(varCriteria)
        Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)

    End Sub

     

    by: LudiquePosted on 2007-08-17 at 12:27:16ID: 19719639

    Pasted that in.
    Saved.  Compiled and it gave the error
    Variable not defined
    PolicyPrint = Yes

     

    by: LudiquePosted on 2007-08-17 at 12:36:18ID: 19719693

    So I've commented out the lines referring to PolicyPrint (we can get back to that later)
    Saved. Compiled and pressed the big red (well little grey really) button.

    and I get the same kind of message  ContactID=7 AND ProviderID=30 AND PolicyPrint=-1

    but then a Run-time error '2450'

    Can't find the form frmPolicy referred to in a macro expression or Visual Basic Code

     

    by: LudiquePosted on 2007-08-17 at 12:47:40ID: 19719766

    Just checked.  frmPolicy definitely exists and when opened shows all records.
    but I still get the same error message if I try to use FilterPoliciesForm

     

    by: 1WilliamPosted on 2007-08-17 at 15:20:40ID: 19720781

    1) Does your temp query def work properly (I thought that is what this question was about)?

    I declare the source of the values for my criteria using the me keyword. Assuming these are on the form, I would of remaed the test boxes with txt, check boxes with chk. So text box ContactID would be txtContactID and identified as Me.txtContactID. Prevents confusion between surce (Recordset or form)
    I typically would write the code for the criteria like this:
        varCriteria = Null
            If Not IsNull(ContactID) Then _
            varCriteria = varCriteria & " AND ContactID =" & Me.txtContactID
        If Not IsNull(ProviderID) Then _
            varCriteria = varCriteria & " AND ProviderID =" & Me.txtProviderID
        If Not IsNull(ProductID) Then _
            varCriteria = varCriteria & " AND ProductID =" & Me.txtProductID
        If Not IsNull(PolicyStatusID) Then _
            varCriteria = varCriteria & " AND PolicyStatusID=" & Me.txtPolicyStatusID
        If Not IsNull(Kfdreference) Then _
            varCriteria = varCriteria & " AND Kfdreference =" & Me.txtKfdreference
        If Not IsNull(PolicyFundFormatID) Then _
            varCriteria = varCriteria & " AND PolicyFundFormatID =" & txtMe.PolicyFundFormatID
        If Not IsNull(AdviserID) Then _
            varCriteria = varCriteria & " AND AdviserID =" & Me.txtAdviserID
        If Not IsNull(ParaplannerID) Then _
            varCriteria = varCriteria & " AND ParaplannerID =" & Me.ParaplannerID
        If Not IsNull(PolicyPrint) Then _
            varCriteria = varCriteria & " AND PolicyPrint =" & Me.chkPolicyPrint

    Of course, if the value is text, (for example Kfdreference) I would erite it thusly:
    varCriteria = varCriteria & " AND Kfdreference ='" &  Me.txtKfdreference & "'"

     

    by: LudiquePosted on 2007-08-17 at 17:44:54ID: 19721258

    I tried that but got lots of variable not defined messages which I figured out so that now the code looks like this:

    Option Compare Database

    Option Explicit

    Private Sub cmdClear_Click()
       txtContactID = Null
       txtProviderID = Null
       txtProductID = Null
       txtPolicyStatusID = Null
       txtKfdreference = Null
       txtPolicyFundFormatID = Null
       txtAdviserID = Null
       txtParaplannerID = Null
       chkPolicyPrint = Null
       txtContactID.SetFocus
    End Sub

    Private Sub cmdQuery_Click()

        Dim varCriteria As Variant

    varCriteria = Null
            If Not IsNull(txtContactID) Then _
            varCriteria = varCriteria & " AND ContactID =" & Me.txtContactID
        If Not IsNull(txtProviderID) Then _
            varCriteria = varCriteria & " AND ProviderID =" & Me.txtProviderID
        If Not IsNull(txtProductID) Then _
            varCriteria = varCriteria & " AND ProductID =" & Me.txtProductID
        If Not IsNull(txtPolicyStatusID) Then _
            varCriteria = varCriteria & " AND PolicyStatusID=" & Me.txtPolicyStatusID
        If Not IsNull(txtKfdreference) Then _
            varCriteria = varCriteria & " AND Kfdreference =" & Me.txtKfdreference
        If Not IsNull(txtPolicyFundFormatID) Then _
            varCriteria = varCriteria & " AND PolicyFundFormatID =" & Me.txtPolicyFundFormatID
        If Not IsNull(txtAdviserID) Then _
            varCriteria = varCriteria & " AND AdviserID =" & Me.txtAdviserID
        If Not IsNull(txtParaplannerID) Then _
            varCriteria = varCriteria & " AND ParaplannerID =" & Me.txtParaplannerID
        If Not IsNull(chkPolicyPrint) Then _
            varCriteria = varCriteria & " AND PolicyPrint =" & Me.chkPolicyPrint


        MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

        'Exit Sub
       
        ' store into a query definition for later use:

          varCriteria = Mid(varCriteria, 6)    ' NEW^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

        CurrentDb.QueryDefs("qselTemp").SQL = "SELECT * FROM forFrmPolicy" & " WHERE " + varCriteria & ";"
       
        ' open a report:
        ' DoCmd.OpenReport "rptPolicies", acViewPreview, WhereCondition:=Nz(varCriteria)

        ' filter an open form:
        Forms!frmPolicy.Filter = Nz(varCriteria)
        Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)

    End Sub

    However, when it runs I get a message that says
    AND ContactID =7 AND ProviderID =39

    and the same 'can't find fmPolicy' error message as above.

     

    by: LudiquePosted on 2007-08-17 at 17:51:49ID: 19721269

    Having run the Debug it stops at the last couple of lines

        ' filter an open form:
        Forms!frmPolicy.Filter = Nz(varCriteria)
        Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)

    Is it because it's not opened the form at the point where it's trying to apply the filter?

     

    by: LudiquePosted on 2007-08-17 at 18:03:39ID: 19721288

    Hurrah!
    I've changed it to

      ' filter an open form:
        DoCmd.OpenForm "frmPolicy"
           Forms!frmPolicy.Filter = Nz(varCriteria)
        Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)

    AND IT WORKS!!!!! Whoop!

    However, I still get an annoying message like
    AND ContactID =7 AND ProviderID =39 and have to click OK before it opens the recordset.

    Any way to make it stop?

     

    by: 1WilliamPosted on 2007-08-17 at 18:08:07ID: 19721300

    Good deal1
    you still have this:
    MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

    Comment it out.

     

    by: LudiquePosted on 2007-08-17 at 18:10:31ID: 19721307

    Good idea.
    For the annoying message I've put DoCmd.SetWarnings False at the top and DoCmd.SetWarnings True at the bottom but it still shows it.

     

    by: 1WilliamPosted on 2007-08-17 at 18:16:13ID: 19721318

    Did you comment out the message box by puttting a single quote in front?
    Change this:
    MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

    To this:
    ' MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

     

    by: LudiquePosted on 2007-08-17 at 18:18:54ID: 19721328

    Yes I did.
    Ok I will.  But why?

     

    by: LudiquePosted on 2007-08-17 at 18:20:38ID: 19721332

    Oh I see.  Yes.  OK.

    Now about that irritating message that tells me the ID numbers that have been selected....

     

    by: LudiquePosted on 2007-08-17 at 19:59:24ID: 19721546

    Thank you very much 1William - your assistance and patience has been invaluable.  I'm actually looking forward to trying it out as a method for generating reports next!

    For completeness the final code is as follows:

    ------------------------------------------------------
    Option Compare Database

    Option Explicit

    ' This code was created by Harfang and amended with the assistance of 1William  - members of the www.experts-exchange.com community
    ' See http://www.experts-exchange.com/Microsoft/Development/MS_Access/Q_22770456.html

    Private Sub cmdClear_Click()
       txtContactID = Null
       txtProviderID = Null
       txtProductID = Null
       txtPolicyStatusID = Null
       txtKfdreference = Null
       txtPolicyFundFormatID = Null
       txtAdviserID = Null
       txtParaplannerID = Null
       chkPolicyPrint = Null
       txtContactID.SetFocus
    End Sub

    Private Sub cmdQuery_Click()

        Dim varCriteria As Variant

    DoCmd.SetWarnings False
    varCriteria = Null
            If Not IsNull(txtContactID) Then _
            varCriteria = varCriteria & " AND ContactID =" & Me.txtContactID
        If Not IsNull(txtProviderID) Then _
            varCriteria = varCriteria & " AND ProviderID =" & Me.txtProviderID
        If Not IsNull(txtProductID) Then _
            varCriteria = varCriteria & " AND ProductID =" & Me.txtProductID
        If Not IsNull(txtPolicyStatusID) Then _
            varCriteria = varCriteria & " AND PolicyStatusID=" & Me.txtPolicyStatusID
        If Not IsNull(txtKfdreference) Then _
            varCriteria = varCriteria & " AND Kfdreference =" & Me.txtKfdreference
        If Not IsNull(txtPolicyFundFormatID) Then _
            varCriteria = varCriteria & " AND PolicyFundFormatID =" & Me.txtPolicyFundFormatID
        If Not IsNull(txtAdviserID) Then _
            varCriteria = varCriteria & " AND AdviserID =" & Me.txtAdviserID
        If Not IsNull(txtParaplannerID) Then _
            varCriteria = varCriteria & " AND ParaplannerID =" & Me.txtParaplannerID
        If Not IsNull(chkPolicyPrint) Then _
            varCriteria = varCriteria & " AND PolicyPrint =" & Me.chkPolicyPrint


       ' MsgBox Nz(varCriteria, "No Criteria selected - All Records will be shown")

        'Exit Sub
       
        ' store into a query definition for later use:

          varCriteria = Mid(varCriteria, 6)    ' NEW^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

        CurrentDb.QueryDefs("qselTemp").SQL = "SELECT * FROM forFrmPolicy" & " WHERE " + varCriteria & ";"
       
        ' open a report:
        ' DoCmd.OpenReport "rptPolicies", acViewPreview, WhereCondition:=Nz(varCriteria)
       
        ' run a macro:
        'DoCmd.RunMacro "ExportPolicies"       'This macro includes the WHERE Criteria

        ' filter an open form:
        DoCmd.OpenForm "frmPolicy"
        Forms!frmPolicy.Filter = Nz(varCriteria)
        Forms!frmPolicy.FilterOn = Not IsNull(varCriteria)
    DoCmd.SetWarnings True

    End Sub

     

    by: 1WilliamPosted on 2007-08-18 at 03:18:31ID: 19722157

    I take it the problem is now completely solved?

     

    by: LudiquePosted on 2007-08-20 at 16:39:50ID: 19734578

    Except for the annoying message that confirms the selections.  But Ho Hum.  I'm thinking it may be a good thing anyway

    20120131-EE-VQP-002

    3 Ways to Join

    30-Day Free Trial

    The Experts

    98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

    He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

    The Experts

    97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

    The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

    Testimonials

    "...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

    Testimonials

    "I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

    Testimonials

    "WOW! You guys have great, active, and knowledgeable people on here." moore50

    Business Clients

    Business Clients

    In the Press

    "If you’ve got a question... Experts Exchange can supply an answer.”

    In the Press

    "...an invaluable aid for both IT professionals and those who require tech support."

    In the Press

    "where IT professionals provide quick answers on just about any topic"

    Business Account Plans

    Loading Advertisement...