Question

Problem with Access 2007 VBA - INSERT INTO

Asked by: marku24

I am getting an error trying to insert these fields from an Access form into a table.  When I step through the SQL is picking up the correct values but on my db.Execute (strSQL) I am getting a "Too Few Parameters - Expected 3" error.  Am I missing something?

Private Sub Command10_Click()
 
Dim db As DAO.Database
Dim strSQL As String
 
Set db = CurrentDb()
 
strSQL = "INSERT INTO Table1 (PartName, PartClass, PartDate, PartUserID)VALUES (" & Me.txtPartName & ", " & Me.txtPartClass & ", " & Me.txtPartDate & ", " & Me.txtPartUserID & ")"
 
db.Execute (strSQL)
 
db.Close
 
 
 
End Sub

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-09-15 at 09:48:53ID24733576
Tags

Microsoft Access 2007

Topics

Microsoft Access Database

,

SQL Query Syntax

Participating Experts
2
Points
250
Comments
5

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. strSQL insert
    ' Build our SQL String strSQL = strSQL & "INSERT INTO scratch " strSQL = strSQL & "(text_field, integer_field) " & vbCrLf strSQL = strSQL & "VALUES (" strSQL = strSQL & "'" & strTextField & "'" strS...
  2. db.execute("insert into.....") not working
    Hi All, Could someone there tell me why db.execute("insert...") is not working?? I am using DAOs. It used to add a new record into the database but its not adding now. I am not even getting any error messages. I appreciate your help in advance.
  3. strsql
    hello friends, How to select only first 5 fields from a pf using sql by column number ?? i dont want to use like select id name etc from pf . I want to use like fld1,fld 2 from pf ?? hope u got my question Thanks in advance
  4. Conn.Execute(strSQL)
    Conn.Execute(strSQL) How can I tell if this was successful? Can I do an If THen around it and it will enter the block if it worked?

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: DatabaseMXPosted on 2009-09-15 at 09:52:22ID: 25336904

Courtesy of EE's mbizup:

"References to form controls work fine in stored queries.  If you take that same query and open it through VBA, the same form reference that worked before will cause an error -- unless you evaluate that reference seperately.  This holds true for OpenRecordset statements, and also CurrentDB.Execute and Docmd.RunSQL."


ok ... here is the example.

Setup:
A form with RecordSource of tblEmp  (employees table - two fields EmpID, EmpName)
Textbox on the form bound to EmpID
A saved Query Def (qryParametersTest) in the database window with this SQL:

SELECT tblEmp.EmpID, tblEmp.EmpName
FROM tblEmp
WHERE (((tblEmp.EmpID)=[Forms]![frmTest].[txtEmpID]));

This function:

Public Function mQyrParmTest() As Boolean
   
    Dim rst As DAO.Recordset, qdf As DAO.QueryDef
    Set qdf = CurrentDb.QueryDefs("qryParametersTest")
    With qdf
        .Parameters("[Forms]![frmTest].[txtEmpID]") = ([Forms]![frmTest].[txtEmpID])
        ' or Parameters(0) = ([Forms]![frmTest].[txtEmpID])
        Set rst = .OpenRecordset(dbOpenDynaset)
        MsgBox rst![EmpName]    'this will display the Employee name related to the ID currently on the form
    End With
    Set rst = Nothing
    Set qdf = Nothing
End Function

------

mx

 

by: marku24Posted on 2009-09-15 at 09:56:02ID: 25336930

Thanks but my form isn't bound to any recordset.  I'm not sure how the query above applies.

 

by: peter57rPosted on 2009-09-15 at 10:06:22ID: 25337015

This error normally means you have used incorrect spellings for your field names.
However there could be other issues here because ther are certainely other errors in the sql.
Try...

strSQL = "INSERT INTO Table1 (PartName, PartClass, PartDate, PartUserID) VALUES ('" & Me.txtPartName & "', '" & Me.txtPartClass & "',# " & Me.txtPartDate & "#, " & Me.txtPartUserID & ")"

this assumes that Partname and Partclass are text and PartUserId is numeric.

ALos
remove the brackets from
db.Execute (strSQL)

and delete the line that says
db.close

 

by: marku24Posted on 2009-09-15 at 10:50:39ID: 25337413

I actually got it to work by declaring variables outside of SQL statement.   The only hiccup is the date doesn't come through correctly.  Is my syntax off in the SQL statement?  It shows up correctly in the variable.

Private Sub Command10_Click()
Dim db As DAO.Database
Dim strSQL As String
 
Dim frmName As String
Dim frmClass As String
Dim frmDate As Date
Dim frmUser As String
 
frmName = "'" & Me.txtPartName & "'"
frmClass = "'" & Me.txtPartClass & "'"
frmDate = Me.txtPartDate
frmUser = "'" & Me.txtPartUserID & "'"
 
Set db = CurrentDb()
 
strSQL = "INSERT INTO Table1 (PartName, PartClass, PartDate, PartUserID)VALUES (" & frmName & " , " & frmClass & " , " & frmDate & "  , " & frmUser & " )"
 
 
db.Execute strSQL
db.Close
 
End Sub

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:

Select allOpen in new window

 

by: peter57rPosted on 2009-09-16 at 22:46:28ID: 25353133

Dates must be enclosed in # # as i showed before.

Delete the line
db.close
You didn't open the database in code so you don't close it.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...