Question

cross thread access

Asked by: jagguy

Hi,

I am getting a cross thread access error, when loading an image in a background thread in silverlight

How do i fix this?



Private Sub bw_DoWork(ByVal sender As Object, ByVal e As DoWorkEventArgs)


     Dim bw As BackgroundWorker = New BackgroundWorker
     
 AddHandler bw.DoWork, AddressOf bw_DoWork
      ...
        For i = 1 To 10
            System.Threading.Thread.Sleep(500)
            bw.ReportProgress(i * 10)
            a.X = i
            a.Y = i
            e.Result = "l"
        Next

        img = New Image
        _x = 100
        _y = 300
        url = New Uri("images/circle.png", UriKind.Relative)
        uu = New BitmapImage(url)
        uu.UriSource = url
        img.Source = uu
        Canvas.SetLeft(img, _x)
        Canvas.SetTop(img, _y)
        Canvas.SetZIndex(img, 10)
        canvas1.Children.Add(img)
        AddHandler uu.ImageOpened, AddressOf uu_downloadComplete

    End Sub
 

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-11-06 at 01:29:07ID24877367
Topics

WPF and Silverlight

,

C# Programming Language

Participating Experts
4
Points
500
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. AddHandler
    I have this at the moment. Public Sub CreateCollapseEntry(ByVal intCnt As Integer) Dim picCollapse(5) As PictureBox Dim i As Integer For i = 1 To intCnt picCollapse(i) = New PictureBox With picCollapse(i) ....
  2. AddHandler not working.
    Can anyone tell me why the code below is not working. When the button is clicked control does not seem to pass to the SubmitBtn_Click routine. Thanks. Dim SubmitBtn as Button SubmitBtn = New Button SubmitBtn.Text = "OK" SubmitBtn.Id = "OKButton" AddHandle...
  3. AddHandler syntax error
    I have the following lines of code in my app (I put them in a module for global use)...I am getting a syntax error on the AddHandler (only that word is underlined), but when I look at the documentation, the syntax looks the same (see copied code below mine) 'The 2 event ...
  4. Cross-thread operation not valid
    I am getting the following error "Cross-thread operation not valid: Control 'frmSplash' accessed from a thread other than the thread it was created on." I indicate where the error occurs below. Private FormAlpha As Double = 0 Private WithEvents AlphaTimer ...
  5. Close form within Timer Addhandler
    VS 2005, Trying to close a form within addhandler of timer function, but does not work. Code: Public Class frmMain Dim aTimer As New System.Timers.Timer() Public Sub btnGo_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnGo.Click ...
  6. Cross-Threading...
    First off, I've already searched MSDN regarding this issue and I can't seem to apply their example to what I'm trying to do. I am using BackGroundWorker to Fill my DataSets And Create DataTables and it works fine. A little marque ProgressBar shows while it's processing for ar...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jagguyPosted on 2009-11-06 at 02:54:39ID: 25758058


this works but I am not sure if there can be problems with this method
    Private Sub bw_DoWork(ByVal sender As Object, ByVal e As DoWorkEventArgs)

     
        For i = 1 To 10
            System.Threading.Thread.Sleep(500)
            bw.ReportProgress(i * 10)
            a.X = i
            a.Y = i
            e.Result = "l"
        Next
     
    End Sub
   
 

    Private Sub bw_ProgressChanged(ByVal sender As Object, ByVal e As ProgressChangedEventArgs)
        img = New Image
        _x = 100
        _y = 300
        url = New Uri("images/circle.png", UriKind.Relative)
        uu = New BitmapImage(url)
        uu.UriSource = url
        img.Source = uu
        Canvas.SetLeft(img, _x)
        Canvas.SetTop(img, _y)
        Canvas.SetZIndex(img, 10)
        canvas1.Children.Add(img)
        AddHandler uu.ImageOpened, AddressOf uu_downloadComplete


        Me.tb1.Text = e.ProgressPercentage.ToString() & "%"

       
    End Sub

 

by: vo1dPosted on 2009-11-07 at 02:29:06ID: 25765724

a cross thread exception occurs when a thread other than the creating thread of a control tries to access one of  that control's methods or properties. to avoid that problem, you have to invoke a delegate for your ui update.

 

by: jagguyPosted on 2009-11-07 at 04:03:11ID: 25765944

>>you have to invoke a delegate for your ui update.

In vb.net how do i do this as I only have c# examples

worker.DoWork +=
  delegate(object sender, DoWorkEventArgs e)

 

by: vo1dPosted on 2009-11-07 at 05:34:06ID: 25766262

i'm not a vb developer.
but the reason, why your code example1 crashes but example2 not, is the fact, that the bw_DoWork eventhandler runs in the new thread of the backgroundworker, whereas your bw_ProgressChanged runs in the ui thread, which got the controls. you can prove that by extending both eventhandler with a line (in c#) :
Console.WriteLine(Thread.CurrentThread.ManagedThreadId);

 

by: adgPosted on 2009-11-07 at 13:15:46ID: 25768088

The solution is to use the control's Invoke method.

There is a property on a control (a Form is a control), that is true when you read it from a thread that is not the GUI thread, called InvokeRequired.

If InvokeRequired is true, then you have to use the Invoke method and pass in a delegate that does the work. My example uses an anonymous delegate and checks InvokeRequired to tell whether to use Invoke or just execute the anonymous delegate.

I use ThreadPool.QueueUserWorkItem to get ThreadProcedure to execute in a thread that is not the GUI thread (in a system thread pool thread).

Action is a standard delegate type that declares a function that takes no arguments, and doesn't return a value. An anonymous delegate declared the way I have declared it magically has access to all of the local variables that are in scope at the point that the delegate is declared.

Invoke is a method on a control (in this case, the Form) that executes the passed delegate in the GUI thread. If you are familliar with Win32 programming, the GUI thread message pump eventually gets around to executing the method.

If you are familliar with the async pattern, there are BeginInvoke and EndInvoke methods that allow you to asynchronously execute code in the GUI thread without waiting for it to complete.

using System;
using System.Threading;
using System.Windows.Forms;
 
namespace EECrossThreadAccess
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
 
        private void button1_Click(object sender, EventArgs e)
        {
            ThreadPool.QueueUserWorkItem(ThreadProcedure);
 
        }
 
        private void ThreadProcedure(object p)
        {
            Action doSomething = new Action(delegate
                {
                    label1.Text = "This was changed from another thread";
                });
 
            if (InvokeRequired)
            {
                // Running in some thread other than the GUI thread
                Invoke(doSomething);
            }
            else
            {
                // I'm running in the GUI thread, it's ok to just do it
                doSomething();
            }
        }
    }
}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:

Select allOpen in new window

 

by: adgPosted on 2009-11-08 at 14:26:16ID: 25772270

Oh, you wanted it in VB. Since this is the C# area, I just blindly assumed you wanted it in C#.

I am not a VB expert, but I figured it out :)

Basically, I have added a little block of code at the top of the function that tests InvokeRequired, and if it is true, invokes itself using Invoke.

I tried to get it to work using an anonymous method, but nothing happened. Perhaps I am getting something slightly wrong with the lambda syntax in VB. Instead, I have put it in a separate sub and used AddressOf. It works that way.

Imports System.Threading
 
Public Class Form1
    Private Sub SetLabelTextExample(ByVal text As String)
        If InvokeRequired Then
            Dim invokeMyself As Action(Of String) = AddressOf SetLabelTextExample
            Invoke(invokeMyself, text)
            Return
        End If
 
        Label1.Text = text
    End Sub
 
    Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click
        REM Queue a user work item to artificially get execution into another thread
        ThreadPool.QueueUserWorkItem(AddressOf ThreadProcedure)
    End Sub
 
    Private Sub ThreadProcedure()
        REM Executing in non-UI thread...
        SetLabelTextExample("Called from non-UI thread")
    End Sub
 
    Private Sub Button2_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button2.Click
        REM Executing in UI thread...
        SetLabelTextExample("Called from UI thread")
    End Sub
End Class
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:

Select allOpen in new window

  • screenshot.png
    • 6 KB

    Screenshot of sample implementation (EECrossThreadAccess)

    Screenshot of sample implementation (EECrossThreadAccess)
 

by: chinu1310Posted on 2009-11-11 at 11:25:55ID: 25798111

What you need to do is use Dispatcher.BeginIvoke in order to update the UI from backend thread.

http://forums.silverlight.net/forums/t/19637.aspx

 

by: cafejavaPosted on 2009-11-16 at 08:09:24ID: 25831297

You can use this code in C# to make them access each other.

Control.CheckForIllegalCrossThreadCalls = false;

                                              
1:

Select allOpen in new window

 

by: vo1dPosted on 2009-11-16 at 08:14:31ID: 25831341

please do not use Control.CheckForIllegalCrossThreadCalls = false .

this is what MSDN sais about that property:
---
When a thread other than the creating thread of a control tries to access one  of that control's methods or properties, it often leads to unpredictable  results. A common invalid thread activity is a call on the wrong thread that  accesses the control's Handle property. Set CheckForIllegalCrossThreadCalls to true to find and diagnose this thread activity more easily  while debugging. Note that illegal cross-thread calls will always raise an  exception when an application is started outside the debugger.

---

as explained before use invocation to be threadsafe.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...