Advertisement

05.23.2008 at 03:26AM PDT, ID: 23427099
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!
9.4

Overriding the ADO Connection Object

Asked by garry_m in Active Server Pages (ASP)

Tags: ,

I've recently inherited a site which has a large number of ADO database connections and recordsets.  This site is quite vast and keeping track of all these connections and queries is proving quite time consuming.  We recently came into some problems with SQL injection attempts from posted form parameters.

At the moment, every page uses a single connection object created at the top of the page like so:

Dim oDBConn
Set oDBConn = Server.CreateObject("ADODB.Connection")
oDBConn.Open sConnectionString

And at the end of the page it is closed:

oDBConn.Close()
Set oDBConn = Nothing

Instead of checking all form parameters and such before they are put into a SQL string, I plan to override the ADODB.Connection object with my own custom Connection Object, one which simply copies all of the methods and properties of the ADODB.Connection object.  Like so:

Dim oDBConn
Set oDBConn = New ADOConnectionWrapper
oDBConn.Open sConnectionString
oDBConn.Execute("SELECT * FROM Test")

((Class attached as code snippet.))

This all works fine when doing things such as:

oDBConn.CursorLocation = 3
Set oRS = oDBConn.Execute("SELECT * FROM Test")

As it just passes the method parameters to the underlying connection object.  However, an error occurs when I try to pass the custom connection object as a parameter of the open method of a recordset object, like so:

Dim oRS
Set oRS = Server.CreateObject("ADODB.Recordset")
oRS.Open "SELECT * FROM Test", oDBConn, 1, 1

The error recieved is:

Error Type:
ADODB.Recordset (0x800A0BB9)
Arguments are of the wrong type, are out of acceptable range, or are in conflict with one another.

So my question is, am I missing out a parameter of the connection object that the oRS.Open method is calling?  Or is this just simply not possible?  This seems like a really nice way of validating SQL input and throwing up errors before they are executed without having to change every oDBConn.Execute() across the whole site, just by overriding it in one place saves a lot of time.

Could anyone help shed some light on this for me please?  If you need any more info just let me know, thanks.
Start Free Trial 
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:

Class ADOConnectionWrapper
 
    Private ActiveConnection
 
    Public Sub Class_Initialize()
        Set ActiveConnection = Server.CreateObject("ADODB.Connection")
    End Sub
    
    Public Sub Class_Terminate()
        If IsObject(ActiveConnection) Then
            If ActiveConnection.State = 1 Then
                ActiveConnection.Close()
            End If
            Set ActiveConnection = Nothing
        End If
    End Sub
    
    Public Sub Open(ConnectionString)
        ActiveConnection.Open ConnectionString
    End Sub
    
    Public Sub Close()
        ActiveConnection.Close()
    End Sub
    
    Public Function Execute(sSQL)
        Call Log(sSQL)
        '// sanitise SQL string here before execution and choose whether to execute or not (not in place yet)
        Set Execute = ActiveConnection.Execute(sSQL)
    End Function
    
    Private Function Log(Value)
        '// do some nice logging here if you want
    End Function
 
    '// inherit all the other properties and methods of ADODB.Connection and pass them to underlying connection object
 
    Public Property Let CommandTimeout(Value)
        ActiveConnection.CommandTimeout = Value
    End Property
    
    Public Property Get CommandTimeout()
        CommandTimeout = ActiveConnection.CommandTimeout
    End Property
    
    Public Property Let ConnectionString(Value)
        ActiveConnection.ConnectionString = Value
    End Property
    
    Public Property Get ConnectionString()
        ConnectionString = ActiveConnection.ConnectionString
    End Property
 
    Public Property Let ConnectionTimeout(Value)
        ActiveConnection.ConnectionTimeout = Value
    End Property
    
    Public Property Get ConnectionTimeout()
        ConnectionTimeout = ActiveConnection.ConnectionTimeout
    End Property
 
    Public Property Let CursorLocation(Value)
        ActiveConnection.CursorLocation = Value
    End Property
    
    Public Property Get CursorLocation()
        CursorLocation = ActiveConnection.CursorLocation
    End Property
 
    Public Property Let DefaultDatabase(Value)
        ActiveConnection.DefaultDatabase = Value
    End Property
    
    Public Property Get DefaultDatabase()
        DefaultDatabase = ActiveConnection.DefaultDatabase
    End Property
    
    Public Property Let IsolationLevel(Value)
        ActiveConnection.IsolationLevel = Value
    End Property
    
    Public Property Get IsolationLevel()
        IsolationLevel = ActiveConnection.IsolationLevel
    End Property
    
    Public Property Let Mode(Value)
        ActiveConnection.Mode = Value
    End Property
    
    Public Property Get Mode()
        Mode = ActiveConnection.Mode
    End Property
 
    Public Property Let Provider(Value)
        ActiveConnection.Provider = Value
    End Property
    
    Public Property Get Provider()
        Provider = ActiveConnection.Provider
    End Property
 
    Public Property Let State(Value)
        ActiveConnection.State = Value
    End Property
    
    Public Property Get State()
        State = ActiveConnection.State
    End Property
 
    Public Property Let Version(Value)
        ActiveConnection.Version = Value
    End Property
    
    Public Property Get Version()
        Version = ActiveConnection.Version
    End Property
 
    Public Function BeginTrans()
        BeginTrans = ActiveConnection.BeginTrans()
    End Function
    
    Public Function Cancel()
        Cancel = ActiveConnection.Cancel()
    End Function
 
    Public Function CommitTrans()
        CommitTrans = ActiveConnection.CommitTrans()
    End Function
        
    Public Function OpenSchema()
        OpenSchema = ActiveConnection.OpenSchema()
    End Function
    
    Public Function RollbackTrans()
        RollbackTrans = ActiveConnection.RollbackTrans()
    End Function
 
End Class
[+][-]05.23.2008 at 04:30AM PDT, ID: 21631052

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]06.06.2008 at 06:06AM PDT, ID: 21728627

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]06.06.2008 at 06:14AM PDT, ID: 21728698

At Experts Exchange, members can ask their questions to thousands of technology professionals, also known as Experts. Experts compete and collaborate to answer those questions by leaving comments like this one.

Start your 7-day free trial to view this Expert Comment or ask the Experts your question.

 
[+][-]06.06.2008 at 06:49AM PDT, ID: 21729010

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 7-day free trial to view this Author Comment or ask the Experts your question.

 
[+][-]06.06.2008 at 06:53AM PDT, ID: 21729046

View this solution now by starting your 7-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

 

About this solution

Zone: Active Server Pages (ASP)
Tags: ASP, IE7, FireFox 2.0
Sign Up Now!
Solution Provided By: DarthSonic
Participating Experts: 1
Solution Grade: A
 
 
 
Loading Advertisement...
20080716-EE-VQP-32 / EE_QW_2_20070628