You are renaming all the files with the same name. Not allowed.
Try this (untested) ...
Main Topics
Browse All Topics
Loading Advertisement...
Question
rename files with current date in a bat file
i've got a bat file, trying to rename files in a certain directory, just to include the date, such that new files w/the same name will not overwrite them. i'm trying to test it now, then i would schedule it to run on a daily basis
i don't think i'm doing the bat file correctly. first, when invoked, it just gives me a 'can't find the specified file' message for each file. then, it pumps out a blank log
can anybody help me 1st get the rename corrected, and then get the logging corrected, please? here's a copy of the bat file:
@ECHO OFF
CLS
SET CURRENTDATE=
SET GETSYSDATE=
FOR /F " tokens=1,2,3* delims=/, " %%i IN ('date /T') DO SET CURRENTDATE=%%i%%j%%k%%l
FOR /F " tokens=1,2,3* " %%i IN ('echo %CURRENTDATE%') DO SET GETSYSDATE=%%j%%k%%l
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
ren "\\myserver\public\dba\mes
This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.
Subscribe now for full access to Experts Exchange and get
Instant Access to this Solution
- Plus...
- 30 Day FREE access, no risk, no obligation
- Collaborate with the world's top tech experts
- Unlimited access to our exclusive solution database
- Never be left without tech help again
Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.
- "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
- "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
- "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.
See what Experts Exchange can do for you.
Got a question?
We've got the answer.
Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.
Need individual assistance?
Our experts are ready to help.
If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.
Want to learn from the best?
Read articles from industry experts.
Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.
Working on a long term project?
Store your work and research.
Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.
Access the answers to your technology questions today.
30-day free trial. Register in 60 seconds.
What Makes Experts Exchange Unique?
Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.
Trusted by the world's most respected brands.
Faithfully serving IT professionals since 1996.
Try it out and discover for yourself.
30-day free trial. Register in 60 seconds.
Free Tech Articles
-
WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
-
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
-
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
-
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
-
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
-
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...
Cloud Class Webinars
- Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
- Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
- IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
- Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
- Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
- How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...
Join the Community
Give a Little. Get a Lot.
Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.
Answers
@ECHO OFF
REM Default to tokens 1 to 3.
SET UnivDateTokens=1-3
REM Determine the first token.
FOR /F "tokens=1 delims=.:/-, " %%A IN ('DATE /T') DO SET UnivDatePart1=%%A
REM If the first token is a letter then use tokens 2 to 4 instead.
IF "%UnivDatePart1:~0,1%" GTR "9" SET UnivDateTokens=2-4
REM Extract the current date and put it into the yy, mm, dd variables depending upon the system date format.
FOR /F "tokens=%UnivDateTokens% delims=.:/-, " %%A in ('DATE /T') DO (
FOR /F "skip=1 tokens=2-4 delims=/-,()." %%D IN ('ECHO.^|DATE') DO (
SET %%D=%%A
SET %%E=%%B
SET %%F=%%C
SET UnivDatePart1=
SET UnivDateTokens=
)
)
REM Extract the time into hh, mm, nn, ms variables.
FOR /F "tokens=1-4 delims=/:. " %%A IN ("%TIME%") DO (
SET HH=%%A
SET NN=%%B
SET SS=%%C
SET MS=%%D
)
IF %HH% LEQ 9 (
SET /A HH+=0
SET HH=0%HH%
)
REM Create a shortcut to the current date/time in CCYYMMDDHHNNSSMS format.
SET TodaysDateTime=%YY%%MM%%DD
REM Create the log file.
ECHO Renaming started %TodaysDateTime% > ./messagingfileslog.txt
REM Define the location of the files
SET Source=\\myserver\public\d
REM Define the filenames
SET Files=fix.AAAA.csv fix.BBBB.csv fix.CCCC.csv fix.DDDD.csv fix.EEEE.csv fix.FFFF.csv fix.GGGG.csv fix.HHHH.csv fix.IIII.csv other_file.csv
REM For each file ...
FOR %%F IN (%Files%) DO (
REM If it exists.
IF EXIST "%Source%\%%F.csv" (
REM Delete any potential backup.
IF EXIST "%Source%\%TodaysDateTime%
REM Rename it.
REN "%Source%\%%F.csv" "%TodaysDateTime% - %%F.csv"
REM Check to see that we did all of that OK.
IF EXIST "%Source%\%TodaysDateTime%
ECHO Renamed "%Source%\%%F.csv" to "%TodaysDateTime% - %%F.csv" >> ./messagingfileslog.txt
) ELSE (
REM Couldn't rename it.
ECHO Could not rename "%Source%\%%F.csv" to "%TodaysDateTime% - %%F.csv" >> ./messagingfileslog.txt
)
) ELSE (
REM Couldn't find it.
ECHO Could not find "%Source%\%%F.csv">> ./messagingfileslog.txt
)
)
Line 55 edited - sorry.
@ECHO OFF
REM Default to tokens 1 to 3.
SET UnivDateTokens=1-3
REM Determine the first token.
FOR /F "tokens=1 delims=.:/-, " %%A IN ('DATE /T') DO SET UnivDatePart1=%%A
REM If the first token is a letter then use tokens 2 to 4 instead.
IF "%UnivDatePart1:~0,1%" GTR "9" SET UnivDateTokens=2-4
REM Extract the current date and put it into the yy, mm, dd variables depending upon the system date format.
FOR /F "tokens=%UnivDateTokens% delims=.:/-, " %%A in ('DATE /T') DO (
FOR /F "skip=1 tokens=2-4 delims=/-,()." %%D IN ('ECHO.^|DATE') DO (
SET %%D=%%A
SET %%E=%%B
SET %%F=%%C
SET UnivDatePart1=
SET UnivDateTokens=
)
)
REM Extract the time into hh, mm, nn, ms variables.
FOR /F "tokens=1-4 delims=/:. " %%A IN ("%TIME%") DO (
SET HH=%%A
SET NN=%%B
SET SS=%%C
SET MS=%%D
)
IF %HH% LEQ 9 (
SET /A HH+=0
SET HH=0%HH%
)
REM Create a shortcut to the current date/time in CCYYMMDDHHNNSSMS format.
SET TodaysDateTime=%YY%%MM%%DD
REM Create the log file.
ECHO Renaming started %TodaysDateTime% > ./messagingfileslog.txt
REM Define the location of the files
SET Source=\\myserver\public\d
REM Define the filenames
SET Files=fix.AAAA.csv fix.BBBB.csv fix.CCCC.csv fix.DDDD.csv fix.EEEE.csv fix.FFFF.csv fix.GGGG.csv fix.HHHH.csv fix.IIII.csv other_file.csv
REM For each file ...
FOR %%F IN (%Files%) DO (
REM If it exists.
IF EXIST "%Source%\%%F.csv" (
REM Delete any potential backup.
IF EXIST "%Source%\%TodaysDateTime%
REM Rename it.
REN "%Source%\%%F.csv" "%TodaysDateTime% - %%F.csv"
REM Check to see that we did all of that OK.
IF EXIST "%Source%\%TodaysDateTime%
ECHO Renamed "%Source%\%%F.csv" to "%TodaysDateTime% - %%F.csv" >> ./messagingfileslog.txt
) ELSE (
REM Couldn't rename it.
ECHO Could not rename "%Source%\%%F.csv" to "%TodaysDateTime% - %%F.csv" >> ./messagingfileslog.txt
)
) ELSE (
REM Couldn't find it.
ECHO Could not find "%Source%\%%F.csv">> ./messagingfileslog.txt
)
)
still isn't finding them -- it is logging properly, though -- 1/2 way there
Renaming started 2007101508051175
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
Could not find "\\myserver\public\dba\mes
@ECHO OFF
REM Default to tokens 1 to 3.
SET UnivDateTokens=1-3
REM Determine the first token.
FOR /F "tokens=1 delims=.:/-, " %%A IN ('DATE /T') DO SET UnivDatePart1=%%A
REM If the first token is a letter then use tokens 2 to 4 instead.
IF "%UnivDatePart1:~0,1%" GTR "9" SET UnivDateTokens=2-4
REM Extract the current date and put it into the yy, mm, dd variables depending upon the system date format.
FOR /F "tokens=%UnivDateTokens% delims=.:/-, " %%A in ('DATE /T') DO (
FOR /F "skip=1 tokens=2-4 delims=/-,()." %%D IN ('ECHO.^|DATE') DO (
SET %%D=%%A
SET %%E=%%B
SET %%F=%%C
SET UnivDatePart1=
SET UnivDateTokens=
)
)
REM Create a shortcut to the current date/time in CCYYMMDD format.
SET TodaysDateTime=%YY%%MM%%DD
REM Create the log file.
ECHO Renaming started %TodaysDateTime% > ./messagingfileslog.txt
REM Define the location of the files
SET Source=\\myserver\public\d
REM Define the filenames
SET Files=fix.AAAA.csv fix.BBBB.csv fix.CCCC.csv fix.DDDD.csv fix.EEEE.csv fix.FFFF.csv fix.GGGG.csv fix.HHHH.csv fix.IIII.csv other_file.csv
REM For each file ...
FOR %%F IN (%Files%) DO (
REM If it exists.
IF EXIST "%Source%\%%F.csv" (
REM Delete any potential backup.
IF EXIST "%Source%\%TodaysDateTime%
REM Rename it.
REN "%Source%\%%F.csv" "%TodaysDateTime%.%%F.csv"
REM Check to see that we did all of that OK.
IF EXIST "%Source%\%TodaysDateTime%
ECHO Renamed "%Source%\%%F.csv" to "%TodaysDateTime%.%%F.csv"
) ELSE (
REM Couldn't rename it.
ECHO Could not rename "%Source%\%%F.csv" to "%TodaysDateTime%.%%F.csv"
)
) ELSE (
REM Couldn't find it.
ECHO Could not find "%Source%\%%F.csv">> ./messagingfileslog.txt
)
)
Sorry. I added the list of names without fix.***.csv. THen added other_file.csv, and fix.****.csv, but forgot the .csv bit in the main code.
Try this ...
@ECHO OFF
REM Default to tokens 1 to 3.
SET UnivDateTokens=1-3
REM Determine the first token.
FOR /F "tokens=1 delims=.:/-, " %%A IN ('DATE /T') DO SET UnivDatePart1=%%A
REM If the first token is a letter then use tokens 2 to 4 instead.
IF "%UnivDatePart1:~0,1%" GTR "9" SET UnivDateTokens=2-4
REM Extract the current date and put it into the yy, mm, dd variables depending upon the system date format.
FOR /F "tokens=%UnivDateTokens% delims=.:/-, " %%A in ('DATE /T') DO (
FOR /F "skip=1 tokens=2-4 delims=/-,()." %%D IN ('ECHO.^|DATE') DO (
SET %%D=%%A
SET %%E=%%B
SET %%F=%%C
SET UnivDatePart1=
SET UnivDateTokens=
)
)
REM Create a shortcut to the current date/time in CCYYMMDD format.
SET TodaysDateTime=%YY%%MM%%DD
REM Create the log file.
ECHO Renaming started %TodaysDateTime% > ./messagingfileslog.txt
REM Define the location of the files
SET Source=\\myserver\public\d
REM Define the filenames
SET Files=fix.AAAA.csv fix.BBBB.csv fix.CCCC.csv fix.DDDD.csv fix.EEEE.csv fix.FFFF.csv fix.GGGG.csv fix.HHHH.csv fix.IIII.csv other_file.csv
REM For each file ...
FOR %%F IN (%Files%) DO (
REM If it exists.
IF EXIST "%Source%\%%F" (
REM Delete any potential backup.
IF EXIST "%Source%\%TodaysDateTime%
REM Rename it.
REN "%Source%\%%F" "%TodaysDateTime%.%%F"
REM Check to see that we did all of that OK.
IF EXIST "%Source%\%TodaysDateTime%
ECHO Renamed "%Source%\%%F" to "%TodaysDateTime%.%%F" >> ./messagingfileslog.txt
) ELSE (
REM Couldn't rename it.
ECHO Could not rename "%Source%\%%F" to "%TodaysDateTime%.%%F" >> ./messagingfileslog.txt
)
) ELSE (
REM Couldn't find it.
ECHO Could not find "%Source%\%%F">> ./messagingfileslog.txt
)
)
RQuadling did a lot of work on this - but I have to ask the question - couldn't you have gotten the same results without all the fancy logging by just turning echo on? Logging and friendly error messages are nice, but when coding, it's a lot faster to just switch echo on and review the output. At least in my opinion. There's nothing "wrong" with RQ's methods, but it's just a bit excessive and unnecessary in my opinion.
Well, I understand what you're saying, but.... I'm a dba, I don't know the bat files as well as probably both of you do, and I don't know that I could have gotten the same simply by turning on echo. Surely I can, but again, I don't know the bat files much beyond the absolute basics. Hence, the inquiry. RQ's suggestion worked both on the rename and the fancy logging, which is exaclty what I was looking for.
[dbaSQL] - yes. That should be fine. Whatever is easiest for you really. If all your files are .csv then what you've done is fine.
That line COULD also be written as ...
SET Files=other_file
FOR %%L IN (A B C D E F G H I) DO SET Files=!Files! fix.%%L%%L%%L%%L
If you feel particularly crazy. This does mean you could add J K L M just by adding the 4 letters!
[leew] - The reason I log things like this is that I run my scripts unattended. Habit. The script I did is based upon some code I already have and I never run this manually - Windows Scheduler does, so no screen output.
If you are running these scripts by hand, then yes, you can remove the echo on, but the output will also include all the code.
And in loops, especially embedded loops like these, that can be REALLY awkward.
But, as you said, it is not "wrong" either way.
I also have a small wrapper app which takes the log files and emails them to me. Saves me having to look through lots of log files on different servers.
3 Ways to Join
Business Accounts
- Perfect for organizations
- Multiple users
- Save over 36%
- Create a Business Account
Answer for Membership
- Earn free access
- Showcase your knowledge
- No credit card required
- Sign Up to Answer
Loading Advertisement...
by: ghostdog74Posted on 2007-10-15 at 05:38:22ID: 20077459
a thought, are you mapped to a drive? if yes , use the drive letter...