Hi
I have the following script which was produced by expert _nn_, but I want the script not to search files such as *1.*, that is any file name with the number 1 at the end of the file name, is not to be searched.:
@echo off
set COUNT=0
for /F "skip=1 tokens=1-3" %%a in ('find /C "ERROR = 1" C:\test_search\*.txt') do call :increment %%c
:: uncomment if needed
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-BAD
) else (
net send pc-000024 test-GOOD
)
echo Message sent.
goto end
:increment
set /A COUNT=%COUNT%+%1
:end
This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.
Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.
If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.
Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.
Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.
Access the answers to your technology questions today.
30-day free trial. Register in 60 seconds.
Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.
Try it out and discover for yourself.
30-day free trial. Register in 60 seconds.
Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.
IF spaces are going to cause problems then I'll make sure we do not have files with spaces.
The script is reading the file test1.txt which is the only file which has ERROR = 1 within it, and then sending test-BAD. Which should not be the case as it should be ignoring this file, and moving onto the next one file.
any suggestions
Amazingly, I've found out that the *1.* pattern cannot be trusted ! My NT server returned me a file named "cisco.smi.my.txt" as matching !
&%*@# !!!
Another proposal though :
@echo off
:: global parameters, please adapt as needed
set FOLDER=C:\test_search
set PATTERN=ERROR = 1
set COUNT=0
pushd %FOLDER%
for /f "delims=" %%a in ('dir /b *.txt') do call :increment "%%a"
popd
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-BAD
) else (
net send pc-000024 test-GOOD
)
echo Message sent.
goto end
:increment
set TMPNAME=%~1
:: (1) character taken at 5th positon from then end (-5)
if "%TMPNAME:~-5,1%" equ "1" goto end
:: filenames without path won't have a ':'
for /f "tokens=1-2 delims=:" %%a in ('find /C "%PATTERN%" "%~1"') do set /A COUNT=%COUNT%+%%b
:end
After running this updated script I get the following output:
C:\>test-new.bat
File not found -
File not found -
File not found -
Found 0 occurences. Sending message...
The message was successfully sent to PC-000024.
Message sent.
C:\>
The message sent was test-good, even though of the 4 files in the directory 3 had ERROR = 1 even the file which I want to be ighnored "test1.txt".
Any suggestions
What changes will have to make to the batch file with regard to my script, Brian, as I made the FOR change but with no luckw hat other changes are needed?:
@echo off
:: global parameters, please adapt as needed
set FOLDER=C:\test_search
set PATTERN=ERROR = 1
set COUNT=0
pushd %FOLDER%
for /f "delims=" %%a in ('dir /b *.txt') do call :increment "%%a"
popd
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-BAD
) else (
net send pc-000024 test-GOOD
)
echo Message sent.
goto end
:increment
set TMPNAME=%~1
:: (1) character taken at 5th positon from then end (-5)
if "%TMPNAME:~-5,1%" equ "1" goto end
:: filenames without path won't have a ':'
for /f "tokens=1-2 delims=:" %%a in ('find /C "%PATTERN%" "%~1"') do set /A COUNT=%COUNT%+%%b
:end
Argh, I forgot the %~1 syntax is not valid on NT (first with 2K and better) ... :(
Also, %VAR:~n,m% doesn't work for n negative. :((
Merging with Brian's idea, that would give :
@echo off
:: global parameters, please adapt as needed
set FOLDER=C:\test_search
set PATTERN=ERROR = 1
set COUNT=0
pushd %FOLDER%
for /f "delims=" %%a in ('dir /b *.txt ^|findstr /v "1."') do call :increment "%%a"
popd
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-BAD
) else (
net send pc-000024 test-GOOD
)
echo Message sent.
goto end
:increment
:: filenames without path won't have a ':'
for /f "tokens=1-2 delims=:" %%a in ('find /C "%PATTERN%" %1') do set /A COUNT=%COUNT%+%%b
:end
No time, but the simple: Unix style metacharacter usage is very new to windows, but longer extension names are not.
The earliest version that worked on 2000 using the *1.* pattern should also work on NT with the *.1* pattern if you recreate your special files with their own extension starting with 1. After all, you ARE creating your own file sub-type, go ahead and give it credit as such.
ie: instead of putting text to be concidered special text in thisfile1.txt, put it in thisfile.1txt.
then include this so every program will know how to open it and what "type" to call it:
assoc .1txt || assoc .1txt=txtfile
(that checks first and leaves extension alone if it's already set to anything so running this as part of a command is harmless.)
Good Luck,
2K
(\o/)
I have changed the script slightly, namely the pattern looking for changed from ERROR = 1 to ERROR = 0 and the messages sent AS A RESULT. I remembered that the pattern could be error = 1 or more. So I'm looking for errors = 0 but this script is not working, in that its not reading the files correctly and reading the text error = 0. Suggestions?
@echo off
:: global parameters, please adapt as needed
set FOLDER=C:\test_search
set PATTERN=ERROR = 0
set COUNT=0
pushd %FOLDER%
for /f "delims=" %%a in ('dir /b *.txt ^|findstr /v "1."') do call :increment "%%a"
popd
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-GOOD
) else (
net send pc-000024 test-BAD
)
echo Message sent.
goto end
:increment
:: filenames without path won't have a ':'
for /f "tokens=1-2 delims=:" %%a in ('find /C "%PATTERN%" %1') do set /A COUNT=%COUNT%+%%b
:end
Business Accounts
Answer for Membership
by: _nn_Posted on 2003-11-05 at 06:55:49ID: 9687115
Hi again :)
I'd propose :
@echo off
set COUNT=0
for /F "skip=1 tokens=1-3" %%a in ('find /C "ERROR = 1" C:\test_search\*.txt') do call :increment %%b %%c
:: uncomment if needed
echo Found %COUNT% occurences. Sending message...
if %COUNT% GEQ 1 (
net send pc-000024 test-BAD
) else (
net send pc-000024 test-GOOD
)
echo Message sent.
goto end
:increment
for /f %%k in ('dir /b C:\test_search\*1.*') do if /i "%%k"=="%1" goto end
set /A COUNT=%COUNT%+%2
:end
I'm suddenly realizing that we could run into problems if the filenames happen to have spaces in them. Can this happen ?