Question

What's wrong with this code (Dijkstra Shortest Path algorithm)

Asked by: paddy8788

I want to calculate the shortest path length using Dijkstra's algorithm. But somehow I made a mistake, but I cannot figure it out

Below is my code.
I use adjacency matrix to represent graph so I wrote my own code for the linked list.

I ran some sample data and it was okay. But the checking system says that I was wrong...

Thank you for your help!

//THE PART OF LINKED LIST:
 
public class List {
	private static int MAX = Integer.MAX_VALUE;
	
	private class Point {
		int p, len;
		Point next;
		
		public Point(int x, int y){
			p = x;
			len = y;
			next = null;
		}
	}
	private Point head;
	private Point tail;
	
	public List(){
		head = null;
		tail = null;
	}
	
	
	//Add edge with vertex x and length len
	public void add(int x, int len){
		Point p = new Point(x, len);
		
		if (head == null){
			head = tail = p;
		}
		else{
			
			tail.next = p;
			tail = p;
		}
	}
	
	//Get edge of vertex y
	public int get(int y){
		if (head == null)
			return MAX;
		Point id = head;
		while (id != null){
			if (id.p == y)
				return id.len;
			id = id.next;
		}
		return MAX;
	}
	
	//Remove the edge of vertex x
	public int remove(int x){
		if (head == null)
			return MAX;
		Point id = head;
		if (head.p == x)
		{
			int val = head.len;
			head = head.next;
			return val;
		}
		while (id.next != null)
		{
			if (id.next.p == x)
			{
				int val = id.next.len;
				id.next = id.next.next;
				return val;
			}
			id = id.next;
		}
		
		return MAX;
	}
	}
 
//THE PART OF DIJSKTRA SHORTEST PATH ALGORITHM
// MAX = Integer.MAX_VALUE to denote infinity
//The List[] data = new List[n] stores the adjacency lists for n vertices
public static int shortestPath(List[] data, int n, int src, int dest){
		Vector<Integer> t = new Vector<Integer>();	//Tenative set
		
		int [] val = new int[n];	//Value of the shortest paths from src to other vertices
		
		//Initial value for val[i] is the length between src and node i
		for(int i = 0; i < n; i++){
			val[i] =  (i == src)? 0 : data[src].get(i);
		}
		
		//Add other vertices into tentative set
		for (int i = 0; i < n; i++)
			if (i != src)
				t.add(i);
	
		//As long as tentative set is not empty, we iterate
		while (!t.isEmpty()){
			int s = t.size();	//Size of tentative node
			int min = 0;
			
			//If there is no edge between permanent set and tentative set, we exit
			for (int i = 1; i < s; i++){
				int m = t.elementAt(i);
				if (m!= src && val[t.elementAt(min)] > val[m])
					min = i;
			}
			
			//Now we find the minimum path length
			int k = t.elementAt(min);		//Get the value of the node with minimum path length
			
			//The smallest value is destination, so we remove it
			if (k == dest)
				return val[dest];
 
			//If the minimum value is MAX, it means that there is no egdges left
			if (val[k] == MAX)
				return -1;
 
			
			//Remove from tentative set
			t.removeElementAt(min);
			
			//Recalculate the value of the array val[]
			for (int i = 0; i < n; i++)
				if(i != src)
				{
					int tmp = MAX;
					int u = data[k].get(i);
					//There is an edge between i and k, calculate the length
					if (u < MAX)					
						tmp = val[k] + u;
					//Update val[i] if we have smaller path length
					if (tmp < val[i])
						val[i] = tmp;
				}
		}
		
		//Return the value of the shortest path length from src to dest
		return val[dest];
	}

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-11-20 at 04:03:18ID23921138
Tags

Java

,

Dijkstra algorithm

Topics

Algorithms

,

Java Programming Language

Participating Experts
3
Points
250
Comments
5

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Dijkistra Shortest Path
    Hi guys Does anyone has the source for Dijkistra's 'Shortest Path' algorithm?
  2. Dijkstra's algorithm for shortest path
    In my assignment I have to find the shortest path for airport networks. I have to read a file which stores , to , from and distances from that port to the neighbouring port. This is sample code where the ports are hardcoded #include <stdio.h> #include <stdlib.h> ...
  3. Floyd algorith to get shortest path between two vertices
    I am trying to implement floyd algorith to find shortest path ..cna any one help me...
  4. Dijkstra - Shortest Path algorithm VB.net (C# acceptable)
    Guys, I'm running out of time and I want someone to supply me with a file (class, textfile etc.) which contains Dijkstra's Shortest Path algorithm in VB.net or C# .
  5. Finding the shortest path between two cities...
    I am trying to write a program that will find the shortest path between two cities. From all of the reading I have been doing, Dijkstra's algorithm is the way to go. Despite having read over many different sites explaining the algorithm I am having trouble getting a full un...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: V4ForumsPosted on 2008-11-20 at 19:24:48ID: 23010363

As I am not much into algorithms I went in looking for enough test cases that would help you validate the code.

Here is a another version of Dijkstra source code with extensive test cases to validate the same.

http://renaud.waldura.com/doc/java/dijkstra/renaud-waldura-dijkstra.zip

Would be glad to hear that helped you. Thanks for this question. :)

 

by: ai_ja_naiPosted on 2008-11-23 at 13:35:24ID: 23025988

I don't get this
for (int i = 0; i < n; i++)
                        if (i != src)
                                t.add(i)

why bothering to add all other nodes? even those unreachable.. shouldn't we add just the nodes reachable from the current cut?

 

by: ai_ja_naiPosted on 2008-11-23 at 15:38:10ID: 23026258

Would you give me the code which you initialized the algorithm with?

 

by: pinkky4realPosted on 2009-01-13 at 12:13:02ID: 23366750

It is given a chess board with N*N squares. On the board there is a dice with the dimensions
equal with one square on the board and occupies perfectly the surface of a square. On each side of
the dice there is an integer value between 1 and 100.
The dice can move by rotating itself with 90º around one of it`s edge on the board. With this
move it can go in the upper, lower, left and right square. With more moves, the dice can go to each
square on the board. The cost of a path is equal to the sum of the values on the side on the board,
including the first and the last position.
Giving you the dimension of the board N, the six values on the sides of the cube, the starting
position and the final position, find a minimum path from the starting position to the finish one. You
must save in a file the length of the minimum path and the path itself.
Input data: file cube.in
N // board dimension
face back left right up down // the 6 values on the sides of the dice
x1 y1 x2 y2 // the positions of the start and finish squares, with 1 to N numbering
Output data: file cube.out
C // the cost of the minimum path
L // the length of the path, as number of moves of the dice
x1 y1
x2 y2
.....
xL yL // the positions of the squares in the path
Observations: At the start, the cube is positioned with the face side in the positive direction of
Oy axis, the right side on the positive direction of Ox and the top on the positive direction of
Oz.
All the coordinates start from 1.
Limits:
1<=N<=100

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...