Question

why is it so slow for my background subtraction

Asked by: gen12324

can someone tell me why my code run so slow for the background subtraction? Is there any ways to make it faster?

// Background subtraction with edge detection.cpp : Defines the entry point for the console application.
//
#include "stdafx.h"
#include <cv.h>
#include <cvaux.h> 
#include <highgui.h> 
#include <ctype.h> 
#include <stdio.h> 
 
IplImage *frame1 = NULL, *frame2 = NULL, *frame3 = NULL; 
IplImage *diff1 = NULL, *diff2 = NULL, *result = NULL; 
//IplImage* cannyImg; 
IplImage *grayImg = 0; // gray image 
 
int main(int argc, char** argv) 
{ 
int height,width,step,channels; 
uchar *data1, *data2, *data3, *diffData1, *diffData2, *resultData; 
 
int i, j; 
int threshold = 30; 
int diff; 
 
/* Start capturing */ 
 
 
CvCapture* capture = cvCaptureFromCAM( CV_CAP_ANY );
	if( !capture ) 
	{
    fprintf( stderr, "ERROR: capture is NULL \n" );
    getchar();
    return -1;
	}
	
 
//capture = cvCaptureFromAVI("C:\Documents and Settings\biob202\Desktop\ax fyp\optical_flow_input.avi"); 
 
 
int //mode = CV_RETR_EXTERNAL; 
  
    mode = CV_RETR_EXTERNAL; //detect both outside and inside contour 
  
 
if( !capture ) 
 
{ 
        
fprintf(stderr,"Could not initialize...\n"); 
//return -1; 
 
} 
 
/* Capture 1 video frame for initialization */ 
 
frame2 = cvQueryFrame(capture);    // retrive from the video 
frame3 = cvQueryFrame(capture); 
 
/* Create windows */ 
 
cvNamedWindow("Actual Video", 1);    // creating window 
 
cvNamedWindow("With Differencing", 1); 
cvMoveWindow("With Differencing", 500,0); 
cvNamedWindow("BackGround", 1); 
cvMoveWindow("BackGround", 100,350); 
 
//cvNamedWindow("canny Edge",1); 
//cvMoveWindow("canny Edge", 750, 350); 
 
CvBGStatModel* bg_model; 
 
bg_model =cvCreateGaussianBGModel( frame2 ); 
 
 
/* Get properties of frame */ 
width = frame2->width; 
height = frame2->height; 
step = frame2->widthStep; 
channels = frame2->nChannels; 
 
int key=-1; 
while(key != 'q') 
{ 
        
 
/* Get consecutive frames */ 
frame1 = cvCloneImage(frame2); 
 
// cvReleaseData(frame2); 
// cvReleaseImage(&frame2); 
frame2 = cvCloneImage(frame3); 
 
// cvReleaseData(frame3); 
// cvReleaseImage(&frame3);  
frame3 = cvQueryFrame(capture); 
 
/* Initialize difference and result frames */ 
diff1 = cvCloneImage(frame3); 
diff2 = cvCloneImage(frame3); 
result = cvCloneImage(frame3); 
 
 
/* Image is treated as at unsigned char data hence we use an 
unsigned char pointer to point to the same to access pixels */ 
 
data1 = (uchar *)frame1->imageData; 
data2 = (uchar *)frame2->imageData; 
data3 = (uchar *)frame2->imageData; 
diffData1 = (uchar *)diff1->imageData; 
diffData2 = (uchar *)diff2->imageData; 
resultData = (uchar *)result->imageData; 
 
 
/* Get difference of frames */ 
cvAbsDiff(frame2,frame1,diff1); 
cvAbsDiff(frame3,frame2,diff2); 
cvUpdateBGStatModel( frame2, bg_model ); 
 
 
 
// Check for threshold 
 
for(i=0;i<=height-1;i++) 
{ 
for(j=0;j<=width-1;j++) 
{ 
//Difference depends on sum of pixels on each channel 
 
if(((diffData1[i*step+j*channels+0] + 
diffData1[i*step+j*channels+1] + diffData1[i*step+j*channels+2]) > 
threshold) && ((diffData2[i*step+j*channels+0] + 
diffData2[i*step+j*channels+1] + diffData2[i*step+j*channels+2]) > 
threshold)) 
{ 
resultData[i*step+j*channels+0] = 255; 
resultData[i*step+j*channels+1] = 255; 
resultData[i*step+j*channels+2] = 255; 
} 
else 
{ 
resultData[i*step+j*channels+0] = 0; 
resultData[i*step+j*channels+1] = 0; 
resultData[i*step+j*channels+2] = 0; 
} 
} 
}
 
//end of frame differencing with binarization 
 
grayImg = cvCreateImage( cvSize(result->width, result->height), 
IPL_DEPTH_8U, 1 ); 
    
    //convert original color image (3 channel rgb color image) to gray-level image 
    cvCvtColor( result, grayImg, CV_BGR2GRAY ); 
   // cannyImg = cvCreateImage(cvGetSize(result), IPL_DEPTH_8U, 1); 
 
// cvCanny(grayImg, cannyImg, 50, 150, 3); 
 
 
cvShowImage("Actual Video",frame2); 
cvShowImage("With Differencing",result); 
cvShowImage("BackGround", bg_model->background); 
//cvShowImage("canny Edge", cannyImg); 
 
  
 
cvReleaseImage(&frame1); 
cvReleaseImage(&diff1);  
cvReleaseImage(&diff2); 
cvReleaseImage(&result); 
 
key = cvWaitKey(10); 
}//end of while 
 
 
cvDestroyWindow("Actual Video"); 
cvDestroyWindow("With Differencing"); 
cvDestroyWindow("BackGround"); 
//cvDestroyWindow("canny"); 
cvReleaseCapture(&capture); 
 
return 0; 
}
                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-08-11 at 22:53:54ID24645516
Topics

Algorithms

,

Microsoft Visual C++.Net

,

Windows Programming

Participating Experts
2
Points
500
Comments
11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Subtraction Function
    Is there not a subtraction function in excel?
  2. Date Subtract
    Hi, Can someone show mw how to do this. Dim myvariable1 as date Dim myvariable2 as date myvariable1 = (Now().ToString("g")) myvariable2 = myvariable1 subtract 12 months or one year example:...... if myvariable1 = 3/30/2005 then... myvariable2 = 3/30/2...
  3. Time Subtraction
    Hello All, I need to subtract minutes from a given time. Say, if I wanted to send an alert to someone, and the time that the alert was sent is 13:00 (1:00PM). I want to send the alert before 13:00 to ensure that the person receives the alert before 13:00. So, in my program I...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: AndyAinscowPosted on 2009-08-11 at 23:10:52ID: 25076064

First - identify the slow part of your code.  (GetTickCount  returns the number of milliseconds since windows started, put a number of lines in to see the time taken between code sections)

 

by: gen12324Posted on 2009-08-12 at 00:40:21ID: 25076422

so how should i do that? where should i put the GetTickCount

 

by: AndyAinscowPosted on 2009-08-12 at 01:57:32ID: 25076809

long l1 = GetTickCount();
//some code
long l2 = GetTickCount();
//more code
....

at end of code put a breakpoint and compare the values.  See which piece of code is taking the time up.

 

by: gen12324Posted on 2009-08-12 at 03:26:18ID: 25077256

hmm.. i use it on other computer it doesn't lag

 

by: itsmeandnobodyelsePosted on 2009-08-12 at 03:59:28ID: 25077397

>>> hmm.. i use it on other computer it doesn't lag

If hardware is similar, check event viewer if there are error events on some devices.

You invoke event viewer by CTRL+R and input eventvwr. The System and Application tab are the interesting ones.

If hardware is not comparable, you should follow the advice Andy gvae you and spot the calls which were slow.

 

by: gen12324Posted on 2009-08-12 at 04:18:10ID: 25077484

hmm.. now i use vs c++ 6.0 then it can work.

 

by: AndyAinscowPosted on 2009-08-12 at 04:31:51ID: 25077567

>>>hmm.. now i use vs c++ 6.0 then it can work.

?
The version of VC you use should make no (or minimal) difference to how fast your code runs.



Stop and think.
You have a problem.  Step 1 is to identify the problem (which lines of code take a lot of time) then you can start working on a solution.  Just guessing at what is slow will very likely waste your time unless you happen to guess correctly.

 

by: itsmeandnobodyelsePosted on 2009-08-12 at 05:51:09ID: 25078143

>>>hmm.. now i use vs c++ 6.0 then it can work.

If the code compiles both with VC6 and younger VC compiler (VS.NET), the differences are minimal.  STL is more compliant to standard with every version VC7.0, VC7.1, VC8 and VC9. Differences in runtime are enhancements which can't apply for you if the code still compiles with VC6.  

 

by: gen12324Posted on 2009-08-12 at 20:08:40ID: 25085209

Sorry i like to ask how to compare the values?  See which piece of code is taking the time up? From where can i see? Right now i'm using vc++ 6.0.. My com auto updated the vc to 9.0 and i got some error.

 

by: gen12324Posted on 2009-08-12 at 20:11:01ID: 25085215

I believe is the updated error. When it says error occured continue to debug and pressed yes, it still managed to run.

 

by: gen12324Posted on 2009-08-12 at 20:56:46ID: 25085347

It's ok. Thanks for all the help.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...