Question

JComboBox cell renderer/editor updates other JComboBox in same JTable

Asked by: jolly_rog

I'm stuck. I have a JTable that holds a JComboBox which is populated depending on the value in another cell (plain) in the same row. Everything displays correctly, with the correct values in each combo box. The problem is when I make a selection on a combo box, any previous combo box selections revert to the default state. I know I'm stomping on either my combo box instance or the Vector I'm populating it with in either my cell editor or cell renderer class. I'm also fairly certain I'm implementing too many instances of JComboBox.

Thanks in advance....

import java.util.Vector;
import javax.swing.JTable;
import javax.swing.table.TableCellEditor;
import javax.swing.table.TableCellRenderer;
import javax.swing.table.TableColumnModel;
import javax.swing.table.TableModel;
 
public class ComboBoxTable extends JTable {
    
    public ComboBoxTable(TableModel tm) {
        super(tm);
        tableModel = (ComboBoxOutputTableModel)tm;
    }
    
    ComboBoxOutputTableModel tableModel;
    
    Vector valuesVector = null;
    
    
    public TableCellRenderer getCellRenderer(int row, int column){
        if(column == 1){
            setValuesVector(row,column);
            MyComboBoxRenderer renderer = new MyComboBoxRenderer(valuesVector);
            getColumnModel().getColumn(1).setCellRenderer(renderer);
            return renderer;
        }
        else return super.getCellRenderer(row, column);
    }
 
    public TableCellEditor getCellEditor(int row, int column)
    {       
        if (column == 1){           
            
            MyComboBoxEditor editor = new InegQueueComboBoxEditor(valuesVector);
            return editor;
        }
        else return super.getCellEditor(row, column);
    }
    
    /**
     * Gets the collection from the table model data for the current row and populates 
     * the Vector that will be set to a comboBox with it
     * tableModel.getData() returns Object[int][String[]]
     */
    public void setValuesVector(int row, int column){
        Object[] modelRow = tableModel.getData()[row];   
        this.valuesVector = new Vector((Vector)modelRow[column]);
    }
 
}
 
public class MyComboBoxRenderer implements TableCellRenderer {
   
    public MyComboBoxRenderer(Vector v){
 
    }
 
    public Component getTableCellRendererComponent(JTable table, Object value,
            boolean isSelected, boolean hasFocus, int row, int column) {
        JComboBox comboBox = null;
               
        if(value == null){
            comboBox = new JComboBox();
        }else{
            Vector vector = (value instanceof Vector)?(Vector)value:new Vector();
            comboBox = new EiiComboBox(vector);
            comboBox.setFont(LookAndFeelConstants.getLabelFont());
        }
        if (isSelected) {
            comboBox.setForeground(table.getSelectionForeground());
            comboBox.setBackground(table.getSelectionBackground());
            
        } else {
            comboBox.setForeground(table.getForeground());
            comboBox.setBackground(table.getBackground());
        }
        return comboBox;
    }
    
}
 
 
public class MyComboBoxEditor extends AbstractCellEditor implements TableCellEditor {
 
    private Component comp = null;
    private int r = 0;
    private int c = 0;
   
    public MyComboBoxEditor(Vector items) {
        super();
    }
    
 
    public Component getTableCellEditorComponent(JTable table, Object value, boolean isSelected, int row, int column) {
        Component com = null;
        r = row;
        c = column;
        JComboBox comboBox;
        
        if(value == null || value.toString().length() == 0) com = new JTextField("");
        else if(value instanceof Vector){
            comboBox = new JComboBox();
              if(comboBox.getModel().getSize() > 0){
                    // clear it...
                  comboBox.removeAllItems();
              }
              comboBox.setModel(new DefaultComboBoxModel((Vector)value));
              
              comboBox.addItemListener(new ItemListener(){
                public void itemStateChanged(ItemEvent e) {
                
                	//nothing implemented here yet
                }                  
              });
 
              com = comboBox;
              
        }else {
        
            comboBox = new JComboBox();
              if(comboBox.getModel().getSize() > 0){
                    // clear it...
                  comboBox.removeAllItems();
              }
              comboBox.addItem(value);
              com = comboBox;
        }
        comp = com;
        return com;
    }
 
	//inherited
	
    public Object getCellEditorValue() {
        return null;
    }
}

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-06-18 at 15:11:18ID23497112
Tags

Java, Swing

Topics

Java AWT & Swing

,

Java Editors & IDEs

Participating Experts
1
Points
500
Comments
19

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Swing JTable Cell JComboBox
    Hi, I need to make a column of a JTable to be a JComboBOx, thus selectable from a drop-down list. Any solution? Thanks. cbbl23
  2. Jcombobox with jtable
    I am rendering jcombobox in one of my jtable columns what i want is, Whenever i change the items in jcombo box i want to fire something event and i want to retrieve the selected item. Which listener i need to add to jtable. please help me i will be thankful to you
  3. adding JList to a cell of a JTable
    I want to display a JList in a cell of a JTable . How can i do it.
  4. JComboBox in JTable
    This is the cell editor class with only a few adjustments under actionPerformed: class CellEditor extends AbstractCellEditor implements TableCellEditor { JComboBox component = new JComboBox() ; JTable parentTable ; public CellEditor( JTable parentTable ) { ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jolly_rogPosted on 2008-06-18 at 15:15:56ID: 21817794

Just to clarify, the value in the other column is a parameter for a sql query, hence the different values for each row's comboBox. It's also persisted in the data object retrieved from the tableModel, but the value is irrelevant to the current problem.

 

by: objectsPosted on 2008-06-18 at 17:12:39ID: 21818333

your renderer never sets the selected item, thus it will always be the default
Set the required value in getTableCellRendererComponent()

 

by: jolly_rogPosted on 2008-06-18 at 17:49:33ID: 21818468

In getTableCellRendererComponent()  I have:

if(value == null){
            comboBox = new JComboBox();
        }else{
            Vector vector = (value instanceof Vector)?(Vector)value:new Vector();
            comboBox = new JComboBox(vector);
        }
}

so should I change that to :
int x = the seleceted index; //dig this value out of the ItemEvent?
new JComboBox(vector.elementAt(x));

?

 

by: objectsPosted on 2008-06-18 at 17:53:11ID: 21818482

no you need something like:

comboBox.setSelectedItem(value);

or

comboBox.setSelectedIndex(indexOfValueInVector);

 

by: jolly_rogPosted on 2008-06-19 at 07:59:06ID: 21822788

I tried that and when I make a selection on another row's comboBox, the one I just selected goes back to the default. Same problem.

 

by: jolly_rogPosted on 2008-06-19 at 08:39:25ID: 21823300

I thought maybe my problem is that in my table, I'm sending the renderer the Vector associated with the row I've clicked on, so it overwrites what was populating the comboBox in the previously selected row?
So I made this change:

    public Vector getValuesVector(int row, int column){
        Object[] modelRow = tableModel.getData()[row];  
        return new Vector((Vector)modelRow[column]);
   }
///////
MyComboBoxRenderer renderer = new MyComboBoxRenderer( getValuesVector(int row, int column));

But the values are different in the new Vector(which is the only value the renderer knows),so  the selected item doesn't exist the next time the renderer gets called, right?

 So, how do I fix THAT?

 

by: objectsPosted on 2008-06-19 at 16:19:53ID: 21827291

You need to actually set the value to something that is in the combos list, it doesn't make sense to set it to something thats not in there.

 

by: jolly_rogPosted on 2008-06-19 at 19:18:42ID: 21827981

That's what I figured.

One idea I have is to create a data structure that I populate with my result set data and then iterate through it and create a new JComboBox for each set, and just pass them into my renderer and editor.

Or, just use the data structure to hold reference to each collection for the comboBoxes.

 

by: objectsPosted on 2008-06-19 at 19:31:02ID: 21828033

How does the value get set to something that is not in the combo?

 

by: jolly_rogPosted on 2008-06-20 at 05:30:42ID: 21830520

I'm going to have to come up with a way to iterate through the "master" data from my result and create a new comboBox for each set of data on the fly, then pass them to my renderer and editor. Each combo has it's own value set at that point.

 

by: objectsPosted on 2008-06-20 at 14:41:17ID: 21835147

so soes every combo have a different list of options? where are the options coming from?

 

by: jolly_rogPosted on 2008-06-20 at 18:42:08ID: 21835994

Yeah they're all different, because the value in the other column (which comes from another -simpler- query) is a parameter in the query that produces the values for the combo. By the nature of the schema, they all come out with different value sets. Of course, we're talking 1 - n combos with 0-n items in each one.

I'm still trying to come up with a way to persist the different value sets, but it's tough when it's unkonwn how many there might be.

As I think about it, maybe some factory could pop out the vectors that would all be unique instances, but for the renderer to hold reference to the right one is a challenge.

I'm sure the project architect thought this looked real cool when he did it in vizio.

 

by: objectsPosted on 2008-06-21 at 17:01:10ID: 21839242

The available values could be stored in the table model. The renderer could then pull all the required values and setup the combo accordingly.

 

by: jolly_rogPosted on 2008-06-21 at 20:34:20ID: 21839583

So you agree with my idea, that the table model could have a factory method to generate the value objects for the renderer?

 

by: objectsPosted on 2008-06-22 at 16:22:46ID: 21842640

sounds ok as long as it doesn't take too long to generate them everytime.

 

by: jolly_rogPosted on 2008-06-25 at 12:01:10ID: 21868812

My next cut is going to try to create an editor model that builds a map of editors keyed by the string value of the first column. We'll see how that goes.

 

by: objectsPosted on 2008-06-25 at 15:06:55ID: 21870276

sounds like an overkill (and you'll need renerers as well as editors)
all you need is the combo models.

 

by: jolly_rogPosted on 2008-06-30 at 13:26:10ID: 21902741

I gave up. I just changed the design to iterate my data and set a new row with a label and combo for each iteration. Works great, I can persist the selections and it took 30 minutes.

Thanks for your help, anyway.

 

by: jolly_rogPosted on 2008-06-30 at 13:29:17ID: 31468603

This is a really complex task, and tough, if not impossible to implement, so I'm awarding the points based on the help and accuracy as far as it got me before I went with a different design.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...