Question

insert a char * into a std::vector<char *>

Asked by: francis77

I want to insert a char * into a std::vector<char *>.  I use vec.push_back(charPtr) but it does nothing.  Does anyone know how to do this ?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-04 at 18:42:49ID24784336
Tags

Vector

,

C++

Topics

C++ Builder

,

C / C++ / C# Editors and IDEs

,

C++ Programming Language

,

Microsoft Visual C++

Participating Experts
4
Points
250
Comments
18

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. forward declaration of std::map and std::vector
    Hi! My question is how to do a forward declaration of a std::map and a std::vector. I have sample code for a way to do a forward declaration for a list and a string. Ex list : The row below is added to the headerfile where you have a list variable. #include "list_fwd....
  2. std::vector easy question
    Hi! Do std::vector accept Mutithread programing?. Thanks, Jorge
  3. std::vector delete() question
    Are std::vectors contiguous memory like arrays? So if I delete a single position from the middle of the vector, will all objects from that point to the vector end be copied forward 1 position?
  4. std::vector
    Hello experts, I have code below that I got from another developers. It compiles in VC.NET 2002, but doesn't compiles is VC 2003. std::vector<HANDLE> m_vHandles; dw=WaitForMultipleObjects((DWORD)m_vHandles.size(), m_vHandles.begin().base(), FALSE, INFINITE); Error: ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: evilrixPosted on 2009-10-05 at 07:20:11ID: 25495458

>> I use vec.push_back(charPtr) but it does nothing
What do you mean it does nothing?

Incidentally, you are better off using a string otherwise you have to manage the memory the char * points to.
http://www.cplusplus.com/reference/string/string/

string s = "hello world";
vector<string> v;
v.push_back(s);

 

by: Let_Me_BePosted on 2009-10-05 at 07:22:13ID: 25495489

If by nothing you mean that it doesn't clone the string, then yes. It will just push the pointer into the vector.
Use strdup, or new + strdup to clone the string.

 

by: Subrat2009Posted on 2009-10-06 at 05:49:36ID: 25504365

Hi francis77

If u can show us the code where std::vector<char*> isn't working well, then we can tell u where is the fault.

FYI: As per evilrix said, u need the manage the memory  the char * points to.

This vector is only storing the addresses of string but not the actual string. So if u don't have valid string present as the time when u are iterating vector, then how will u get those string. U r having the addresses of the string inside vector but at those address if there is no valid string, then it's the situation of 'dangling pointer'.

 

by: itsmeandnobodyelsePosted on 2009-10-06 at 05:53:00ID: 25504403

To add to above comments:

It normally is poor design to storing pointers in a container with copy semantics like std::vector. If you would clear the container, the memory the pointers were pointing to never was freed (worse if you have stored the pointers into a second location) or you have to free each single pointer item before clearing.

There are only two valid exceptions to that, function pointers and baseclass pointers for virtual use. None of them applies here. The best is you follow the advice of evilrix and use std::string for storing text, what is the C++ way.

 

by: francis77Posted on 2009-10-06 at 16:10:51ID: 25510887

I need to make some testing and will reply if I need some help on the same subject.  I was able to add a char * and a string to the vector.  Thanks for your help.

 

by: Subrat2009Posted on 2009-10-06 at 21:53:20ID: 25512301

Please see the title and descriptins of this question."insert a char * into a std::vector<char *>" and answer is already given. No wherein the question, it's mentioned that string insertion. That might be a better suggestion.

 

by: itsmeandnobodyelsePosted on 2009-10-07 at 00:11:56ID: 25512753

I'll support the objection given by Subrat2009 though I don't share the argumentation.

In C++ a std::string always is a valid alternative to a char pointer whether it is explicitly asked for or not. But surely the question was answered in the thread, so there is no reason for deleting the question or taking the Autor's comment as an answer (if that was requested by the asker).

 

by: evilrixPosted on 2009-10-07 at 00:17:10ID: 25512776

>> I'll support the objection given by Subrat2009 though I don't share the argumentation.

Sometimes the asker doesn't know there is a better/safer way. Storing a char* in a vector is nearly always a road to disaster. Firstly, there is the lifetime of the memory the char * points to. Who owns it? Who deletes it? Also, making code exception safe with STL containers containing heap allocated memory that is not managed using a reference counted smart pointer (of which there are none in standard C++ suitable for use in an STL container) it messy.

 

by: evilrixPosted on 2009-10-08 at 11:30:01ID: 25528522

The 'safe' (and most C++ correct) way to push a char * into a vector is shown here as the very first answer (by encapsulating it in a string).

http:#25495458

Other than that, it seems the asker never explained why they had issues with this (my very first posted asked for clarification).

 

by: francis77Posted on 2009-10-08 at 15:23:10ID: 25530838

The vector was in a class but was not initialized correctly, when I take it out of the class it is.  If I initialize in the constructor, it works but when another function within the class tries to add to the vector, it throws an exception.  This is where the problem resides.  I have included some class definitions I have made.  It is called like :

Database<MySQL> d;
d = new Database<MySQL>();

Are the variables modified in the MySQL class retained in the d variable ?

template<class T>
class Database
{
private:
     bool _connected;
public:
	__fastcall Database();
	__fastcall virtual ~Database();
	bool getConnected();
	void connect();
};
 
class MySQL
{
private:
	MYSQL *_connectionPtr;
	MYSQL_ROW mysrow;
	Log *lPtr;
//	MYSQL_RES *msres;
        vector<string> row;
public:
	MYSQL *getConnectionHandlePtr() { return _connectionHandlePtr; };
 
	__fastcall MySQL();
	__fastcall ~MySQL();
	int connect(const char *, const char *, const char *, const char *);
	int execute(char *);
	void close(void);
        void create();
	unsigned int error(int);
};
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:

Select allOpen in new window

 

by: evilrixPosted on 2009-10-08 at 23:38:48ID: 25532748

In your example code, T is never used is it? Can you explain why this needs to be a template if you don't use T anywhere?

Also, can you show the code where you try to use the vector?

 

by: itsmeandnobodyelsePosted on 2009-10-09 at 02:04:04ID: 25533260

>>>> The 'safe' (and most C++ correct) way to push a char * into a vector is shown here as the very first answer (by encapsulating it in a string).

That statement is not true. By encapsulating a char *  into a string the pointer itself wasn't stored but only the text the pointer was pointing to.

So, the first answer is only the solution if the purpose was to store the text and not the pointer.

A later comment of the Asker "I was able to add a char * and a string to the vector" seems to indicate that both the answers of evilrix and SubRat2009 were valid solutions for the asker.  

 

by: evilrixPosted on 2009-10-09 at 02:06:23ID: 25533267

>> seems to indicate that both the answers of evilrix and SubRat2009 were valid solutions for the asker.
Which confirms my original statement!

 

by: itsmeandnobodyelsePosted on 2009-10-09 at 02:20:28ID: 25533314

>>>> The vector was in a class but was not initialized correctly

That is not possible.

If you create an instance of MYSQL class for all class members - including the 'row' member - the constructor was called which would create an empty container. As the member was private and there was no public interface which exports the row vector it only could be filled by (non-static) member functions of class MYSQL. An initialization is not necessary in no case.

>>>>       MYSQL *getConnectionHandlePtr() { return _connectionHandlePtr; };

That is a very dangerous construct. There are only a few valid class designs which would have a pointer to another instance of the class itself, e. g. nodes of a tree container. IMO, you have too much pointer members and therefore the crashes. For example, why should anyone want to store a Log* in a database instance? If you have one logfile for all database instances you don't need the pointer but should have a singleton instance of the Log which could be accessed without pointer. Or, if each MYSQL instance has its own Log, it could have a Log member and not a pointer.    

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...