Sorting Vectors in c++

nice idea and it does appear to be simple----I forgot to add my teacher wants us to use a bubble sort sorry for the confusion

>> I forgot to add my teacher wants us to use a bubble sort sorry for the confusion

Ok, so you should be able to implement a generic bubble sort routine, which will sort anything that implements or supports a operator <(). It shouldn't matter what's being sorted as the semantics are the same. So in your case the logic for sorting int types is identical to sorting strings, it's just the predicate for sorting (the operator < ()) that is specific for the type. In the case of strings you normally perform a lexical comparison and with int types its a value comparison.

If you already have a bubble sort written that works correctly it should be pretty simple to modify it to work with int types, either by copying it and changing as necessary or (the smarter way) making it templated to work with any type.

I take it you know how a bubble sort works?

What, specifically, are you stuck on? Can you provide the problem code please for review?

Thanks.

how to add to the bubble sort my other vector so it associates with the sorted vector  In this case  the string vector.  I have a loose idea how bubble sorts work.  I've got the code for the bubble sort but not how to add the other vector to it.     in  simple terms    my program compares cars and their mpg.
one vector is the name of the car one vector is the mpg.   So if I sort the car name  how do I keep the mpg with the associated car

>> So if I sort the car name  how do I keep the mpg with the associated car
Ah, I see now. Create a vector of a struct of type Car, where this struct stores both name and mpg. Sort the vector by name and the name and mpg will stay together since they are intrinsically bound together in the struct. Your struct should implement an operator<() that returns true if the lhs string is less than the rhs string for the name.

Something like this...

struct Car
{
   int mpg;
   string name;

   bool operator <(string lhs, string rhs) { return true if string lhs < string rhs }
}

vector <Car> vc;

// Add cars to vc

bubble_sort(vc);


This is far simpler than trying to associate 2 vectors and maintain ordering.

Thanks I'll accept your solution but this is not what my teacher was looking for
I'm aware my original issue was not a very good way to store data but we haven't gotten to arrays yet
My program has been written for both vectors to be used as separate entities after the sort
I'll keep looking for another solution
I appreciate your help

I've got to go to school now.
I'll accept your solution though

>>  I'll accept your solution but this is not what my teacher was looking for
Ok, well you don't have to accept it if it doesn't solve the issue. If you can explain more about the problem -- specifically what the assignment restrictions are -- I'm happy to help further,

If you're just trying to keep the vectors associated, simply do the exact same manipulations on the 2nd vector.

Of course the attached code is meaingless. But the point is you're only comparing your string vector, and doing the same sorting manipulation with your int vector but not comparing it. That way the indices get changed in the same way as each other.

void Sort(std::vector<string> s, std::vector<int> i){ 
std::vector<string> temp;
std::vector<int> temp2; 
if (s[k] > s[l]){ 
temp[k] = s[l];
temp[l] = s[k];
temp2 [k] = s[l];
temp2 [l] = s[k]; 
}
s = temp;
i = temp2; 

}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:

>>>>  If you're just trying to keep the vectors associated, simply do the exact same manipulations on the 2nd vector.

That means if you swap strings of the string vector - say swap at positions i and j - then swap at the same positions in the int vector.

Finally both vectors were sorted at the same positions.

   John    Mary   Abel   Betty   Tom

      1        2         3       4           5


When swapping John at 0 and Abel at 2, you have to swap the 1 at 0 and the 3 at 2, so taht you temporarily have

  Abel    Mary   John   Betty   Tom

      3        2         1       4           5

i. e. John is always associated to 1 and Abel always has the 3.


   

Here was my resolved solution.  Worked it out in school.  Uses the Bubble sort  Thank you to everyone!
      for (unsigned int i=0; i<Vcar.size()-1; ++i)   // Sort Vector
      {
            for (unsigned int j=1; j<Vcar.size(); ++j)
            {
                  if(Vcar[j-1]>Vcar[j])
                  {
                        temp=Vcar[j];
                        Vcar[j] = Vcar[j-1];
                        Vcar[j-1] = temp;
                        temp1=Vmpg[j];         //keeps corresponding/associated vector with
                        Vmpg[j] = Vmpg[j-1];   //sorted vector
                        Vmpg[j-1] = temp1;
            }
      }
      }