Question

Declarations/Instamtiation in ASP.Net - where is the appropriate place??

Asked by: allanmark

Greetings!!

Having just resolved a query, I had a look at the code to see what I could learn from the exercise and realise that I am not clear on where to declare/instyantiate my objects. Below are two examples, marked CORRECT  & WRONG (as I understand them), together with a comment on execution.

WRONG:

    protected SqlConnection sqlConnectC;
    protected SqlCommand sqlCommandC;

    protected void Page_Load(object sender, EventArgs e)
    {
      if (!Page.IsPostBack)
      {
       
      }
    }

    protected void Button1_Click1(object sender, EventArgs e)
    {
        sqlConnectC = new SqlConnection(conString);
        sqlCommandC = new SqlCommand("countContracty", sqlConnectC);
        sqlCommandC.CommandType = CommandType.StoredProcedure;

        // Input parameter
        SqlParameter workParam = new SqlParameter("@startType", SqlDbType.Int);
        workParam.Direction = ParameterDirection.Input;
        workParam.Value = 99;
        sqlCommandC.Parameters.Add(workParam);

        // Output parameter
        SqlParameter workParam2 = new SqlParameter("@contractCount", SqlDbType.Int);
        workParam2.Direction = ParameterDirection.Output;
        sqlCommandC.Parameters.Add(workParam2);

        if (RadioButtonList1.SelectedIndex == 0)
        {
            sqlCommandC.Parameters["@startType"].Value = 0;
        }
        else
        {
            sqlCommandC.Parameters["@startType"].Value = 1;
        }

        sqlConnectC.Open();
        sqlCommandC.ExecuteNonQuery();
        sqlConnectC.Close();

         lblCount.Text = "Count: " +sqlCommandC.Parameters[1].Value.ToString();

Execution: App runs 100%!!!


CORRECT:

    protected SqlConnection sqlConnectC;
    protected SqlCommand sqlCommandC;

    protected void Page_Load(object sender, EventArgs e)
    {
      if (!Page.IsPostBack)
      {
          sqlConnectC = new SqlConnection(conString);
          sqlCommandC = new SqlCommand("countContracty", sqlConnectC);
          sqlCommandC.CommandType = CommandType.StoredProcedure;

          // Input parameter
          SqlParameter workParam = new SqlParameter("@startType", SqlDbType.Int);
          workParam.Direction = ParameterDirection.Input;
          workParam.Value = 99;
          sqlCommandC.Parameters.Add(workParam);

          // Output parameter
          SqlParameter workParam2 = new SqlParameter("@contractCount", SqlDbType.Int);
          workParam2.Direction = ParameterDirection.Output;
          sqlCommandC.Parameters.Add(workParam2);
       
      }
    }

    protected void Button1_Click1(object sender, EventArgs e)
    {

        if (RadioButtonList1.SelectedIndex == 0)
        {
            sqlCommandC.Parameters["@startType"].Value = 0;
        }
        else
        {
            sqlCommandC.Parameters["@startType"].Value = 1;
        }

        sqlConnectC.Open();
        sqlCommandC.ExecuteNonQuery();
        sqlConnectC.Close();

Execution:  

Server Error in '/Stored_Proc_03_Scalar_Param' Application.
Object reference not set to an instance of an object.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.NullReferenceException: Object reference not set to an instance of an object.

Source Error:

Line 44:         if (RadioButtonList1.SelectedIndex == 0)
Line 45:         {
Line 46:             sqlCommandC.Parameters["@startType"].Value = 0;
Line 47:         }
Line 48:         else

Source File: d:\MyStuff - Allan\New Horizons\Training\Course_Practicals\ASP_Projects\Stored_Proc_03_Scalar_Param\Default.aspx.cs    Line: 46

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2007-08-16 at 21:53:00ID22768979
Tags

instance

,

object

,

output

Topics

Programming for ASP.NET

,

C# Programming Language

Participating Experts
3
Points
300
Comments
4

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. new SqlCommand ("INSERT INTO")
    The Dreamweaver code shown below (asp.net 1.1, C#) gives this error on line 30: Description: An error occurred during the compilation of a resource required to service this request. Please review the following specific error details and modify your source code appropriately....
  2. C# sqlConnection
    I am new to C# and am having a hard time trying to figure some things out. For example I have my main form where I create my connection: public const string SQL_STRING = "Server=xxxxx;" + "DataBase=xxxxx;" + ...
  3. SqlCommand in sql server 2005
    In sql server 2005 in ASP.NET with C# if I want to call a stored procedure I write: SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["IIB_DataConnectionString"].ConnectionString); SqlCommand cmd = new SqlCommand(&...
  4. How to declare an SqlCommand object
    How do I delcare the Command object here? I'm getting syntax errors. I don't think I'm declaring it right. I need to keep the scope of the command object "above" the "If" statements: SqlConnection connection = new SqlConnection("Server=...... SqlCo...
  5. SqlCommand and SqlDataAdapter
    Hello, I have the following code below and I'm not sure if I need to use an SqlCommand to call my Stored Procedure or if I only need to use the SqlDataAdapter to do this. I don't want to use both if I don't have to. Please take a look at my code below and tell me if I can ju...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Chirag1211Posted on 2007-08-16 at 21:59:54ID: 19714667

The 2nd example of the code throws an error because in the Page_Load() event you have written code as :
if(!Page.IsPostaback)
{
sqlConnectC = new SqlConnection(conString);
sqlCommandC = new SqlCommand("countContracty", sqlConnectC);
sqlCommandC.CommandType = CommandType.StoredProcedure;


.........}

Now sqlCommandC object will only get instantiated when your page will get loaded for the first time. But when you click on the button the code inside the if() statement will not work. So the sqlCommandC object will be null which when accessed inside Button_Click() event will throw null reference exception

So the change for this could you remove the if() condition in the Page_load()

Regards,

Chirag Patel.

 

by: dbaduckPosted on 2007-08-16 at 22:07:16ID: 19714688

Regardless of the Page_Load if statement, you have to understand scope of the variables you create.

When you create or instantiate the variable inside a block, like an if( ) { } then the variables only exist there. If you declare the variables in a function then that is where they exist.

Now the key is in this case that you have them declared outside of any function or block, so the variable itself is OK, but in this case you have instantiated them by using new () inside a block that is executed only the first (as indicated above) therefore on the second iteration or postback, the variables are declared but not instantiated and therefore you get the error of null reference exception.

The first example that you indicate is Wrong, I am interested in why you think it is wrong.  It is actually right, and in your example, it is the way you should do this because you use the variables when you need them and then they go out of scope.  In your second example you are trying to be generic and have a GLOBAL object, and that is not the best practice in .NET.

Ben.

 

by: Ready1Posted on 2007-08-16 at 22:47:36ID: 19714798

I agree with dbaduck your wrong is actually correct. What you need to consider is that asp.net is stateless so (unless you use Session all over the shop) once the page loads any instances of objects you have used are disposed.

In Page_Load once you create an instance of


    SqlConnection sqlConnectC;
    SqlCommand sqlCommandC;

it will be cleaned up once it goes out of scope and you will need to reinitialize if you want to use it in any PostBacks.

regards,
Ready1

 

by: allanmarkPosted on 2007-08-17 at 12:50:49ID: 19719793

I come from the ancient days of Mainframe COBOL - variables using sparing, etc, etc. To top that I have been out of real programming for almost three years  - I guess I've got  amajor technology catch up to do.

To all three replies - thankyou - each one ha staught me something!  It makes a whole lot more sense, now.

Cheers
  allanmark

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...