[x]
Posted via EE Mobile

Search, ask, and monitor your questions on the go with EE Mobile. Visit Experts Exchange from your mobile device and never be out of touch again.

Question
[x]
Attachment Details
[x]
The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

  • The Grade of the Solution
  • The Zone Rank of the Expert Providing the Solution
  • The Number of Author and Expert Comments
  • The Number of Experts Contributing
  • The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

8.4

Declarations/Instamtiation in ASP.Net - where is the appropriate place??

Asked by allanmark in Programming for ASP.NET, C# Programming Language

Tags: instance, object, output

Greetings!!

Having just resolved a query, I had a look at the code to see what I could learn from the exercise and realise that I am not clear on where to declare/instyantiate my objects. Below are two examples, marked CORRECT  & WRONG (as I understand them), together with a comment on execution.

WRONG:

    protected SqlConnection sqlConnectC;
    protected SqlCommand sqlCommandC;

    protected void Page_Load(object sender, EventArgs e)
    {
      if (!Page.IsPostBack)
      {
       
      }
    }

    protected void Button1_Click1(object sender, EventArgs e)
    {
        sqlConnectC = new SqlConnection(conString);
        sqlCommandC = new SqlCommand("countContracty", sqlConnectC);
        sqlCommandC.CommandType = CommandType.StoredProcedure;

        // Input parameter
        SqlParameter workParam = new SqlParameter("@startType", SqlDbType.Int);
        workParam.Direction = ParameterDirection.Input;
        workParam.Value = 99;
        sqlCommandC.Parameters.Add(workParam);

        // Output parameter
        SqlParameter workParam2 = new SqlParameter("@contractCount", SqlDbType.Int);
        workParam2.Direction = ParameterDirection.Output;
        sqlCommandC.Parameters.Add(workParam2);

        if (RadioButtonList1.SelectedIndex == 0)
        {
            sqlCommandC.Parameters["@startType"].Value = 0;
        }
        else
        {
            sqlCommandC.Parameters["@startType"].Value = 1;
        }

        sqlConnectC.Open();
        sqlCommandC.ExecuteNonQuery();
        sqlConnectC.Close();

         lblCount.Text = "Count: " +sqlCommandC.Parameters[1].Value.ToString();

Execution: App runs 100%!!!


CORRECT:

    protected SqlConnection sqlConnectC;
    protected SqlCommand sqlCommandC;

    protected void Page_Load(object sender, EventArgs e)
    {
      if (!Page.IsPostBack)
      {
          sqlConnectC = new SqlConnection(conString);
          sqlCommandC = new SqlCommand("countContracty", sqlConnectC);
          sqlCommandC.CommandType = CommandType.StoredProcedure;

          // Input parameter
          SqlParameter workParam = new SqlParameter("@startType", SqlDbType.Int);
          workParam.Direction = ParameterDirection.Input;
          workParam.Value = 99;
          sqlCommandC.Parameters.Add(workParam);

          // Output parameter
          SqlParameter workParam2 = new SqlParameter("@contractCount", SqlDbType.Int);
          workParam2.Direction = ParameterDirection.Output;
          sqlCommandC.Parameters.Add(workParam2);
       
      }
    }

    protected void Button1_Click1(object sender, EventArgs e)
    {

        if (RadioButtonList1.SelectedIndex == 0)
        {
            sqlCommandC.Parameters["@startType"].Value = 0;
        }
        else
        {
            sqlCommandC.Parameters["@startType"].Value = 1;
        }

        sqlConnectC.Open();
        sqlCommandC.ExecuteNonQuery();
        sqlConnectC.Close();

Execution:  

Server Error in '/Stored_Proc_03_Scalar_Param' Application.
Object reference not set to an instance of an object.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.NullReferenceException: Object reference not set to an instance of an object.

Source Error:

Line 44:         if (RadioButtonList1.SelectedIndex == 0)
Line 45:         {
Line 46:             sqlCommandC.Parameters["@startType"].Value = 0;
Line 47:         }
Line 48:         else

Source File: d:\MyStuff - Allan\New Horizons\Training\Course_Practicals\ASP_Projects\Stored_Proc_03_Scalar_Param\Default.aspx.cs    Line: 46
[+][-]08/16/07 09:59 PM, ID: 19714667Accepted Solution

View this solution now by starting your 30-day free trial. Setting up your free trial is quick, easy, and secure. We will return you to this solution, unlocked, when you're done.

About this solution

Zones: Programming for ASP.NET, C# Programming Language
Tags: instance, object, output
Sign Up Now!
Solution Provided By: Chirag1211
Participating Experts: 3
Solution Grade: A
 
[+][-]08/16/07 10:07 PM, ID: 19714688Assisted Solution

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 30-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08/16/07 10:47 PM, ID: 19714798Assisted Solution

Assisted solutions are selected by the member who asked the question as a comment that contributed to their question's solution.

Start your 30-day free trial to view this Assisted Solution or ask the Experts your question.

 
[+][-]08/17/07 12:50 PM, ID: 19719793Author Comment

Often, when Experts are collaborating with members who have asked questions, they will request additional information about the problem. Askers respond with an author comment like this one.

Start your 30-day free trial to view this Author Comment or ask the Experts your question.

 
 
Loading Advertisement...
20091111-EE-VQP-92 / EE_QW_2_20070628