Question

ASP.NET Return inserted row id

Asked by: thomasmutton

Hello experts.

Hopefully this is a nice and easy one for you guys.

I have an external class with a method that inserts values into a table through a stored procedure. I now want to it to send back the inserted row ID.

How would I do this with my code?

EXTERNAL CLASS
    
public static void AddModule(string name_en, string name_el, string desc_en, string desc_el)
    {
        SqlConnection myConnection = new SqlConnection(Configuration.DbConnectionString);
 
        SqlCommand cmd = new SqlCommand("AddTrainingModule", myConnection);
        cmd.CommandType = CommandType.StoredProcedure;
 
        cmd.Parameters.Add(new SqlParameter("@name_en", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_en"].Value = name_en;
        cmd.Parameters.Add(new SqlParameter("@name_el", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_el"].Value = name_el;
        cmd.Parameters.Add(new SqlParameter("@desc_en", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_en"].Value = desc_en;
        cmd.Parameters.Add(new SqlParameter("@desc_el", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_el"].Value = desc_el;
 
        try
        {
            myConnection.Open();
            cmd.ExecuteNonQuery();
        }
        catch (SqlException err)
        {
            throw new ApplicationException("Cannot add training module.");
        }
        finally
        {
            myConnection.Close();
        }
    }
 
 
STORED PROCEDURE
 
ALTER PROCEDURE dbo.AddTrainingModule
@name_en			nvarchar(200),
@name_el			nvarchar(200),
@desc_en			nvarchar(1000),
@desc_el			nvarchar(1000)
 
AS
 
INSERT INTO dbo.tbl_trainingmodules
        (tm_Name_en, tm_Name_el, tm_Desc_en, tm_Desc_el) 
  VALUES 
        (@name_en, @name_el, @desc_en, @desc_el)

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-04-01 at 07:36:24ID23285873
Tags

asp.net

,

any

,

n/a

Topic

Programming for ASP.NET

Participating Experts
2
Points
0
Comments
15

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Inserting Rows
    In order to make it easier for the user to do data entry, I would like to place a button on my worksheet that when clicked, a new row is inserted. This row would be inserted above whatever the active cell was when the button was clicked. The macro would then copy all the form...
  2. ASP.net Insert row into Datagrid during ItemDataBound
    Does anyone know how to insert a row into the Datagrid during ItemDataBound? I may need to add a row after x number of records. I am trying to insert a category break in my product list. I can not use a Master/Detail grid scenario, because of the way items are displayed. ...
  3. Inserting a new row using ADO.NET
    I designed my form with the Data Components at design time. All DataAdapters commands are bound to Stored Procedures, all textboxes are bound to their respective fields. The select and update methods work like a charm. However, I don't know how to insert a new row. ...
  4. Insert row at bottom of DataGrid
    I want to insert a row at the bottom of the datagrid, which it does IF a column on the DataGrid is not clicked . . changing the sort order. How can I insert the row at the bottom even if one of the columns is clicked, changing the sort order? I'm guessing the "I...
  5. database independent last inserted row
    Hi I have a small web application, which inserts data into a database. A column in one of the table is an auto incremented id. Once I insert a row, I need to get the id just inserted to continue with other tables. So far so good, nothing complex and it is something I have ...
  6. Last Inserted Row ID
    is there an efficient way of retrieving the last inserted row id in Informix.

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: hongjunPosted on 2008-04-01 at 07:40:25ID: 21254376

Try this

stored procedure
================ 
ALTER PROCEDURE dbo.AddTrainingModule
@name_en                  nvarchar(200),
@name_el                  nvarchar(200),
@desc_en                  nvarchar(1000),
@desc_el                  nvarchar(1000)
 
AS 
SET NOCOUNT ON 
INSERT INTO dbo.tbl_trainingmodules
        (tm_Name_en, tm_Name_el, tm_Desc_en, tm_Desc_el) 
  VALUES 
        (@name_en, @name_el, @desc_en, @desc_el) 
SELECT @@IDENTITY 

---------- 
asp.net
--- 
        try
        {
            myConnection.Open();
            int id = Convert.ToInt32(cmd.ExecuteScalar());
        }

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:

Select allOpen in new window

 

by: thomasmuttonPosted on 2008-04-01 at 08:10:20ID: 21254703

This seems to return zero every time..

 

by: hongjunPosted on 2008-04-01 at 08:13:05ID: 21254734

What is the datatype of id for tbl_trainingmodules table?

 

by: thomasmuttonPosted on 2008-04-01 at 08:14:09ID: 21254743

integer

 

by: hongjunPosted on 2008-04-01 at 08:15:41ID: 21254759

From your insert statement, you are not including the id in the column list. It's necessary since the datatype of that field is not an identity. I believe it's not an identity.

 

by: thomasmuttonPosted on 2008-04-01 at 08:16:35ID: 21254768

by the way, I am calling it like this


        // Add the training module
        TrainingModules.AddModule(strName_en, strName_el, strDesc_en, strDesc_el);

        Response.Write(Convert.ToString(TrainingModules.Title));



and setting it as a public integer in external class like so

    private static int intid;
    public static int Title
    {
        get { return intid; }
    }


    public static void AddModule(string name_en, string name_el, string desc_en, string desc_el)
    {
        SqlConnection myConnection = new SqlConnection(Configuration.DbConnectionString);

        SqlCommand cmd = new SqlCommand("AddTrainingModule", myConnection);
        cmd.CommandType = CommandType.StoredProcedure;

        cmd.Parameters.Add(new SqlParameter("@name_en", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_en"].Value = name_en;
        cmd.Parameters.Add(new SqlParameter("@name_el", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_el"].Value = name_el;
        cmd.Parameters.Add(new SqlParameter("@desc_en", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_en"].Value = desc_en;
        cmd.Parameters.Add(new SqlParameter("@desc_el", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_el"].Value = desc_el;

        try
        {
            myConnection.Open();
            cmd.ExecuteNonQuery();
            int intid = Convert.ToInt32(cmd.ExecuteScalar());
        }
        catch (SqlException err)
        {
            throw new ApplicationException("Cannot add training module.");
        }
        finally
        {
            myConnection.Close();
        }
    }

 

by: hongjunPosted on 2008-04-01 at 08:39:28ID: 21254999

Perhaps you should get the next max id since you are not using identity.

ALTER PROCEDURE dbo.AddTrainingModule
@name_en			nvarchar(200),
@name_el			nvarchar(200),
@desc_en			nvarchar(1000),
@desc_el			nvarchar(1000)
 
AS
 
SET NOCOUNT ON
 
DECLARE @ID integer
 
SELECT @ID=IsNull(MAX(youridfield)+1, 1) FROM dbo.tbl_trainingmodules
 
INSERT INTO dbo.tbl_trainingmodules
        (youridfield, tm_Name_en, tm_Name_el, tm_Desc_en, tm_Desc_el) 
  VALUES 
        (@id, @name_en, @name_el, @desc_en, @desc_el)
SELECT @ID

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:

Select allOpen in new window

 

by: thomasmuttonPosted on 2008-04-01 at 08:49:39ID: 21255131

well there is an identity on the table

the table structure is as follows

ID      (int PK)
tm_Name_en
tm_Name_el
tm_Desc_en
tm_Desc_el

 

by: hongjunPosted on 2008-04-01 at 08:52:41ID: 21255169

Try this

ALTER PROCEDURE dbo.AddTrainingModule
@name_en                  nvarchar(200),
@name_el                  nvarchar(200),
@desc_en                  nvarchar(1000),
@desc_el                  nvarchar(1000)
 
AS 
SET NOCOUNT ON 
INSERT INTO dbo.tbl_trainingmodules
        (tm_Name_en, tm_Name_el, tm_Desc_en, tm_Desc_el) 
  VALUES 
        (@name_en, @name_el, @desc_en, @desc_el) 
SELECT IDENT_CURRENT('dbo.tbl_trainingmodules')

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:

Select allOpen in new window

 

by: thomasmuttonPosted on 2008-04-01 at 10:04:51ID: 21255944

hmm still zero

 

by: thomasmuttonPosted on 2008-04-01 at 11:22:02ID: 21256638

we were close there but the value wasnt returning properly in the external class so i did this.

EXTERNAL CLASS
 
public class TrainingModules
{
		private int tmID;
		private string strName_en;
		private string strName_el;
		private string strDesc_en;
        private string strDesc_el;
 
		public int ModuleID
		{
			get {return tmID;}
			set {tmID = value;}
		}
		public string Name_en
		{
			get {return strName_en;}
			set {strName_en = value;}
		}
		public string Name_el
		{
			get {return strName_el;}
			set {strName_el = value;}
		}
		public string Desc_en
		{
			get {return strDesc_en;}
			set {strDesc_en = value;}
		}
		public string Desc_el
		{
			get {return strDesc_el;}
			set {strDesc_el = value;}
		}
 
		public TrainingModules(string strName_en, string strName_el, string strDesc_en, string strDesc_el)
		{
			//this.tmID = tmID;
			this.strName_en = strName_en;
			this.strName_el = strName_el;
			this.strDesc_en = strDesc_en;
			this.strDesc_el = strDesc_el;
		}
 
        public TrainingModules() { }
 
 
    public string AddModule(TrainingModules tm)
    {
        SqlConnection myConnection = new SqlConnection(Configuration.DbConnectionString);
 
        SqlCommand cmd = new SqlCommand("AddTrainingModule", myConnection);
        cmd.CommandType = CommandType.StoredProcedure;
 
        cmd.Parameters.Add(new SqlParameter("@name_en", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_en"].Value = tm.Name_en;
        cmd.Parameters.Add(new SqlParameter("@name_el", SqlDbType.NVarChar, 200));
        cmd.Parameters["@name_el"].Value = tm.Name_el;
        cmd.Parameters.Add(new SqlParameter("@desc_en", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_en"].Value = tm.Desc_en;
        cmd.Parameters.Add(new SqlParameter("@desc_el", SqlDbType.NVarChar, 1000));
        cmd.Parameters["@desc_el"].Value = tm.Desc_el;
 
        cmd.Parameters.Add(new SqlParameter("@tm_ID", SqlDbType.Int));
        cmd.Parameters["@tm_ID"].Direction = ParameterDirection.Output;
 
        try
        {
            myConnection.Open();
            cmd.ExecuteNonQuery();
            return Convert.ToString(cmd.Parameters["@tm_ID"].Value);
        }
        catch (SqlException err)
        {
            throw new ApplicationException("Cannot add training module.");
        }
        finally
        {
            myConnection.Close();
        } 
    }
}
 
 
 
WEB FORM CODE BEHIND
        string strTrainingModuleId = db.AddModule(new TrainingModules(
            strName_en, strName_el, strDesc_en, strDesc_el));
 
        Response.Write(strTrainingModuleId);
 
STORED PROCEDURE
ALTER PROCEDURE dbo.AddTrainingModule
@name_en			nvarchar(200),
@name_el			nvarchar(200),
@desc_en			nvarchar(1000),
@desc_el			nvarchar(1000),
@tm_ID				int OUTPUT
 
AS
 
INSERT INTO dbo.tbl_trainingmodules
        (tm_Name_en, tm_Name_el, tm_Desc_en, tm_Desc_el) 
  VALUES 
        (@name_en, @name_el, @desc_en, @desc_el)
SET @tm_ID = @@IDENTITY
SELECT @tm_ID

                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:

Select allOpen in new window

 

by: hongjunPosted on 2008-04-02 at 08:03:43ID: 21263789

I am ok with delete.

 

by: modus_operandiPosted on 2008-04-21 at 03:56:22ID: 21400281

Closed, 500 points refunded.
modus_operandi
EE Moderator

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...