July 7, 2008 08:16am pdt

1. TheLearn... 639,323
2. samtran0331 369,738
3. raterus 361,590
4. Velio 325,285
5. naspinski 251,474
6. Dhaest 191,439
7. prairiedog 181,463
8. dusion 159,328
9. angelIII 148,299
10. tedbilly 139,075
11. jpaulino 136,603
12. GreenGhost 130,835
13. pratima_mcs 127,218
14. zkeown 123,565
15. Rejojohny 118,615

1. TheLearn... 2,752,904
2. samtran0331 2,439,397
3. raterus 1,981,829
4. nauman_a... 1,214,228
5. sammy1971 1,150,812
6. Rejojohny 1,062,434
7. mmarinov 996,221
8. scolja 960,492
9. lem2802 624,688
10. AerosSaga 600,606
11. Edwin_C 568,753
12. tusharashah 517,701
13. Justin_W 489,746
14. GavinMan... 469,710
15. angelIII 460,031

05.11.2008 at 02:03AM PDT, ID: 23392493

	[x] Attachment Details

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.0

Reference an Object for better code writing

Zones: Programming for ASP.NET, C# Programming Language, Visual Studio .NET 2005

Tags: C#, ASP.NET, VB.NET, .NET

Hi all,
Basically I'm doing a class that takes all the controls and if it's TextBox control / Literal Control / Label Control / etc.. it will check it's "Text" value, and if the "Text Value" starts with "__", it will change the text to text within the Database.
It's working, but I have the feeling that it can be done better.

I've attached the code.
Is there a different (and more efficient) way to take and insert the Control's Text value without "Casting" each one of them depending on their type?

For example, somehting like that:
(_the_actual_control_type)control.Text = "blah blah";

Thanks

         
           
           
             private void ProcessForm(HtmlForm form)
		{
			foreach (Control control in form.Controls)
			{
                if (control is TextBox)
				{
                    TextBox mControl = (TextBox)control;
                    if (mControl.Text.StartsWith("__")) mControl.Text = writeTextFromDB(mControl.Text);
				}
                else if (control is Label)
                {
                    Label mControl = (Label)control;
                    if (mControl.Text.StartsWith("__")) mControl.Text = writeTextFromDB(mControl.Text);
                }
                //and so on.....
			}
		}

           
         

Start your free trial to view this solution

Question Stats

Zone: Programming

Question Asked By: giligatech

Solution Provided By: PockyMaster

Participating Experts: 4

Solution Grade: A

Translate:

Loading Advertisement...

Microsoft

Internet Protocols
Applications

Development
OS

Hardware
Windows Security

Apple

Operating Systems
Hardware

Programming
Networking

Software

Internet

Search Engines
File Sharing
WebTrends / Stats
Spy / Ad Blockers

Web Browsers
New Net Users
Web Development
Chat / IM

Anti Spam
Web Servers
Anti-Virus
Email Clients

Gamers

Tips
Online / MMORPG
Puzzle
Emulators

Action / Adventure
Role Playing
Consoles
Game Programming

Strategy
Sports
Misc
Computer Games

Digital Living

Hardware
New Net Users
New Users

Software
Digital Music
Gaming World

Home Security
Apple
Networking Hardware

Virus & Spyware

Vulnerabilities
IDS
Encryption
Anti-Virus

Operating Systems Security
Software Firewalls
WebApplications
Cell Phones

Operating Systems
Internet
Hardware Firewalls

Hardware

Handhelds / PDAs
Displays / Monitors
Components
Networking Hardware

Peripherals
Laptops/Notebooks
Storage
Servers

Desktops
New Users
Misc
Apple

Software

System Utilities
Industry Specific
Network Management
Photos / Graphics
Page Layout
VMWare
Misc
Web Development

OS
CYGWIN
Voice Recognition
Message Queue
Quality Assurance
Security
Firewalls
MultiMedia Applications

Development
Database
Office / Productivity
Business Management
OS/2 Apps
Server Software
Internet / Email

ITPro

OS
Storage
Encryption
Operating Systems Security
Apple Hardware
Laptops & Notebooks
Servers
Networking Hardware
Peripherals

Devices
Displays / Monitors
WebTrends / Stats
Search Engines
Firewalls
WebApplications
IDS
Vulnerabilities
Email Clients

File Sharing
Spy / Ad Blockers
Web Browsers
Web Servers
Networking
Anti-Virus
Chat / IM
Anti Spam

Developer

Web Servers
Web Browsers
Game Programming
Dev Tools
Industry Specific
Office / Productivity

Database
CYGWIN
Web Development
Search Engines
File Sharing
WebTrends / Stats

Programming
Content Management
Application Servers
Protocols

Storage

Removable Backup Media
Storage Technology
Servers

Grid
Remote Access
Backup / Restore

Misc
Hard Drives

Miscellaneous
Security
Development
Linux
VMWare

MainFrame OS
Unix
Apple
OS / 2
AS / 400

BeOS
Microsoft
VMS / OpenVMS

Database

Oracle
Miscellaneous
MySQL
Software
Sybase
Contact Management
PostgreSQL
Data Manipulation
Clarion
InterSystems Cache

Siebel
MUMPS
OLAP
SQLBase
SAS
GIS & GPS
4GL
Berkeley DB
DB2
Informix

Interbase / Firebird
FoxPro
Reporting
LDAP
Filemaker Pro
MS SQL Server
dBase
MS Access

Security

Misc
Web Browsers
Software Firewalls
Operating Systems Security
File Sharing

Spy / Ad Blockers
Vulnerabilities
WebApplications
IDS
Anti-Virus

Encryption
Anti Spam
Email Clients
VPN
Chat / IM

Programming

Editors IDEs
Installation
Handhelds / PDAs
Multimedia Programming
System / Kernel

Algorithms
Game
Signal Processing
Project Management
Open Source

Database
Misc
Languages
Processor Platforms
Theory

Web Development

Scripting
Blogs
Web Servers
Software
Search Engines
Web Graphics
Images

Internet Marketing
Images and Photos
Components
Document Imaging
Web Languages/Standards
Illustration
WebApplications

Fonts
WebTrends / Stats
Authoring
Digital Camera Software
Miscellaneous

Networking

Protocols
Apple Networking
Network Management
Message Queue
Application Servers
Content Management
File Servers
Email Servers
Misc
Java Editors & IDEs

Wireless
Networking Hardware
Backup / Restore
System Utilities
ISPs & Hosting
Web Servers
Storage Technology
Removable Backup Media
Servers
Broadband

Grid
OS / 2
Novell Netware
Unix Networking
Windows Networking
Security
Telecommunications
Operating Systems
Linux Networking

Other

Community Advisor
Lounge
Community Support
New Net Users

Philosophy / Religion
Math / Science
Miscellaneous
URLs

Expert Lounge
Politics
Puzzles / Riddles

Community Support

Suggestions
New to EE
New Topics
Community Advisor

CleanUp
Announcements
General

Feedback
Input
EE Bugs

05.11.2008 at 02:29AM PDT, ID: 21541941

Rank: Master

DarrenD:

If you know that each control that you want to access has the text propety can you just use something like this

Just a thought.

Cheers,

Darren

                       
             foreach (Control control in form.Controls)
{
  if (control is TextBox || control is Label) // Add any extra controls that have the Text property
  {
    if (ontrol.Text.StartsWith("__")) control.Text = writeTextFromDB(control.Text);
  }
}

Open in New Window

05.11.2008 at 02:37AM PDT, ID: 21541954

giligatech:

It doesn't work. I get:
'System.Web.UI.Control' does not contain a definition for 'Text'

05.11.2008 at 02:56AM PDT, ID: 21541976

Rank: Master

PockyMaster:

Sorry, but I haven't got VS installed here..
But there should be an interface called ITextControl.
http://msdn.microsoft.com/en-us/library/system.web.ui.itextcontrol.aspx

You can try if your control implements that interface.
e.g.
System.Web.UI.WebControls.Label does

05.11.2008 at 05:01AM PDT, ID: 21542188

Rank: Master

DarrenD:

The error makes perfect sense. I didn't try my solution. Try accessing it using the interface like PockyMaster said. But each control that you want to access will have to implement that interface otherwise you will have to use an if statement or a case statement like you did above I think.

Sorry about that. Let us know if you find a workable solution

Darren

05.11.2008 at 05:08AM PDT, ID: 21542208

giligatech:

Hi DarrenD & PockyMaster,
Can you please give me an example on how to implement the ITextControl interface?

Thanks

05.11.2008 at 06:48AM PDT, ID: 21542453

Smallfish2004:

Hi,

You have asked for it: You can use a custom mapper class for each type of supported control and use the Factory Design pattern (http://www.dofactory.com/Patterns/PatternAbstract.aspx) to create the mapper according to the control type.

Mapper m = Factory.Create(control);
m.MapControlProperties(control, values);

like this, you don't have the hard-coded very long and maintenance nightmare "switch" block.

There you will be able to attach to any control u will ever use! and your code will be more readable.

Have luck!
Yair Cohen

05.11.2008 at 07:09AM PDT, ID: 21542487

ajolly:

a simple performance optimization I would like to suggest is to use normal for loop than foreach.

                       
         
           
           
             private void ProcessForm(HtmlForm form)
  {
    Int32 controlsCount = form.Controls.Count;
    for (Int32 i=0; i<controlsCount; i++)
    {
      if (typeof(form.Controls[i])==TextBox)
      {
        // Do stuff here
      }
      else if (...)
      {
         ...
      }
    }
  }
           
         

Open in New Window

05.11.2008 at 07:17AM PDT, ID: 21542501

giligatech:

Thanks ajolly
but I still can't understand how to make it right

05.11.2008 at 08:16AM PDT, ID: 21542640

Rank: Master

PockyMaster:

normally you should be able to:

foreach(Control control in form.Controls)
{

ITextControl obj = control as ITextControl;

if (obj != null)
{
obj.Text = "blabla";
}
}

Accepted Solution

20080236-EE-VQP-29 / EE_QW_2_20070628