Question

OnClick EventHandler is lost when dynamically moving a Button into a DetailsView grid cell

Asked by: Christian_Agard

I am building an ASP.NET page, with C# code behind, using a MultiView with various DetailsViews and buttons on each View.  Some of the buttons are dynamically captioned, and also I want to group them into the "value" cell of a DetailsView, rather than floating below the grid.

So I do this in a PreRender handler:

         for ( int row = 0; row < DetailsViewResponse.Controls[0].Controls.Count; row++ )
         {
            DataControlFieldCell dcfc = DetailsViewResponse.Controls[0].Controls[row].Controls[0] as DataControlFieldCell;
            if ( dcfc != null )
            {
               DataControlField dcf = dcfc.ContainingField;
               if ( dcf != null )
               {
                  BoundField bf = dcf as BoundField;
                  if ( bf != null )
                  {
                     Control dataCell = DetailsViewResponse.Controls[0].Controls[row].Controls[1];
                     switch ( bf.DataField )
                     {
                        case MessageCollection.ColumnNameChoices:
                           // Clear any existing child controls.
                           dataCell.Controls.Clear();
                           dataCell.Controls.Add( this.ChoiceButton1 );
                           dataCell.Controls.Add( this.ChoiceButton2 );
                           dataCell.Controls.Add(this.ChoiceButton3);

                           // Manually re-register the event-handling method for
                           // the Click event of the Button control.
                           //this.ChoiceButton2.Attributes.Add("onClick", ???);
                           //this.ChoiceButton2.Click += new EventHandler(this.ChoiceButton2_Click);

                           break;
                        case MessageCollection.ColumnNameSelectedChoice:
                           // Clear any existing child controls.
                           dataCell.Controls.Clear();
                           dataCell.Controls.Add(this.SelectedChoiceButton);
                           break;
                     }
                  }
               }
            }
         }

When I do this, the buttons' OnClick (e.g. ChoiceButton1_Click) stops working.  Clicking on the button does nothing.

As soon as I comment out any of the dataCell.Controls.Add() calls, that button's OnClick starts working again.

I tried various ways to try to re-attach the OnClick handler, as shown by the commented out lines, but none worked.


How to reenable or retain the OnClick handler for a button that is moved into a DetailsView cell?
p.s. The DetailsView is enabled.

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-08-01 at 06:45:48ID23614105
Tags

C#

Topic

Programming for ASP.NET

Participating Experts
1
Points
500
Comments
7

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Onclick change of a cell background color
    I'd like to change the background of a cell color from white to blue (#000080) by onclick. How do I refer to the specific cell? The table data is dynamic. thnx MissJones
  2. Onclick
    Whats the syntack to use onclick to point to a url when a table cell is clicked... Thanks
  3. datagrid onclick events
    hi I have an issue with onclick event on a datagrid cell, after the data grid is populated is there any way i could know which row is clicked on the client side???
  4. Onclick change cell bgColor
    Ok, I have been trying to do this for the last hour and I give up. What i'm trying to do is have a function that when you click on a cell it will change the bgColor of that cell, but if you click on another cell or you click on the same cell again then it will set the bgColo...
  5. OnClick
    Hi Experts, I am trying to create a web page where users can select one of too teams and place a bet. The following is an example of the first column in the table where I would like to click. Currently when I click It fails and says ColA_Click is undefined. Also I would l...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: Infinite_RecursionPosted on 2008-08-01 at 07:41:11ID: 22138703

Hi, I am not sure if it is relevant, but you might want to remove the button from its original Parent's Controls collection before adding it to the DetailsView.

 

by: Christian_AgardPosted on 2008-08-01 at 08:38:02ID: 22139349

Good idea!  However I tried and it did not make a difference.  Thanks

 

by: Infinite_RecursionPosted on 2008-08-02 at 14:18:33ID: 22145704

Hi,
it would be helpful if you can provide the whole code.

 

by: Christian_AgardPosted on 2008-08-07 at 11:10:55ID: 22183661

See attached code snippets.

Create a C# Web Site.
Drop on a DetailsView, ObjectDataSource, 2 Buttons, and a TextBox.
Label the Buttons.
Configure the DataSource to use the JustSomeData class and its GetData() method for SELECT.
Attach the DetailsView to the DataSource.

Run it.

Click Button2 and you get a message in the TextBox.
Click Button1 and nothing happens.

Default.aspx.cs:
 
using System;
using System.Data;
using System.Configuration;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;
 
public partial class _Default : System.Web.UI.Page 
{
    protected void Page_Load(object sender, EventArgs e)
    {
       DetailsView1.DataBind();
 
       DetailsView1.Visible = true;
    }
   protected void Button1_Click(object sender, EventArgs e)
   {
      TextBox1.Text = "You clicked Button1!";
   }
   protected void Button2_Click(object sender, EventArgs e)
   {
      TextBox1.Text = "You clicked Button2!";
   }
 
   protected override void Render(HtmlTextWriter writer)
   {
      Render_DetailsView1();
 
      base.Render(writer);
   }
 
   protected void Render_DetailsView1()
   {
      for (int row = 0; row < DetailsView1.Controls[0].Controls.Count; row++)
      {
         DataControlFieldCell dcfc = DetailsView1.Controls[0].Controls[row].Controls[0] as DataControlFieldCell;
         if (dcfc != null)
         {
            DataControlField dcf = dcfc.ContainingField;
            if (dcf != null)
            {
               BoundField bf = dcf as BoundField;
               if (bf != null)
               {
                  Control dataCell = DetailsView1.Controls[0].Controls[row].Controls[1];
                  switch (bf.DataField)
                  {
                     case "Column1":
                        dataCell.Controls.Add(this.Button1);
                        break;
                  }
               }
            }
         }
      }
   }
}
 
 
App_Code\JustSomeData.cs:
 
using System;
using System.Data;
using System.Configuration;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;
 
/// <summary>
/// Summary description for JustSomeData
/// </summary>
public class JustSomeData : DataSet
{
	public JustSomeData()
	{
      this.Tables.Add();
      this.Tables[0].Columns.Add("Column0");
      this.Tables[0].Columns.Add("Column1");
      this.Tables[0].Columns.Add("Column2");
      this.Tables[0].Rows.Add("Row0Column0Value", "Row0Column1Value", "Row0Column2Value");
	}
 
   public DataSet GetData()
   {
      return this;
   }
 
}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:

Select allOpen in new window

 

by: Infinite_RecursionPosted on 2008-08-08 at 10:44:44ID: 22192013

Hi. Thanks for posting the code. I took a look and the problem is clear. The ASP.NET Page Life Cycle is important to understand when manipulating the control Hierarchy in any situation. In this case, moving the controls around (specifically in the case Button1) is not happening soon enough. When you do what you do, the button looses its link to the event handlers and the event handler is never called. The solution is pretty simple, move the calle to Render_DetailsView1 to an earlier point like the Page_Load method.


check the attached code and you'll be fine.
Enjoy.

//call removed from the Render method (you can also remove the whole method since it is useless now
protected override void Render(HtmlTextWriter writer)
{
   //Render_DetailsView1();
 
   base.Render(writer);
}
//and move the call to Page_Load
protected void Page_Load(object sender, EventArgs e)
{
   DetailsView1.DataBind();
 
   DetailsView1.Visible = true;
       Render_DetailsView1();
}
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:

Select allOpen in new window

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...