Question

ASP.NET file upload locks file

Asked by: dmat1

I have an ASP.Net file upload script that I use to upload and resize an image. It also creates a thumbnail. The problem is that if I try to upload a different image to replace the one I just uploaded I get an error. When I go to my FTP and try to delete it I get a permission denied. I can delete the file the next day though.

From what I can tell my script doesnt release the file immediately. Can someone take a look at my script and tell me what I am missing?

<%@ Page Trace="False" Language="vb" aspcompat="false" debug="true" validateRequest="false"%>
<%@ Import Namespace=System.Drawing %>
<%@ Import Namespace=System.Drawing.Imaging %>
<%@ Import Namespace=System %>
<%@ Import Namespace=System.Web %>
<%@ Import Namespace="System.IO" %>
 
 
<SCRIPT LANGUAGE="VBScript" runat="server">
    Const Tx = 160 ' max width for thumbnails
    Const Ty = 120 ' max height for thumbnails
    Const Fx = 360' max width for full images
    Const Fy = 240' max height for full images
    Const upload_dir = "/img/agents/" ' directory to upload file
    Const upload_original = "big" ' filename to save original as (suffix added by script)
    Const upload_thumb = "small" ' filename to save thumbnail as (suffix added by script)
    Const upload_max_size = 5000 ' max size of the upload (KB) note: this doesn't override any server upload limits
    Dim fileExt ' used to store the file extension (saves finding it mulitple times)
    Dim newWidth, newHeight As Integer ' new width/height for the thumbnail
    Dim l2 ' temp variable used when calculating new size
    Dim fileFld As HttpPostedFile ' used to grab the file upload from the form
    Dim originalimg As System.Drawing.Image ' used to hold the original image
    Dim msg ' display results
    Dim upload_ok As Boolean ' did the upload work ?
    Dim MyFileName As String
    Dim CryptID  As String    
    
</script>
 
 
<%
 
 
    Randomize() ' used to help the cache-busting on the preview images
    upload_ok = False
    If LCase(Request.ServerVariables("REQUEST_METHOD")) = "post" Then
        fileFld = Request.Files(0) ' get the first file uploaded from the form (note:- you can use this to itterate through more than one image)
        If fileFld.ContentLength > upload_max_size * 1024 Then
            msg = "Sorry, the image must be less than " & upload_max_size & "Kb"
        Else
            Try
                originalimg = System.Drawing.Image.FromStream(fileFld.InputStream)
                ' work out the width/height for the thumbnail. Preserve aspect ratio and honour max width/height
                ' Note: if the original is smaller than the thumbnail size it will be scaled up
                If (originalimg.Width / Fx) > (originalimg.Width / Fy) Then
                    l2 = originalimg.Width
                    newWidth = Fx
                    newHeight = originalimg.Height * (Fx / l2)
                    If newHeight > Fy Then
                        newWidth = newWidth * (Fy / newHeight)
                        newHeight = Fy
                    End If
                Else
                    l2 = originalimg.Height
                    newHeight = Fy
                    newWidth = originalimg.Width * (Fy / l2)
                    If newWidth > Fx Then
                        newHeight = newHeight * (Fx / newWidth)
                        newWidth = Fx
                    End If
                End If
                Dim thumb As New Bitmap(newWidth, newHeight)
                'Create a graphics object
                Dim gr_dest As Graphics = Graphics.FromImage(thumb)
                ' just in case it's a transparent GIF force the bg to white
                Dim sb = New SolidBrush(System.Drawing.Color.White)
                gr_dest.FillRectangle(sb, 0, 0, thumb.Width, thumb.Height)
                'Re-draw the image to the specified height and width
                gr_dest.DrawImage(originalimg, 0, 0, thumb.Width, thumb.Height)
                Try
                 MyFileName = "agent" & request.querystring("pic_id")
 
                    fileExt = System.IO.Path.GetExtension(fileFld.FileName).ToLower()
'                    originalimg.Save(Server.MapPath(upload_dir & MyFileName & "-" & upload_original & fileExt), originalimg.RawFormat)
                    thumb.Save(Server.MapPath(upload_dir & "/large/" & MyFileName & fileExt), originalimg.RawFormat)
 
 
 
        Dim bAns As Boolean
        Dim sNewFile As String
	Dim BMPFullPath as String
 
 
BMPFullPath=Server.MapPath(upload_dir & "/large/"  & MyFileName & fileExt)
 
 
        Try
            'bitmap class in system.drawing.imaging
            Dim objBmp As New Bitmap(BMPFullPath)
 
            'below 2 functions in system.io.path
            sNewFile =Server.MapPath(upload_dir) & "/large/" &  MyFileName & ".jpg"
            objBmp.Save(sNewFile, ImageFormat.Jpeg)
 
 
            bAns = True 'return true on success
        Catch
            bAns = False 'return false on error
        End Try
 
 
 
                    msg = "Uploaded " & fileFld.FileName & " to " & Server.MapPath(upload_dir & upload_original & fileExt)
                    upload_ok = True
		    
		    'Using the FileInfo class
		    
 
		    
                Catch ex As Exception
                    msg = "Sorry, there was a problem saving the image."
                End Try
                ' Housekeeping for the generated thumbnail
                If Not thumb Is Nothing Then
                    thumb.Dispose()
                    thumb = Nothing
                End If
            Catch
                msg = "Sorry, that was not an image we could process."
            End Try
       
 
 
 
'*******************
'large image
'*******************
 
Try
                originalimg = System.Drawing.Image.FromStream(fileFld.InputStream)
                ' work out the width/height for the thumbnail. Preserve aspect ratio and honour max width/height
                ' Note: if the original is smaller than the thumbnail size it will be scaled up
                If (originalimg.Width / Tx) > (originalimg.Width / Ty) Then
                    l2 = originalimg.Width
                    newWidth = Tx
                    newHeight = originalimg.Height * (Tx / l2)
                    If newHeight > Ty Then
                        newWidth = newWidth * (Ty / newHeight)
                        newHeight = Ty
                    End If
                Else
                    l2 = originalimg.Height
                    newHeight = Ty
                    newWidth = originalimg.Width * (Ty / l2)
                    If newWidth > Tx Then
                        newHeight = newHeight * (Tx / newWidth)
                        newWidth = Tx
                    End If
                End If
                Dim full As New Bitmap(newWidth, newHeight)
                'Create a graphics object
                Dim gr_dest As Graphics = Graphics.FromImage(full)
                ' just in case it's a transparent GIF force the bg to white
                Dim sb = New SolidBrush(System.Drawing.Color.White)
                gr_dest.FillRectangle(sb, 0, 0, full.Width, full.Height)
                'Re-draw the image to the specified height and width
                gr_dest.DrawImage(originalimg, 0, 0, full.Width, full.Height)
                Try
 
	    
                    fileExt = System.IO.Path.GetExtension(fileFld.FileName).ToLower()
'                    originalimg.Save(Server.MapPath(upload_dir & MyFileName & "-" & upload_original & fileExt), originalimg.RawFormat)
                    full.Save(Server.MapPath(upload_dir & "/small/" & MyFileName & fileExt), originalimg.RawFormat)
 
 
 
        Dim bAns As Boolean
        Dim sNewFile As String
	Dim BMPFullPath as String
 
 
BMPFullPath=Server.MapPath(upload_dir & "/small/"  & MyFileName & fileExt)
 
 
        Try
            'bitmap class in system.drawing.imaging
            Dim objBmp As New Bitmap(BMPFullPath)
 
            'below 2 functions in system.io.path
            sNewFile =Server.MapPath(upload_dir) & "/small/" &  MyFileName & ".jpg"
            objBmp.Save(sNewFile, ImageFormat.Jpeg)
objBmp.Dispose()
            bAns = True 'return true on success
        Catch
            bAns = False 'return false on error
        End Try
 
 
 
                    msg = "Uploaded " & fileFld.FileName & " to " & Server.MapPath(upload_dir & upload_original & fileExt)
                    upload_ok = True
		    
		    'Using the FileInfo class
		    
 
		    
                Catch ex As Exception
                    msg = "Sorry, there was a problem saving the image."
                End Try
                ' Housekeeping for the generated thumbnail
                If Not full Is Nothing Then
                    full.Dispose()
                    full = Nothing
                End If
            Catch
                msg = "Sorry, that was not an image we could process."
            End Try
        End If
 
 
 
 
 
 
 
 
        ' House Keeping !
        If Not originalimg Is Nothing Then
 
            originalimg.Dispose()
            originalimg = Nothing
        End If
    End If
%>
<html>
<head>
<LINK href="/rhino.css" type=text/css rel=stylesheet>
</head>
<body>
<center>
 
<table width=550 bgcolor=white><tr><td align=center><br>
<br>
 
 
 
<p>
    &nbsp;</p>
 
 <form id="Form1" enctype="multipart/form-data" method="post" runat="server">
 <table>
 <tr><td>Select the new file to upload:</td></tr><tr><td><input type="file" name="upload_file"></td></tr>
 
 
 <tr><td colspan=1><input type="submit" value="Upload" id="Submit1" language="javascript" onclick="return Submit1_onclick()">
 </table>
 </form>
 
 <%
     If upload_ok Then
 
%>
<script language="JavaScript" type="text/javascript">
opener.agentpic.src="<%=upload_dir & "/large/" & MyFilename   &  ".jpg?" & rnd()%>";
window.close();
</script>
 
 
 <table>
 <tr>
 
 <td valign=top align=center>
 
<img src="<%=upload_dir & "/large/" & MyFilename   &  ".jpg?" & rnd()%>"></td>
 </tr>
 </table>
 <%
 Else
     Response.Write(msg)
 End If
 %><br>
 
</td></tr></table>
 
</center>
</body>
</html>

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:
194:
195:
196:
197:
198:
199:
200:
201:
202:
203:
204:
205:
206:
207:
208:
209:
210:
211:
212:
213:
214:
215:
216:
217:
218:
219:
220:
221:
222:
223:
224:
225:
226:
227:
228:
229:
230:
231:
232:
233:
234:
235:
236:
237:
238:
239:
240:
241:
242:
243:
244:
245:
246:
247:
248:
249:
250:
251:
252:
253:
254:
255:
256:
257:
258:
259:
260:
261:
262:
263:
264:
265:
266:
267:
268:
269:
270:
271:
272:
273:
274:
275:
276:
277:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-01-23 at 13:38:20ID24079067
Topic

Programming for ASP.NET

Participating Experts
3
Points
500
Comments
8

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Image Thumbnail in ASP.NET
    Hi, I am importing image from a folder and I need to make thumbnails on a asp.net web page. When click the thumbnail will open a new window with the original window. Thanks
  2. Asp.net Image Upload resizing.
    Hell, I'm using ASP.net/VB.net to upload an image using "System.Web.UI.HtmlControls.HtmlInputFile". I'm able to upload successfully ensuring that all images are jpeg but I'm looking for a way to determine the size of the image and compressing/resizing the image so ...
  3. Image Upload resizing in VB Language/ASP.NET
    Introduction : I am trying to accomplish the automatic resizing of images files that are uploaded through a upload control. I have already completed the upload process but now before saving the file to the disk, i need to ensure that the images get resized to a predefined dim...
  4. Upload Image, Resize, and Thumbnail
    Hello, I am struggleing to find an answer to this one. Basically I am not all that familiar with PHP but people here have helped me in the past by making a simple image upload-->resize-->give link to picture. The code also renames the picture to number 1, the next uplo...
  5. asp.net script / solution to resize uploaded images on ser…
    Here is my situation.... Im sitll working under clasic ASP and I have a web hosting that cant provide me any dll components such as ASPImageResize or other third part solutions but the server is under windows 2003 os and I heard that ASP.NET have integrated solution for res...
  6. ASP.Net C# Image resizer
    Hello experts, I was wondering if anyone had, or knows of a good application for image resizing for ASP.net C#?

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: CB_ThirumalaiPosted on 2009-01-24 at 05:30:22ID: 23456287

full, originalimg, thumb all use the .Dispose() and set those to Nothing as well, is it from the objBmp Save that is locking the file, and if so, just try using objBmp = Nothing for it too and see.

 

by: CB_ThirumalaiPosted on 2009-01-24 at 05:31:42ID: 23456296

Also, you are reusing the same variable objBmp, just use the .Dispose() and set to Nothing in the first instance use as well and see.

 

by: CB_ThirumalaiPosted on 2009-02-18 at 03:01:54ID: 23668906

Have you got the solution for this?

 

by: dmat1Posted on 2009-02-18 at 15:38:33ID: 23676437

I get an error that the variable objBitmap is not a variable when I try to dispose of it.
When I try to delete files with my FTP program it is the thumbnail and the original that I can't delete.

Someone suggested using a differtent name each time but that wont work since the images are named for the product or property. I am using this script in two different sites. On two different servers but with the same hosting company.

 

by: CB_ThirumalaiPosted on 2009-02-21 at 16:50:50ID: 23702736

There isn't a statement with objBitmap as a variable in your above posted code.

 

by: DropZonePosted on 2009-02-23 at 02:38:36ID: 23709767

I think he meant objBmp

     -dZ.

 

by: suchandsuchPosted on 2009-03-17 at 11:54:14ID: 23911221

CB Thirumalai is right ( I had this problem too, and just found my own solution ): FileUpload isn't causing the lock - System.Drawing.Image is - you need to dispose of that object anywhere you use it, in your case:

originalimg.Dispose()

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...