Question

How to generate dynamic SQL queries in Visual Studio 2008 .NET

Asked by: electricd7

Hello,

I am very new to ASP.NET but have been doing ASP classic for years. I am trying to setup my first simple .NET page displaying data from a SQL database. I am used to do set RS = Server.CreateObject("ADODB.Recordset") and was hoping there was something similar to it in .NET so I could just script in all my SQL calls, but thus far I haven't found it. So I have created a Repeater and bound it to a datasource which I built using the wizard. The problem is, I am not sure how to set the query parameters to dynamic values from the QueryString. Here is the code I currently have. I would like the query at the end to be the same as the 'sqlquery' variable I built at the top. Thanks!

<script runat="server">
sub Page_Load
        Dim facilityid As Integer
        Dim cyear As Integer
        Dim cmonth As Integer
        Dim sqlquery As String
        facilityid = Request.QueryString("facilityid")
        cyear = Request.QueryString("year")
        cmonth = Request.QueryString("month")
        sqlquery = "select * from dbo.dashboardview where facilityid=1 and year=2009 and month=2;"
        tb4.Text = sqlquery
    End Sub
</script>
 
 
<html>
<body>
 
<form id="Form1" runat="server">
<asp:TextBox id="tb4" runat="server" />
<asp:Repeater ID="Repeater1" runat="server" DataSourceID="SqlDataSource1" >
<HeaderTemplate>
<table border="1" width="100%">
  <tr bgcolor="#b0c4de">
  <th>Name</th>
  <th>Numerator</th>
  <th>Denominator</th>
  </tr>
</HeaderTemplate>
 
<ItemTemplate>
  <tr>
    <td><%#Container.DataItem("name")%></td>
    <td><%#Container.DataItem("num")%></td>
    <td><%#Container.DataItem("denom")%></td>
  </tr>
</ItemTemplate>
 
<FooterTemplate>
  </table>
</FooterTemplate>
</asp:Repeater>
<asp:SqlDataSource ID="SqlDataSource1" runat="server" 
    ConnectionString="<%$ ConnectionStrings:IWT-BaldridgeConnectionString %>" 
    SelectCommand="select * from dbo.dashboardview where facilityid=1 and year=2009 and month=2" >
</asp:SqlDataSource>
 
</form>
 
</body>
</html>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:

Select all Open in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Plus...

30 Day FREE access, no risk, no obligation
Collaborate with the world's top tech experts
Unlimited access to our exclusive solution database
Never be left without tech help again

Subscribe Now

Asked On: 2009-10-28 at 10:11:13ID24851793
Topics: Programming for ASP.NET
,; .NET
Participating Experts: 1
Points: 500
Comments: 11

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

"The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
"Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
"Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Free Tech Articles

WARNING: 5 Reasons why you should NEVER fix a computer for free.
It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
SCCM OSD Basic troubleshooting
SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
Create a Win7 Gadget
This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
Outlook continually prompting for username and password
There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
Backup Exchange 2010 Information Store using Windows Backup
There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

Avoiding Bugs in Microsoft Access
Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
Top 10 Best New Features in Visio 2010
Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
IT Consultant Business Secrets Revealed
Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
Disaster Recovery and Business Continuity
Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
Organize Your Visio Diagrams with Containers and Lists
Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
How to Us Objects, Properties, Events and Methods in Microsoft Access
Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Watch More

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

by: rafayaliPosted on 2009-10-28 at 10:24:05ID: 25685801

Just append the querystrings to the sql statement
sqlquery = "select * from dbo.dashboardview where facilityid=1 and year=" + request.querystring("year") + " and month= " + request.querystring("month") + ";"

A better approach would be to use sqlparameters.

Dim objconn As New System.Data.SqlClient.SqlConnection(connectionString:=)
Dim objcomm As New System.Data.SqlClient.SqlCommand(("select * from dbo.dashboardview where facilityid=1 and year=@year and month=@month", objconn)
objcomm.Parameters.AddWithValue("@year", Request.QueryString("year"))
objcomm.Parameters.AddWithValue("@month", Request.QueryString("month"))
Dim reader As System.Data.SqlClient.SqlDataReader = objcomm.ExecuteReader()
repeater1.datasource=reader
repeater1.databind()

Place code in a page event where you want it to happen.

by: electricd7Posted on 2009-10-28 at 10:33:30ID: 25685944

OK I now have changed the code to match your suggestion, but am getting an expected ')' at the end of the objcomm line that I don't get. Its a simple syntax thing, but not sure how to fix it. Here is the new code:

<script runat="server">
Dim objconn As New System.Data.SqlClient.SqlConnection(connectionString:"Data Source=server;Initial Catalog=dbname;Persist Security Info=True;User ID=uname;Password=pword")
        Dim objcomm As New System.Data.SqlClient.SqlCommand(("select * from dbo.dashboardview where facilityid=1 and year=@year and month=@month", objconn)
        objcomm.Parameters.AddWithValue("@year", Request.QueryString("year"))
        objcomm.Parameters.AddWithValue("@month", Request.QueryString("month"))
    Dim reader As System.Data.SqlClient.SqlDataReader = objcomm.ExecuteReader()
repeater1.datasource=reader
repeater1.databind()
</script>
 
 
<html>
<body>
 
<form id="Form1" runat="server">
<asp:Repeater ID="Repeater1" runat="server">
<HeaderTemplate>
<table border="1" width="100%">
  <tr bgcolor="#b0c4de">
  <th>Name</th>
  <th>Numerator</th>
  <th>Denominator</th>
  </tr>
</HeaderTemplate>
 
<ItemTemplate>
  <tr>
    <td><%#Container.DataItem("name")%></td>
    <td><%#Container.DataItem("num")%></td>
    <td><%#Container.DataItem("denom")%></td>
  </tr>
</ItemTemplate>
 
<FooterTemplate>
  </table>
</FooterTemplate>
</asp:Repeater>
 
</form>
 
</body>
</html>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:

Select all Open in new window

by: electricd7Posted on 2009-10-28 at 10:38:03ID: 25685997

OK I took out the connectionstring: portion of that line and it seems to be working. Now I get an error that says: Declaration expected on this line:

Line 4: objcomm.Parameters.AddWithValue("@year", Request.QueryString("year"))

by: electricd7Posted on 2009-10-28 at 10:55:36ID: 25686189

OK that was solved by putting the code block between Sub functions :) (duh).

Now I have an error that reads:

ExecuteReader requires an open and available Connection. The connection's current state is closed

My current code is:

<script runat="server">
    Sub Page_Load(ByVal sender As Object, ByVal e As EventArgs)
 
        Dim objconn As New System.Data.SqlClient.SqlConnection("Data Source=server;Initial Catalog=dbname;Persist Security Info=True;User ID=uname;Password=pword")
        Dim objcomm As New System.Data.SqlClient.SqlCommand("select * from dbo.dashboardview where facilityid=1 and year=@year and month=@month", objconn)
        objcomm.Parameters.AddWithValue("@year", Request.QueryString("year"))
        objcomm.Parameters.AddWithValue("@month", Request.QueryString("month"))
        Dim reader As System.Data.SqlClient.SqlDataReader = objcomm.ExecuteReader()
        Repeater1.DataSource = reader
        Repeater1.DataBind()
    End Sub
</script>
 
 
<html>
<body>
 
<form id="Form1" runat="server">
<asp:Repeater ID="Repeater1" runat="server">
<HeaderTemplate>
<table border="1" width="100%">
  <tr bgcolor="#b0c4de">
  <th>Name</th>
  <th>Numerator</th>
  <th>Denominator</th>
  </tr>
</HeaderTemplate>
 
<ItemTemplate>
  <tr>
    <td><%#Container.DataItem("name")%></td>
    <td><%#Container.DataItem("num")%></td>
    <td><%#Container.DataItem("denom")%></td>
  </tr>
</ItemTemplate>
 
<FooterTemplate>
  </table>
</FooterTemplate>
</asp:Repeater>
 
</form>
 
</body>
</html>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:

Select all Open in new window

by: rafayaliPosted on 2009-10-28 at 11:03:26ID: 25686286

Sorry for missing these. I should have pasted a complete sample code. I apologize for this.
To resolve open connection issue, use OBJCONN.OPEN() before executing the reader.

by: rafayaliPosted on 2009-10-28 at 11:04:59ID: 25686302

And connection string line SHOULD NOT LOOK LIKE THIS:

Dim objconn As New System.Data.SqlClient.SqlConnection(connectionString:"Data Source=server;Initial Catalog..................

it is expecting a string value so change to:

Dim objconn As New System.Data.SqlClient.SqlConnection("Data Source=server;Initial Catalog.................................

by: rafayaliPosted on 2009-10-28 at 11:05:39ID: 25686311

ok i see your connection string issue was resolved. thats good. so now basically just call OBJCONN.OPEN() before executereader line and close the reader and objconn at the end. Thats it

by: electricd7Posted on 2009-10-28 at 11:10:37ID: 25686380

Getting really close... now the error shows up in the VS2008 window and not the ie window when I play the file. It now says:

Parameterized Query '(@year nvarchar(4000),@month nvarchar(4000))select * from dbo.da' expects parameter @year, which was not supplied.

Current code looks like this:

<script runat="server">
    Sub Page_Load(ByVal sender As Object, ByVal e As EventArgs)
 
        Dim objconn As New System.Data.SqlClient.SqlConnection("Data Source=server;Initial Catalog=dbname;Persist Security Info=True;User ID=uid;Password=pwd")
        Dim objcomm As New System.Data.SqlClient.SqlCommand("select * from dbo.dashboardview where facilityid=1 and year=@year and month=@month", objconn)
        objcomm.Parameters.AddWithValue("@year", Request.QueryString("year"))
        objcomm.Parameters.AddWithValue("@month", Request.QueryString("month"))
        objconn.Open()
        Dim reader As System.Data.SqlClient.SqlDataReader = objcomm.ExecuteReader()
        Repeater1.DataSource = reader
        Repeater1.DataBind()
    End Sub
    
    
 
</script>
 
 
<html>
<body>
 
<form id="Form1" runat="server">
<asp:Repeater ID="Repeater1" runat="server">
<HeaderTemplate>
<table border="1" width="100%">
  <tr bgcolor="#b0c4de">
  <th>Name</th>
  <th>Numerator</th>
  <th>Denominator</th>
  </tr>
</HeaderTemplate>
 
<ItemTemplate>
  <tr>
    <td><%#Container.DataItem("name")%></td>
    <td><%#Container.DataItem("num")%></td>
    <td><%#Container.DataItem("denom")%></td>
  </tr>
</ItemTemplate>
 
<FooterTemplate>
  </table>
</FooterTemplate>
</asp:Repeater>
 
</form>
 
</body>
</html>

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:

Select all Open in new window

by: electricd7Posted on 2009-10-28 at 11:14:07ID: 25686426

Nevermind...got it :) Here's your points!

by: rafayaliPosted on 2009-10-28 at 11:29:55ID: 25686613

Glad you figured it out. How did you change the event handler, did you do postback check or querystring check?

by: electricd7Posted on 2009-10-28 at 12:38:51ID: 25687351

Querystring check as of now.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

For individual users
Instant access to solutions
Ask your tech questions
Start your 30-day Free Trial

Business Accounts

Perfect for organizations
Multiple users
Save over 36%
Create a Business Account

Answer for Membership

Earn free access
Showcase your knowledge
No credit card required
Sign Up to Answer

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...

Question

How to generate dynamic SQL queries in Visual Studio 2008 .NET

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

Programming for ASP.NET

.NET

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Need individual assistance?

Our experts are ready to help.

Want to learn from the best?

Read articles from industry experts.

Working on a long term project?

Store your work and research.

What Makes Experts Exchange Unique?

Trusted by the world's most respected brands.

Faithfully serving IT professionals since 1996.

Related Solutions

Free Tech Articles

Cloud Class Webinars

Join the Community

Give a Little. Get a Lot.

Answers

3 Ways to Join

The Experts

The Experts

Testimonials

Testimonials

Testimonials

Business Clients

Business Clients

In the Press

In the Press

In the Press