Question

reduce redundant data access code

Asked by: llj45

Hello,
  I find myself constantly using the code listed in a web based system which is currently under construction.  In the interest of reducing the use of the same code over and over, I wish to develop a class, function or sub or something which can be sent several parameters to do what the repetitive code does now.  These parameters would have to include the list of incoming "parameters" to the stored procedure.  Probably, there needs to be two different classes or whatever.  One class would return the results of SELECT statements.  The other class or whatever would return simply the record count or such indicating success from an INSERT, UPDATE or DELETE operation.
  The number of parameters going into the class or whatever varies.  So, perhaps, an array could be used to transport a flexible number of parameters to the stored procedure.

  Perhaps, there are good working examples on the Internet of how to do this work.
I am using ASP.NET 3.5, ADO.NET 3.5 and VB.NET with stored procedures in SQL Server 2008.
I don't need anything really elaborate just help me dramatically reduce the redundant code.  So, put the code in one place and call it again and again to work with the database.
Also, SQL datasource control on the aspx page doesn't work for me.
Thanks, LLJ45

SAMPLE 1 - SELECT
Dim SprocCommand As New SqlClient.SqlCommand
        Dim SprocConn As String = WebConfigurationManager.ConnectionStrings("RCD").ConnectionString
        Dim dcPlan As New SqlClient.SqlConnection(SprocConn)
        Dim daPlan As New SqlClient.SqlDataAdapter()
        Dim dsPlan As New DataSet
 
        Try
            SprocCommand.CommandType = CommandType.StoredProcedure
            SprocCommand.Connection = dcPlan
            SprocCommand.CommandText = "usp_plan_find_pin"
 
            Call SprocCommand.Parameters.Clear()
 
            'Create and append the parameters for the SELECT command
            Dim parmSSN As New SqlClient.SqlParameter("@SSN", Trim(txtSSN.Text))
            SprocCommand.Parameters.Add(parmSSN)
 
            Dim parmHPHONE As New SqlClient.SqlParameter("@HPHONE", Trim(txtHTelephone.Text))
            SprocCommand.Parameters.Add(parmHPHONE)
 
            Dim parmHZIP As New SqlClient.SqlParameter("@CERTNUM", Trim(txtCertNum.Text))
            SprocCommand.Parameters.Add(parmHZIP)
 
            If dcPlan.State <> ConnectionState.Open Then
                dcPlan.Open()
            End If
 
            daPlan.SelectCommand = SprocCommand
 
            dsPlan.Clear()
            daPlan.Fill(dsPlan)
 
            dcPlan.Close()
 
SAMPLE 2 - INSERT, UPDATE OR DELETE
                    Dim SprocCommand2 As New SqlClient.SqlCommand
                    Dim SprocConn2 As String = WebConfigurationManager.ConnectionStrings("RCD").ConnectionString
                    Dim dcPlan2 As New SqlClient.SqlConnection(SprocConn2)
                    Dim daPlan2 As New SqlClient.SqlDataAdapter()
 
                    ' get the info. needed to display the test
                    SprocCommand2.CommandType = CommandType.StoredProcedure
                    SprocCommand2.Connection = dcPlan2
                    SprocCommand2.CommandText = "usp_plan_save"
 
                    SprocCommand2.Parameters.Clear()
 
                    'Create and append the parameters for the SELECT command
                    Dim parmPIN2 As New SqlClient.SqlParameter("@PIN", Trim(Session("pr_pin")))
                    SprocCommand2.Parameters.Add(parmPIN2)
                    Dim parmID2 As New SqlClient.SqlParameter("@TESTID", Trim(Session("pr_TestID")))
                    SprocCommand2.Parameters.Add(parmID2)
                    Dim parmQuesID2 As New SqlClient.SqlParameter("@DISPLAYNUM", questionID)
                    SprocCommand2.Parameters.Add(parmQuesID2)
                    Dim parmChoiceID As New SqlClient.SqlParameter("@CHOICEID", choiceID)
                    SprocCommand2.Parameters.Add(parmChoiceID)
 
                    If dcPlan2.State <> ConnectionState.Open Then
                        dcPlan2.Open()
                    End If
 
                    SprocCommand2.ExecuteNonQuery()
 
                    dcPlan2.Close()

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-29 at 19:10:58ID24856870
Tags

asp.net ado.net vb.net

Topics

Programming for ASP.NET

,

Microsoft Visual Basic.Net

,

SQL Server 2008

Participating Experts
1
Points
500
Comments
8

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. ASP.net and ado.net
    In what way ASP.NET and ADO.NET related. do i have to use ado.net if i have to access a database using asp.net
  2. Newbie to ADO.NET
    Hi im really brand spanking new tho this c# / ado.net game. Im trying (really) to build a small app using vs2003 and trying to get to grips with dataapaters,connections,datasets etc.... Im coding it by hand instead of using the wizard, so i get a better understanding. but i...
  3. ado.net not listed in datasource
    Hi I need to connect to an XML file as a datasource for a crystal report.. But ADO.net is not listed in the create new connection lists.. using Crystal 10. any thoughts how i can add this in? thanks
  4. VB.NET / ADO.NET Suggestions
    I have an VB.NET 2003/2005 program that is a report server. It's currently using classic ADO and has no problems... when I stress test it runs select statements every 3 seconds to check a queue on a connection that's global and never closed (if it happens to lose connection,...
  5. Use a SqlDataReader.  ADO.NET 2.0.  VB.NET ASP…
    ADO.NET 2.0. VB.NET 2.0 ASP.NET .NET 2.0 I have a Function that returns a SQLDataReader (see the function below) The reader executes a stored procedure that returns a few fields. How do I use this reader to get the values returned by the stored procedure? I need to use t...
  6. ReportViewer & custom datasource
    Hello Experts: I've been trying to load an SSRS report in a reportviewer on my asp.net website using vb.net code-behind. I've been trying to user serverreport since I have an active 2008 reporting server. I can't get the report to load. There are no errors, just a blank i...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: TheLearnedOnePosted on 2009-10-30 at 11:40:05ID: 25705713

Here is an example of a class that has a method that you can re-use, and extend to get what you need.

Imports System.Data
Imports System.Data.SqlClient
Imports System.Configuration
 
Public Class DataLayer
 
    Public Shared Function ExecuteStoredProcedure(ByVal procedureName As String, _
        ByVal ParamArray parameterList As SqlParameter()) As DataTable
 
        Dim connectionString As String = ConfigurationManager.ConnectionStrings("MyDatabase").ConnectionString
        Dim table As New DataTable()
        Using adapter As New SqlDataAdapter(procedureName, connectionString)
            adapter.SelectCommand.CommandType = CommandType.StoredProcedure
            adapter.SelectCommand.Parameters.AddRange(parameterList)
            adapter.Fill(table)
        End Using
        Return table
    End Function
 
End Class
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:

Select allOpen in new window

 

by: llj45Posted on 2009-10-30 at 19:55:49ID: 25708157

Hi, TheLearnedOne
  THANKS!

  Could you provide the code to call this function and to create the arraylist for the variable number of parameters going to the stored procedure?

  What would a similar function return for a INSERT, UPDATE or DELETE operation?  The record count for the number of rows affected by the operation on the database via an output parameter?

  Probably, this code has been written by someone already.  If I could find a good complete example on the Internet, I could adapt the example to this need.  Also, this way would conserve your time.
I've read many of your helpful solutions on EE! ! !
Thanks, LLJ45

 

by: TheLearnedOnePosted on 2009-10-31 at 10:00:06ID: 25710466

That is a static method, so you don't need an instance of the DataLayer class, so you could do something like this:

Dim employeeData As DataTable = DataLayer.ExecuteStoredProcedure("spGetEmployeesForDepartment", New SqlParameter("@DepartmentID", departmentID))

 

by: llj45Posted on 2009-11-02 at 17:47:46ID: 25725512

Hi, TheLearnedOne
  Thanks so much for the sample code!
  I've had some time to read, research and understand it.  The ParamArray capability is great! ! ! !

  Next, can you help me with how the datalayer class will handle INSERT, UPDATE and DELETE operations?  Probably another function would be a good idea in the datalayer class?  I use the ExecuteNonQuery() method of the SqlClient.SqlCommand class to invoke these database operations.
I do not use a data adapter for INSERT, UPDATE and DELETE.
Is there a way to automatically return the number of records affected by the database operation via the ExecuteNonQuery() method?  Perhaps, the new function could return this number of records affected to let the calling code know either success or failure (ie. 0 = failure or >0 = success?

  If I have this last piece of information, I think I will be good to go.  Then, I could award these points and close this question.

Thanks!
LLJ45

 

by: TheLearnedOnePosted on 2009-11-02 at 19:44:49ID: 25725891

Here is an example, coding in the comment block, so don't hold me to anything:

Imports System.Data
Imports System.Data.SqlClient
Imports System.Configuration
 
Public Class DataLayer
 
    Public Shared Function GetDataFromStoredProcedure(ByVal procedureName As String, _
        ByVal ParamArray parameterList As SqlParameter()) As DataTable
 
        Dim connectionString As String = ConfigurationManager.ConnectionStrings("MyDatabase").ConnectionString
        Dim table As New DataTable()
        Using adapter As New SqlDataAdapter(procedureName, connectionString)
            adapter.SelectCommand.CommandType = CommandType.StoredProcedure
            adapter.SelectCommand.Parameters.AddRange(parameterList)
            adapter.Fill(table)
        End Using
        Return table
    End Function
 
    Public Shared Function ExecuteStoredProcedure(ByVal procedureName As String, ParamArray parameterList As SqlParameter()) As Integer
        Dim connectionString As String = ConfigurationManager.ConnectionStrings("MyDatabase").ConnectionString
        Using connection As New SqlConnection(connectionString)
           connection.Open()
           Using command As New SqlCommand(procedureName, connection)
              command.CommandType = CommandType.StoredProcedure
              command.Parameters.AddRange(parameterList)
              Return command.ExecuteNonQuery()
           End Using
        End Using
    End Function
 
End Class
                                              
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:

Select allOpen in new window

 

by: llj45Posted on 2009-11-04 at 18:06:01ID: 25746158

Hi,
  Again, thanks for the sample code.
I have three questions:
using this code to call the class:
Dim employeeData As DataTable = DataLayer.ExecuteStoredProcedure("spGetEmployeesForDepartment", New SqlParameter("@DepartmentID", departmentID))
1) what does departmentID represent? the variable which contains the value for @DepartmentID;  the intellisense in VS 2008 for ASP.NET using VB.NET code prompts for a data type such as integer or string
for the second arguement; please clarify
2) please send the sample code for call to the DataLayer class using more than one SqlParameter
3) don't all of the parameters sent to a paramarray have to be of the same data type such as integer or string?  If so, is there a way to work around this fact?
Thanks, LLJ45

 

by: TheLearnedOnePosted on 2009-11-04 at 19:06:35ID: 25746425

The stored procedure would take an integer argument that indicates what department to get a list of employees.  The "real" value can come from a query string value session variable, etc.  

You create instances of SqlParameter, since that is the type for the ParamArray.

Multiple parameter example:

Public Function GetProductList(ByVal categoryID As Integer, ByVal subCategoryID As Integer) As DataTable
  Return DataLayer.ExecuteStoredProcedure("spGetProductList", _
          New SqlParameter("@CategoryID", categoryID), _
          New SqlParameter("@SubCategoryID", subCategoryID)
End Function

 

by: llj45Posted on 2009-11-07 at 17:02:06ID: 31647836

THANKS!

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...