Question

Bad performance, panels inside panels

Asked by: mSchmidt

Hi

I have made a UserControl which draws itself using
1 Panel, within that panel it will load
1 - n (standard around 3) UserControls
   This UserControl has 1 TableLayout with 7 Columns.
   Each column will have 1 Button and 1-10 additional USercontrol which holds 2 labels.

I dont think this layout is THAT complicated however it will render quite slowly, you can see each of the last usercontrols being added one at a time.

I tried doing a SuspendLayout to prevent the screen from being updated, however this changed nothing at all.

Cant i use suspendlayout to do this or ?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-03-06 at 09:15:55ID24206393
Topics

.NET

,

C# Programming Language

,

Microsoft Visual C#.Net

,

Visual Studio

Participating Experts
2
Points
500
Comments
16

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Arrange panels left to right in flow layout
    Can anyone tell me why panels stack on top of each other when contained inside of a flow layout container and how to work around it? If I put labels or controls in a container with flow layout they simply flow left to right until they run out of room and then start a second r...
  2. Usercontrol with Panel, need to act as container in IDE
    Hi I have a UserControl with a Label, docked to the top, and a Panel, docked to fill the rest of the control space. Once the control is compiled and dropped onto a form I am unable to treat the Panel within the UserControl as a container, as i would be able to if i placed a...
  3. Loading UserControls in Panel in C#
    I'm new to C# and VS.NET and was having an issue I was hoping someone could help me with. I have a main form that has some standard information I would always like to display on my application (like a header for a webpage but in this case an application). I then have a pane...
  4. Ajax, Render JavaScript inside Update Panel
    I use a javascript to "auto complete" text boxes when typing It connect itself to a textbox by document.getElementById('" + tbxTwo.ClientID + "') this works well if the text box is rendered in Page_Load But if I inside a UpdatePanel, presses a button to g...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: RedKelvinPosted on 2009-03-09 at 18:23:17ID: 23842843

 

by: mSchmidtPosted on 2009-03-10 at 01:04:39ID: 23844229

Sorry i havent made that obvious enough, its not ASP, its WinForms.

 

by: TheLearnedOnePosted on 2009-03-10 at 18:48:20ID: 23853332

SuspendLayout doesn't prevent the screen from being updated, it just prevents multiple layout events.  LockWindowUpdate Win32 API call prevents a screen from updating.

 

by: mSchmidtPosted on 2009-03-11 at 02:07:39ID: 23854949

So you would do a
[DllImport("user32")]

The bad thing about this though is that you are effectively removing the chance to run this program on other systems than Windows, or am i wrong ?

There is no LockWindowUpdate as part as the .NET Framework ?
Seems like a rather important feature ?

 

by: mSchmidtPosted on 2009-03-11 at 02:29:38ID: 23855063

Hmm i just tried implementing it,
Did help concerning the "flickering", however it just resulted in the system seeming to take alot of time to load.
So no speed enhancements, seems that the construction is simply to slow.

Loading this  http://www.scoding.dk/view.jpg   with the construction described in the first post, shouldnt that be possible faster that 8 seconds ?

The data is not the issue its iterated very fast, however it seems that the problem is the way that the panels resize and realign to each new panel.
I can litteraly see every single panel being added one at a time, resulting in the other panels resizing.



ShiftSchedule mSched = new ShiftSchedule(); <-- HERE ALL SUB OBJECTS ARE CREATED AND ADDED TO THE TOP PANEL, THIS IS VERY QUICK
 
panel.Controls.Add(mSched); <-- THIS IS THE SLOW PART, WHEN IT HAS TO RENDER THE TOP PANEL AND ALL ITS CHILDREN.
                                              
1:
2:
3:

Select allOpen in new window

 

by: mSchmidtPosted on 2009-03-11 at 02:50:47ID: 23855173

Hmm i found part of a solution.

within the Constructor of the ShiftSchedule, i added all the children controls.
Afterwards adding the ShiftSchedule to the form resulting in all children controls being drawn without any suspend layout, meaning after each drawn controls the layout of all children is adjusted.

 

by: TheLearnedOnePosted on 2009-03-11 at 06:57:33ID: 23857215

1) You are right that LockWindowUpdate is a Windows API call, and not platform independent.

2) I don't understand how the partial solution that you explain helps.

 

by: mSchmidtPosted on 2009-03-11 at 07:27:38ID: 23857612

If i do it like this it boosts performance greatly

ShiftSchedule a = new ShiftSchedule();
panel.Controls.Add(a);
a.LoadSubcontrols();

I have made a new post to try to figure that part out:
http://www.experts-exchange.com/Programming/Languages/C_Sharp/Q_24219292.html


 

by: TheLearnedOnePosted on 2009-03-11 at 07:59:06ID: 23858046

What is "ShiftSchedule"?

 

by: mSchmidtPosted on 2009-03-11 at 14:25:53ID: 23862554

Its a UserControl.

This is copied from the other post mentioned:

Hi

Iam adding alot of controls to a UserControl, and when all the children are rendered i need the layout of specific panels to be suspended.
However the OnPaint doesnt seem to be the one taking care of this part.
I also tried OnLayout with no results either.

I have some code like this:
                ShiftSchedule mSched;
                mSched = new ShiftSchedule(item, shiftList,mDate) { Dock = DockStyle.Top };
                shiftSchedulePanel.Controls.Add(mSched);
                mSched.LoadGrid();

Implented like this:
This way is very slow:
        public ShiftSchedule(ShiftGroup mGroup, ShiftList sList, DateTime mDate)
        {
            InitializeComponent();
            this.mDate = mDate;
            this.SelectedGroup = mGroup;
            shiftList = sList;
            lbGroupName.Text = mGroup.Name;
            ctlShiftDay1.LoadValues(mDate, SelectedGroup.ID, shiftList);
            ctlShiftDay2.LoadValues(mDate.AddDays(1), SelectedGroup.ID, shiftList);
            ctlShiftDay3.LoadValues(mDate.AddDays(2), SelectedGroup.ID, shiftList);
            ctlShiftDay4.LoadValues(mDate.AddDays(3), SelectedGroup.ID, shiftList);
            ctlShiftDay5.LoadValues(mDate.AddDays(4), SelectedGroup.ID, shiftList);
            ctlShiftDay6.LoadValues(mDate.AddDays(5), SelectedGroup.ID, shiftList);
            ctlShiftDay7.LoadValues(mDate.AddDays(6), SelectedGroup.ID, shiftList);
        }
        public void LoadGrid()
        {

        }

However doing this is okay fast:
        public ShiftSchedule(ShiftGroup mGroup, ShiftList sList, DateTime mDate)
        {
            InitializeComponent();
            this.mDate = mDate;
            this.SelectedGroup = mGroup;
            shiftList = sList;
            lbGroupName.Text = mGroup.Name;
           
        }
        public void LoadGrid()
        {
            ctlShiftDay1.LoadValues(mDate, SelectedGroup.ID, shiftList);
            ctlShiftDay2.LoadValues(mDate.AddDays(1), SelectedGroup.ID, shiftList);
            ctlShiftDay3.LoadValues(mDate.AddDays(2), SelectedGroup.ID, shiftList);
            ctlShiftDay4.LoadValues(mDate.AddDays(3), SelectedGroup.ID, shiftList);
            ctlShiftDay5.LoadValues(mDate.AddDays(4), SelectedGroup.ID, shiftList);
            ctlShiftDay6.LoadValues(mDate.AddDays(5), SelectedGroup.ID, shiftList);
            ctlShiftDay7.LoadValues(mDate.AddDays(6), SelectedGroup.ID, shiftList);
        }

It seems that there is a large difference on the two approaches and i would like to know why ?!
I though that it could have something to do with how OnPaint is done but it doesnt seem to.
        protected override void OnPaint(PaintEventArgs e)
        {
            panel1.SuspendLayout();
            tableLayoutPanel1.SuspendLayout();
            base.OnPaint(e);
            panel1.ResumeLayout();
            tableLayoutPanel1.ResumeLayout();
        }

Does anyone have any ideas why this is happening, and what the best way of doing this would be ?

 

by: TheLearnedOnePosted on 2009-03-11 at 19:15:05ID: 23864211

I would love to say that I can see exactly what is going on, but I have such a myopic view of your world, and I wouldn't even know where to look.

 

by: mSchmidtPosted on 2009-03-11 at 23:27:43ID: 23865307

Well i can try to give you some more information:
This is the code thats inside the LoadValues, the thing i find very wierd is that doing th e LoadValues within the contructor of the ShiftSchedule and then adding the ShiftSchedule to my form is very slow.
However Adding the ShiftSchedule first and then loading the values is like 10-20 times faster.

Does that give you a better idea or would you need even more information ?

        public void LoadValues(DateTime mDate, int groupID, ShiftList shiftList)
        {
            this.groupID = groupID;
            this.selectedDate = mDate;
            this.shiftList = shiftList;
            shiftList.ShiftAdded += new ShiftList.AddShiftEventHandler(shiftList_ShiftAdded);
            shiftList.ShiftChanged += new ShiftList.EditShiftEventHandler(shiftList_ShiftChanged);
            reloadPanel();
        }
        void reloadPanel()
        {
            this.SetStyle(ControlStyles.OptimizedDoubleBuffer, true);
            this.SetStyle(ControlStyles.AllPaintingInWmPaint, true);
            this.SetStyle(ControlStyles.UserPaint, true);
            shiftPanel.SuspendLayout();
            shiftPanel.Controls.Clear();
            var q = (from a in shiftList.GetList()
                     where
                         a.Date.Date == selectedDate.Date
                         && a.GroupID == groupID
                     orderby a.ShiftTime descending
                     select a);
            foreach (Shift item in q)
            {
                addToPanel(item);
            }
            shiftPanel.ResumeLayout();
        }

 

by: mSchmidtPosted on 2009-03-11 at 23:33:42ID: 23865341

Add to Panel does this
        void addToPanel(Shift mShift)
        {
            ctlShift aShift = new ctlShift(mShift) { Dock = DockStyle.Top };
            aShift.shiftClickHandler += new ctlShift.OnShiftEventHandler(shiftClickHandler);
            shiftPanel.Controls.Add(aShift);
        }

 

by: TheLearnedOnePosted on 2009-03-12 at 09:38:17ID: 23870529

Hmmm...have you run any code profilers against this code both ways?

 

by: mSchmidtPosted on 2009-03-12 at 09:42:26ID: 23870587

code profilers ?

 

by: TheLearnedOnePosted on 2009-03-12 at 09:47:58ID: 23870669

Red ANTS
http://www.red-gate.com/Products/ants_profiler/index.htm

CodeProject: The Simple Profiler for .NET Developers.
http://www.codeproject.com/KB/showcase/RedGate_ANTSProfilerv2.aspx

.NET CODE TUNING
Make Your Apps Fly with the New Enterprise Performance Tool
http://msdn.microsoft.com/en-us/magazine/cc163872.aspx

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...