Question

Scope Question - "Local Variable Already Defined in Scope"

Asked by: AJ0424

Hello!

I am new to development of any kind and I have what I think is a scope problem but I do not know how to fix it.  

What I am trying to do:
The page in question (FileUpload.aspx) is a page that allows a user to upload a file to a folder.  I am trying to capture the fileid (scope_identity) and username (of the user logged in) (I have done this).  The next part is to use the username as a parameter for a stored proc that will return the guid for the username value.

After I have both the fileid and the userid (guid), I need to run an insert stored proc that inputs both to a linking table. This table has an id pk, userid, fileid.


Where I am stuck:
I had help in setting this next part up and I really do not yet fully understand everything that is happening here (at least not enough to really trouble shoot).  What I have is another page (ClientFileRepository.aspx) that has a class with several methods for retrieving data from stored procs.  On the original page (FileUpload.aspx) I am using two methods in one "if" block - one is an insert, the other a select.  The build fails and tells me that "A local variable "repository" is already defined in this scope." but if I rename it, it renames it in both instances.

At this point I am in over my head...I thought I needed them together because each returns a value I need to insert into a table.  I am at a loss as to how this should be rewritten so that I can grab both values and insert them into my table.  I assume this will require yet another method which will just complicate the matter further.

Can anyone tell me what I am doing wrong?  Any help would be appreciated!!

Thanks,
AJ

using System;
using System.Data;
using System.Configuration;
using System.Collections;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;
using System.Data.SqlClient;  //had to add to connect to sql
 
 
 
 
namespace FileTransfer2
{
    
    public partial class FileUpload : System.Web.UI.Page
    {
        protected void Page_Load(object sender, EventArgs e)
        {
            
        }
 
        protected void lbtnReturntoHome_Click(object sender, EventArgs e)
        {
            Response.Redirect("default.aspx");
        }
 
        
        protected void btnSubmit_Click(object sender, EventArgs e)
        {
            //lblResults.Text = "";
            
            if (FileUpload1.HasFile)
                try
                {
                    string folderPath = ConfigurationManager.AppSettings["UploadDirectory"]; 
                    string filePath = System.IO.Path.Combine(folderPath, FileUpload1.FileName); //concatenates path + file name
                    FileUpload1.SaveAs(filePath); 
 
                    lblResults.Text = "File Successfully Uploaded: <br>" + "File name: " +
                        FileUpload1.FileName + "<br>" + 
                        FileUpload1.PostedFile.ContentLength + " kb<br>" +
                        "Content type: " +
                        FileUpload1.PostedFile.ContentType;
 
                    ClientFileRepository repository = new ClientFileRepository();
                    int fileid = repository.InsertNewFile(FileUpload1.FileName, txtDescription.Text, filePath);
                    string UserName = User.Identity.Name;
 
 
                    //This is where I am having a problem
                    ClientFileRepository repository = new ClientFileRepository();
                    DataTable UserGuid = repository.GetUserGuid(UserName);
                    if (UserGuid != null && UserGuid.Rows.Count > 0)
                    {
                        string UserID = UserGuid.Rows[0]["UserId"].ToString();
                        Response.Write(UserID);
                    }
 
                    else
                    {
                        Response.Write("No userid found.");
                    }
 
 
                    lblError.Text = "";
 
                    
                }
                
                catch (Exception ex) //this should catch if jibberish is entered but it doesn't
                {
                    //lblError.Text = "Error: File was not found.";
                    Response.Write("Error: " + ex.Message);
                }
            else
            {
                txtDescription.Text = "";
                lblResults.Text = "";
                lblError.Text = "You have not specified a file.";
            }
 
                        
        }
    }
}
 
 
 
using System;
using System.Data;
using System.Configuration;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;
using System.Data.SqlClient;
 
namespace FileTransfer2
{
    public class ClientFileRepository
    {
 
        public int InsertNewFile(string fileName, string description, string clientfile)
        {
            using (SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["FileTransferConnectionString"].ToString()))
            {
                using (SqlCommand cmd = new SqlCommand("InsertNewFile", conn)) //stored proc name
                {
                    cmd.CommandType = CommandType.StoredProcedure;
                    cmd.Parameters.AddWithValue("@FileName", fileName);
                    cmd.Parameters.AddWithValue("@Description", description);
                    cmd.Parameters.AddWithValue("@ClientFile", clientfile);
                    conn.Open();
                    return int.Parse(cmd.ExecuteScalar().ToString()); //returns scope_identity from proc
                }
            }
        }
 
 
        public DataTable GetFileInfo(int id)
        {
            using (SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["FileTransferConnectionString"].ToString()))
            {   
                using (SqlCommand cmd = new SqlCommand("getFilebyFileID", conn)) //stored proc name
                {
                    cmd.CommandType = CommandType.StoredProcedure;
                    cmd.Parameters.AddWithValue("@Id", id);
 
                    SqlDataAdapter daFilesbyId = new SqlDataAdapter(cmd);
                    DataTable FilesbyId = new DataTable();
                    conn.Open();
                    daFilesbyId.Fill(FilesbyId);
                    return FilesbyId;
                }
            }
        }
 
        public DataTable GetUserGuid(string UserName)
        {
            using (SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["FileTransferConnectionString"].ToString()))
            {
                using (SqlCommand cmd = new SqlCommand("getUserID", conn))
                {
                    cmd.CommandType = CommandType.StoredProcedure;
                    cmd.Parameters.AddWithValue("@UserName", UserName);
 
                    SqlDataAdapter daGetUserGuid = new SqlDataAdapter(cmd);
                    DataTable UserGuid = new DataTable();
                    conn.Open();
                    daGetUserGuid.Fill(UserGuid);
                    return UserGuid;
                }
            }
        }
 
 
        
    }
}
 
 
SQL:
 
ALTER proc [dbo].[getUserID]
	@UserName nvarchar(256)
 
AS
 
select
	u.UserId
 
from aspnet_Users u
where u.UserName = @UserName

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-10-14 at 19:19:59ID23815206
Tags

C#, asp.net, SQL 2005

Topics

Microsoft Visual C#.Net

,

Programming for ASP.NET

Participating Experts
4
Points
500
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. repository installation
    hello every body. i have installed oracle 8.1.7 and then designer 6i rel 4. after aliasing the database i was able to connect to the database using the sqlplus 8.) until now every thing is ok. after performing the instructions of the repository in the designer cd and trying...
  2. variable scope
    Hi! I need to declare a variable in a javascript that its scope is only in the opened page. for example, if I have A.html page in two web servers and there is a code there: var x=document.domain; If I open the two pages from two explorer windows, I want that x won't be overid...
  3. scope
    In the project viewer I have - ms excel objs - sheet1 - sheet2 - modules -modFileStuff -module1 - class modules -er A command button, placed on sheet1, calls a public sub residing in module modFileStuff. Calls it just fine. However, trying this in the module mod...
  4. Variable Scope
    Hi guys, this morniing I posted a question & Tim answered me clear & in the answer he suggest me to don't use the "application" scope when I declare a variable & I can understand why. So I change the scope & it became: <c:set var="folder&quo...
  5. Variable Scope?
    Please consider the following code: #define WAIT(count_us) do \ { \ boot_u32_t loop_counter; \ \ /* DELAY to be implemented */ \ for (loop_counter = 0; \ loop_counter < (FLASH_...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: CyrexCore2kPosted on 2008-10-14 at 21:00:43ID: 22717997

Change

ClientFileRepository repository = new ClientFileRepository();

to

repository = new ClientFileRepository();

 

by: BondinASPPosted on 2008-10-14 at 21:33:07ID: 22718087

remove this line

//This is where I am having a problem
                    ClientFileRepository repository = new ClientFileRepository();

 

by: CuteBugPosted on 2008-10-14 at 21:49:59ID: 22718139

You are declaring "ClientFileRepository repository" two times in the same scope at Line numbers 49 and 55.
Both these lines are in the same scope i.e. within the same pair of curly brackets. {}

The two declarations confuse the compiler, that's why it generates the error. The compiler finds that you have already declared a variable of the same name before.

So you have two options to solve the error
1. Remove the statement at line 55
2. Change the statement at line 55 to
                repository = new ClientFileRepository();
           This will cause the object created at line 49 to be disposed and made available for Garbage collection. The variable will now point to a new object at line 55.
    But looking at the flow of the code, this will not give you the expected results.

   So my opinion is to go with the first option. Remove line 55.

 

by: ragi0017Posted on 2008-10-14 at 23:46:53ID: 22718502

i dont think that the statement at line no. 55 ClientFileRepository repository = new ClientFileRepository(); is required at all

 

by: AJ0424Posted on 2008-10-15 at 05:37:13ID: 22720196

Thanks everyone!  That worked perfectly and now I have a better understanding of what that code is actually doing!

I appreciate it!!
AJ

 

by: AJ0424Posted on 2008-10-15 at 05:40:10ID: 31506169

Thank you all very much - I hope you don't mind, I split the points since you all helped me.

CuteBug, I especially appreciate the explanation behind your answer - it cleared up a bit of the mystery for me!

Thanks,
AJ

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...