Question

pthreads and Sockets -> exits with "Killed"

Asked by: darksinclair

Greetings, I am trying to create a program which works with both Sockets and pthreads.  The application listens on a specified TCP port and once a request is made it opens up two pthreads, one which parses the incoming data and places the information on a queue, and another that actually processes the information placed on the queue.

My Problem is that once I send data to the socket and the program reads from the socket it crashes with the output "Killed"... I cannot figure out why it is doing this. any ideas?

Here is the output from the program:

$ ./pp
queueInit: Queue Creation Successful.
Socket listening on port '3333'
Server Message: Awaiting socket request.
Server Message: Request acknowledged, processing packet...
Thread [16386] Created.
Thread [32771] Created.
Process Packet Subroutine: Queue EMPTY ... Waiting
Data Received: 192.168.2.11:80:>:192.168.2.1:80:S

Killed
$

As you can see It can open the port fine for listening, accept the data I send in the packet and output the data received ('192.168.2.11:80:>:192.168.2.1:80:S' is the data sent.) and then all of a sudden it simply crashes out with the output Killed.

Below is the relevant code,

//------------------------------------------> main()
...
for( ; ; )
{
     client = sizeof( client_addr );
     printf("Server: Awaiting request.\n");
     newsocket = accept( socket, (struct sockaddr *) &client_addr, &client_socket );
     printf("Server Message: Request acknowledged, processing request.\n");

     pthread_create( &extractor, NULL, extract_info, q );
     pthread_create( &process, NULL, process_packet, q );
     pthread_join( extractor, NULL );
     pthread_join( process, NULL );
}
...

//----------------------------------------->extract_info( void *fifo )
{
     char data[MAX_INPUT_LENGTH];
     input_t *input;
          input = (input_t *) malloc( sizeof( input_t * ) );
     queue *q;
          q = (queue *) fifo;

     printf("Thread [%d] Created.\n", pthread_self() );

     /* Read from the socket - retreive packet information */
     read( newsocket, &data, MAX_INPUT_LENGTH );
     printf("Data Received: %s\n", data );

     printf(" TEST?? " );
...
}

Note : that the program is able to print the Data Received .. Line.. however, it crashes before ever printing the "TEST??" ... As well, if I take out the data received line it does not print the TEST?? line.. it simply crashes out with "killed" again.

Thanks for your time in advance.  Any Comments / Suggestions welcome.

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2005-09-08 at 09:40:36ID21554968
Tags

killed

,

pthreads

,

sockets

Topic

C Programming Language

Participating Experts
3
Points
500
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Linux pthread programming....
    What am i doing wrong??? I think the output will be: .1 .2 .1 .2 .1 .2 etc etc etc .1 .1 .1 .1 ^C but its not happen... --x-- #include <stdio.h> #include <pthread/mit/pthread.h> void *do_it (void *ptr); void *do_it2 (void *ptr); int main (void) { int *pIn...
  2. printf
    In my compiler package there is a directory called include where all the header files are included.. Isn't there supposed to be a source file for every header file where functions are defined? I can't find anywhere the source files... for example I would be interested in see...
  3. pthreads
    i was trying to use a function pthreads_setconcurrency() defined in pthread.h it says undefined function the other functions work fine (pthread_create etc) I wanted to start more than one thread simultaneously any help ??
  4. Pthread_create problems
    Hi, I'm trying to compile this on a Solaris platform. Unfortunately, the threads don't seem to work. When I print out the return value from pthread_create, I get a -1. This tells me the threads were not created correctly. Can someone see what I'm doing wrong he...
  5. libipq and pthreads
    Hi, Here is a sample code where I try to delay every packet by some time (in the code I posted here it is fixed to 100 msec.). Inorder to do so, I start a pthread for every packet that is received by libipq . I have iptables rules that queues tcp packets that are coming and ...
  6. pthreads and signals
    I have a c++ code that creates two threads. The program is running constantly, so I wanted to stop is by ctr+c (as opposed to kill, because I wanted to save some files and other logging stuff). I also wanted to be notified of segmentation faults. What I did was something lik...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: AxterPosted on 2005-09-08 at 09:43:31ID: 14846052

>>input = (input_t *) malloc( sizeof( input_t * ) );

The above line of code will only allocate enough memory for the size of the pointer.
It should be the following:
input = (input_t *) malloc( sizeof( input_t ) );

 

by: AxterPosted on 2005-09-08 at 09:45:33ID: 14846075

>> read( newsocket, &data, MAX_INPUT_LENGTH );
>> printf("Data Received: %s\n", data );

You should check the quantity of code that you read, and then make sure to put a terminated zero at the end point.
Other wise your printf statement won't know where the end of the string is at, and could crash.

 

by: darksinclairPosted on 2005-09-08 at 09:47:58ID: 14846095

Ah, thanks, I missed that typo, However, that isnt the problem, I do not work with the input_t type at all before the program crashes.  

Thanks for catching that mistake but the problem is still open.

 

by: darksinclairPosted on 2005-09-08 at 09:55:29ID: 14846155

A good thought Axter, and I am pretty sure that it is something in the read,, and I am not comfortable / familiar with socket programming, however I tested giving inputs with \0 and it still did the same thing... I dont' think that it is the printf statement which is crashing me by not being able to find the terminating character because if I leave out the "Data Received.." printf and use only the next printf("1"); the program crashes without ever even printing the 1...

Was worth a try though,

Thanks,

 

by: AxterPosted on 2005-09-08 at 10:03:19ID: 14846220

Can you post more of your code?

When it crashes, can you look at the stack?

 

by: darksinclairPosted on 2005-09-08 at 10:08:11ID: 14846257

Actually I think I have resolved it... Kindof.

This works:

read(...);
printf("%s", data );
...

This does not...
read(..);
printf("%s\n", data);

... Obviously something with the \n is conflicting somewhere... but I can just leave it out to currently resolve my issue... Im not sure if this will hold true for anyone else.. but seeing as how I couldnt find anything on this in google.. I'm not sure many others have run into this problem...

Currently this issue is resolved...

Thanks for your help though Axter.

 

by: person1994Posted on 2005-09-08 at 10:29:18ID: 14846424

Try chaging read( newsocket, &data, MAX_INPUT_LENGTH );  to read( newsocket, data, MAX_INPUT_LENGTH );

data is already a pointer.

Good luck,

 

by: Infinity08Posted on 2005-09-09 at 04:49:56ID: 14851363

This sounds a lot like a multi-programming issue ...

add traces to the other thread (the "process" thread) to see at what position it is at the moment of the crash. Because it's very likely that the crash occurred in the "process" thread and not in the "extractor" thread as you suspect.

Mark every log line with the thread ID - that way you'll easily see when which thread works, and what it does.

If you add enough logging to the threads, you should see that the crash occurs in the "process" thread.

 

by: darksinclairPosted on 2005-12-20 at 08:30:48ID: 15519551

Sorry for the delay, I forgot about this question and the problem has long been resolved.  Thanks for all your help however, Excellent places to begin looking.  Thanks.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...