Take a hyphen out of string and concatenate

This is actually for a LoadRunner script:

So I have a function called

web_reg_save_param("AcctOffer") that will store the value AABB-RRWWH

So following what you wrote above I declared it as

char* AcctOffer; (at top of script)

then added your snippet below the function

web_reg_save_param("AcctOffer")  \\this saves the parameter
lr_eval_string({AcctOffer}) \\may use this to return the current value of the string

for (int i=0,j=0; AcctOffer[i]; i++)
{
      if (Acctoffer[i] != '-')
      {
          Acctoffer[j] = Acctoffer[i];
          j++;
      }
}
Acctoffer[j] = 0;

Look right??

So, it is not C/C++ really?

it is a mix of custom functions and C...so don't be thrown off by the functions...am just looking for the logic given I have a variable called AcctOffer that will be char* defined....how do I spin thru AcctOffer to take out the hyphen and either leave the variable the same name or give it a new one.

char* offer;
web_reg_save_param("AcctOffer")  //ignore this line
offer=lr_eval_string({AcctOffer})  //ignore this..as offer is now the result defined

for (int i=0,j=0; offer[i]; i++)
{
      if (offer[i] != '-')
      {
          offer[j] = offer[i];
          j++;
      }
}
offer[j] = 0;

Not sure how this is working above but assume offer[j] is new value??

So do we  offernew = offer[j];  ???

The code is compiling after I changed as such:

int i,j;
char *offer;

web_reg_save_param("AcctOffer")  
offer=lr_eval_string({AcctOffer})  
lr_output_message("This is to test if I am reading the variable" , offer);  Note: This comes back as "AABB-RRWWH"

for (i=0,j=0; offer[i]; i++)
{
      if (offer[i] != '-')
      {
          offer[j] = offer[i];
          j++;
      }
}
offer[j] = 0;

lr_output_message("Test to see if I can read the new variable" , offer[j]);  Note: this comes back as "(null)"

So everything is good except how do I get offer[j] value (hopefully AABBRRWWH) to come back instead of null?

offer[j] is the last character in the "offer" string, that is 0 (null)
offer is the pointer to the entire trimmed string.

try with something like:
r_output_message("Test to see if I can read the new variable" , offer);  

Instead of null there is nothing there for the last statement....hmmm

is there anything we can put in the for loop to verify it is building the string?

I don't know about your library internals, just can suggest standard way to output some message:

printf("offer = %s", offer);

or if you are in a windows environment:

::MessageBox(NULL, offer, "Offer Contents", MB_OK);

OK...let me dig on this for a bit and I will come back to you. I will NOT abandon this post...smiles.

Thanks for the help...I am on my way.

Below is an alternative solution using STL. If you are writing C++ code this might be worth considering if your code is already using std::string's if not jaime_olivares' solution is sound and I would stick to that.

[output]

Before: AABB-RRWWH-AABB-RRWWH
After: AABBRRWWHAABBRRWWH

[/output]

#include <string>
#include <iostream>
 
void RemoveHyphen(std::string & s)
{
	std::string::size_type pos = 0;
	while((pos = s.find('-', pos)) < s.size()) {
			s.replace(pos, 1, "");
	}
}
 
int main()
{
	std::string s = "AABB-RRWWH-AABB-RRWWH";
	
	std::cout << "Before: " << s << std::endl;
	RemoveHyphen(s);
	std::cout << "After: "<< s << std::endl;
 
	return 0;
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:

Another alternative for std::string using iterators (which may be a little more efficient). Again, you should only consider this if you already use std::string's otherwise definitely go with jaime_olivares' solution.

#include <string>
#include <iostream>
 
void RemoveHyphen(std::string & s)
{
	std::string::iterator itr = s.begin();
	while(itr != s.end()) itr = ('-' == *itr) ? s.erase(itr) : itr + 1;
}
 
int main()
{
	std::string s = "AABB-RRWWH-AABB-RRWWH";
	
	std::cout << "Before: " << s << std::endl;
	RemoveHyphen(s);
	std::cout << "After: "<< s << std::endl;
 
	return 0;
}
                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:

And one more STL implementation, which traverses the string in a similar way offered by jaime_olivares'. The difference being this is done using STL std::string and iterators.

#include <string>
#include <iostream>
#include <algorithm>
 
void RemoveHyphen(std::string & s)
{
	std::string::iterator itr1 = s.begin();
	std::string::iterator itr2 = s.begin();
 
	for(; itr2 != s.end(); ++itr2)
	{
		if(*itr2 != '-')
		{
			*itr1 = *itr2;
			++itr1;
		}
	}
 
	s.resize(s.size() - std::distance(itr1, itr2));
}
 
int main()
{
	std::string s = "AABB-RRWWH-AABB-RRWWH";
	
	std::cout << "Before: " << s << std::endl;
	RemoveHyphen(s);
	std::cout << "After: "<< s << std::endl;
 
	return 0;
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:

Hi Everyone,

Inevitably there were some parameters to a custom function in LoadRunner VuGen that allowed to accomplish the task. By all rights, Jaime's answers should have worked. The code compiled but kept returning "blank".

So true to my word, here was the solution (which only applies to LoadRunner)

char  *tofferbeg, *tofferend, newoffer[9];

 

web_reg_save_param("L_offerbeg",

                                                               "LB=offerMap = {'",

                                                               "RB=':",

                                                               "SaveOffset=0",

                                                               "SaveLen=4",

                                                               LAST);

 

    web_reg_save_param("L_offerend",

                                                               "LB=offerMap = {'",

                                                               "RB=':",

                                                               "SaveOffset=5",

                                                               "SaveLen=5",

                                                               LAST);

 

tofferbeg=lr_eval_string("{L_offerbeg}");

tofferend=lr_eval_string("{L_offerend}");

strcat(newoffer,tofferbeg);

strcat(newoffer,tofferend);

lr_output_message ( "The new offer #%s", newoffer);

 

free( tofferbeg, tofferend, newoffer);

Thanks for all your help. I will reward the points to Jaime as he was spot on with the answer but I just couldn't make it work.