Question

bst crashes after compiling

Asked by: mikeregas

I have an assignment that is suppose to be a spell checker using a BST. It compiles but it crashes after tthe dictionary file is entered. Any direction would be great.

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
 
 
//CONSTANTS 
#define wrdlen 48 
#define linelen 1024
 
 
// A struct representing a node in a binary search tree
 
struct BSTnode
{  
char word[wrdlen];// The contents of the node	
struct BSTnode* left;// Links to the node's left and right children
struct BSTnode* right;
 
};
 
// Adds a new node to the tree. Duplicates are disallowed. Returns 1 if a
// new node was added, returns 0 if newdata was already in the tree
int insert(struct BSTnode** root, char newword[wrdlen])
{
    // If we've reached the right place to insert, create a new node and add it in
	if( (*root) == NULL)
	{
		(*root) = (struct BSTnode*)malloc(sizeof(struct BSTnode));
        strcpy((*root)->word,newword);
		(*root)->left = NULL;
		(*root)->right = NULL;
		return 1;
	}
    // Otherwise, search for the correct place to insert
 
	if(strcmp(newword,(*root)->word)<0)
	{
		return insert( &((*root)->left), newword);
	}
 
	else if(strcmp(newword,(*root)->word)>0)
	{
		return insert( &((*root)->right), newword);
	}
// If the new data is neither less than nor greater than the the data at
// the current node, it must be equal, and duplicates are not allowed
	else
	return 0;
}
 
// Returns 1 if target is in the tree and 0 otherwise
int search(struct BSTnode* root, char target[wrdlen])
{
    // An empty tree contains nothing, much less target
	if(root == NULL)
		return 0;
	// If the current node is what we're looking for, we've found it 
 
	if(strcmp(root->word,target) == 0)
		return 1;
    // If what we're looking for is smaller than this node, it must be in
    // the left subtree if it exists
	if(strcmp(target,root->word) < 0)
		return search(root->left, target);
	// Similarly, if the target is greater than this node, it can only be in
    // the right subtree
	else
	return search(root->right, target);
}
 
// An iterative version of the search algorithm
int searchiterative(struct BSTnode* root, char target[wrdlen])
{
	struct BSTnode* crnt = root; 
	// Keep descending through the tree until we reach the bottom or find what
	// we're looking for
	while(crnt != NULL && strcmp(crnt->word,target)!=0)
	{
		if(strcmp(target,crnt->word)>0)
		crnt = crnt->left;
 
		else
		crnt = crnt->right;
	}
	// If we reached the bottom of the tree, then the target isn't present,
	// otherwise we found what we're looking for
	if(crnt == NULL)
		return 0;
	
	else
		return 1;
}
 
void spellcheck(struct BSTnode* root, char *token, int line)
{
    //capital letters are from 65 -> 90
    //lowercase letters are from 97-122  
    if(search(root, token))//if you find it normally then 
      return;
 
     else if(token[0] >= 65 && token[0] <= 90)
     {
          token[0] = token[0] + 32;
          if(search(root, token))
             return;
 
          else
          {   
              token[0] = token[0] - 32;
              printf("Line %d: %s\n", line, token); 
              return;
          }
     }
 
     else
     {
         printf("Line %d: %s\n", line, token);
         return;
     }
}
 
 
int main(void)
{
    FILE *ifp; //dictionary file
    FILE *scfp; //file to be spellchecked
    char infile[wrdlen]; //"words.txt";
    char Tinfile[wrdlen]; //"test.txt"; //test file
    int valid = 0;
    struct BSTnode* root;
    char newword[wrdlen];
    int i = 0;
    char str[linelen];
	char delims[] = {"~!@#$%^&*()-_=+[]{}\\|;:\'\",.<>/?\n\r\t "};
	char *token;
	
     
 
    //ask the user for the dictionary file
    while(!valid)
    {
         printf("Please enter the name of the dictionary file you wish to access\n");
         scanf("%s", infile);
         ifp = fopen(infile, "r");         
 
         if(ifp == NULL)
           printf("sorry, could not find that file!\n");
         else
         {   
             valid = 1;
             printf("Reading file now.........\n");
         }
    }    
    valid = 0;
    //read in all the words and place them into a BST
    while(!feof(ifp))
    {
        fscanf(ifp, "%s ", newword);
        insert(&root, newword);
    }   
 
    //ask the user for the file to be spellchecked
    while(!valid)
    {
		printf("what is the name of the file you would like to spellcheck?\n");
		scanf("%s", Tinfile);
		scfp = fopen(Tinfile, "r");
		if(scfp == NULL)
           printf("sorry, could not find that file!\n");
		else
		{   
             valid = 1;
             printf("Reading file now.........\n");
		}
    }    
 
    printf("The following words were not recognized: \n");    
 
    for(i = 1; !feof(scfp); i++)
    {
     	fgets(str, linelen, scfp);
		
		token = strtok(str, delims);          
 
		while( token != NULL ) 
		{
			spellcheck(root, token, i);    
			token = strtok( NULL, delims );
	    }    
    }
	system("PAUSE");
    return 0; 
}

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:
134:
135:
136:
137:
138:
139:
140:
141:
142:
143:
144:
145:
146:
147:
148:
149:
150:
151:
152:
153:
154:
155:
156:
157:
158:
159:
160:
161:
162:
163:
164:
165:
166:
167:
168:
169:
170:
171:
172:
173:
174:
175:
176:
177:
178:
179:
180:
181:
182:
183:
184:
185:
186:
187:
188:
189:
190:
191:
192:
193:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2008-11-10 at 19:22:24ID23893214
Topic

C Programming Language

Participating Experts
2
Points
500
Comments
9

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Notes Client Crashes When Spell Checking E-mail.
    We are using Version 5.0.3 of the Notes Client. This is a US Version running on a PC with British(English) Regional settings. We choose custom install as per Lotus Support's advice in order to install the UK.dic as the ordinary setup recognises UK regional settings but does n...
  2. code that crashes compiler??!!
    Hi, got this WIERD error when compiling my code, it gives an acces voilation within dcc40.dll when i try to compile my code. dcc50 seems to be the compiler allright found that on the internet. I also tried to use another pc but it doesn't work. Also the commandline compiler c...
  3. VB crashes at compile time.
    Hello, I am using VB 6.0 enterprise edition under Win98. Everytime I make even the simplest program just with a textbox, label or picture, when I try and compile it, it automatically crashes. I have no idea why just only these three objects crash when buttons, and OLE obje...
  4. Urgent (Spell Checker Component)
    Hi there, Anyone know of a Freeware Spell Checker component that works with SynEdit ? Thanks It's Urgent so, i'm giving 500 point for the right answer. Thanks SFern.

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: sunnycoderPosted on 2008-11-10 at 21:59:47ID: 22928001

run the code using a debugger. When it crashes, examine the stack trace. That would give you the exact location and (hopefully) reason for crash.

It would help if you would attach some sample input that you are using.

 

by: sunnycoderPosted on 2008-11-10 at 23:51:39ID: 22928362

struct BSTnode* root = NULL;

It is a good practice to initialize all variables at the time of declaration.

 

by: Infinity08Posted on 2008-11-11 at 01:54:51ID: 22928857

Yes, I pointed that out to mikeregas in his previous question about the same subject :

        http://www.experts-exchange.com/Programming/Languages/C/Q-23892281-spell-checker-with-BST.html

The insert function relies on the root being initialized to NULL.

 

by: Infinity08Posted on 2008-11-11 at 05:12:45ID: 22929928

May I ask why you gave a B grade (again) ? That usually means that something was missing in the answer and/or that something is still unclear. If that's the case, then don't hesitate to ask for clarification where needed. ie. you don't have to close a question if it hasn't been answered yet.

 

by: sunnycoderPosted on 2008-11-11 at 07:51:05ID: 22931603

A side effect of consistent bad grading is that experts stop participating in your questions.

 

by: mikeregasPosted on 2008-11-11 at 08:54:15ID: 22932245

is there a way to change it I was not even aware that it was monitered, I am sorry you were very helpful

 

by: Infinity08Posted on 2008-11-11 at 09:10:53ID: 22932430

If you want to change grades or do something else that you can't do yourself, you can use the "Request Attention" link, and someone will come and help you out :)

        http://www.experts-exchange.com/help.jsp#hi404

 

by: mikeregasPosted on 2008-11-11 at 09:43:29ID: 31515386

thank you again for your help and explinations

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...