Question

FindFirstFile, FindNextFile, and FindClose

Asked by: pretty_girl

Each time I execute the following set of instructions within a program (in a loop or by iteratively calling a method), the Windows Task Manager indicates a memory leak of about 4100KB.

WIN32_FIND_DATA      w32fd;
HANDLE               hFind;

for (int i = 0; i < 1000; i++)
   {
   hFind = FindFirstFile("*.*",&w32fd);
   FindClose(&w32fd);
   FindNextFile(hFind,&w32fd);
   FindClose(&w32fd);
   while (FindNextFile(hFind,&w32fd))
      {
      FindClose(&w32fd);
      }
   }

How do I avoid the memory leaks?  Do I have to do something with hFind?

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2002-01-16 at 09:08:34ID20255950
Tags

findfirstfile

,

findnextfile

Topic

C++ Programming Language

Participating Experts
4
Points
200
Comments
6

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. FindFirstFile/FindNextFile/FindClose
    FindFirstFile/FindNextFile/FindClose How do I use these three functions or other functions to get the directories and files on a server. And how do I see them in the client ? What are the steps from getting the directories and files to sending and receiving and displaying on ...
  2. FindFirstFile and FindNextFile Example...
    Hi... I need the FindFirstFile and FileNextFile example Visual C++ Source code... If you have, send to me.. thanks
  3. FindFirstFile and FindNextFile usage
    I'm using MS Vis C++ 6.0 on an NT machine. I need some help in using FindFirstFile and FindNextFile. If someone could give me 2 simple codes, it would be great. 1) I need a code that would output the list of files (and directories if possible) to screen. 2) I need a code ...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: jasonclarkePosted on 2002-01-16 at 09:14:58ID: 6736882

All those FindClose calls look wrong, I think it should be something like:

  hFind = FindFirstFile("*.*",&w32fd);
  if (hFind != INVALID_HANDLE_VALUE)
  {
     do
     {
       // Do Something with found file...
     } while (FindNextFile(hFind, &w32fd));
     FindClose(hFind);
  }

 

by: pretty_girlPosted on 2002-01-16 at 10:40:35ID: 6737134

You are right - I put the extra FindClose calls just to see if there was not some undocumented behavior causing the memory leaks.

If I change the code to...

WIN32_FIND_DATA      w32fd;
HANDLE               hFind;

for (int i = 0; i < 1000; i++)
  {
  hFind = FindFirstFile("*.*",&w32fd);
  FindNextFile(hFind,&w32fd);
  while (FindNextFile(hFind,&w32fd));
  FindClose(&w32fd);
  }

I am still losing 4100KB memory per iteration.  If I change the code to...

WIN32_FIND_DATA      w32fd;
HANDLE               hFind;

for (int i = 0; i < 1000; i++)
  {
  hFind = FindFirstFile("*.*",&w32fd);
  FindClose(&w32fd);
  }

I still get memory leaks => FindFirstFile and FileNextFile are allocating memory which is not deallocated by FindClose.  My thinking is that I have to deallocate the memory referenced by a pointer in w32fd.  The question is, what?  In more general terms, what do I have to do to get the memory back?

 

by: conchitaPosted on 2002-01-16 at 11:05:33ID: 6737183

FindClose takes the find handle, not the WIN32_FIND_DATA.
When you pass it the structure, it is just failing, and since you never call close on the HANDLE, you are leaking it.

So you need to change this line:

FindClose(&w32fd);


to:

FindClose(hFind);

Also, there seem to be some problems with your loop. jasonclarke posted the typical way of doing this.

FindFirst returns a search handle, which will be INVALID_HANDLE_VALUE if there are no files. If it is valid, then you can use it in a call FindNextFile to find the rest of the files. Once you are done with it, then you need to close it.

So you have to first check the handle to make sure it is valid. Then use it in your calls to FindNextFile. Then close it.

 

by: pretty_girlPosted on 2002-01-16 at 11:26:14ID: 6737226

Conchita,

Thanks for pointing that out - I did not read jasonclarke's comment carefully.  When I changed FindClose(&w32fd) to FindClose(hFind) it fixed the problem.

 

by: fedorPosted on 2002-01-18 at 09:29:41ID: 6741433

If it fixed the problem, it is good idea to accept the comment made by Conchita as an answer.

 

by: griesshPosted on 2002-04-08 at 06:07:36ID: 6925198

Dear pretty_girl

I think you forgot this question. I will ask Community Support to close it unless you finalize it within 7 days. You can always request to keep this question open. But remember, experts can only help you if you provide feedback to their questions.
Unless there is objection or further activity,  I will suggest to accept

     "jasonclarke"

comment(s) as an answer.

If you think your question was not answered at all, you can post a request in Community support (please include this link) to refund your points. The link to the Community Support area is: http://www.experts-exchange.com/commspt/

PLEASE DO NOT ACCEPT THIS COMMENT AS AN ANSWER!
======
Werner

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...