Question

Problem with a program

Asked by: elpredicador

I am trying to make an encryption/decription tool, but I can't make it work. It compiles perfectly, but it does not create the output file. Here is the code for the encryption function:


void encriptar(char* str){

     FILE *source, *dest;
     char ch;
     int i;

     source=fopen(str,"rt");

     if(source==NULL){
          cout<<"No se pudo abrir el archivo "<<str<<endl;//could not open file
          cin;
          system("cls");
          return;
     }

     dest=fopen("encriptado.txt", "w");
     if(dest==NULL){
          cout<<"No se pudo abrir el archivo \"encriptado.txt\""<<endl; //could not open destination file
          cin;
          system("cls");
          return;
     }
     
     rewind(source);
     while(!feof(source)){

          ch=fgetc(source);

          i=ch*ch;

          fprintf(dest, "%i",i);
     }
     fcloseall();
     cout<<"Se ha terminado de encriptar con éxito"<<endl;//successfully finished encrypting
     cin;
}

Sorry for the low points, but I don't have much..

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2002-11-02 at 13:18:36ID20388896
Topic

C++ Programming Language

Participating Experts
6
Points
50
Comments
23

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. cout << "Needed: Debugging ++   help";
    What i want the below code to do is read a file and read it accordingly to these steps: 1) read in first line and if there is no space in buffer[0], split up the line (delete the colon that follows the first filename) and pass the individual tokens to a function checkfiledat...
  2. C++ fstream and cout
    i have a little problem, when im working on an encryption algorithm thing and im facing a problem that is not really related to the alg. itslef, well here is a code of what im taking about: im facing the problem that the value of char(i) [for smaller number anyways; under ...
  3. Cout color
    Is there any way to change the color of the cout statements, or cin for that matter?
  4. Incorrect void function
    I have a program that I have been experimenting with to learn C++, and found that when I added a Void function to display a line that I am not displaying one of the values correct. The value is correct when it peforms the calculation, but not when the display line calls the v...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: person1994Posted on 2002-11-02 at 15:34:54ID: 7401535

One thing you may want to try, is not to use a mix of cin/cout with fptinf. I've ran into problems when I mix the two. So just to try it out comment out all your cin/cout lines.

Good luck

 

by: elpredicadorPosted on 2002-11-02 at 15:39:31ID: 7401545

so how do you use cout to a file??

 

by: CoolBreezePosted on 2002-11-02 at 15:42:08ID: 7401550

from the code, it should work. check that u have permission to write in the directory u are working in

 

by: AxterPosted on 2002-11-02 at 17:52:42ID: 7401726

Do you get an error saying you could not open the file?

Please give more details about the failure.

 

by: AxterPosted on 2002-11-02 at 17:54:55ID: 7401734

Try using a full path for the output file.

The code may be working, but placing it in a location that you're not expecting.

 

by: elpredicadorPosted on 2002-11-03 at 08:37:35ID: 7402923

when you run the program it acts as it worked perfectly, but when you go to the file that should be there, it doesn't appear.
I'll try using complete path.

 

by: elpredicadorPosted on 2002-11-03 at 08:49:36ID: 7402952

Well, it seems that it was because the file was placed anywhere. How can I make it in the programs dir?

 

by: AxterPosted on 2002-11-03 at 11:41:02ID: 7403256

What operating system are you using?

 

by: bjchambPosted on 2002-11-03 at 20:12:54ID: 7404329

Make sure that you fflush the output file before closing it.  If you don't the data will never hit the file.

 

by: LorandPosted on 2002-11-04 at 03:48:23ID: 7405288

Normally the line
dest=fopen("encriptado.txt", "w");
will create the file in the current directory. If the current dir is not the program's dir, you can specify in the command line, for example, where do you want to place the output file.

 

by: jonninPosted on 2002-11-04 at 04:56:40ID: 7405491

also, search your disk for the output file and see where it went... In a cmd window, for win32, type dir/s whatever.name... (faster than the windowed search, for one file)...




 

by: AxterPosted on 2002-11-04 at 09:45:01ID: 7406677

You can use the _getcwd() function to get the current directory, and concat the current directory with the file name.

If you want it to go into the program directory, you can get the program directory by looking at the path pass to the main function.
Example:
int main(int argc, char* argv[])
{
     printf("My path is %s\n", argv[0]);
     return 0;
}

 

by: elpredicadorPosted on 2002-11-05 at 13:47:53ID: 7412009

Im on winXP, and the file appeared on the root of my user.
how do I use _getcwd() ?, because is asks for a char* and an int.

 

by: AxterPosted on 2002-11-05 at 15:40:59ID: 7412374

Example:

#include <iostream>
#include <string>

#include <direct.h>
std::string GetCwd()
{
     char buffer[1024];
     getcwd(buffer, sizeof(buffer));
     return buffer;
}

int main(int argc, char* argv[])
{
     std::string CurrentWorkingDir = GetCwd();
     std::cout << CurrentWorkingDir << std::endl;
     return 0;
}

 

by: AxterPosted on 2002-11-05 at 15:43:10ID: 7412387

Better yet:

#include <direct.h>
std::string GetCwd(const char* FileNameOnly)
{
     char buffer[1024];
     getcwd(buffer, sizeof(buffer));
     strcat(buffer, "\\");
     strcat(buffer, FileNameOnly);
     return buffer;
}

int main(int argc, char* argv[])
{
     std::string CurrentWorkingDir = GetCwd("encriptado.txt");
     std::cout << CurrentWorkingDir << std::endl;
     return 0;
}

 

by: elpredicadorPosted on 2002-11-05 at 17:08:45ID: 7412598

I tried using your function, axter, but it doesn't work. I had to modify it a little (added buffer[] to the arguments, instead of declarating it), but now my program crashes even before it starts showing text on  the console.
BTW, I am not using strings, only char arrays, because I don't feel confortable with strings.

 

by: AxterPosted on 2002-11-05 at 17:23:17ID: 7412637

Then you have to pass in the target buffer that you want to take the value.

Example:
#include <direct.h>
char* GetCwd(char * TargetBuffer, int SizeOfBuffer, const char* FileNameOnly)
{
     getcwd(TargetBuffer, SizeOfBuffer);
     strcat(TargetBuffer, "\\");
     strcat(TargetBuffer, FileNameOnly);
     return TargetBuffer;
}

int main(int argc, char* argv[])
{
     char FullPathAndFileName[1024];
     std::cout << GetCwd(FullPathAndFileName, sizeof(FullPathAndFileName), "encriptado.txt") << std::endl;
     return 0;
}

If the above does not work, please give details of what exactly doesn't work.
Give ALL the details that you can.  The more information the better.

 

by: elpredicadorPosted on 2002-11-05 at 17:26:32ID: 7412650

did this:

char* GetCwd(const char* FileNameOnly, char buffer[1024])
{
    getcwd(buffer, sizeof(buffer));
    strcat(buffer, "\\");
    strcat(buffer, FileNameOnly);
    return buffer;
}

 

by: AxterPosted on 2002-11-05 at 19:12:13ID: 7412893

>>char* GetCwd(const char* FileNameOnly, char buffer[1024])

That's incorrect.  Use the method I posted instead:

char* GetCwd(char * TargetBuffer, int SizeOfBuffer, const char* FileNameOnly)

And pass in the variable as posted in above example:
char FullPathAndFileName[1024];
GetCwd(FullPathAndFileName, sizeof(FullPathAndFileName), "encriptado.txt");

You should try the above method first, and then try experimenting with it after you have a working method.

 

by: elpredicadorPosted on 2002-11-07 at 18:11:13ID: 7422886

Thanks Axter, that worked fine.

 

by: elpredicadorPosted on 2002-11-07 at 18:12:21ID: 7422889

but why is it incorrect the other method?
cant figure it out

 

by: AxterPosted on 2002-11-07 at 18:17:09ID: 7422911

If you use the other method, the function will be returning a local variable, that would loose scope.
That means the return value would be pointing to a variable that doesn't exist anymore.

 

by: elpredicadorPosted on 2002-11-07 at 18:50:48ID: 7423025

Thanks for your help

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...