strcpy question

use std::string instead of char* within your structs you'll be good, i.e. if you defined itemName as std::string, then, you can simply write itemName = name and won't need to worry about memory

seriously, char* shouldn't be used with newly written c++ code unless this is for a legacy c api

-- ba

try
strcpy(this.invList[i].itemName, name.c_str());

how exactly are you calling that routine?

//great responses, and thank you all!

//i'm a novice at c++, and they talk about strings, but everything i see in the
//book is
char string1[]= ""; etc

//a couple of followups

//smitty1276>>that line worked, thanks, but and I am going to try to implement burcarpat's suggestion.

//burcarpat>> actually tried to define as strings, and used
#include <string>
//but just noticed I forgot  
using std::string;
//how should my struct look?
string itemName;//?

I am going to go back at this in the morning!

thanks again

here's a working version of your code, implemented using std::string:

-- cut from here ---
// c/c++
#include <iostream>
#include <string>

struct TFoodItem {
  std::string itemName;
  int price;
  int quant;
}; // TFoodItem

struct TCustomer {
  std::string custName;
  TFoodItem shpList[20];
}; // TCustomer

class CFoodStr {
public:
  CFoodStr() { };
  void TruckArr();
  void custArr(std::string);
  void checkOut(int);
private:
  TFoodItem invList[20];
  TCustomer shpCart[10];
}; // CFoodStr

void
CFoodStr::TruckArr() {

  std::string name;
  std::cout << "\nENTER CONTENTS\n";

  for(int i = 0; i < 20; ++i) {
    std::cout <<"ITEM # "<< i << std::endl;
    std::cout <<"\n\n\nITEM NAME       :";
    std::cin >> name;
    invList[i].itemName = name;
  };    

}; // CFoodStr::TruckArr


int
main(int    _argc,
     char*  _argv[]) {

  CFoodStr FoodStr;

  FoodStr.TruckArr();

  return 0;

}; // main
-- cut from here ---

i suggest, you always use the std:: prefix when referring to standard library.  that way, you don't need any using statements.  using statements clutter the global namespace and thus should generally be avoided

also, you might want to use std::vector instead of an array.  in this case, you don't need it but it would be a good exercise.  std::vector is capable of doing everything that a c-array can do and them some

btw, i strongly suggest you get a better c++ book if your book does not explain std::string properly.  stroustrup's (the c++ programming language) or josuttis' (the standard c++ library) books will do just fine

-- ba

Your problem is a bufferoverflow! Use strncpy()

>invList[i].itemName = new char[ strlen(name.c_str())+1 ];  
Not a good idea!  An attacker can input a 2GB string and your application will shutdown...

Just use:

// Set the length of the max input!
#define MAX_INPUT 100

invList[i].itemName = new char[ MAX_INPUT+1];  
ZeroMemory(invList[i].itemName, siezof(invList[i].itemName));

// No bufferoverflows now
strncpy(reinterpret_cast<char*>(invList[i].itemName), name.c_str(), MAX_INPUT);

//....

// don forget to free
delete [] invList[i].itemName;

But you have to set the size of invList[i].itemName to a value that is large enough for you!


I hope this helps you

Additonal you should use:

char* name=""
cin>> name;

// inizialize
invList[i].itemName = new char[ MAX_INPUT+1];  
ZeroMemory(invList[i].itemName, siezof(invList[i].itemName));

// No bufferoverflows now
strncpy(reinterpret_cast<char*>(invList[i].itemName), name, MAX_INPUT);



// befor terminating the class

for(int i=0;i<=invList[i].Count-1;i++)
{
  delete [] invList[i].itemName;
}

Additonal you should use:

char* name=""
cin>> name;

// inizialize
invList[i].itemName = new char[ MAX_INPUT+1];  
ZeroMemory(invList[i].itemName, siezof(invList[i].itemName));

// No bufferoverflows now
strncpy(reinterpret_cast<char*>(invList[i].itemName), name, MAX_INPUT);



// befor terminating the class

for(int i=0;i<=invList[i].Count-1;i++)
{
  delete [] invList[i].itemName;
}