virtual cashier program please modify

>> could you please and make modification where neccessary.

What kind of modifications are you talking about ?
Do you notice any problems ? Do you have features that you need to add ?

hi jomfra,

the loop looks a bit weird .. if number of items is 1, its not executed at all.
if it is 2, then the loop is executed once. and you are asking in the loop again for
"number of items purchased" .. why is that?

>> float x;
>> printf("enter number of items purchased by %s-",a);
>> scanf("%f",&b);
>> for (x=1;x<b;x++)
>> {
>>   printf("enter the num of itmes purchased-");
>>   scanf("%f",&c);

besides you should use the "++"-increment-operator on int's, not on a float


>> float b,c,d,e,f,g,h,i,j,k,r,s,t,x,y,z;

it helps a lot, if you start using better names for your variables...


ike

firstable i think you should think about what is the program supposed to do ..
put it in pseudocode and then start writing the real code for it ..

of course we can help you with each step ..

hello ikework,

is it possible you can rewrite the above program using better names for
varibles etc.

I am new to this and need a good example to follow .

i will go ahead and increase the point .

hello moderator i need to increase this pionts to 500

hello moderator,

Could please increase the points to 500

hello moderator,

please ignore the request to increase point i inadvertently attach request

to the wrong question.

thanks

>> is it possible you can rewrite the above program using better names for varibles etc.

well, we can help you learning and assist you .. but i won't do the work for you .. then you have to hire a programmer ;)

why not giving it a try and post here what you have changed so far .. i'm sure we can help you doing it ..
that way you will learn a lot more .. its your turn .. :)


ike

>> is it possible you can rewrite the above program using better names for varibles etc.

1) jkr made an important remark - one that you should modify.

2) ike's remark about the loops is very valid - so you should modify the loop accordingly (either use integers for amounts and loop counters, or don't use ++).

3) As ike pointed out, right now, you have variable names that don't mean anything. It makes following the code very difficult, and makes making mistakes a lot easier.

Compare this :

    scanf("%f",&d);
    z=c*d;

to this eg. :

    scanf("%f", &item_cost);
    total_item_cost = item_amount * item_cost;

The second is easier to understand what's happening.


Making these three modifications to your code will already make it a lot better. Give it a try, and post your results here, and we'll help you further if needed.


Note that this is just a summary post, with no real new information, so it doesn't deserve any points ;)

You posted the question in the C++ TA as well, but it is pure C code. Are you interested in suggestions regarding C++? Some of the problems, e. g. 'scanf', 'putting all code into one main function', would be made very differently when actively using classes, STL, cout/cin, ... But I don't want you to bother with C++  if the requirements were for C only ...

Regards, Alex

Problem identified in the 1st comment, wonder why you want to delete this...

jkr, it's not REALLY a problem, is it ? The code still works just fine ;) &a and a have the same address - they just differ in type (but scanf doesn't care about that).

Plus, the author didn't ask to fix a problem - jomfra asked to check the code and to suggest improvements (see http:#19820212). Which we all gave, but then the author didn't get back to us, and we haven't really gotten to the bottom of this ... So I'm also leaning towards a delete/no refund.