September 5, 2008 11:15pm pdt

Member Login

Hall of Fame

Yearly

1jkr 825,889
2Infinity08 542,241
3evilrix 486,865
4itsmeandn... 197,811
5jaime_oliv... 110,648
6josgood 89,718
7Gurudenis 65,567
8ikework 64,065
9DanRollins 60,616
10Zoppo 51,360
11SeanDurkin 49,861
12alb66 47,016
13rstaveley 46,482
14Kdo 44,744
15JohnGaby 33,040
16sunnycoder 30,940
17AndyAins... 30,765
18LordOfPo... 27,428
19ravenpl 25,025
20pepr 24,412
21ozo 22,768
22efn 17,850
23cup 14,590
24wayside 14,250
25trinitrotolu... 12,548

	[x] Attachment Details

BSTR with empty string

Zones: C++ Programming Language, Programming Languages

if I call the following code with an empty string I need the first two line to check wheater the string is empty or not, any better more ellegant looking solution?

Not looking good:

if(Layer=="" )
{ xmlMgr.CreateElement( "Layer" ,NULL , pElement2 , true , 2);}
else {
xmlMgr.CreateElement( "Layer" ,Layer.c_str() , pElement2 , true , 2);
}

         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:

           
           
             /*$ ******************************************************************************
					Method Name			CreateElement	
 
					Parameters			[in] LPCSTR lpcstrElementName
											Name of the element to be created
 
										[in] LPCSTR lpcstrElementText 
											Text of the element to be created (Can be NULL)
 
										[in] MSXML2::IXMLDOMNode* 
											Pareent Node, to which the new element is required to be added
 
										[in] bool  
												true (to immediately add the element to the parent)
												false (just create the element, but don't add now)
 
										[in] int 
												Indentation level
					
					Return				HRESULT
											S_OK (on Success)
											E_FAIL (on Error)
 
					Description			Create a new element and add to the parent node (if required)
					                    Bug with empty NodeText
********************************************************************************** */
HRESULT CXMLMgr::CreateElement(LPCSTR lpcstrElementName, LPCSTR lpcstrElementText , MSXML2::IXMLDOMNode* pParentNode , bool bAdd , int nLevel)
{
	assert (lpcstrElementName != NULL);
	
	HRESULT hr = E_FAIL;
	MSXML2::IXMLDOMElement *pElement = NULL;
 
	SetIndentLevel(nLevel , pParentNode);
	pElement = CreateNode(lpcstrElementName , pElement);
 
	if (lpcstrElementText)
		SetNodeText(lpcstrElementText , pElement);
 
	if (bAdd)
		hr = AppendChildToParent(pElement, pParentNode);	// Append <node> to <root>.
 
	if (pElement)
	{
		m_pLastItemAdded = pElement;
		hr = S_OK;
	}
 
	return hr;
}
 
 
 
HRESULT CXMLMgr::SetNodeText(LPCSTR lpcstrText , MSXML2::IXMLDOMElement* pNode)
{
	assert (lpcstrText != NULL);
	assert (pNode  != NULL);
 
	HRESULT hr = E_FAIL;
	BSTR bstr;
	wi_CharToBSTR(lpcstrText , bstr);
 
	// Writing Element To DOM
         //  this line crash if string is ""
	hr = pNode->put_text(bstr);
 
	SysFreeString(bstr);
 
	return hr;
}

           
         

Start your free trial to view this solution

[x]

The Solution Rating System

With so many solutions, how can you tell which solutions are most likely to help you and which ones are not? To provide you with a tool to use, we rate our solutions based on various elements that most accurately determine if a solution is a quality solution. To explain what factors affect the solution rating, here are the elements we take into consideration when formulating our solution rating.

The Grade of the Solution
The Zone Rank of the Expert Providing the Solution
The Number of Author and Expert Comments
The Number of Experts Contributing
The Feedback of the Community

Your Input Matters
Because of the way the system is set up, the most important variable in this equation is you. As a member of Experts Exchange, you are able to cast your vote on the quality of the solutions in regard to how complete, accurate, helpful and easy to understand each solution is. When you provide your feedback, each rating is adjusted accordingly. So, if you see a solution that has a poor rating that you think is a good solution, let us know by rating it. As you do, the rating will be adjusted and will become more accurate for other members of our site.

If you have any suggestions that you would like to make for our rating system, please ask a question in the Suggestions Zone of Community Support.

Thank you!

9.6

Question Stats

Zone: Programming

Question Asked By: BdLm

Solution Provided By: jkr

Participating Experts: 2

Solution Grade: A

Translate:

Loading Advertisement...

Open Discussion

Comment by BdLm

Still I suffer a lot of run time failures using MSXML + Manager Class + My Different Data Files,
some test are now running but a lot don't,
Any good Input how to fix these run time bugs is welcome :

see eg. http://www.experts-exchange.com/Programming/Languages/CPP/Q_23261729.html

20080723-EE-VQP-34 / EE_QW_2_20070628