C++ counting vowels and consonants

>> you can achieve the same results with size 26 using

You don't even need an array, since you can increments the vowels, consonants and characters counters inside the loop. That will be by far a cleaner way.

Regarding your question about strings, take a look at what's available in the standard C++ strings library :

        http://cplusplus.com/reference/string/

>>>> You don't even need an array
The array has the advantage that the index can be computed from character code.

Counting vowels and consonants in the loop would require an if-else statement in the loop which is not so elegant.

A compromise could be using a switch statement which combines both benefits:


 getline(cin, user_input); // assuming user_input is std::string
 for(int c=0; c < (int)user_input.size(); ++c) // loop through the entire user input
 {
     switch (c)
     {
         case 'A': case 'a:' case 'E': case 'e': case 'I' case 'i': case 'O': case 'o': case 'U': case 'u':
              ++vowels; break;
         default:
              if (isalpha(c) == TRUE)
                  ++consonants;
              else
                  ++characters;
              break;
     }
     characters += vowels + consonants;
 
Of course you could use a  case 'B': case 'b': case 'C' ... for consonants as well what would spare the if statement in the default branch.

>> Counting vowels and consonants in the loop would require an if-else statement in the loop which is not so elegant.

Two nested if statements is all you need. Nothing inelegant about that ;) In fact, it looks pretty clear to me :

if (isalpha(c)) {
  ++characters;
  if (isvowel(c)) {
    ++vowels;
  }
  else {
    ++consonants;
  }
}

                                              

1:
2:
3:
4:
5:
6:
7:
8:
9:

>>>> Two nested if statements is all you need. Nothing inelegant about that ;)

 ;-)

     switch (c)
     {
         case 'A': case 'a:' case 'E': case 'e': case 'I' case 'i': case 'O': case 'o': case 'U': case 'u':
              ++vowels; break;
         default: consonants += isalpha(c); break;
     }
     characters = vowels + consonants; 

                                              

1:
2:
3:
4:
5:
6:
7:

>>>> characters = vowels + consonants;
should be outside of the loop

You guys are great!  These are all very helpful!  A couple of things...an array was required for this exercise and I also have to make BOTH the C-string and string data type work at the same time.  I have to have two outputs using both methods.  I'm having a problem understanding how to make them both work at the same time.  Again, please and thank you, and you guys are great!

>> an array was required for this exercise

fair enough :)


>> and I also have to make BOTH the C-string and string data type work at the same time.

What did the exact assignment state ? Because I'm not sure how to interpret this.

The point of the array is for speed only (less if/switch statements); however, the isalpha and "isvowel" approach is more elegant.  It is merely what the programmer desires.

>> I also have to make BOTH the C-string and string data type work at the same time.

To allow this to use both, look at the code between "if(useStrInput) {...}else{...}"  You can break these blocks into two separate functions.  Then do something like:

std::string str_input = doStrInput();
char *cstr_input = doCStrInput(); //char * doCStrInput() { char cstr_input[256]; ... return(cstr_input); }

If there is something wrong with my solution, please let me know. Thanks.

Here are the instructions:

Write a program that prompts the user to input a string. The output will be the total number of characters in the string, the total number of consonants in the string, and the total number of vowels in the string. Be sure to prompt for input and to label your output. The code needs to handle the string as a character array (C-string) and as a string data type - so this means that you will see the same output twice, once for a C-string and once for a string data type.  Be sure to find the length of your c-string and the length of your string separately, using functions specific to c-string and string variables.

Because this is a homework asgmt, try to see if you can use my code in my first post to print out both cstr_input and str_input.  Actually, I think all you need to do is just take out the if statement and don't need separate functions unless you want to.  I do minus 'A' because 'A' is the lowest # so everything will fall between 0 and 26.  Ignore my most recent post above this one (wish you could delete or edit posts).

To WhiteMage - I will try that, Thanks!

You're welcome; you'll need separate variables (all variables) for each C-string and string.  All I can suggest further is to mess with the code I posted.  Try to figure out how everything is working and have fun.  The best way to learn a programming language is messing around with it.  Just like any other language, you can't learn it for the final exam with just one all-nighter.  You have to work with it.  See what happens when you do this, etc.  But most importantly just have fun.

I appreciate your help and I do want to try to figure it out on my own.  It is the best way to learn.  I am limited on time though so if you could offer advice on the best route to take such as:  would it be easier to have to different methods or will I figure it out faster keeping it together as it is?  Thanks.

Isn't the character count the length of the string ? I'll consider spaces, digits, punctuation as characters ...

>> I am limited on time though so if you could offer advice on the best route to take

Try to get it working for the C string only first.
Then try to get it working for the C++ string only.

Once you have two separate pieces of code that work, you can combine them to get the final code that has outputs for both approaches.

>> Isn't the character count the length of the string ? I'll consider spaces, digits, punctuation as characters ...

In programming, yes.  If you open up Microsoft Word, it only counts consonants and vowels (at least in the version I'm using).  In English Literature, generally speaking, spaces, digits, and punctuation marks aren't considered characters.  Ultimately, it depends on what her teacher wants, whatever that is.

>>  I am limited on time though so if you could offer advice on the best route to take such as:  would it be easier to have to different methods or will I figure it out faster keeping it together as it is?

Just keep it together, this will be faster.  Here is what you'll basically need to do:

//separate variables for both methods ("string" and "c-string" method)
std::string str_input;
char cstr_input[256] = {0};
int str_counts[26] = {0},cstr_counts[26] = {0};
int str_c = 0,str_v = 0,cstr_c = 0,cstr_v = 0; //c=consonants; v=vowels

//get input from user using str_input
//count everything using str_counts, str_c, and str_v

//get input from user using cstr_input
//count everything using cstr_counts, cstr_c, and cstr_v

//output results as (str_c + str_v), str_c, and str_v
//output results as (cstr_c + cstr_v), cstr_c, and cstr_v

>>>> The code needs to handle the string as a character array (C-string) and as a string data type - so this means that you will see the same output twice, once for a C-string and once for a string data type.  Be sure to find the length of your c-string and the length of your string separately, using functions specific to c-string and string variables.

Though the instructions were using many words to emphasize the bivalence of C/C++ strings, it is neither a necessity to use both C char arrays and C++ string for that task nor is it senseful to do so.

IMO, it would be best to take your first post which looks at the input as to a C string - probably improved by some of the suggestions which also are C compatible - as one of two alternative solutions. Then you could add a pure C++ solution using std::string and no char arrays.

Note, the switch statment, the isvowel and isalpha functions take an int or char type as operand what is without alternative valid for both C *AND* C++, i. e. you could use them in either of the solutions.

If you nevertheless want a mixed solution I would suggest to have a C++ only user input using std::string and do the evaluation of the input string after a statement like

    const char * pszUserInput = user_input.c_str();

After that use C code only, e. g. use strlen to determine the length of input.