C++ Bank Account Program

A few problems I spotted by glancing over the code :

1)

>>         double dep, withdraw;

These variable definitions belong outside of the switch.
As a side note : it's good practice to always initialize your variables as soon as you define them, for example :

        double dep = 0.0, withdraw = 0.0;

That avoids a lot of unexpected problems later on. Make sure to initialize them to acceptable values that don't cause problems themselves.



2) You also seem to be missing break; statements at the end of your switch cases. I suggest to read up on switches a bit :

        http://cplusplus.com/doc/tutorial/control/

(scroll down to the paragraph on switches)



3)

>>         c.balance;

A statement like that doesn't actually do anything ... So it might as well not have been there.



4) You are missing a few end }'s (for your switch and your do loop for example).



5)

>>         string firstName;

You are using the STL string without including the proper header for it :

        #include <string>



6)

>> static double balance;

Making the balance a static member of the CheckingAccount class would mean that all checking accounts have the same balance ... I'm sure that's not what you intended, right ?




Start by fixing these, and then try compiling/running your code again. If you still have problems, then post the exact error messages you get and/or explain the wrong behavior you're noticing.

This is the only error I received before I submitted the question...

1>LINK : fatal error LNK1561: entry point must be defined

I will work on the suggestions made...thanks!

Disregard that last post...I was looking at the wrong program.

The error I received was...

1>c:\documents and settings\veeachone\my documents\visual studio 2008\projects\seminarthree\seminarthree\seminarthree.cpp(55) : fatal error C1075: end of file found before the left brace '{' at 'c:\documents and settings\veeachone\my documents\visual studio 2008\projects\seminarthree\seminarthree\seminarthree.cpp(18)' was matched

(that is where the "do" starts)

>> C1075: end of file found before the left brace '{' at 'c:\documents and settings\veeachone\my documents\visual studio 2008\projects\seminarthree\seminarthree\seminarthree.cpp(18)' was matched

That is because of point 4) in my previous post. If you add the matching } braces for each { brace, that error will go away.

I will work on this and see where I get, thanks!

I have made progress and have gotten it to run but I have a few snags that I hope you can offer some advice on.  My choice #1 works ok but my choice #2 does not.  Did I write the line wrong?  Choice #3 works but it repeats the menu immediately after.  I have not figured out how to exit on choice #4 (please don't roll your eyes, I know I should know that!)  Also, if I make a second choice after the first one the menu also repeats twice.   I'm not asking for you to write any code just point me in the right direction.  Please and thank you.

Sorry, I forgot to include my code....

#include "BankAccount.h"
#include <iostream>
#include <iomanip>
 
using namespace std;
 
int main ()
{
 BankAccount b;
 double balance = 500.00;
 b.setBankAccount("Valerie", "Hull", 123456);
 b.printBankAccount();
 char choice;

 
           
do{
   cout << "Please select a banking activity" << endl;
   cout << "1.  Deposit"  << endl;
   cout << "2.  Withdrawal" << endl;
   cout << "3.  Account Balance" << endl;
   cout << "4.  Exit" << endl;
   cout << endl;
   cout << " Please enter a choice number -->>  ";
 
choice=toupper(getchar());
double dep, withdraw;
switch(choice)
{
      
case '1':
      cout <<"Enter amount of money to deposit:"<< endl;
      cin>>dep;
      cout <<"New Balance: "<<balance + dep<<endl;
      break;
case '2':

      if
            (balance <= 0) cout << "Invalid Funds, Please make another selection.";
      else {
            cout <<"How much would you like to withdrawal?"<<endl;
            cin>>withdraw;
            cout<<"New Balance: $"<<balance - withdraw<<endl;
      }
      break;
case '3':
      cout<<"Your balance is "<<balance<<endl;
      break;
case '4':
      break;
default:
      cout<<"Invalid menu item...Please re-enter your choice"<<endl;
      break;
}
}


while(choice != 4);
{
}
 
return 0;
}


#include <iostream>
#include <iomanip>
#include <string>
 
using namespace std;
 
class BankAccount
{
public:
      void setBankAccount(string fName, string lName, int acctNum);
      void printBankAccount() const;
      
private:
      string firstName;
      string lastName;
      int accountNumber;
};


void BankAccount::setBankAccount(string fName, string lName, int acctNum)
{
      firstName = fName;
      lastName = lName;
      accountNumber = acctNum;
}

void BankAccount::printBankAccount() const
{
      cout<<"Hello, "<<firstName<<" "<<lastName<<" Account Number: "<<accountNumber<<endl;
}

You were very helpful!   Thanks again!!

This is very helpful!!  Thanks again!