Question

improve padding addition code

Asked by: bachra04

I need an improvement to the getMemberListSize methods using shift opration etc...

/// This structure is defined for a little endian platform.
/// 
///     0               1               2               3
///     0 1 2 3 4 5 6 7 0 1 2 3 4 5 6 7 0 1 2 3 4 5 6 7 0 1 2 3 4 5 6 7
///    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
///    |    RadioId    |   RS  |   DS  |T|        ACN          |  RRRR |
///    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
///    |                        MMI                    |   memberId    |
///    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
///    |   |memberId...        |    memberId...    |    memberId...    |  
///    +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
///    ...
 
/// </summary>
struct RadioEvStruct
{ 
   /////////////////////////////////////////////////////////////////////
   //        First Line of packet
   /////////////////////////////////////////////////////////////////////
   unsigned __int16 RadioId:8; 	            //0-255 possible patch Id
   unsigned __int16 RadioState:4;            //(1)Keyed,(0)Not Keyed
   unsigned __int16 DimState:4;              //(1)Active,(0)Deactive
   unsigned __int16 MMI:1;                   //(0)group,(1)group (tetra)
   unsigned __int16 MemberNb:11;             // The number of members 
                                             // up to 1024
   unsigned __int16 Reserved:4;  	            // Reserved bits for future use.
 
   /////////////////////////////////////////////////////////////////////
   //        The rest of the packet
   /////////////////////////////////////////////////////////////////////
   unsigned char*   aMemberList;         // Contains 0 or 1 MMI (24 bits)
                                         // + 0 to 50 members (10 bits each)                                        
                                         // members + (optional) required 
                                         // padding to avoid alignment problem.
 
   /// <summary>
   /// Comparison operator.
   /// </summary>
   //////////////////////////////////////////////////////////////////////////
   // memberwise comparison is safer because of the potential padding problem 
   // Here we assume there is no padding or alignment problems as well as   
   // everything is little indian. 
   // The length of the MemberList + 4 is multiple of 4.
 
   bool operator == (RadioEvStruct RadioEvStatus)
   {
      return  memcmp (this, & RadioEvStatus, getMemberListSize() + 4);  
   }
 
   /// <summary>
   /// Inverse Comparaison operator.
   /// </summary>
   bool operator != (RadioEvStruct RadioEvStatus)
   {
      return !(*this == RadioEvStatus);
   }
   
   unsigned __int16 getMemberListSize()
   {
   	// calculates and returns the size of the memberList based
	// on the values of MMI and MemberNb fields.
 
	   unsigned __int16 uGroupSize = this.MMI ? 3:2;
      unsigned __int16 uTotalBitsSize = (uGroupSize + this.MemberNb)*32;
      return (uTotalBitsSize + (( 4 - uTotalBitsSize % 4)%4))/8;
 
   }
};

                                  
1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:

Select allOpen in new window

This Question has been solved and asker verified All Experts Exchange premium technology solutions are available to subscription members.

Subscribe now for full access to Experts Exchange and get

Instant Access to this Solution

  • Plus...
  • 30 Day FREE access, no risk, no obligation
  • Collaborate with the world's top tech experts
  • Unlimited access to our exclusive solution database
  • Never be left without tech help again

Subscribe Now

Asked On
2009-10-22 at 06:57:29ID24834486
Topics

C++ Programming Language

,

C Programming Language

Participating Experts
2
Points
500
Comments
16

Trusted by hundreds of thousands everyday for fast, accurate and reliable tech support.

  • "The time we save is the biggest benefit of Experts Exchange to Warner Bros. What could take multiple guys 2 hours or more each to find is accessed in around 15 minutes on Experts Exchange." Mike Kapnisakis, Warner Bros.
  • "Our team likes having a resource that is more secure than just using Google and most experts using this service really know their stuff. It's nice to look here first versus using Google." Dayna Sellner, Lockheed Martin
  • "Anytime that I've been stumped with a problem, 9 out of 10 times Experts Exchange has either the accepted solution or an open discussion of the potential solution to the problem." Kenny Red, eBay Inc.

See what Experts Exchange can do for you.

Got a question?

We've got the answer.

Experts Exchange has been collecting answers to technology questions since 1996…3 million and counting! If you have a question, chances are we already have your answer.

Screenshot of Experts Exchange Knowledgebase

Need individual assistance?

Our experts are ready to help.

If you can't find the exact answer you're looking for, ask our exclusive community of 50,000 experts. You’ll get a personalized answer from a trusted professional.

Screenshot of Experts Exchange Knowledgebase

Want to learn from the best?

Read articles from industry experts.

Thousands of free tech tips, tricks, how-to’s and tutorials are available in our peer reviewed articles section. See for yourself how smart our experts are, no login required.

Screenshot of an Article

Working on a long term project?

Store your work and research.

Save solutions to your questions, answers you’ve discovered through searching plus helpful articles in your personal knowledgebase for easy future access.

Screenshot of Experts Exchange Knowledgebase

Access the answers to your technology questions today.

Subscribe Now

30-day free trial. Register in 60 seconds.

What Makes Experts Exchange Unique?

Members of the expert community talk about why the experience at Experts Exchange is different than what you will find anywhere else.

Trusted by the world's most respected brands.

image of each brand's logo

Faithfully serving IT professionals since 1996.

Experts Exchange Logo

Try it out and discover for yourself.

Subscribe Now

30-day free trial. Register in 60 seconds.

Related Solutions

  1. Improving in Java
    hi, i am currently learning java, i have learned quite a bit, things such as arrays,input/output through keyboard,a little graphics,OOP concepts etc but its still hard for me to develop applets and applications as i want. i just need a good advice on how i can improve my prog...
  2. Performance improvements for this Q ( follow up question )
    Hi all, I just wanted to know if there were any improvements that could be made to the coding from my previous question : http://www.experts-exchange.com/Programming/Programming_Languages/Visual_Basic/Q_21348688.html#13535268 If so what are they and can I please have examp...
  3. Function Improvement...
    Can anyone improve the following sub? (yes, I understand .GetRows() is available, however this works, and has worked exactly how I've needed it to, i'm just wonderingif improvements can be made) <% Sub SelectDB(ByVal connSTR, ByVal fieldlist, ByVal table, ByVal myfilter,...

Free Tech Articles

  1. WARNING: 5 Reasons why you should NEVER fix a computer for free.
    It is in our nature to love the puzzle. We are obsessed. The lot of us. We love puzzles. We love the challenge. We thrive on finding the answer. We hate disarray. It bothers us deep in our soul. W...
  2. SCCM OSD Basic troubleshooting
    SCCM 2007 OSD is a fantastic way to deploy operating systems, however, like most things SCCM issues can sometimes be difficult to resolve due to the sheer volume of logs to sift through and the dispe...
  3. Migrate Small Business Server 2003 to Exchange 2010 and Windows 2008 R2
    This guide is intended to provide step by step instructions on how to migrate from Small Business Server 2003 to Windows 2008 R2 with Exchange 2010. For this migration to work you will need the fo...
  4. Create a Win7 Gadget
    This article shows you how to create a simple "Gadget" -- a sort of mini-application supported by Windows 7 and Vista. Gadgets can be dropped anywhere on the desktop to provide instant information, ...
  5. Outlook continually prompting for username and password
    There have been a lot of questions recently regarding Outlook prompting for a username and password whilst using Exchange 2007. There are a few reasons why this would happen and I will try to cover t...
  6. Backup Exchange 2010 Information Store using Windows Backup
    There seems to be quite a lot of confusion around the ability to backup Exchange 2010 using the built in Windows Backup feature. This stems from the omission of this feature prior to Exchange 2007 s...

Cloud Class Webinars

  1. Avoiding Bugs in Microsoft Access
    Alison Balter takes and in-depth look at avoiding bugs in Access. In this webinar you will learn about using the immediate window to debug your applications, invoking the debugger, using breakpoints to troubleshoot, stepping through code, setting the next statement to execute, ...
  2. Top 10 Best New Features in Visio 2010
    Scott Helmers gives live demonstrations of the top 10 new features in Visio 2010. This webinar will teach you how to create compelling diagrams by adding shapes to the page with a single click, linking the shapes in a diagram to data in Excel (or SQL Server, or SharePoint), ...
  3. IT Consultant Business Secrets Revealed
    Michael Munger, Experts Exchange tech pro and IT consultant, pulls back the curtain on his very successful businesses and answers question on every IT consultant and business owner should know about. He shares secrets on what he did to solve the 5 most common problems in IT, ...
  4. Disaster Recovery and Business Continuity
    Quest CTO, Mike Billon, gives an overview of the steps involved in building a dunamic disaster recovery plan. Through case studies and an examination of software/hardware tooles for monitoring and testing, you'll gain a better understandin of where you are, where you want ...
  5. Organize Your Visio Diagrams with Containers and Lists
    Scott Helmers uses cross functional flowcharts, wireframe diagrams, data graphic legends and seating charts to teach you: how to ustilize all three new structured diagram components in Visio 2010, the best practices for organizeing shapes in previous version of Visio, how to organize ...
  6. How to Us Objects, Properties, Events and Methods in Microsoft Access
    Alison Dalter gives an in-depbth look at objects, properties, events and methods in Microsoft Access. In this webinar you will learn about using the object browser, referring to objects, working with properties and methods, working with object variables, understanding the ...

Join the Community

Give a Little. Get a Lot.

Join the community of experts here and help other tech pros by answering question in your area of expertise. You can earn FREE access to all Experts Exchange's premium features and resources.

Join the Community

Answers

 

by: bachra04Posted on 2009-10-22 at 07:00:41ID: 25634259

Sorry
a quick correction:
   
   unsigned __int16 getMemberListSize()
   {
         // calculates and returns the size of the memberList based
      // on the values of MMI and MemberNb fields.

         unsigned __int16 uGroupSize = this.MMI ? 3:2;
      unsigned __int16 uTotalBitsSize = (uGroupSize + this.MemberNb)*32;
      return (uTotalBitsSize + (( 32 - uTotalBitsSize % 32)%32))/8;

   }

 

by: Infinity08Posted on 2009-10-22 at 07:18:51ID: 25634489

What do you mean by improve ?

 

by: _phoenix_Posted on 2009-10-22 at 08:16:43ID: 25635191

You mean something like:

   unsigned __int16 uGroupSize = MMI ? 3:2;
   unsigned __int16 uTotalBitsSize = (uGroupSize + MemberNb) << 6;
   return (uTotalBitsSize + (( 32 - (uTotalBitsSize & 31)) & 31)) >> 4;

 

by: _phoenix_Posted on 2009-10-22 at 08:17:55ID: 25635208

sorry, forgot the this keyword... I don't have the complete implementation here :D, hope that helps to improve your function

 

by: bachra04Posted on 2009-10-22 at 08:58:19ID: 25635712

Sorry for not being clear enough,
By improve I mean inspect the code (verify that it works correctly) , make it more efficient
What phoenix did is almost what I need.
Just a question, does not hurt the fact that MemberNb is only 11 bits longs ?

 

by: _phoenix_Posted on 2009-10-22 at 09:28:58ID: 25636046

uGroupSize + MemberNb would be something like (if MemberNb = 1024 set & uGroupSize = 3)

0000000000000011
XXXXX10000000000
-------------------------
XXXXX10000000011

Your result after by shifting by 6 or multiplying by 32 will be (1000000001100000), if you only want 11 bits you should mask the value by 0x0FFF.

 

by: bachra04Posted on 2009-10-22 at 09:49:47ID: 25636254

Yes I got it Thanks.
Last request I'm curious to know how the shift operation will be in this case :

unsigned __int16 uTotalBitsSize = (uGroupSize*8 + this.MemberNb*10);

 

by: Infinity08Posted on 2009-10-22 at 10:02:00ID: 25636391

>> By improve I mean inspect the code (verify that it works correctly)

What do you want the function to do ?

 

by: _phoenix_Posted on 2009-10-22 at 10:06:43ID: 25636448

unsigned __int16 uTotalBitsSize = (uGroupSize << 4 + (this.MemberNb << 4 + this.MemberNb << 2));

 

by: bachra04Posted on 2009-10-22 at 10:08:28ID: 25636469

The function will calculate the size of the list composed by 0 or 1 block of 24 bits and a number of blocks of 10 bits each then add the necessary padding to get the size multiple of 32 bits and returns the total size in bytes.

 

by: Infinity08Posted on 2009-10-22 at 11:29:57ID: 25637442

>> The function will calculate the size of the list composed by 0 or 1 block of 24 bits and a number of blocks of 10 bits each then add the necessary padding to get the size multiple of 32 bits and returns the total size in bytes.

Something like this then :

   unsigned __int16 getMemberListSize()
   {
        // calculates and returns the size of the memberList based
        // on the values of MMI and MemberNb fields.
 
        unsigned __int16 bitCount = ((this.MMI) ? 24 : 0) + (this.MemberNb * 10);
        return ((bitCount / 32) + ((bitCount % 32) ? 1 : 0));
   }
                                              
1:
2:
3:
4:
5:
6:
7:
8:

Select allOpen in new window

 

by: bachra04Posted on 2009-10-26 at 08:23:06ID: 25663162

I've never asked to close the question, I already accepted the question and assigned points between two participants

 

by: bachra04Posted on 2009-10-26 at 08:23:12ID: 25663163

I've never asked to close the question, I already accepted the question and assigned points between two participants

 

by: bachra04Posted on 2009-10-26 at 08:24:56ID: 25663181

I think you have a bug in the system any time I try to accept the answer from multiple people

 

by: Infinity08Posted on 2009-10-26 at 09:06:26ID: 25663709

If you accept answers, then that automatically closes the question. I assume what you're referring to is the auto-close message, which appears if you select your OWN reply as the answer. If you select only expert replies as the answer, the question will be closed immediately without the auto-close message.

20120131-EE-VQP-002

3 Ways to Join

30-Day Free Trial

The Experts

98% positive feedback on 31,087 answers since March 2000. angeliii is a Microsoft Most Valuable Professional for his work with MS SQL Server & Develoment.

He has also proven his knowledge of Visual Basic Programming, PHP Scripting and Oracle Databases.

The Experts

97% positive feedback on 10,752 answers since July 2000. lrmoore has more than 18 years experience in the networking industry.

The six-time Mircosoft MVPs specialties include firewalls, virtual private networking, and network management.

Testimonials

"...and excellent source for support... Kind of like having your very own IT dept." Electriciansnet

Testimonials

"I was apprehensive at signing up at first. However... it has already made my life as an IT administrator much easier." JaCrews

Testimonials

"WOW! You guys have great, active, and knowledgeable people on here." moore50

Business Clients

Business Clients

In the Press

"If you’ve got a question... Experts Exchange can supply an answer.”

In the Press

"...an invaluable aid for both IT professionals and those who require tech support."

In the Press

"where IT professionals provide quick answers on just about any topic"

Business Account Plans

Loading Advertisement...